meson: apply meson format

since [1] was merged in openbmc-build-scripts, meson format is required
to pass CI.

References:
[1] https://gerrit.openbmc.org/c/openbmc/openbmc-build-scripts/+/77742

Cha

meson: apply meson format

since [1] was merged in openbmc-build-scripts, meson format is required
to pass CI.

References:
[1] https://gerrit.openbmc.org/c/openbmc/openbmc-build-scripts/+/77742

Change-Id: I66206066c41dd3d6225855d0530c72f5089a964b
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

fixup: test: example device

- Fix the update progress loop in
test/common/exampledevice/example_device.cpp.
The update progress should be incremented there.

- Move a comment to the relevant lin

fixup: test: example device

- Fix the update progress loop in
test/common/exampledevice/example_device.cpp.
The update progress should be incremented there.

- Move a comment to the relevant lines in
test/common/exampledevice/example_updater_main.cpp

Tested: Unit tests pass.

Change-Id: I5fa908e1c6f95eaaa2710853c065fc341a30035f
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

fw update: implement example device

Introduce example-device and example-code-updater, which are used as
examples for how to implement devices and code updaters according to the
design [1]

Tested:

fw update: implement example device

Introduce example-device and example-code-updater, which are used as
examples for how to implement devices and code updaters according to the
design [1]

Tested:

The example code updater allows us to perform manual testing without
a dependency on any specific device.

Running the example code updater results in follow dbus output:

```
busctl --full --no-pager tree xyz.openbmc_project.ExampleCodeUpdater

└─ /xyz
└─ /xyz/openbmc_project
└─ /xyz/openbmc_project/software
└─ /xyz/openbmc_project/software/ExampleSoftware_4081

busctl --full --no-pager introspect xyz.openbmc_project.ExampleCodeUpdater /xyz/openbmc_project/software/ExampleSoftware_4081

CodeUpdater /xyz/openbmc_project/software/ExampleSoftware_4081
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
...
xyz.openbmc_project.Software.Activation interface - - -
.Activation property s "xyz.openbmc_project.Software.Activation.Activations.Active" emits-change writable
.RequestedActivation property s "xyz.openbmc_project.Software.Activation.RequestedActivations.None" emits-change writable
xyz.openbmc_project.Software.Update interface - - -
.StartUpdate method hs o -
.AllowedApplyTimes property as 1 "xyz.openbmc_project.Software.ApplyTime.RequestedApplyTimes.OnReset" emits-change
xyz.openbmc_project.Software.Version interface - - -
.Purpose property s "xyz.openbmc_project.Software.Version.VersionPurpose.Unknown" emits-change writable
.Version property s "v1.0"
```

References:
[1] https://github.com/openbmc/docs/blob/master/designs/code-update.md

Change-Id: I2bad241b3102e58eda5139174791adda82f6ca95
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: Ifc60fd8e7091d83202753a57f215667613f1691c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I4a9d4410fcf7c9e87481d7d962fbcc92d071c913
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I4a9d4410fcf7c9e87481d7d962fbcc92d071c913
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

fw update: library to create pldm fw package

Implement some helper functions to easily create a pldm fw package in a
few lines of user code.

This is helpful for unit testing the code update flow.

fw update: library to create pldm fw package

Implement some helper functions to easily create a pldm fw package in a
few lines of user code.

This is helpful for unit testing the code update flow.

The package created is for testing purpose. The library is not
fully-featured or complete and should not be relied upon for anything
other than the tests in this repo.

https://github.com/openbmc/docs/blob/master/designs/code-update.md

Tested: next few patches in series

Change-Id: If899e5537a2e5ac641544ca80e8876d83549da28
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

re-organize the current files into bmc directory

More daemons are being developed in phosphor-bmc-code-mgmt repo as part
of https://github.com/openbmc/docs/blob/master/designs/code-update.md.
For th

re-organize the current files into bmc directory

More daemons are being developed in phosphor-bmc-code-mgmt repo as part
of https://github.com/openbmc/docs/blob/master/designs/code-update.md.
For this move the current files for BMC code update into bmc
subdirectory for a better code organization.

Tested:
meson build passes.

Change-Id: I7b5575bcfbe54ac00aa803f94b5d8f6d69ce2f3f
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

test/README.md: Update access permissions

The default access permission for the README.md file should be 664.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia2c14646fd99eab3a580b1c2

test/README.md: Update access permissions

The default access permission for the README.md file should be 664.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia2c14646fd99eab3a580b1c276a46ff2f604b1ae

show more ...

test/README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "

test/README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia1af9ab633a14fb94bb6bb26800238fcb1d4ff95

show more ...

test/README.md: Fix MD004 warnings

The following warnings are generated by using markdownlint analysis:
```
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
```
Refer to markdo

test/README.md: Fix MD004 warnings

The following warnings are generated by using markdownlint analysis:
```
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
```
Refer to markdown-lint [1] to fix MD004
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/004-ul-style.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: If4b0dcbd538a886d593ab3162f019a817eadeedd

show more ...

test/README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading

test/README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Instructions on how to execute..."]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I957dbc3093701663267a93bee4f2c688b1f9d1e8

show more ...

gen-bios-tar: Update private signing key

Updating from 1024 bits to 4096 bits for a more secure key

Change-Id: Idaa9bcdc04ec4143ff8035c84040646458bf8398
Signed-off-by: Rashmica Gupta <rashmica@linu

gen-bios-tar: Update private signing key

Updating from 1024 bits to 4096 bits for a more secure key

Change-Id: Idaa9bcdc04ec4143ff8035c84040646458bf8398
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>

show more ...

clang-tidy: Enable performance-inefficient-string-concatenation

This check warns about the performance overhead arising from
concatenating strings using the operator+

Change-Id: I93a5797adb0ffc9aa1

clang-tidy: Enable performance-inefficient-string-concatenation

This check warns about the performance overhead arising from
concatenating strings using the operator+

Change-Id: I93a5797adb0ffc9aa1d2353bab0a5ff6773ec6d5
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Change-Id: Ia0867db019db8e40e710bdd4025e030061f7a992
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable performance-unnecessary-value-param check

This check flags value parameter declarations of expensive to copy
types that are copied for each invocation but it would suffice to
pass

clang-tidy: Enable performance-unnecessary-value-param check

This check flags value parameter declarations of expensive to copy
types that are copied for each invocation but it would suffice to
pass them by const reference.

Change-Id: I631deda63fcbb74362313c9596bf7e72933b0d0c
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable performance-for-range-copy check

This check optimizes performance in C++ for range-based loops
(for (auto element : container)), the key consideration is to
avoid unnecessary copi

clang-tidy: Enable performance-for-range-copy check

This check optimizes performance in C++ for range-based loops
(for (auto element : container)), the key consideration is to
avoid unnecessary copies of elements, especially when dealing with
larger or more complex objects.

Change-Id: I3349630950f72e1c0365b2ab23b7858c1bfbc9d4
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable cppcoreguidelines-explicit-virtual-functions

This check enforces guidelines related to explicitly specifying
override or final when overriding virtual functions in C++
classes.

C

clang-tidy: Enable cppcoreguidelines-explicit-virtual-functions

This check enforces guidelines related to explicitly specifying
override or final when overriding virtual functions in C++
classes.

Change-Id: I5c7de19e9f7521f4b8a947a25540a44c400da104
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable bugprone-narrowing-conversions check

This check indicates instances where there's a potential loss of
data during type conversions, particularly when converting from
a wider type

clang-tidy: Enable bugprone-narrowing-conversions check

This check indicates instances where there's a potential loss of
data during type conversions, particularly when converting from
a wider type to a narrower type.

Change-Id: I43f3d9ff4a6d672f51c7b2d3eccca90f262fa852
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable bugprone-implicit-widening-of-multiplication-result

The check diagnoses instances where a result of a multiplication is
implicitly widened, and suggests (with fix-it) to either si

clang-tidy: Enable bugprone-implicit-widening-of-multiplication-result

The check diagnoses instances where a result of a multiplication is
implicitly widened, and suggests (with fix-it) to either silence
the code by making widening explicit, or to perform the
multiplication in a wider type, to avoid the widening afterwards.

Change-Id: I97b1b3d3158d753e70bd2bd98f7938dc6e35af5a
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

meson: Drop legacy 'verify-signature' option

Currently there are two options for the image signature verification:
- 'verify-signature' (legacy),
- 'verify-full-signature' (current).

Drop legacy op

meson: Drop legacy 'verify-signature' option

Currently there are two options for the image signature verification:
- 'verify-signature' (legacy),
- 'verify-full-signature' (current).

Drop legacy option and let the current one take its place.

Change-Id: Ia205424395179fd190e3d055159beca93cff0545
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Ib954d53a0fdfba96a0e0f9bdd2ad75ed3c4f4927
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove oe-sdk support

Very few of our projects have this extra code and it doesn't seem
very useful considering we have both meson-subproject support and
developers can use devtool.

Signed-o

meson: remove oe-sdk support

Very few of our projects have this extra code and it doesn't seem
very useful considering we have both meson-subproject support and
developers can use devtool.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I41f8ba99600c04596b4fc37cc5b0ec00976d1e24

show more ...

image-verify: Skip full verify for non-BMC images

The verifyFullImage() only supports verify BMC image, but does not apply
to other images like BIOS.

Skip doing verifyFullImage() for non-BMC images

image-verify: Skip full verify for non-BMC images

The verifyFullImage() only supports verify BMC image, but does not apply
to other images like BIOS.

Skip doing verifyFullImage() for non-BMC images so that it is possible
to do BIOS code update when fieldMode is enabled.

Tested: Verify BIOS update is successful without verification error.
Add related unit test case and verify it passes.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Id9e72367bd2797f7a61c017b61fb81df1dd4d15c

show more ...

Add support for Inventory.Decorator.Compatible

This adds support for the compatibility strings interface described in
https://github.com/openbmc/phosphor-dbus-interfaces/tree/master/yaml/xyz/openbmc

Add support for Inventory.Decorator.Compatible

This adds support for the compatibility strings interface described in
https://github.com/openbmc/phosphor-dbus-interfaces/tree/master/yaml/xyz/openbmc_project/Software#compatibility.

The Version objects will now be created with the Inventory.Decorator.Compatible
interface with the compatibility names coming from the MANIFEST file.
e.g.
version=1.2.3
MachineName=foo
purpose=Other
ExtendedVersion=a.b.c
CompatibleName=foo.bar
CompatibleName=baz.bim

Tested:
$ busctl get-property xyz.openbmc_project.Software.Version \
/xyz/openbmc_project/software/517751da \
xyz.openbmc_project.Inventory.Decorator.Compatible Names
as 2 "foo.bar" "baz.bim"

Signed-off-by: Justin Ledford <justinledford@google.com>
Change-Id: I9ee36af2d3d1494d533a3b09c466a250c4fe786b

show more ...

openssl: test: stop using deprecated SHA512_* functions

Complete the work from I91959eef65793f1092536f7e4c027839ce6cdf52 to
switch the test cases over to the OpenSSL 3 supported functions.

Tested:

openssl: test: stop using deprecated SHA512_* functions

Complete the work from I91959eef65793f1092536f7e4c027839ce6cdf52 to
switch the test cases over to the OpenSSL 3 supported functions.

Tested: This was done in two steps to show that the conversion is
identical. Test cases pass with conversion.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia2abc82f0b1282a52925a0eb9a2246d05f9b30cf

show more ...