fw update: tests for software update

Tests for the software update flow.

Minimal PLDM packages are constructed in testcases and the update flow
is run on software instance.

These tests should chec

fw update: tests for software update

Tests for the software update flow.

Minimal PLDM packages are constructed in testcases and the update flow
is run on software instance.

These tests should check that the common code behaves as outlined in the
design [1]

References:
[1] https://github.com/openbmc/docs/blob/master/designs/code-update.md

Change-Id: Ibf473999b692a85dd86e4ab57a9a4c322257fc40
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

fw update: tests for device

Tests for the device update flow.

Minimal PLDM packages are constructed in testcases and the update flow
is run on device instance.

These tests should check that the co

fw update: tests for device

Tests for the device update flow.

Minimal PLDM packages are constructed in testcases and the update flow
is run on device instance.

These tests should check that the common code behaves as outlined in the
design [1]

References:
[1] https://github.com/openbmc/docs/blob/master/designs/code-update.md

Change-Id: I8f12839afd47ef3403a80439af54fedcc00f10be
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

test: common: software associations: remove NOLINT

remove `clang-analyzer-core.uninitialized.Branch` in a testcase.

Apparently the NOLINT is not required there, not sure if it was due to
clang upda

test: common: software associations: remove NOLINT

remove `clang-analyzer-core.uninitialized.Branch` in a testcase.

Apparently the NOLINT is not required there, not sure if it was due to
clang update or if it's been resolved in later revisions of the linked
patch. Anyways we can drop it now.

Tested: clang-tidy passes

Fixes: ade5c5aad34fa313b1bdd88577f44ba6f64ef43c

Change-Id: Ibba3a10db586b3096880fecba68ebc797b6ac077
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

test: common: software

Test API of `class Software`, focus on initial state on construction.

Change-Id: I20350748d02f62cfb8371fee68d43ebbdb91609c
Signed-off-by: Alexander Hansen <alexander.hansen@9

test: common: software

Test API of `class Software`, focus on initial state on construction.

Change-Id: I20350748d02f62cfb8371fee68d43ebbdb91609c
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

test: common: software version

Test Software Version DBus API.

Change-Id: I287b7e7957199463ec80bda8f71bf881bc0e5cb8
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

test: common: associations

Test software associations in common code.
Write necessary wrappers in example device to use the protected members.

Change-Id: If7c38f12472699672ed8a4c1b3e1c99c398cdba5
S

test: common: associations

Test software associations in common code.
Write necessary wrappers in example device to use the protected members.

Change-Id: If7c38f12472699672ed8a4c1b3e1c99c398cdba5
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

All: add purpose parameter to setVersion calls

All calls to setVersion now include a purpose argument, changing the
purpose string from "unknown" to "other".

Change-Id: I201db1719333b51deead2dd99c9

All: add purpose parameter to setVersion calls

All calls to setVersion now include a purpose argument, changing the
purpose string from "unknown" to "other".

Change-Id: I201db1719333b51deead2dd99c9f637c782efd6c
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>

show more ...

test: common: software config

Tests for the common configuration all updaters receive from EM.

Change-Id: Ic242b5fbaa88a1b10ec9b9e97e084e1e85e7e9e0
Signed-off-by: Alexander Hansen <alexander.hansen

test: common: software config

Tests for the common configuration all updaters receive from EM.

Change-Id: Ic242b5fbaa88a1b10ec9b9e97e084e1e85e7e9e0
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

test: common: random software id

Test that the random software id matches our regex.

Change-Id: I0eb9b5c58b993ef6172b059daec086872e7656fb
Signed-off-by: Alexander Hansen <alexander.hansen@9elements

test: common: random software id

Test that the random software id matches our regex.

Change-Id: I0eb9b5c58b993ef6172b059daec086872e7656fb
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

clang-tidy: remove some NOLINTS

Since readability-static-accessed-through-instance check has been
disabled in [1], the NOLINTs can be removed.

References:

[1] https://gerrit.openbmc.org/c/openbmc/

clang-tidy: remove some NOLINTS

Since readability-static-accessed-through-instance check has been
disabled in [1], the NOLINTs can be removed.

References:

[1] https://gerrit.openbmc.org/c/openbmc/phosphor-bmc-code-mgmt/+/80392

Change-Id: If7e80a0bc447bfbd054b6c007d230c2d14a54f41
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

phosphor-bmc-code-mgmt: Migrate to pldm_edac_crc32()

crc32 is deprecated in the libpldm API due to a lack of a common symbol
prefix. Migrate to pldm_edac_crc32().

Change-Id: Id3e0996452dc26d1dae2c6

phosphor-bmc-code-mgmt: Migrate to pldm_edac_crc32()

crc32 is deprecated in the libpldm API due to a lack of a common symbol
prefix. Migrate to pldm_edac_crc32().

Change-Id: Id3e0996452dc26d1dae2c635361e38e737a01efc
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: apply meson format

since [1] was merged in openbmc-build-scripts, meson format is required
to pass CI.

References:
[1] https://gerrit.openbmc.org/c/openbmc/openbmc-build-scripts/+/77742

Cha

meson: apply meson format

since [1] was merged in openbmc-build-scripts, meson format is required
to pass CI.

References:
[1] https://gerrit.openbmc.org/c/openbmc/openbmc-build-scripts/+/77742

Change-Id: I66206066c41dd3d6225855d0530c72f5089a964b
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

fixup: test: example device

- Fix the update progress loop in
test/common/exampledevice/example_device.cpp.
The update progress should be incremented there.

- Move a comment to the relevant lin

fixup: test: example device

- Fix the update progress loop in
test/common/exampledevice/example_device.cpp.
The update progress should be incremented there.

- Move a comment to the relevant lines in
test/common/exampledevice/example_updater_main.cpp

Tested: Unit tests pass.

Change-Id: I5fa908e1c6f95eaaa2710853c065fc341a30035f
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

fw update: implement example device

Introduce example-device and example-code-updater, which are used as
examples for how to implement devices and code updaters according to the
design [1]

Tested:

fw update: implement example device

Introduce example-device and example-code-updater, which are used as
examples for how to implement devices and code updaters according to the
design [1]

Tested:

The example code updater allows us to perform manual testing without
a dependency on any specific device.

Running the example code updater results in follow dbus output:

```
busctl --full --no-pager tree xyz.openbmc_project.ExampleCodeUpdater

└─ /xyz
└─ /xyz/openbmc_project
└─ /xyz/openbmc_project/software
└─ /xyz/openbmc_project/software/ExampleSoftware_4081

busctl --full --no-pager introspect xyz.openbmc_project.ExampleCodeUpdater /xyz/openbmc_project/software/ExampleSoftware_4081

CodeUpdater /xyz/openbmc_project/software/ExampleSoftware_4081
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
...
xyz.openbmc_project.Software.Activation interface - - -
.Activation property s "xyz.openbmc_project.Software.Activation.Activations.Active" emits-change writable
.RequestedActivation property s "xyz.openbmc_project.Software.Activation.RequestedActivations.None" emits-change writable
xyz.openbmc_project.Software.Update interface - - -
.StartUpdate method hs o -
.AllowedApplyTimes property as 1 "xyz.openbmc_project.Software.ApplyTime.RequestedApplyTimes.OnReset" emits-change
xyz.openbmc_project.Software.Version interface - - -
.Purpose property s "xyz.openbmc_project.Software.Version.VersionPurpose.Unknown" emits-change writable
.Version property s "v1.0"
```

References:
[1] https://github.com/openbmc/docs/blob/master/designs/code-update.md

Change-Id: I2bad241b3102e58eda5139174791adda82f6ca95
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: Ifc60fd8e7091d83202753a57f215667613f1691c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I4a9d4410fcf7c9e87481d7d962fbcc92d071c913
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I4a9d4410fcf7c9e87481d7d962fbcc92d071c913
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

fw update: library to create pldm fw package

Implement some helper functions to easily create a pldm fw package in a
few lines of user code.

This is helpful for unit testing the code update flow.

fw update: library to create pldm fw package

Implement some helper functions to easily create a pldm fw package in a
few lines of user code.

This is helpful for unit testing the code update flow.

The package created is for testing purpose. The library is not
fully-featured or complete and should not be relied upon for anything
other than the tests in this repo.

https://github.com/openbmc/docs/blob/master/designs/code-update.md

Tested: next few patches in series

Change-Id: If899e5537a2e5ac641544ca80e8876d83549da28
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

re-organize the current files into bmc directory

More daemons are being developed in phosphor-bmc-code-mgmt repo as part
of https://github.com/openbmc/docs/blob/master/designs/code-update.md.
For th

re-organize the current files into bmc directory

More daemons are being developed in phosphor-bmc-code-mgmt repo as part
of https://github.com/openbmc/docs/blob/master/designs/code-update.md.
For this move the current files for BMC code update into bmc
subdirectory for a better code organization.

Tested:
meson build passes.

Change-Id: I7b5575bcfbe54ac00aa803f94b5d8f6d69ce2f3f
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

test/README.md: Update access permissions

The default access permission for the README.md file should be 664.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia2c14646fd99eab3a580b1c2

test/README.md: Update access permissions

The default access permission for the README.md file should be 664.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia2c14646fd99eab3a580b1c276a46ff2f604b1ae

show more ...

test/README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "

test/README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia1af9ab633a14fb94bb6bb26800238fcb1d4ff95

show more ...

test/README.md: Fix MD004 warnings

The following warnings are generated by using markdownlint analysis:
```
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
```
Refer to markdo

test/README.md: Fix MD004 warnings

The following warnings are generated by using markdownlint analysis:
```
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
```
Refer to markdown-lint [1] to fix MD004
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/004-ul-style.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: If4b0dcbd538a886d593ab3162f019a817eadeedd

show more ...

test/README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading

test/README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Instructions on how to execute..."]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I957dbc3093701663267a93bee4f2c688b1f9d1e8

show more ...

gen-bios-tar: Update private signing key

Updating from 1024 bits to 4096 bits for a more secure key

Change-Id: Idaa9bcdc04ec4143ff8035c84040646458bf8398
Signed-off-by: Rashmica Gupta <rashmica@linu

gen-bios-tar: Update private signing key

Updating from 1024 bits to 4096 bits for a more secure key

Change-Id: Idaa9bcdc04ec4143ff8035c84040646458bf8398
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>

show more ...

clang-tidy: Enable performance-inefficient-string-concatenation

This check warns about the performance overhead arising from
concatenating strings using the operator+

Change-Id: I93a5797adb0ffc9aa1

clang-tidy: Enable performance-inefficient-string-concatenation

This check warns about the performance overhead arising from
concatenating strings using the operator+

Change-Id: I93a5797adb0ffc9aa1d2353bab0a5ff6773ec6d5
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Change-Id: Ia0867db019db8e40e710bdd4025e030061f7a992
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...