History log of /openbmc/phosphor-bmc-code-mgmt/reboot-guard-disable.service.in (Results 1 – 2 of 2)
Revision Date Author Comments
# 8d16554c 07-Sep-2022 Andrew Geissler <geissonator@yahoo.com>

ensure disable of reboot occurs after enable

Seen a few instances where both the enable and disable service seem to
get queued up at the same time (at least so close together that systemd
sees them

ensure disable of reboot occurs after enable

Seen a few instances where both the enable and disable service seem to
get queued up at the same time (at least so close together that systemd
sees them as being requested to run at the same time). This results in a
race condition on which runs first. Bad things happen if the disable
happens to get called before the enable.

Put an explicit dependency in the services so if they are both queued at
the same time, they are run in the correct order.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I0c7a04ede468e200b7fa2ca8184907ebeaf82d5d

show more ...


# 436be816 17-Jun-2020 Adriana Kobylak <anoo@us.ibm.com>

build: Rename .service files to service.in

Rename the .service files to .service.in to allow service files
to support config variable substitution. Ex, this line in .in:
ExecStart=

build: Rename .service files to service.in

Rename the .service files to .service.in to allow service files
to support config variable substitution. Ex, this line in .in:
ExecStart=/usr/bin/obmc-flash-bmc ubiro @IMG_UPLOAD_DIR@
would become this in .service file:
ExecStart=/usr/bin/obmc-flash-bmc ubiro "/tmp/images"

This allows the service files to use the user defined config
values instead of making assumptions that the default is used.

This commit only renames the service files. The subsequent
commit will make use of this feature.

In addition, the subdir meson.build files were deleted with
this commit. The reason is that the service files need to be
moved to the main meson.build to be able to read the conf file,
and without the service files, the subdir meson.build files are
just a couple lines long so there's not really a reason to have a
separate meson.build file.

Tested: Verified the service files were installed as before.

Change-Id: I29190d1f0664352fbee8a0ada9de959fd0269d6e
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...