clang-error: fix clang-diagnostic-inconsistent-missing-override error

This clang-error is generated when a function overrides a member
function but is not marked 'override'.

Change-Id: If27a9a75ae1

clang-error: fix clang-diagnostic-inconsistent-missing-override error

This clang-error is generated when a function overrides a member
function but is not marked 'override'.

Change-Id: If27a9a75ae1d7b6112226e233db30421a02e8556
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I8870ce249bba3373e85f82903cfa875d6a7c8725
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Populate MinimumVersion property

The Minimum Version is now an available D-Bus interface:
```
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/70110
```
Populate its value if it's bei

Populate MinimumVersion property

The Minimum Version is now an available D-Bus interface:
```
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/70110
```
Populate its value if it's being defined.

Tested: If the msl meson options are defined, the D-Bus property is
populated with the value of the defined minimum version:
```
root@witherspoon:~# busctl get-property xyz.openbmc_project.Software.BMC.Updater /xyz/openbmc_project/software xyz.openbmc_project.Software.MinimumVersion MinimumVersion
s "2.15.0"
```

Change-Id: I0f9df0cfd7c06794df836e161b3416094a8535de
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

sdbus++: use non-deprecated namespaces

The sdbusplus repository has deprecated some namespaces and they are
currently only enabled with the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE
guard. Switch to the

sdbus++: use non-deprecated namespaces

The sdbusplus repository has deprecated some namespaces and they are
currently only enabled with the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE
guard. Switch to the new namespace names.

Change-Id: Iaab6df118eb4dc65139e759dcb22851422f88389
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I96286490697ce5d7fecc1c9c358f5f1d054137ec

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5479733e7f0a81c10fa432538be3f6cf730541f4

show more ...

dual-image: Detect the running image slot

Add detect-slot-aspeed to detect which slot it is running on, and
assign the member variable, which will be used in future commits.

Tested:
* In normal

dual-image: Detect the running image slot

Add detect-slot-aspeed to detect which slot it is running on, and
assign the member variable, which will be used in future commits.

Tested:
* In normal case, verify the primary slot is 0 and secondary slot
is 1.
* Manually assign value 1 in /run/media/slot, and verify the slot
number is reversed.
* Manually trigger wdt2 timeout and verify in secondary flash that
the slot number is correct, that the running slot is 1 and the
other slot is 0.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I69edb1961b4c4bb79e7897c38b9ce8dded42f829

show more ...

cleanup: Fix warnings found by cppcheck

Fix various warnings found by cppcheck.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I4db2319f5890d7aa73c8f418f610a6cba338ce24

bios: Update bios_active version after code update

When BIOS is updated, update the bios_active's version so that it shows
the expected version, otherwise it shows the version before the

bios: Update bios_active version after code update

When BIOS is updated, update the bios_active's version so that it shows
the expected version, otherwise it shows the version before the update.

The new uploaded version is not deleted in this commit.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I93ea834411ae48054d6514517d6e57a4d69e4b92

show more ...

Add BIOS DBus object

When HOST_BIOS_UPGRADE is enabled, create the "default" BIOS DBus object
so that it could be used for other services.
Typically, the BIOS version is sent from BI

Add BIOS DBus object

When HOST_BIOS_UPGRADE is enabled, create the "default" BIOS DBus object
so that it could be used for other services.
Typically, the BIOS version is sent from BIOS via OEM ipmi command, and
the oem handler could set the BIOS version accordingly.

When the BIOS is updated, this service could directly set the BIOS
version as well.

Tested: Verify the BIOS activation/version object is created on DBus.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I10d7b9a035d6a6f649fc5950f37e8fdb0db70176

show more ...

Add support for full BMC FW flash image

Add BMC flash file name list for full flash image.
Save the information for which images are being updated.

Tested: Update '.static.mtd.a

Add support for full BMC FW flash image

Add BMC flash file name list for full flash image.
Save the information for which images are being updated.

Tested: Update '.static.mtd.all.tar' with redfish API (
UpdateService.SimpleUpdate).
Verified the code update works well.

Change-Id: Icb47e518db61a8d17998179aed328d0cf56db6f5
Signed-off-by: Bright Cheng <bright_cheng@wiwynn.com>
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

clang-format: update to latest from docs repo

The openbmc/docs/style/cpp/.clang-format has been updated to support
clang-format10, take this opportunity to update it in this repo.

clang-format: update to latest from docs repo

The openbmc/docs/style/cpp/.clang-format has been updated to support
clang-format10, take this opportunity to update it in this repo.

Change-Id: I9e6b9853bf4cd7399b1ae504ea3be5093d763fee
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

string: ensure string included

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

string: ensure string included

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I457b7ca46bd010a9c5b363495d43a9b38e430bcf

show more ...

Build issue fix with ubifs

Recent change for updateable association causes
build failure when ubifs is enabled. Made newly
added api createUpdateableAssociation public.

Test

Build issue fix with ubifs

Recent change for updateable association causes
build failure when ubifs is enabled. Made newly
added api createUpdateableAssociation public.

Tested:
Enabled ubifs and build is successful.

Change-Id: I2ba90e876ce8a1f95d7cd3b2839b543f27f1b15d
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Add updateable association to active BMC FW object

Add 'updateable' association to the active BMC
firmware version object. This 'updateable' association
can be used to mark all the f

Add updateable association to active BMC FW object

Add 'updateable' association to the active BMC
firmware version object. This 'updateable' association
can be used to mark all the firmware components
which can be programmable from BMC interfaces like
Redfish.

Tested:
- Able to query the updateable endpoint objects.
Req:
busctl call xyz.openbmc_project.ObjectMapper
/xyz/openbmc_project/software/updateable
org.freedesktop.DBus.Properties Get ss
xyz.openbmc_project.Association endpoints

Res:
v as 1 "/xyz/openbmc_project/software/1201fc36"

- Get on FirmwareInventory shows correct value
for 'Updateable' property. Redfish support is
added as new commit.

URI: /redfish/v1/UpdateService/FirmwareInventory/1201fc36
Res: Can see "Updateable": true output

Change-Id: Id74a134dacdea86399d10fbe0a4b0e62728d1cf4
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

serialize: Add version purpose

Add store/restore of the version purpose. Only need to store it if the
activation was successful, since those are the only versions that are
restored a

serialize: Add version purpose

Add store/restore of the version purpose. Only need to store it if the
activation was successful, since those are the only versions that are
restored after BMC reboot.

Tested: Verified a code update with an image of purpose System got its
value restored instead of being set to BMC by default.

Change-Id: I6414e9f3b992a8c29046b4d3a3d581c20a166cee
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Move to new association interface

A new association interface is defined in phosphor-dbus-interfaces
It would be nice to move the local version of the interface
to the new one.

Move to new association interface

A new association interface is defined in phosphor-dbus-interfaces
It would be nice to move the local version of the interface
to the new one.

The behavior of how association work is described here:
https://github.com/openbmc/docs/blob/master/object-mapper.md#associations

Partially resolves openbmc/openbmc#3584

Tested: See the org.openbmc.Associations interface has been replaced by the xyz
one in /xyz/openbmc_project/software/version_id object

Signed-off-by: John Wang <wangzqbj@inspur.com>
Change-Id: I249b7fea26f720b57e60e0bf8ba8bc71c620af98

show more ...

item_updater: Call remove association on delete

The remove association function was supposed to be called on delete but
was never implemented so if the associations are queried but the v

item_updater: Call remove association on delete

The remove association function was supposed to be called on delete but
was never implemented so if the associations are queried but the version
has been deleted, that'd be false information, so call to remove the
associations on delete, also rename it to delete all associations,
because the delete function already determined if the requested version
is functional.

Tested: Verified the associations for the requested version are deleted
with a DeleteAll and Delete call.

Change-Id: Ia4fde01c9500b648660bc9a4c355d44a35af7cc5
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Fix being able to activate a Failed version

When an activation fails, the version is marked as Failed.
On a subsequent activation, the bmc updater core dumps due
to 2 issues during t

Fix being able to activate a Failed version

When an activation fails, the version is marked as Failed.
On a subsequent activation, the bmc updater core dumps due
to 2 issues during the freeSpace call:
1. The Failed activation doesn't have a Priority object, so
default its priority to a large value.
2. If the subsequent activation is to the same version id,
then freeSpace should not do an erase on it, because that
removes the activations object that it's trying to activate.

Tested: Verified that doing an activation after a version
was marked as Failed did not core dump the updater anymore.

Change-Id: Iba36497b53738e00283cfec55e8c666f943cd5d5
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

clang-format: Update to match docs repo

Update the .clang-format file.
Now includes header sorting and updating PointerAlignment.

Change-Id: I5c7690d8d83cdebe26ff3a73b90a2a8c17d

clang-format: Update to match docs repo

Update the .clang-format file.
Now includes header sorting and updating PointerAlignment.

Change-Id: I5c7690d8d83cdebe26ff3a73b90a2a8c17dd8054
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move setting the priority U-Boot variable to ubi

The service that sets the priority value is unique to the ubi
layout because there is only one version at a time on the
static layout

Move setting the priority U-Boot variable to ubi

The service that sets the priority value is unique to the ubi
layout because there is only one version at a time on the
static layout.
Move the calling of the service to the ubi implementation.

Tested:
- Witherspoon: Priorities are still set.
- Romulus: The BMC.Updater app does not core dump with the
latest sdbusplus changes due to calling a non-existent service.

Change-Id: Ica1c68f00d5cb43c51ee09c5a3851613edf941d5
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

item_updater: sort ubi specific code

Add item_updater_helper and implement it in ubi and static layouts.

Tested: Build this repo on both Romulus and Witherspoon OK;
Test

item_updater: sort ubi specific code

Add item_updater_helper and implement it in ubi and static layouts.

Tested: Build this repo on both Romulus and Witherspoon OK;
Tested on Romulus and Witherspoon that code update works fine.

Change-Id: I706cfe63900f89bb41672dcc745b3483e06838c7
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Perform uboot mirroring operation during BMC boot

Add a function to call the "mirror u-boot" service when the BMC boots.
Since the BMC is booting, we know we had a good u-boot and u-boot

Perform uboot mirroring operation during BMC boot

Add a function to call the "mirror u-boot" service when the BMC boots.
Since the BMC is booting, we know we had a good u-boot and u-boot
environment, so we can safely copy the current one to the alternate
chip.

Change-Id: Ib628ea4a5fc9ae8d80f1047bddf94eb3fa52cdba
Signed-off-by: Eddie James <eajames@us.ibm.com>

show more ...

Enable clang code format

Change-Id: Ia899858c11cff6e4fa26b820b35b1e5dca1b57df
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

Call freeSpace() function before update

Add new function to delete version objects as part of the Activation.
The code update service automatically removes the ubi volumes to make
sp

Call freeSpace() function before update

Add new function to delete version objects as part of the Activation.
The code update service automatically removes the ubi volumes to make
space, but it does not remove the dbus object associated with the
removed volume. The side effect of leaving the dbus object is that
when freePriority() is called at the end of the Activation, a new
priority value is assigned to all version dbus objects (including the
deleted one) which fills up the u-boot environment variables.

Tested: Verified that after an Activation, there were only 2 priority
values in the u-boot env variables instead of 3, and they corresponded
to existing volumes.

Change-Id: I41a7ea95eeea1c8a2cb8ce4b41671e77f5c42cac
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...