Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I4025cb986df411caca292ae207bf6e79f232cc1b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I04b3a42ae6b6e53cad330bcd6b524d78368d2bd1
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add meson build

This adds the meson build files to be able to use meson instead of
autotools.

Tested: builds as expected, able to change password and log in.

Change-Id: I834b2fe205c3b79086b7a55e4b

Add meson build

This adds the meson build files to be able to use meson instead of
autotools.

Tested: builds as expected, able to change password and log in.

Change-Id: I834b2fe205c3b79086b7a55e4b7bcc39efa8a95e
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Fixes for warnings

Migrating to meson compiles with more warnings enabled. This change
fixes those warnings. Most were signedness differences.

Tested: compiles with no errors
able to log in

Fixes for warnings

Migrating to meson compiles with more warnings enabled. This change
fixes those warnings. Most were signedness differences.

Tested: compiles with no errors
able to log in over ipmi and change password

Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Change-Id: Iae8ac6a5797919f52d61fbf546738094e57dc2ee

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I67a8e53501042adf9b23a7f48e201d079aff5d69
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Improve exceed length limit error message

The error message printed when username or password length exceeds the
limit uses a hex value without 0x prefix, which is really confusing in
some cases. Th

Improve exceed length limit error message

The error message printed when username or password length exceeds the
limit uses a hex value without 0x prefix, which is really confusing in
some cases. This patch changes them to decimal format. Also use removes
extra strlen calls as they are of O(1) complexity.

Tested:
Update an ipmi user with a 22-char password, 22 is logged instead of 16

Change-Id: Idec08d920c6377d4db9af7dd616c73f618a1e839
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Return PAM_AUTHTOK_ERR when length exceeds limit

Currently, when the length of username or password exceeds IPMI limit,
it returns PAM_NEW_AUTHTOK_REQD. But according to the man page of
pam_sm_chaut

Return PAM_AUTHTOK_ERR when length exceeds limit

Currently, when the length of username or password exceeds IPMI limit,
it returns PAM_NEW_AUTHTOK_REQD. But according to the man page of
pam_sm_chauthtok, PAM_NEW_AUTHTOK_REQD is not a vaild return value.
Return PAM_AUTHTOK_ERR instead.

Tested:
Try updating a user in ipmi group with a 21-char password by calling
pam_chauthtok, PAM_AUTHTOK_ERR is returned.

Change-Id: Ia055f253865e9f4174dcbee8eec87917b7612f94
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

[pam-ipmi]: Fix key & password file permission

Limit keyfile & password file permission to owner read & write
600, instead of reading by group & other users.
This change will update the file permiss

[pam-ipmi]: Fix key & password file permission

Limit keyfile & password file permission to owner read & write
600, instead of reading by group & other users.
This change will update the file permission to correct one,
whenever an update is requested

Tested: changed passwords to see that the permissions get updated.

Change-Id: I7bf6f01e0b92730cc5cfef5d1eb9b0add60e9d83
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Removal of excess 16 bytes padding

Cipher block padding is applied twice(once manually, and
once through EVP_CipherFinal()) causing excess 16 bytes of
data. Manual padding is removed to fix the issu

Removal of excess 16 bytes padding

Cipher block padding is applied twice(once manually, and
once through EVP_CipherFinal()) causing excess 16 bytes of
data. Manual padding is removed to fix the issue.

Unit-Test:
1. Verified that files are padded correctly without
excess 16 bytes. Also, verified the password update and
RMCP+ login using ipmitool
ipmitool user set password <userid> <password>
ipmitool -I lanplus -H 127.0.0.1 -U <userid> -P <password>
raw 6 1
2. Also verified renaming of user name and login
after that

Resolves openbmc/openbmc#3463

Change-Id: Icc29c4747388ef377a00cb79be6096938a360f6b
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

fixup: do not assign immediately before reassigning

Minor cleanup from cppcheck to not assign before immediately
re-assigning.

[src/pam_ipmisave/pam_ipmisave.c:243] ->
[src/pam_ipmisave/pam_ipmisav

fixup: do not assign immediately before reassigning

Minor cleanup from cppcheck to not assign before immediately
re-assigning.

[src/pam_ipmisave/pam_ipmisave.c:243] ->
[src/pam_ipmisave/pam_ipmisave.c:245]: (style)
Variable 'fd' is reassigned a value before the old
one has been used.

Change-Id: I3d995e561973bc37cef633232016c6e6340ea814
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

move .clang-format file into position

The CI expects the .clang-format file to appear at the root of the
repository.

Also fixes the Language selection from C to Cpp. Clang-format uses the
Cpp lang

move .clang-format file into position

The CI expects the .clang-format file to appear at the root of the
repository.

Also fixes the Language selection from C to Cpp. Clang-format uses the
Cpp language specifier for both C and C++.

Fixes it to use spaces instead of tabs per:
https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#c

Change-Id: Ibcc40eeb04c73f53a33986bdc47d69e59d59373c
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

PAM-IPMI module - stores special users password

Special group('ipmi') user's passwords are stored
by pam_ipmicheck and pam_ipmisave module.
pam_ipmicheck will check password restrictions
for the spe

PAM-IPMI module - stores special users password

Special group('ipmi') user's passwords are stored
by pam_ipmicheck and pam_ipmisave module.
pam_ipmicheck will check password restrictions
for the special group user and pam_ipmisave
will update the password in special password
file in encrypted form.
Note: These modules still needs pam_unix support
to store the hashed password and work along
with pam_unix in stacked module concept

Change-Id: Id959107cae1819ff622e5993cd276075bcb92d2a
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...