UTIL:D1 keyword added to backup restore.

UTIL:D1 keywords needs to be backed up and restored
as the case may be to either the cache or hardware.

On Hardware based back up storage it will be backed

UTIL:D1 keyword added to backup restore.

UTIL:D1 keywords needs to be backed up and restored
as the case may be to either the cache or hardware.

On Hardware based back up storage it will be backed to VSBK:D1

Change-Id: I7f79532b216468751525aa81282e342b6ba6fb20
Signed-off-by: Giridhari Krishna <giridharikrishnan@gmail.com>

show more ...

Set default for LX and FC keywords

The commit set default values for keyword LX and FC.

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: Ic948c9cfa9906b873fab51d873936a03647b3a3c

UTIL F0 keyword addition.

F0 Keyword from UTIL Record is being used for restoring Replay ID
even during factory reset.
Data:
Keyword details in Michael Lim's box folder.

Signed-off-by: Giridhari Kr

UTIL F0 keyword addition.

F0 Keyword from UTIL Record is being used for restoring Replay ID
even during factory reset.
Data:
Keyword details in Michael Lim's box folder.

Signed-off-by: Giridhari Krishna <giridharikrishnan@gmail.com>
Change-Id: Icf8e3f544159ae3d174976681c440260cee3a065

show more ...

Added DDR5 DDIMM capacity calculation

Added the calculation for the capacity of a ddr5 ddimm

Change-Id: Ia20c2828db8ee695747ca90f62b2a2458ccd5394
Signed-off-by: jinuthomas <jinu.joy.thomas@in.ibm.c

Added DDR5 DDIMM capacity calculation

Added the calculation for the capacity of a ddr5 ddimm

Change-Id: Ia20c2828db8ee695747ca90f62b2a2458ccd5394
Signed-off-by: jinuthomas <jinu.joy.thomas@in.ibm.com>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I51402657aa93a128cbcb2ba56eb4138e179d3438

show more ...

Unable to set minimum ship level

The software-manager-tool internally calls WriteKeyword d-bus api to
set firmware version in hardware (in VSYS FV).
The software-manager-tool is unable to set curren

Unable to set minimum ship level

The software-manager-tool internally calls WriteKeyword d-bus api to
set firmware version in hardware (in VSYS FV).
The software-manager-tool is unable to set current firmware level
as minimum ship level due to a bug in vpd-manager "WriteKeyword"
d-bus api.

In WriteKeyword, when we try to read from filestream and write into
vector, the maximum possible vpd size(65504) is given as the total
bytes to be read (n). But the actual hardware data is lesser than
65504 in size.

If the filestream read operation runs out of characters to extract
before n characters have been successfully read, it reads the
available characters and stores it in vector and internally it sets
both bad bit and fail bit.

And with recent changes since we catch all filestream exceptions, this bug
has been caught and code flow is broken.

Fix:
Query the size of the VPD and perform filestream read based on the
given VPD size. If the given VPD size exceeds the maximum possible size
(65504), then read till 65504 only.

The same issue has been addressed in vpd-tool read keyword from hardware.

Test:
vpd-tool -r -H -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R VSYS -K FV
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"FV": "fw1020.00-00 "
}
}

vpd-tool -r -O /system/chassis/motherboard -R VSYS -K FV
{
"/system/chassis/motherboard": {
"FV": "fw1020.00-00 "
}
}

software-manager-tool --setminlevel
<6> Current version: fw1050.00-4.16-dirty. Setting Minimum Ship Level to: fw1050.00-4

vpd-tool -r -O /system/chassis/motherboard -R VSYS -K FV
{
"/system/chassis/motherboard": {
"FV": "fw1050.00-4 "
}
}

vpd-tool -r -H -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R VSYS -K FV
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"FV": "fw1050.00-4 "
}
}

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: I6e24d744542f0a67a872605c7793d73ee27c541c

show more ...

Catching File Exceptions in openpower-vpd-parser

In this commit, I have added code to handle file exceptions
more effectively. By implementing proper exception handling,
we can improve the robustnes

Catching File Exceptions in openpower-vpd-parser

In this commit, I have added code to handle file exceptions
more effectively. By implementing proper exception handling,
we can improve the robustness and reliability of the file
operations within our codebase.

Here are the key changes made in this commit:

- Introduced a try-catch block around the file operation sections.
- Within the try block, added code to perform the necessary file
operations.
- Implemented catch blocks to handle specific file exceptions.
- In each catch block, included appropriate error handling logic,
such as logging the error message or displaying a user-friendly
error message.
- Ensured that the catch blocks gracefully handle the exceptions
and prevent the program from crashing or behaving unexpectedly.

By adding this exception handling code, we can anticipate and handle
potential file-related errors gracefully, providing a smoother
experience for users and preventing any unexpected crashes or data
loss. This would also aid in debugging issues.

Change-Id: I621a7f0ba68d2c298e4fea0a9d3e21d1939cd090
Signed-off-by: jinuthomas <jinu.joy.thomas@in.ibm.com>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I46a48a720bc66e845c883

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I46a48a720bc66e845c8838ec1aa1c3809c09b49d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

vpd-tool: Flow to read keyword from hardware updated

The commit implements change to check if the offset passed by the user
for a given EEPROM path is equal to the offset if defined for that
EEPROM

vpd-tool: Flow to read keyword from hardware updated

The commit implements change to check if the offset passed by the user
for a given EEPROM path is equal to the offset if defined for that
EEPROM in inventory JSON.
In case of any mismatch, error message is flagged to the user.

As all EEPROMs are not modelled in inventory JSON file, In order to
handle case where an EEPROM path passed by user is not present in JSON,
check has been added to avoid any exception thrown due to extraction of
inventory path from JSON based on the passed EEPROM path.

Test cases:

CASE1: Trying to read from i2c FRU

/tmp/vpd-tool -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K PN --seek 0x30000
Invalid offset, please correct the offset
Recommended Offset is: 0

/tmp/vpd-tool -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K PN
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"PN": "00L5521"
}
}

CASE2: Trying to read from proc and EEPROM not defined in JSON:

/tmp/vpd-tool -r -H -O /sys/bus/spi/drivers/at25/spi22.0/eeprom -R VINI -K CC
Invalid offset, please correct the offset
Recommended Offset is: 196608

/tmp/vpd-tool -r -H -O /sys/bus/spi/drivers/at25/spi22.0/eeprom -R VINI -K CC --seek 0x30000
{
"/sys/bus/spi/drivers/at25/spi22.0/eeprom": {
"CC": "5C5F"
}
}
/tmp/vpd-tool -r -H -O /sys/bus/spi/drivers/at25/spi23.0/eeprom -R VINI -K CC --seek 0x30000
{
"/sys/bus/spi/drivers/at25/spi23.0/eeprom": {
"CC": "5C5F"
}
}

/tmp/vpd-tool -r -H -O /sys/bus/spi/drivers/at25/spi23.0/eeprom -R VINI -K CC --seek 0x3000
VHDR record not found
Did you provide a valid offset? By default VPD offset is taken as 0. To input offset, use --seek. Refer vpd-tool help.

/tmp/vpd-tool -r -H -O /sys/bus/spi/drivers/at25/spi23.0/eeprom -R VINI -K CC
VHDR record not found
Did you provide a valid offset? By default VPD offset is taken as 0. To input offset, use --seek. Refer vpd-tool help.

/tmp/vpd-tool -r -H -O /sys/bus/spi/drivers/at25/spi22.0/eeprom -R VINI -K CC --seek 0x3000
Invalid offset, please correct the offset
Recommended Offset is: 196608

Signed-off-by: Giridhari Krishna <giridharikrishnan@gmail.com>
Change-Id: I246ca983fc75490999f18386bf60e949959d49d2

show more ...

DIMM capacity changed from MB to KB

Calculation of DIMM capacity is changed to KB for it to have as required in GUI.

Test Result:
busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbm

DIMM capacity changed from MB to KB

Calculation of DIMM capacity is changed to KB for it to have as required in GUI.

Test Result:
busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0

MemoryDataWidth property q 0 emits-change writable
.MemoryDeviceLocator property s "" emits-change writable
.MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable
.MemorySizeInKB property u 67108864 emits-change writable
Signed-off-by: Giridhari Krishna <giridharikrishnan@gmail.com>
Change-Id: Ied51938c4ca9d42f6e761db403c06a69b0d8e0ba

show more ...

Back up and Restore update

The commit updates the flow of Back up and Restore of system VPD.

Updates:
- Removing call_out_inventory_path tag from the PEL create call
in case there is any issue whil

Back up and Restore update

The commit updates the flow of Back up and Restore of system VPD.

Updates:
- Removing call_out_inventory_path tag from the PEL create call
in case there is any issue while backup or restore.
This was done to avoid any calls from phosphor-logging to
VPD-Manager at this stage as Manager service is not up at this
point resulting in a D-Bus call failure.

- Removing dupicate code as and where possible in the flow.

The commit is an extension of following commit:
https://gerrit.openbmc.org/c/openbmc/openpower-vpd-parser/+/62250/

Tests:
PEL was created duringthe flow and confirmed that there was no
call to VPD-Manager from phosphor-logging.

Tested for all te scenarios w.r.t backup and restore of system
VPD.

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: I92779247438bf50d907fd7f60ed94dda6fadb2a0

show more ...

Backup & restore changes for bonnell's system VPD

This commit implements the changes of system backplane VPD backup on
the base banel VPD and restoring it from the base panel VPD

The bonnell BMC is

Backup & restore changes for bonnell's system VPD

This commit implements the changes of system backplane VPD backup on
the base banel VPD and restoring it from the base panel VPD

The bonnell BMC is embedded in the system backplane, so if either fails,
the backplane should be replaced as a whole. So the changes have been
made to backup the system backplane critical keywords on the operator
panel base EEPROM under the VSBK record.

Test:
Case 1: A PEL with error severity is created when the base
panel EEPROM file doesn't exist.

Case 2: A PEL with error severity is created when the base
panel VPD has ecc exceptions.

Case 3: A PEL with error severity is created when the base
panel EEPROM doesn't contain VSBK record.

Case 4: System VPD's critical keywords are backing up in the base panel
VPD

Case 5: System VPD's critical keywords are restoring from the base panel
VPD

Case 6: The VSBK record creation and population of properties on dbus

Case 7: A PEL with warning serverity is created when there is a
mismatch between system VPD & base panel keyword values.

Case 8: A PEL with error serverity is created when both the system VPD
& base panel keyword values are default.

Tests above works as expected.

Change-Id: Ieea6ff4e267518f010c924e2d51a2b080b47e91c
Signed-off-by: Kantesh Nagaradder <kantesh.nagaradder@ibm.com>

show more ...

vpd-tool:Skip displaying Asset interface

vpd-tool by default displays specific VINI properties for all FRUs
which is again displayed as a part of Asset interface properties when
the Asset interface

vpd-tool:Skip displaying Asset interface

vpd-tool by default displays specific VINI properties for all FRUs
which is again displayed as a part of Asset interface properties when
the Asset interface is found in vpd JSON extraInterfaces{}.

To avoid displaying duplicates in vpd-tool, vpd-tool skips displaying
Asset interface properties.

Test:
Tested that no duplicates are found in vpd-tool output.

vpd-tool -o -O /system/chassis/motherboard/fan1
[
    {
        "/system/chassis/motherboard/fan1": {
            "CC": "7B5G",
            "DR": "Fan",
            "FN": "02YK237",
            "LocationCode": "U78DA.ND0.WZS002T-A1",
            "Manufacturer": "Delta",
            "PN": "02YK200",
            "Present": "true",
            "RI": "",
            "RT": "",
            "SN": "YS10JP12V0TY",
            "TYPE": "FRU",
            "type": "xyz.openbmc_project.Inventory.Item.Fan"
        }
    }
]

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: I6ee4d7210ac9cf5178685a3dbf6581f973dd2235

show more ...

Update service files in repo (#133)

The service files in the repo are currently used for
upstream compilation only, we will move to use this at
a later stage , so we will need to keep the data in sy

Update service files in repo (#133)

The service files in the repo are currently used for
upstream compilation only, we will move to use this at
a later stage , so we will need to keep the data in sync.

Change-Id: I34137fc60395146a4dc72a5c55b57e18d2edff8d
Signed-off-by: jinuthomas <jinu.joy.thomas@in.ibm.com>

show more ...

fix GCC 13 issues

GCC 13 removes `uint*_t` family of types from one of the common
includes so we need to explicitly include cstdint.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I

fix GCC 13 issues

GCC 13 removes `uint*_t` family of types from one of the common
includes so we need to explicitly include cstdint.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I010b4a0e7c1fa1c9d2a79b83918a92fa33493e93

show more ...

Added CCIN for ISDIMM

CCIN values added based on Bonnell_IS_DIMM Service Plan_v2

Change-Id: Ic836802bec723f6ca8001e9b2c09f6fb696e4587
Signed-off-by: jinuthomas <jinu.joy.thomas@in.ibm.com>

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in Op

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in OpenBMC had been taking advantage of in that
we were able to document our templated target dependencies without it
actually doing anything. The real installation of services within
targets occurs in our bitbake recipes due to the complexity of chassis
and host instances on a per machine basis.

Leave the dependency information in the service files but comment them
out. It's useful to be able to look at a service and understand which
targets it's going to be installed into by the bitbake recipes.

In some cases, we had hard coded the target instance, which does install
the service correctly, but only in that one target. All services should
be installed via the bitbake recipe to ensure the service is properly
installed in all instances of the target. Once the bump for this commit
goes into openbmc/openbmc, I will ensure the recipe is updated to
install all services correctly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I80aa53404644f83bdbd5cbfbbdafc190011a75c8

show more ...

vpd-tool: Fixing of display of KW values having 0x00s

Keywords with values "0x00..." are being displayed now in Hex.
~# /tmp/vpd_tool -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K B4

vpd-tool: Fixing of display of KW values having 0x00s

Keywords with values "0x00..." are being displayed now in Hex.
~# /tmp/vpd_tool -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K B4
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"B4": "0x00"
}
}
~# /tmp/vpd_tool -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K B3
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"B3": "0x000000000000"
}
}
~# /tmp/vpd_tool -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K B7
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"B7": "0x000000000000000000000000"
}
}
HexDump results for comparison:
00000170 80 01 42 33 06 00 00 00 00 00 00 42 34 01 00 42 |..B3.......B4..B|
00000180 37 0c 00 00 00 00 00 00 00 00 00 00 00 00 50 46 |7.............PF|

Signed-off-by: Giridhari Krishna <giridharikrishnan@gmail.com>
Change-Id: I242caab54cb3c28d74819e614b99df79f881ba5a

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia442cdc88aaeaab2f1384cc46a56f5cd5e40f2f5
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

vpd-tool #kw support

This commit is to enable vpd-tool read and write support for pound
keywords starting with # and for numeric keywords.

This commit enables a way to read and write keyword values

vpd-tool #kw support

This commit is to enable vpd-tool read and write support for pound
keywords starting with # and for numeric keywords.

This commit enables a way to read and write keyword values using --file
option, where --file takes a file with absolute path.

when --file option used with --readKeyword flag - vpd-tool saves the
output in the given file.
and when the file option used with --writeKeyword flag - the vpd-tool
takes the value from file and performs write operation.

Test:
-----------------------------------------------
Case 1: Read from hardware and save in text file
-----------------------------------------------
vpd-tool -r -H -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R PSPD -K "#D" --file /tmp/output.txt
Value read is saved in the file /tmp/output.txt

-----------------------------------------------
Case 2: Write to hardware by taking input from a text file
-----------------------------------------------
:~# cat /tmp/write.txt
00102030405060607020304050601020304050606040302010

:~# vpd-tool -w -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R PSPD -K "#D" --file /tmp/write.txt -H
Data updated successfully

:~# vpd-tool -r -H -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R PSPD -K "#D"
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"#D": "0x0010203040506060702030405060102030405060604030201000000000 ...0000"
}
}

-----------------------------------------------
Case 3: Read from cache and pipe to text file
-----------------------------------------------
:~# vpd-tool -r -O /system/chassis/motherboard -R PSPD -K "#D" --file /tmp/read-motherboard-#D.txt
Value read is saved in the file /tmp/read-motherboard-#D.txt

-----------------------------------------------
Case 4: Write to cache by taking input from text file
-----------------------------------------------
:~# cat /tmp/write.txt
00102030405060607020304050601020304050606040302010

:~# vpd-tool -w -O /system/chassis/motherboard -R PSPD -K "#D" --file /tmp/write.txt
Data updated successfully

:~# vpd-tool -r -O /system/chassis/motherboard -R PSPD -K "#D"
{
"/system/chassis/motherboard": {
"#D": "0x0010203040506060702030405060102030405060604030201000000000000000000....."
}
}

-----------------------------------------------
Case 5: Write to cache by taking hex input from console
-----------------------------------------------
:~# vpd-tool -w -O /system/chassis/motherboard -R PSPD -K "#D" -V 0x65
Data updated successfully

:~# vpd-tool -r -O /system/chassis/motherboard -R PSPD -K "#D"
{
"/system/chassis/motherboard": {
"#D": "0x65100c0c000000000000000 ...
}
}

Case 5.1: Write to cache by providing ascii values as input from console

vpd-tool -w -O /system/chassis/motherboard -R PSPD -K "#D" -V abcd
Data updated successfully

vpd-tool -r -O /system/chassis/motherboard -R PSPD -K "#D"
{
"/system/chassis/motherboard": {
"#D": "0x6162636440506060702030405060102030405060604030201000000 .."
}
}

-----------------------------------------------
Case 6: Read from cache and display on console
-----------------------------------------------
:~# vpd-tool -r -O /system/chassis/motherboard -R PSPD -K "#D"
{
"/system/chassis/motherboard": {
"#D": "0x00100c0c00000000000000000000000000000000000000 .....
}
}

-----------------------------------------------
Case 7: Read from hardware and display on console
-----------------------------------------------
vpd-tool -r -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R PSPD -K "#D" -H
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"#D": "0x651020304050606070203040506010203040506060403020100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 ......... 000000000000000000000000000000000000000"
}
}

-----------------------------------------------
Case 8: Write to hardware via console
-----------------------------------------------
vpd-tool -w -H -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R PSPD -K "#D" -V 0x00100c0c000000000000000000000000000000000000
Data updated successfully

vpd-tool -r -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R PSPD -K "#D" -H
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"#D": "0x00100c0c00000000000000000000000000000000000030201000000000000000000000000 ...
}
}

-----------------------------------------------
Case 9: Write 10240 bytes on dbus
-----------------------------------------------
time vpd-tool -w -O /system/chassis/motherboard -R PSPD -K "#D" --file /tmp/output.txt

Data updated successfully

real 0m49.564s
user 0m0.047s
sys 0m0.009s

time vpd-tool -r -O /system/chassis/motherboard -R PSPD -K "#D"
{
"/system/chassis/motherboard": {
"#D": "0x01100c0c0000.....0000123456782746002"
}
}

real 0m0.072s
user 0m0.057s
sys 0m0.001s
------------------------------------------------

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: I3977a7778b28ebcada7788f619b18bbca6ed0c8c

show more ...

vpd-tool: Bug fix for displaying non printable value

Hexa decimal string getting truncated to a byte,
This fix addresses the issue.
Test:
/tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0

vpd-tool: Bug fix for displaying non printable value

Hexa decimal string getting truncated to a byte,
This fix addresses the issue.
Test:
/tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VCFG -K Z1
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"Z1": "0x0894ef83188c"
}
}
/tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VCFG -K Z0
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"Z0": "0x0894ef83188b"
}
}
/tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VCFG -K HW
The given keyword HW or record VCFG or both are not present in the given FRU path /sys/bus/i2c/drivers/at24/8-0050/eeprom
/tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K HW
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"HW": "0x8001"
}
}
~# /tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K B3
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"B3": ""
}
}
:~# /tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K B4
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"B4": ""
}
}
~# /tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K B7
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"B7": ""
}
}
~# /tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R PSPD -K "#D"
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"#D": "0x00100c0c000 .... 000000000000000000" }
}
10240 Bytes printed.

~# /tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K SN
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"SN": "YF30UF31C007"
}
}
~# /tmp/vpd-tool_combin -r -O /system/chassis/motherboard -R VINI -K SN
{
"/system/chassis/motherboard": {
"SN": "YF30UF31C007"
}
}
~# /tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K FN
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"FN": "F230306"
}
}
~# /tmp/vpd-tool_combin -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K PN
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"PN": "03KP340"
}
}
~# /tmp/vpd-tool_combin -r -O /system/chassis/motherboard -R VINI -K FN
{
"/system/chassis/motherboard": {
"FN": "F230306"
}
}
~# /tmp/vpd-tool_combin -r -O /system/chassis/motherboard -R VINI -K PN
{
"/system/chassis/motherboard": {
"PN": "03KP340"
}
}
~# /tmp/vpd-tool_combin -r -O /system/chassis/motherboard -R VINI -K B3
{
"/system/chassis/motherboard": {
"B3": ""
}
}
~# /tmp/vpd-tool_combin -r -O /system/chassis/motherboard -R VINI -K B4
{
"/system/chassis/motherboard": {
"B4": ""
}
}
~# /tmp/vpd-tool_combin -r -O /system/chassis/motherboard -R VINI -K B7
{
"/system/chassis/motherboard": {
"B7": ""
}
}

HexDump results for comparison:

00000820 47 56 5a 02 30 31 5a 30 06 08 94 ef 83 18 8b 5a |GVZ.01Z0.......Z|
00000830 31 06 08 94 ef 83 18 8c 50 46 0b 00 00 00 00 00 |1.......PF......
00000160 45 04 30 30 30 31 43 54 04 40 18 00 0e 48 57 02 |E.0001CT.@...HW.|
00000170 80 01 42 33 06 00 00 00 00 00 00 42 34 01 00 42 |..B3.......B4..B|
00000180 37 0c 00 00 00 00 00 00 00 00 00 00 00 00 50 46 |7.............PF|
000008a0 30 32 56 4d 04 00 00 00 00 23 44 00 28 00 10 0c |02VM.....#D.(...|
000008b0 0c 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
000008c0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
00000920 00 00 00 00 00 00 00 00 00 00 00 b9 cc 00 00 00 |................|
00000930 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
00000970 00 00 00 80 29 b0 00 15 60 04 50 00 00 df 03 ff |....)...`.P.....|
00000980 f3 0f 00 00 01 00 00 00 00 03 00 00 00 00 00 00 |................|
00000990 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
000009b0 00 00 00 00 00 00 00 00 00 00 00 00 00 81 00 00 |................|

Signed-off-by: Giridhari Krishna <giridharikrishnan@gmail.com>
Change-Id: If380ca3483fb4fc88ca1dd159b2fa75703c8fe1c

show more ...

Fix compare check for 11S

The compare check has an issue as it is not correctly coded

Change-Id: I751cc529dff59ba04b43d6cb4dd9effd80b20d2d
Signed-off-by: jinuthomas <jinu.joy.thomas@in.ibm.com>

vpd-tool:UTF-8 encoding support on hardware read

Keyword values when in unreadable format may need to be converted
to Hex. This code converts data from HW to readable format.

Test:
root@bonn003:~#

vpd-tool:UTF-8 encoding support on hardware read

Keyword values when in unreadable format may need to be converted
to Hex. This code converts data from HW to readable format.

Test:
root@bonn003:~# tmp/vpd-tool -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K SN
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"SN": "YF30UF31C007"
}
}
root@bonn003:~# tmp/vpd-tool -r -H -O "/sys/bus/i2c/drivers/at24/8-0050/eeprom" -R VINI -K HW
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"HW": "0x8001"
}
}

Change-Id: I28d9189d95202a565bcba81299f2e548cb4cb83a
Signed-off-by: Giridhari Krishna <giridharikrishnan@gmail.com>

show more ...

Additional change to support ee1004 driver

changed the code to remove hardcoding of driver
changed read parser executable to take driver as input

Change-Id: I6909e2d56d4572e3ff78610248683a75337bb

Additional change to support ee1004 driver

changed the code to remove hardcoding of driver
changed read parser executable to take driver as input

Change-Id: I6909e2d56d4572e3ff78610248683a75337bbd72
Signed-off-by: jinuthomas <jinu.joy.thomas@in.ibm.com>

show more ...

Remove adding parent's presence for child FRUs

In the existing code, vpd-tool emplaces the parent FRU's presence for
child FRU whose "Present" property is not available on d-bus. This
gives a mislea

Remove adding parent's presence for child FRUs

In the existing code, vpd-tool emplaces the parent FRU's presence for
child FRU whose "Present" property is not available on d-bus. This
gives a misleading information on presence state of non embedded FRU's,
which can either be present or absent on a machine.

Fix:
This commit modifies the vpd-tool code to print "Unknown" if the FRU's
Present property is not available on d-bus.

Test:
1. When Present property is not published on d-bus
vpd-tool -o -O /system/chassis/motherboard/powersupply0
[
{
"/system/chassis/motherboard/powersupply0": {
"LocationCode": "U78DA.ND0.WZS0065-E0",
"Present": "Unknown",
"TYPE": "FRU",
"type": "xyz.openbmc_project.Inventory.Item.PowerSupply"
}
}
]

2. When Present property is set to true on dbus
:~# vpd-tool -o -O /system/chassis/motherboard/powersupply0
[
{
"/system/chassis/motherboard/powersupply0": {
"CC": "51DA",
"DR": "IBM PS",
"FN": "03FP221",
"LocationCode": "U780C.ND0.RCH0014-E0",
"PN": "03FP207",
"Present": "true",
"SN": "YL31KY12K0CX",
"TYPE": "FRU",
"type": "xyz.openbmc_project.Inventory.Item.PowerSupply"
}
}
]

3. When Present property is set to false on dbus
:~# vpd-tool -o -O /system/chassis/motherboard/powersupply0
[
{
"/system/chassis/motherboard/powersupply0": {
"CC": "51DA",
"DR": "IBM PS",
"FN": "03FP221",
"LocationCode": "U780C.ND0.RCH0014-E0",
"PN": "03FP207",
"Present": "false",
"SN": "YL31KY12K0CX",
"TYPE": "FRU",
"type": "xyz.openbmc_project.Inventory.Item.PowerSupply"
}
}
]

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: I4c8ce2141b9ae7c46f1421c59de5d627b8aad429

show more ...