collectSingleFruVpd update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is

collectSingleFruVpd update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.

Test:
```
vpd-manager/src/worker.cpp, Line: 1617 DBG: collectSingleFruVpd via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus

- Checked data on dbus, it is updated .

```

Change-Id: I9957a42c3746e4ceeeb2060e1d3bf3a01ab7db9a
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Refactor back up and restore file

The commit optimize logging in the API backupAndRestore.
Instead of logging and returning from multiple places, code has been
modified to throw from multiple error

Refactor back up and restore file

The commit optimize logging in the API backupAndRestore.
Instead of logging and returning from multiple places, code has been
modified to throw from multiple error scenarios and log the error only
in the catch block.

Change-Id: Id4a28f8fa62e8c67269dfec9807ca8b8ec877154
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Refactor backup and restore

This is continuation of backup and restore refactoring, updated
updateKeywordOnPrimaryOrBackupPath API to make use of refactored APIs.

Change-Id: I107bee9ea88b4cc2c4f8bf

Refactor backup and restore

This is continuation of backup and restore refactoring, updated
updateKeywordOnPrimaryOrBackupPath API to make use of refactored APIs.

Change-Id: I107bee9ea88b4cc2c4f8bf61b801dbbcfd9b6591
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Refactor backup and restore for IPZ VPD

This commit split the IPZ VPD backup and restore logic into multiple
APIs to improve maintainability and avoid code duplication.

Change-Id: Ia36e7e84b910412f

Refactor backup and restore for IPZ VPD

This commit split the IPZ VPD backup and restore logic into multiple
APIs to improve maintainability and avoid code duplication.

Change-Id: Ia36e7e84b910412f6cf818ec92cef5812de44045
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

notifyFRUCollectionStatus update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callP

notifyFRUCollectionStatus update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.

Change-Id: I439920e63dc00aba7c643e09d92beb5f0987efc0
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Refactor backup and restore

This change splits the logic into multiple APIs to improve code
maintainability and eliminate duplicate code in backup and restore.
It also updates log messages to use th

Refactor backup and restore

This change splits the logic into multiple APIs to improve code
maintainability and eliminate duplicate code in backup and restore.
It also updates log messages to use the logger instance.

Change-Id: Ie996cf7ef3781b4694b6817f8175da5e0734a0d7
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Add utility API to determine BMC position

For PST systems, the BMC position will be determined based on the value
returned by the cable management service.
This commit adds a stub utility API to ret

Add utility API to determine BMC position

For PST systems, the BMC position will be determined based on the value
returned by the cable management service.
This commit adds a stub utility API to retrieve the BMC position using
the cable management service.

Change-Id: Iba97b97672fa642bf3b705497e3c5d6762f167a9
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Generic method for dbus update

We are using callPIM which calls notifyPIM to update the data on
dbus.Currently it's tightly coupled with phosphor-inventory-manager
so to make this call dynamic, we h

Generic method for dbus update

We are using callPIM which calls notifyPIM to update the data on
dbus.Currently it's tightly coupled with phosphor-inventory-manager
so to make this call dynamic, we have introduced a generic method,
which will decide which service to call on runtime.

```
Test: Tested the patch on a Rainier system.
- Applied patch
- Triggered vpd-tool to update the property of a FRU
- Checked the value on Dbus, value is updated as per the vpd-tool
- Confirmed in journal, shows my patch traces.

vpd-manager/src/ipz_parser.cpp, Line: 804 4 bytes updated successfully on hardware for VINI:CC
vpd-manager/include/utility/dbus_utility.hpp, Line: 369 DBG:Alpana patch running, using function pointer
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify Entered
vpd-manager/include/utility/dbus_utility.hpp, Line: 338 DBG:objectMap processing
vpd-manager/include/utility/dbus_utility.hpp, Line: 347 DBG:l_nodeHandle processed
vpd-manager/include/utility/dbus_utility.hpp, Line: 357 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 380 DBG:dbus method call completed, check the output on dbus

```

Change-Id: If5651e60033fddc79c766f9aa553b0bd55ff2332
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Inventory backup data restoration stub

This commit implements stub changes in wait-vpd-parsers service to check
for inventory backup data and restore it if found. On systems with
redundant BMCs, inv

Inventory backup data restoration stub

This commit implements stub changes in wait-vpd-parsers service to check
for inventory backup data and restore it if found. On systems with
redundant BMCs, inventory data will be synced from Active BMC to Passive
BMC by other service at a specific file path. When the old Passive BMC
is transitioning to Active, it needs to check for the backup data,
restore it and restart the inventory manager service. This commit only
includes stub changes, and actual changes will be handled in future
commits.

Change-Id: I1d22a4069614bed441b1b31fc02bc17c5279a5c8
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

clear stale data on DBus

When BMC goes for a reboot, FRU collection may fail, or the FRU may be
absent. In such cases, the DBus may still hold data from a previous
boot. This commit fixes the above

clear stale data on DBus

When BMC goes for a reboot, FRU collection may fail, or the FRU may be
absent. In such cases, the DBus may still hold data from a previous
boot. This commit fixes the above issue by clearing stale DBus data in
the above cases.

Updated the deleteFruVpd API to utilize resetObjTreeVpd API to clear
data on the FRU and sub FRUs.

Updated the resetDataUnderPIM API to clear presence state only if the
FRU presence is handled by vpd-manager.

Change-Id: I3f9057ed60527dffd8ba56add93389cfe90770dd
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

BIOS handler JSON support

BIOS handling in VPD-Manager uses a system-specific JSON to map BIOS
attributes to specific system VPD records and keywords. Using a
JSON-based approach is necessary becaus

BIOS handler JSON support

BIOS handling in VPD-Manager uses a system-specific JSON to map BIOS
attributes to specific system VPD records and keywords. Using a
JSON-based approach is necessary because these values are dynamic and
may change in the future,making the approach safe, avoids hardcoding,
and eliminates code redundany.

Change-Id: I55f1f1d0f8394a78b901795e38f1480a7f5a81b7
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...

Fix non-cable card enable line not disabled

This commit fixes enable GPIO line not getting disabled during FRU VPD
collection flow. For PCIe cards other than cable cards, the present GPIO
line indic

Fix non-cable card enable line not disabled

This commit fixes enable GPIO line not getting disabled during FRU VPD
collection flow. For PCIe cards other than cable cards, the present GPIO
line indicates card absent. For these cards, vpd-manager should disable
the respective enable GPIO line.
This commit also adds an API in Worker class to check and execute post
fail action. Checking and executing post fail action is required in
multiple places in Worker class. Hence to avoid code duplication, this
API has been added.

Change-Id: I9c25dd872e7a12a0e2a58073b932571a994902d1
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

vpd-tool: Fix for reading pound keyword

Reading keywords which starts with pound(#) or number from dbus using
vpd-tool is failing, because pound is represented as PD_, and numeric
keywords starts wi

vpd-tool: Fix for reading pound keyword

Reading keywords which starts with pound(#) or number from dbus using
vpd-tool is failing, because pound is represented as PD_, and numeric
keywords starts with N_ on dbus, vpd-tool missed handling of these
conversions while querying from dbus.

Changes are made to handle this issue.

```
Testing:
Tested by reading keywords starts with pound and numeric keywords from dbus using vpd-tool

vpd-tool -r -O /system/chassis/motherboard/dcm0/cpu0 -R CRP0 -K "#V"
vpd-tool -r -O /system/chassis/motherboard/dcm0/cpu0 -R LWP3 -K "20
```

Change-Id: I730d5063e9e59308508bda56e97eb9047f7b25b4
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

1210-ghe: rainiest: fix

Fix the symbolic fru link

Change-Id: Ied3478af37e7a283e24ea4da0a73b50a8b09626d
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

1210-ghe:rainiest:fix

Fix feature for skip reboot on fitconfig update

Change-Id: Ie95eac4a3251f5f7bacf62c733c729259088db9b
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

Collection status util API : use PDI defined enums

This commit refactors setCollectionStatusProperty utility API to accept
collection status value from caller as an enum value parameter as
defined i

Collection status util API : use PDI defined enums

This commit refactors setCollectionStatusProperty utility API to accept
collection status value from caller as an enum value parameter as
defined in phsophor-dbus-interfaces instead of string. Using an enum
value instead of string restricts callers to use valid values for
collection status property.

Test:
'''
- Install build on rainier simics
- Wait for BMC to reach Ready state
- See LCD Op Panel is present and VPD has been collected
- Start dbus monitor on xyz.openbmc_project.Common.Progress interface
- Trigger deleteFruVpd for LCD Op Panel
- Observe xyz.openbmc_project.Common.Progress Status property for LCD
Op Panel becomes "NotStarted" after VPD deletion
- Trigger CollectFRUVPD for LCD Op Panel
- Observe xyz.openbmc_project.Common.Progress Status property for LCD
Op Panel becomes "InProgress" and then "Completed" after VPD
collection
'''

Change-Id: I23eeffc0f99e16b8a0807818ed915523fdf9023a
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor set collection status utility API

This commit refactors setCollectionStatusProperty utility API. The
current API implementation has two paths for handling EEPROM path and
inventory path. Th

Refactor set collection status utility API

This commit refactors setCollectionStatusProperty utility API. The
current API implementation has two paths for handling EEPROM path and
inventory path. This commit simplifies the implementation to
converge the two paths.

Test
'''
- Install build on rainier simics
- Wait for BMC to reach Ready state
- See /system/chassis/motherboard/ebmc_card_bmc is present and VPD has
been collected
- Start dbus monitor on xyz.openbmc_project.Common.Progress interface
- Trigger CollectAllFRUVPD
- Observe xyz.openbmc_project.Common.Progress Status property for
ebmc_card_bmc and its sub FRUs
becomes "NotStarted", then "InProgress" and then "Completed" after VPD
collection
'''

Change-Id: I65c7667c9e87929d71d9f3a3e7f52740b2febdad
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Error handling for isFieldModeEnabled API

This commit updates isFieldModeEnabled API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned

Error handling for isFieldModeEnabled API

This commit updates isFieldModeEnabled API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: I5afc616c80e4ede111e68298821c75e58a06ecc5
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Set collection status as a utility method

Move API to set collection status as a utility method.
This is required as it is required to be called from multiple files.

Change-Id: I5941741180ef601d833

Set collection status as a utility method

Move API to set collection status as a utility method.
This is required as it is required to be called from multiple files.

Change-Id: I5941741180ef601d833e6b7806cf18265f8da182
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

1210-ghe:rainiest: fix system vpd object path

system VPD is not part of planar on P12 machines
so the object path will not be of the planar, change
it to be the path of the system object itself.

Ch

1210-ghe:rainiest: fix system vpd object path

system VPD is not part of planar on P12 machines
so the object path will not be of the planar, change
it to be the path of the system object itself.

Change-Id: I917d625b14ed1df535b2888a94c87ab076586666
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

show more ...

Pass placeholder Collection type to logMessage

Add placeholder Collection type while calling logMessage in
collectFrusFromJson, skipPathForCollection, parseAndPublishVPD.
Based on this placeholder,

Pass placeholder Collection type to logMessage

Add placeholder Collection type while calling logMessage in
collectFrusFromJson, skipPathForCollection, parseAndPublishVPD.
Based on this placeholder, logMessage will log the messages to a file
if build time flag is enabled otherwise messages will go to the journal.
Also, changed the call from logging::logMessage to Logger::logMessage.

Test-
Patch has been tested on a rainier system.
- All the logs collected in collection_0.log

root@rain71bmc:~# cat /var/lib/vpd/collection_0.log |more

Change-Id: I5dddc902ebfdb822c450fe25f83df6852703ec2e
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Refactor static non-member methods in IbmHandler

This commit moves couple of static non-member methods used in IbmHandler
, namely setEnvAndReboot and readFitConfigValue to private methods of
IbmHan

Refactor static non-member methods in IbmHandler

This commit moves couple of static non-member methods used in IbmHandler
, namely setEnvAndReboot and readFitConfigValue to private methods of
IbmHandler class. These methods are used exclusively by IbmHandler class
internally. This also allows use of class members and methods inside
these methods.

Change-Id: I0e45ac2065c4b666e1a1fc28e593244b31e71fdd
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Fix Worker class deleted method declarations

This commit fixes deleted method declarations in Worker class. Some of
the method declarations are improperly specified.

Change-Id: I68b034a11ee857f2753

Fix Worker class deleted method declarations

This commit fixes deleted method declarations in Worker class. Some of
the method declarations are improperly specified.

Change-Id: I68b034a11ee857f2753e59263bb16e242e63a287
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Meson option to skip reboot on fitconfig update

This commit adds a meson option to configure rebooting BMC if there is
a mismatch in device tree during initial setup and fitconfig uboot
variable is

Meson option to skip reboot on fitconfig update

This commit adds a meson option to configure rebooting BMC if there is
a mismatch in device tree during initial setup and fitconfig uboot
variable is updated. For certain systems under development, rebooting
the BMC on device tree mismatch is not required, hence this option has
been added.

Test:
'''
- Build a rainiest BMC image with meson option
skip_reboot_on_fitconfig_change enabled
- Start a rainiest simics session with the created BMC image
- Remove JSON symlink and create DTS mismatch
- Restart vpd-manager.service
- Observe no reboot occurs even if DTS mismatch happens, only
vpd-manager service restarts once
- Repeat above steps for skiboards
- Build a rainier BMC image with meson option
skip_reboot_on_fitconfig_change enabled
- Start a rainier simics session with the created BMC image
- Remove JSON symlink and create DTS mismatch
- Restart vpd-manager.service
- Observe BMC reboot occurs because of DTS mismatch and after reboot
BMC comes up with correct DTS
'''

Change-Id: I4234a0bf0723a452c92220f1e8cf935c938fb080
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

fix core dump

Worker needs to be initialized in the process of initial set up as the
object is required to populate Dbus.
Hence the API to initialize worker has been moved from being called
after in

fix core dump

Worker needs to be initialized in the process of initial set up as the
object is required to populate Dbus.
Hence the API to initialize worker has been moved from being called
after initial set up.

Change-Id: I27fafb5930efa5f327ee6edcb0508f57f558deab
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...