Release gpio line once read is done

Explicitly releasing gpio line once the operation is done so that it
does not lead to potential resource busy error.

Change-Id: I2784a095534fee4f6ad3e94f1b66e2f8

Release gpio line once read is done

Explicitly releasing gpio line once the operation is done so that it
does not lead to potential resource busy error.

Change-Id: I2784a095534fee4f6ad3e94f1b66e2f80f7af32e
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Update BMC position based on gpio read

The commit modifies the API checkAndUpdateBmcPosition to update BMC
position based on GPIO pin read.
This change is driven by the fact that post failover, posi

Update BMC position based on gpio read

The commit modifies the API checkAndUpdateBmcPosition to update BMC
position based on GPIO pin read.
This change is driven by the fact that post failover, position of BMCs,
which was previously allotted, should not change.
With current logic, old active BMC, which was say at position 0, was
going for reboot post failover and while coming up, it was not able to
access the motherboard EEPROM path, causing its position to get
modified to 1.

Change-Id: I03da6d13e59b2f3e3ce0bf9348012bf9705f57fd
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Enhance location code expansion with flexible Node/Slot pattern support

This commit refactors the getExpandedLocationCode() function to support
both single-digit and double-digit Node and Slot/Card

Enhance location code expansion with flexible Node/Slot pattern support

This commit refactors the getExpandedLocationCode() function to support
both single-digit and double-digit Node and Slot/Card designators
in FCS location codes, providing greater flexibility for hardware
topology representation across different system configurations.

Changes:
- Add support for Ufcs-NDx and Ufcs-NDxx patterns (x = 0-9, xx = 00-99)
- Add support for Ufcs-SCx and Ufcs-SCxx patterns (x = 0-9, xx = 00-99)
- Support optional suffix patterns (e.g., Ufcs-NDx-BDx, Ufcs-NDxx-BDx)
- Remove implicit default expansion for standalone "Ufcs"
- Require explicit Node/Slot pattern for FCS location codes
- Update regex pattern from \d{2} to \d{1,2} for flexible digit matching
- Improve fallback logic: check if map is empty or missing record
- Optimize code with early returns and lambda for DBus reads
- Add comprehensive error handling for invalid patterns

Supported patterns:
Single digit:
Ufcs-ND5 -> U78D6.ND5.KIC3180
Ufcs-SC3 -> U78D6.SC3.KIC3180
Ufcs-ND5-BD1 -> U78D6.ND5.KIC3180-BD1

Double digit:
Ufcs-ND12 -> U78D6.ND12.KIC3180
Ufcs-SC05 -> U78D6.SC05.KIC3180
Ufcs-ND12-BD3 -> U78D6.ND12.KIC3180-BD3

MTS (unchanged):
Umts -> U9080.HEX.KIC3180

Breaking change:
- Standalone "Ufcs" without Node/Slot pattern now returns error
(INVALID_LOCATION_CODE_FORMAT) instead of defaulting to ND0

Fallback behavior:
- Try parsed VPD map first if not empty and contains record
- Fall back to DBus if map is empty or record not found
- Return error if keywords missing (no silent fallback)

Performance improvements:
- Reduced string copies with const references
- Eliminated duplicate DBus read code with lambda
- Simplified control flow with early returns
- ~30% code reduction while maintaining functionality

Use cases:
- Single-digit format for systems with <10 nodes/slots
- Double-digit format for larger systems with 10-99 nodes/slots
- Backward compatible with existing double-digit implementations

Testing:
- Verified expansion with FC="78D6.001", SE="KIC3180", TM="9080.HEX"
- Validated regex for 1-2 digit Node/Slot with various suffixes
- Confirmed error handling for invalid patterns
- Tested edge cases: ND0, ND9, ND10, ND99, SC0, SC99
- Verified fallback from empty map to DBus

Note: "ND" refers to Node designator, "SC" # codespell:ignore nd,sc
refers to Slot/Card designator in IBM Power system location codes.

Change-Id: I3f3255a1e43495355d509d5c843fc0194e76870e
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

show more ...

1210-ghe:All P12 systems need to be supported

Add the IM keyword support for P12 machines

Change-Id: I8cceec41c9366305bb92c25510422ea59bd0c1c5
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm

1210-ghe:All P12 systems need to be supported

Add the IM keyword support for P12 machines

Change-Id: I8cceec41c9366305bb92c25510422ea59bd0c1c5
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

show more ...

Implement API to restart inventory manager service

This commit implements API to restart inventory manager service. Once
the backup inventory data is copied to primary path, the inventory
manager se

Implement API to restart inventory manager service

This commit implements API to restart inventory manager service. Once
the backup inventory data is copied to primary path, the inventory
manager service needs to be restarted so that it publishes the fresh
data on D-Bus.

Test:
```
- Installed BMC image on PST simics
- Created directory /var/lib/phosphor-data-sync/bmc_data_bkp/var/lib/phosphor-inventory-manager/xyz/openbmc_project/inventory/system/
and copied chassis1 directory from primary PIM path to this directory
- Ran vpd-tool dump object option to see VINI:CC, VINI:FN, etc keyword
values under /system/chassis1/motherboard
- Edited above keyword values under /system/chassis1/motherboard in the backup
inventory directory
- Restarted wait-vpd-parsers service
- Ran vpd-tool dump object option to see VINI:CC, VINI:FN, etc keyword
values updated as expected under /system/chassis1/motherboard
```

Change-Id: I866b9532812cf24dab6b5f2ff0396ac06c125d80
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Implement API to restore inventory backup data

This commit implements API to restore inventory backup data from the
backup path to the primary path. In order for inventory manager service
to pick up

Implement API to restore inventory backup data

This commit implements API to restore inventory backup data from the
backup path to the primary path. In order for inventory manager service
to pick up the backed up data, the data must be copied to primary
inventory data primary path.

Test:
```
- Installed BMC image on PST simics
- Created directory /var/lib/phosphor-data-sync/bmc_data_bkp/var/lib/phosphor-inventory-manager/xyz/openbmc_project/inventory/system/
and copied chassis1 directory from primary PIM path to this directory
- Edited VINI:CC value under /system/chassis1/motherboard in the backup
inventory directory
- Restarted wait-vpd-parsers service
- Observed updated VINI:CC value under /system/chassis1/motherboard in
the primary inventory directory
- Observed all sub directories under /system/chassis1 got copied from
backup inventory path to primary inventory path
- Observed /system/chassis1 path got deleted on the backup inventory
path
```

Change-Id: Ibc5a7a7701b336dab8d55d703ca92a858ce1b58d
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Fix utility API to detect Pass1 planar

This commit fixes an issue in utility API to detect Pass1 planar.
Currently, this API attempts to read IM keyword value from /system
object path from Phosphor

Fix utility API to detect Pass1 planar

This commit fixes an issue in utility API to detect Pass1 planar.
Currently, this API attempts to read IM keyword value from /system
object path from Phosphor Inventory Manager (PIM), but IM keyword is
published on /system/chassis/motherboard on PIM. This commit fixes this.
This commit also adds error handling in case invalid HW or IM keyword is
read from PIM.

Test:
```
- Installed build on system with Pass1 planar and which has a PCIe card
with invalid VPD
- Observed no PEL is created for the PCIe card with invalid VPD
```

Change-Id: I54ce4567ec4cabc02c90f2338160f3edf9800973
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Update wait-vpd-parser service file

This commit updates the service file for wait-vpd-parsers to make
the service start as part of multi-user.target. For redundant BMC
systems, wait-vpd-parsers serv

Update wait-vpd-parser service file

This commit updates the service file for wait-vpd-parsers to make
the service start as part of multi-user.target. For redundant BMC
systems, wait-vpd-parsers service should run on Active BMC as a part of
obmc-bmc-active.target. This is taken care of in the bitbake recipe file
changes. For other systems, wait-vpd-parsers service should run after
system VPD collection and as a part of multi-user.target

Change-Id: Iea5da243ef30e71fcd159b7972d7019e5366e098
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Use BUSNAME for dbus method call

This commit modified the dbus calls in wait-vpd-parser. Replaced IFACE
with BUSNAME, as BUSNAME is defined in meson as 'BUS NAME FOR THE'
'SERVICE'.

Change-Id: I5e4

Use BUSNAME for dbus method call

This commit modified the dbus calls in wait-vpd-parser. Replaced IFACE
with BUSNAME, as BUSNAME is defined in meson as 'BUS NAME FOR THE'
'SERVICE'.

Change-Id: I5e46cb7d7680ee473aaa617822cccfe62a55ff04
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>

show more ...

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more e

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more efficient and succinct.

Change-Id: Id72a3ca364a3a83f7b7685ac359997fbddfb0f5a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

1210-ghe:rbmc-prototype: Add Aspeed fsi JSON

Added json to support ASPEED FSI

Change-Id: Ia6f4175bcb748d0a78e8d2444a4e5ac1e82a6bf9
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

1210-ghe:Rainiest: Fix missing bios json

- added bios handler JSON for rainiest

Change-Id: I1b83854d4ec181f83eaf953eed15e812a3e55e5f
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

1210-ghe:RBMC-prototype: Fix position check logic

Change-Id: I023035573bfe002c40e5b7efaf7abf639ee3b03d
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

1210-ghe:huygens:Dependency fix

- set-spi-mux needs to run before vpd collection
so that devices behind cam can be accessed

Change-Id: I5272ef5613f41925906cf0d4c3f170129826ad4c
Signed-off-by: Jinu

1210-ghe:huygens:Dependency fix

- set-spi-mux needs to run before vpd collection
so that devices behind cam can be accessed

Change-Id: I5272ef5613f41925906cf0d4c3f170129826ad4c
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

show more ...

Listener update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything wi

Listener update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything with logger class.

Test-
- Tested on PST simics
```
```

Change-Id: I0737f8e523c183ea8bdbed549f4424908609c59b
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

bios_handler class update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line eve

bios_handler class update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything with logger class.

Test-
- Tested on PST simics
```
```

Change-Id: I5dc6d96aad95dfa4ec936cc163b118e7b301f333
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Manager update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything wit

Manager update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything with logger class.

Test-
Tested on PST simics.
```
```

Change-Id: I4a5822394a1ff5753a93a50a2bd5c81522c2cf7b
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

ipz_parser update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything

ipz_parser update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything with logger class.

Test-
Tested on PST simics.
```
```

Change-Id: I4bc70022df96c84a650b8d901ab1ec6797c49e89
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

ddimm_parser update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everythin

ddimm_parser update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything with logger class.

Test-
Tested image on PST simics
```
```

Change-Id: I6a943c86ff0fe703eb9e49e00afbd3e86948a6d7
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

parser update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything with

parser update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything with logger class.

Test-
Tested on PST simics
```
```

Change-Id: If33a097a99a6f8da07bf3bb2d551df30b1f40866
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

backup_restore update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everyth

backup_restore update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything with logger class.

Test-
Tested on PST simics
```
```

Change-Id: Ie708bd11c733e5f3deabd18bbbc38985c0e0d0e2
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

single_fab update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything

single_fab update

Updated this class APIs, to use logger::logMessage with placeHolder PEL
instead of using EventLogger::createSyncPel to log a PEL.
This change is required to stream line everything with logger class.

Test-
Tested image on PST simics.
```
```

Change-Id: I06672ff7b38f7edcdabf0b1e2bfe1bfafd5d6078
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Update RBMC system IM value

The IM value defined for the RBMC system was incorrect, which caused
the BMC position to be set incorrectly.
This commit updates the IM value to fix the issue.

Change-Id

Update RBMC system IM value

The IM value defined for the RBMC system was incorrect, which caused
the BMC position to be set incorrectly.
This commit updates the IM value to fix the issue.

Change-Id: Idf0fe45932bef3641e71bd59536bd6ee31edf38c
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Refactor pvm_keep_and_clear bios attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
pvm_keep_and_clear

Refactor pvm_keep_and_clear bios attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
pvm_keep_and_clear attribute. These values are now dynamically
retrieved from the Bios-map JSON file to improve maintainability and
flexibility.

Change-Id: I5fc771d5fd571a2b68ee0fae6911a0144aa1dfe7
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...

Refactor pvm_clear_nvram bios attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
pvm_clear_nvram attri

Refactor pvm_clear_nvram bios attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
pvm_clear_nvram attribute. These values are now dynamically retrieved
from the Bios-map JSON file to improve maintainability and
flexibility.

Change-Id: I09c05bfda86d14ce6680cd131b3b01a3a9885d19
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...