API to register for event listeners

The commit refactors the code to add an API to host initialization
of all the event listeners required.
The refactoring ha been done to add better readability and

API to register for event listeners

The commit refactors the code to add an API to host initialization
of all the event listeners required.
The refactoring ha been done to add better readability and break
constructor of IBM handler into multiple independent functionalities.

Change-Id: I5c07896a60494d01c9654c137fa56924ce6a139b
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Code refactoring

Moving out the initialization of back up and restore object out of
constructor for breaking independent code into separate API and also
for better readability.

Change-Id: I8627fda5

Code refactoring

Moving out the initialization of back up and restore object out of
constructor for breaking independent code into separate API and also
for better readability.

Change-Id: I8627fda5f9c7cf2976d4d5d344c4b138c05e5fb7
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Remove backup&restore of AMM for Balcones system

AMM is not supported on the Balcone system. The UTIL D0 keyword used
for memory mirroring has been removed from the backup and restore
configuration

Remove backup&restore of AMM for Balcones system

AMM is not supported on the Balcone system. The UTIL D0 keyword used
for memory mirroring has been removed from the backup and restore
configuration JSON.

Change-Id: I3f808a68e9fb7a106c348653fcdedd7d52881ae0
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Add README for system JSON configuration files

This commit adds documentation describing the structure and purpose of
system JSON configuration files. It documents FRUs, muxes, and common
interface

Add README for system JSON configuration files

This commit adds documentation describing the structure and purpose of
system JSON configuration files. It documents FRUs, muxes, and common
interfaces, and outlines action group lifecycle steps: setup,
finalization, and recovery . The README also documents supported action
phases and tags, extensibility constraints, and includes a sample JSON
for reference.

Change-Id: I7ffcb220d9963ce2f1160ffbc74e321f2ae32940
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...

Read VPD collection mode

VPD collection mode is used by multiple classes. Instead of reading it
in each class, the mode is read once in the manager class and passed to
other classes to avoid multipl

Read VPD collection mode

VPD collection mode is used by multiple classes. Instead of reading it
in each class, the mode is read once in the manager class and passed to
other classes to avoid multiple reads.

Change-Id: Ie5ee7f4b366625f8ed8c882b98756b83f05d1254
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Add API to check JSON validity

The commit adds an API to check if the JSON passed in the constructor of
BackupAndRestore class in having all the required tags or not.

This has been added so that we

Add API to check JSON validity

The commit adds an API to check if the JSON passed in the constructor of
BackupAndRestore class in having all the required tags or not.

This has been added so that we detect any failure case right at the time
of initializing the class and fail early in case of any issue.

Change-Id: I618df4e787fc510c3b3cf8cddf9ea402a16dece7
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Implement API to check inventory backup path

This commit implements API to check inventory backup path to see if it
has any backup FRU VPD. This API is needed by wait-vpd-parsers service
to decide w

Implement API to check inventory backup path

This commit implements API to check inventory backup path to see if it
has any backup FRU VPD. This API is needed by wait-vpd-parsers service
to decide whether to restore any backed up FRU VPD or to proceed for FRU
VPD collection.

Test:
```
- Installed BMC image on PST simics
- Created directory /var/lib/phosphor-data-sync/bmc_data_bkp/var/lib/phosphor-inventory-manager/xyz/openbmc_project/inventory/system/
with no contents
- Restart wait-vpd-parsers service
- Observe this API returns false
- Created above directory with dummy sub directories chassis0,chassis1
- Restart wait-vpd-parsers service
- Observe this API returns true
```

Change-Id: Ieaa6ee4c0bc3d577d15a73b21b88dbd05be6cafa
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

callPIM replacement with publishVpdonDBus

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this comm

callPIM replacement with publishVpdonDBus

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.
With this commit these APIs has been updated -
setCollectionStatusProperty
checkAndUpdatePowerVsVpd
updateCorrelatedProperty
processPreAction
parseAndPublishVPD
setPresentProperty

Test:
```
vpd-manager/src/worker.cpp, Line: 954 DBG: parseAndPublishVPD via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus

vpd-manager/include/utility/vpd_specific_utility.hpp, Line: 1473 DBG: setCollectionStatusProperty via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
```

Change-Id: I0e9c8b95a924c34e781d195a2a175a3a2c675392
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

resetObjTreeVpd update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is repl

resetObjTreeVpd update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.

Test:
```
vpd-manager/src/worker.cpp, Line: 1290 DBG: deleteFruVpd via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus
vpd-manager/include/utility/json_utility.hpp, Line: 481 Setting GPIO: SLOT10_PRSNT_EN_RSVD to 0
vpd-manager/src/worker.cpp, Line: 1322 Successfully completed deletion of FRU VPD for /xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot10/pcie_card10
```

Change-Id: I50548be953ee9b031741fb93d799b5b73d8a9136
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

callPIM replacement with publishVpdonDBus

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this comm

callPIM replacement with publishVpdonDBus

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.
With this commit these APIs has been updated -
updateKwdOnInheritedFrus
updateCiPropertyOfInheritedFrus
updateVpdKeyword

Test:
```
vpd-manager/src/parser.cpp, Line: 223 DBG: updateVpdKeyword via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus

vpd-manager/include/utility/vpd_specific_utility.hpp, Line: 1217 DBG: updateCiPropertyOfInheritedFrus via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus

```

Change-Id: I2371cf3d4f00c73af32c09b65393be59113f60ca
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

callPIM replacement with publishVpdonDBus

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this comm

callPIM replacement with publishVpdonDBus

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.
With this commit these APIs has been updated -
publishSystemVPD
performInitialSetup
handleChangeInGpioPin
assetTagChangeCallback

Test:
```
vpd-manager/oem-handler/ibm_handler.cpp, Line: 818 DBG: publishSystemVPD: Update system VPD via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus

```

Change-Id: Ic5148f37fe7dfdb2e54f65fe5d22e4b30a457c6e
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

collectSingleFruVpd update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is

collectSingleFruVpd update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.

Test:
```
vpd-manager/src/worker.cpp, Line: 1617 DBG: collectSingleFruVpd via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus

- Checked data on dbus, it is updated .

```

Change-Id: I9957a42c3746e4ceeeb2060e1d3bf3a01ab7db9a
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Refactor back up and restore file

The commit optimize logging in the API backupAndRestore.
Instead of logging and returning from multiple places, code has been
modified to throw from multiple error

Refactor back up and restore file

The commit optimize logging in the API backupAndRestore.
Instead of logging and returning from multiple places, code has been
modified to throw from multiple error scenarios and log the error only
in the catch block.

Change-Id: Id4a28f8fa62e8c67269dfec9807ca8b8ec877154
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Refactor backup and restore

This is continuation of backup and restore refactoring, updated
updateKeywordOnPrimaryOrBackupPath API to make use of refactored APIs.

Change-Id: I107bee9ea88b4cc2c4f8bf

Refactor backup and restore

This is continuation of backup and restore refactoring, updated
updateKeywordOnPrimaryOrBackupPath API to make use of refactored APIs.

Change-Id: I107bee9ea88b4cc2c4f8bf61b801dbbcfd9b6591
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Refactor backup and restore for IPZ VPD

This commit split the IPZ VPD backup and restore logic into multiple
APIs to improve maintainability and avoid code duplication.

Change-Id: Ia36e7e84b910412f

Refactor backup and restore for IPZ VPD

This commit split the IPZ VPD backup and restore logic into multiple
APIs to improve maintainability and avoid code duplication.

Change-Id: Ia36e7e84b910412f6cf818ec92cef5812de44045
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

notifyFRUCollectionStatus update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callP

notifyFRUCollectionStatus update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.

Change-Id: I439920e63dc00aba7c643e09d92beb5f0987efc0
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Refactor backup and restore

This change splits the logic into multiple APIs to improve code
maintainability and eliminate duplicate code in backup and restore.
It also updates log messages to use th

Refactor backup and restore

This change splits the logic into multiple APIs to improve code
maintainability and eliminate duplicate code in backup and restore.
It also updates log messages to use the logger instance.

Change-Id: Ie996cf7ef3781b4694b6817f8175da5e0734a0d7
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Add utility API to determine BMC position

For PST systems, the BMC position will be determined based on the value
returned by the cable management service.
This commit adds a stub utility API to ret

Add utility API to determine BMC position

For PST systems, the BMC position will be determined based on the value
returned by the cable management service.
This commit adds a stub utility API to retrieve the BMC position using
the cable management service.

Change-Id: Iba97b97672fa642bf3b705497e3c5d6762f167a9
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Generic method for dbus update

We are using callPIM which calls notifyPIM to update the data on
dbus.Currently it's tightly coupled with phosphor-inventory-manager
so to make this call dynamic, we h

Generic method for dbus update

We are using callPIM which calls notifyPIM to update the data on
dbus.Currently it's tightly coupled with phosphor-inventory-manager
so to make this call dynamic, we have introduced a generic method,
which will decide which service to call on runtime.

```
Test: Tested the patch on a Rainier system.
- Applied patch
- Triggered vpd-tool to update the property of a FRU
- Checked the value on Dbus, value is updated as per the vpd-tool
- Confirmed in journal, shows my patch traces.

vpd-manager/src/ipz_parser.cpp, Line: 804 4 bytes updated successfully on hardware for VINI:CC
vpd-manager/include/utility/dbus_utility.hpp, Line: 369 DBG:Alpana patch running, using function pointer
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify Entered
vpd-manager/include/utility/dbus_utility.hpp, Line: 338 DBG:objectMap processing
vpd-manager/include/utility/dbus_utility.hpp, Line: 347 DBG:l_nodeHandle processed
vpd-manager/include/utility/dbus_utility.hpp, Line: 357 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 380 DBG:dbus method call completed, check the output on dbus

```

Change-Id: If5651e60033fddc79c766f9aa553b0bd55ff2332
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Inventory backup data restoration stub

This commit implements stub changes in wait-vpd-parsers service to check
for inventory backup data and restore it if found. On systems with
redundant BMCs, inv

Inventory backup data restoration stub

This commit implements stub changes in wait-vpd-parsers service to check
for inventory backup data and restore it if found. On systems with
redundant BMCs, inventory data will be synced from Active BMC to Passive
BMC by other service at a specific file path. When the old Passive BMC
is transitioning to Active, it needs to check for the backup data,
restore it and restart the inventory manager service. This commit only
includes stub changes, and actual changes will be handled in future
commits.

Change-Id: I1d22a4069614bed441b1b31fc02bc17c5279a5c8
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

clear stale data on DBus

When BMC goes for a reboot, FRU collection may fail, or the FRU may be
absent. In such cases, the DBus may still hold data from a previous
boot. This commit fixes the above

clear stale data on DBus

When BMC goes for a reboot, FRU collection may fail, or the FRU may be
absent. In such cases, the DBus may still hold data from a previous
boot. This commit fixes the above issue by clearing stale DBus data in
the above cases.

Updated the deleteFruVpd API to utilize resetObjTreeVpd API to clear
data on the FRU and sub FRUs.

Updated the resetDataUnderPIM API to clear presence state only if the
FRU presence is handled by vpd-manager.

Change-Id: I3f9057ed60527dffd8ba56add93389cfe90770dd
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

BIOS handler JSON support

BIOS handling in VPD-Manager uses a system-specific JSON to map BIOS
attributes to specific system VPD records and keywords. Using a
JSON-based approach is necessary becaus

BIOS handler JSON support

BIOS handling in VPD-Manager uses a system-specific JSON to map BIOS
attributes to specific system VPD records and keywords. Using a
JSON-based approach is necessary because these values are dynamic and
may change in the future,making the approach safe, avoids hardcoding,
and eliminates code redundany.

Change-Id: I55f1f1d0f8394a78b901795e38f1480a7f5a81b7
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...

Fix non-cable card enable line not disabled

This commit fixes enable GPIO line not getting disabled during FRU VPD
collection flow. For PCIe cards other than cable cards, the present GPIO
line indic

Fix non-cable card enable line not disabled

This commit fixes enable GPIO line not getting disabled during FRU VPD
collection flow. For PCIe cards other than cable cards, the present GPIO
line indicates card absent. For these cards, vpd-manager should disable
the respective enable GPIO line.
This commit also adds an API in Worker class to check and execute post
fail action. Checking and executing post fail action is required in
multiple places in Worker class. Hence to avoid code duplication, this
API has been added.

Change-Id: I9c25dd872e7a12a0e2a58073b932571a994902d1
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

vpd-tool: Fix for reading pound keyword

Reading keywords which starts with pound(#) or number from dbus using
vpd-tool is failing, because pound is represented as PD_, and numeric
keywords starts wi

vpd-tool: Fix for reading pound keyword

Reading keywords which starts with pound(#) or number from dbus using
vpd-tool is failing, because pound is represented as PD_, and numeric
keywords starts with N_ on dbus, vpd-tool missed handling of these
conversions while querying from dbus.

Changes are made to handle this issue.

```
Testing:
Tested by reading keywords starts with pound and numeric keywords from dbus using vpd-tool

vpd-tool -r -O /system/chassis/motherboard/dcm0/cpu0 -R CRP0 -K "#V"
vpd-tool -r -O /system/chassis/motherboard/dcm0/cpu0 -R LWP3 -K "20
```

Change-Id: I730d5063e9e59308508bda56e97eb9047f7b25b4
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

1210-ghe: rainiest: fix

Fix the symbolic fru link

Change-Id: Ied3478af37e7a283e24ea4da0a73b50a8b09626d
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>