Add Slot interface to all NVMe drives

Assign a slot number to all drive paths so that the entity manager
config file for IBM's drives can use that to give its objects unique
names. Previously it us

Add Slot interface to all NVMe drives

Assign a slot number to all drive paths so that the entity manager
config file for IBM's drives can use that to give its objects unique
names. Previously it used its own incrementing index but sometimes got
confused and tried to put a duplicate interface on the same object path
which would crash.

This was already being done for IBM's cable card sensors.

Because the NVMe temperature sensor names are being hardcoded in other
places (fan control and HMC telemetry), the slots are being assigned to
always start at 1 and sequentially increment to keep the names the same
as before.

Tested:

Properties are on D-Bus:

```
busctl get-property xyz.openbmc_project.Inventory.Manager \
/xyz/openbmc_project/inventory/system/chassis/motherboard/disk_backplane0/nvme0/dp0_drive0 \
xyz.openbmc_project.Inventory.Decorator.Slot SlotNumber
u 1
```

Change-Id: Id83c5c4ea2aaae810bcd9c1120cef11fb0e7ba74
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Everest:Missing EXP_PRSNT GPIO pin for PCIe cards

In everest VPD JSON, "presence" section with expander presence gpio
pin information is missing for PCIe cards. Due to which during FRU
VPD collectio

Everest:Missing EXP_PRSNT GPIO pin for PCIe cards

In everest VPD JSON, "presence" section with expander presence gpio
pin information is missing for PCIe cards. Due to which during FRU
VPD collection, I2C line for PCIe card VPD is enabled without
checking if IBM specific PCIe card is actually present on the system.

This check is required for PCIe cards because the PCIe slot accepts
both IBM specific cards and any industry standard cards. So during VPD
collection before enabling the I2C line of PCIe card VPD, it's
recommended to check if IBM standard PCIe card is present on
IBM system.

Test:
'''
busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager com.ibm.VPD.Manager
CollectFRUVPD o "/xyz/openbmc_project/inventory/system/chassis/motherboard
/pcieslot2/pcie_card2"

Oct 16 13:10:40 ever6bmc vpd-manager[1929]: Setting GPIO: presence-cable-card2 to 1
Oct 16 13:10:40 ever6bmc vpd-manager[1929]: Executing driver binding
for chip address - 17-0060
Oct 16 13:10:40 ever6bmc kernel: at24 17-0050: 8192 byte 24c64 EEPROM,
writable, 1 bytes/write
Oct 16 13:10:40 ever6bmc kernel: leds-pca955x 17-0060: leds-pca955x:
Using pca9551 8-bit LED driver at slave address 0x60
Oct 16 13:10:40 ever6bmc kernel: leds-pca955x 17-0060: gpios 1040...1047
Oct 16 13:10:40 ever6bmc systemd[1]: Started IPZ format VPD Parser service for
FRU sys/devices/platform/ahb/ahb:apb/ahb:apb:bus@1e78a000/1e78a280.i2c-bus/i2c-4
/i2c-17/17-0050/17-005060.
'''
Change-Id: I92e795e3996cfa0cc7acc04605c59a550755ef85
Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>

show more ...

delete-vpd:Do not throw exception if FRU is absent

While deleting FRU VPD for the FRU which is not present,
do not throw exception and crash the application.

Test:
Tested that the application conti

delete-vpd:Do not throw exception if FRU is absent

While deleting FRU VPD for the FRU which is not present,
do not throw exception and crash the application.

Test:
Tested that the application continues to work fine in case of attempting
VPD deletion for the FRU which is not present.

Change-Id: I6a9a03bfd3378c8c018d8f26b5647b393ed879d4
Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>

show more ...

Update FRU status on recollection

Some FRUs qualifies for recollection at standby. Based on their
recollection status, clear VPD and reset their functional and
present property if required.

Change-

Update FRU status on recollection

Some FRUs qualifies for recollection at standby. Based on their
recollection status, clear VPD and reset their functional and
present property if required.

Change-Id: Iaf8f5b783c71c18cb36639846ab791baad989723
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Update present property for subtree

When BMC is rebooted at chassis off state, all the FRUs are queued
for recollection and their present property is set accordingly.
Whereas in case there is any su

Update present property for subtree

When BMC is rebooted at chassis off state, all the FRUs are queued
for recollection and their present property is set accordingly.
Whereas in case there is any sub fFRU under that parent, which was
not populated based on udev event then its present property remains
what was there before boot, creating a wrong representatin of the
system.

Change-Id: I22168b6064c1b3674798dee26cac6e11ca413c74
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Clear vpd before recollection

Some FRUs qualifies for recollection at standby.
To avoid any misleading representation because of the stale data,
VPD is being cleared and present is set to false befo

Clear vpd before recollection

Some FRUs qualifies for recollection at standby.
To avoid any misleading representation because of the stale data,
VPD is being cleared and present is set to false before
recollection is triggered for those FRUs.
The commit also checks for any sub tree under the parent path and
if found resets data for them as well.

This will also help in detecting any error that can happen during
recollection of those FRUs as their present property will remain
set to false.

Change-Id: I9b706df39648ded63c44363fc817104028e60014
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Update BIOS table type

The typedef used for BIOS table needs to be modified to match the
changes done in the structure of new BIOS table.
Also, monostate has been added to the variant to detect any

Update BIOS table type

The typedef used for BIOS table needs to be modified to match the
changes done in the structure of new BIOS table.
Also, monostate has been added to the variant to detect any type
change in future.

Change-Id: I6f250b84fdb82cd4a1c731265b25cfa908fc3beb
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Fix: vpd-tool input validation checks (#368)

vpd-tool with option’s which does not require an object path is
failing with an error ‘Given path is empty’.

As CLI library checks whether value is pass

Fix: vpd-tool input validation checks (#368)

vpd-tool with option’s which does not require an object path is
failing with an error ‘Given path is empty’.

As CLI library checks whether value is passed or not for the
selected options by default. If the value is passed as empty string
as “” is not being caught by CLI library.

As CLI library checks whether value is passed or not for the selected
options by default. If the value is passed as empty string as “” is not
being caught by CLI library. Added additional validation that passed
object path, record names are not empty.

Change-Id: I06322c71832b9bc3adbf5ffa3cdc1512c44c591c
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

1060:vpd-tool:Check for read only FRUs before write

This commit fixes the issue where vpd-tool tries to perform write
on request for the FRUs which are read only.

Test:
```./vpd-tool -w -O /system/

1060:vpd-tool:Check for read only FRUs before write

This commit fixes the issue where vpd-tool tries to perform write
on request for the FRUs which are read only.

Test:
```./vpd-tool -w -O /system/chassis/motherboard/vrm0 -R VINI -K CC --value 51F3```
Read only EEPROM. Update not allowed.

Change-Id: If24d2a17e26ecb1ca603cbba8a05a2959102fa64
Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>

show more ...

Update udev paths for updated device tree paths

The new device tree has a different set up for the AHB and APB, so
update the udev path check appropriately.

Change-Id: I9eeb619bfae304f990f525ff01d5

Update udev paths for updated device tree paths

The new device tree has a different set up for the AHB and APB, so
update the udev path check appropriately.

Change-Id: I9eeb619bfae304f990f525ff01d52e40a53b2b9e
Signed-off-by: Eddie James <eajames@linux.ibm.com>

show more ...

IBM: P12 kernel IM addition

Added the HUYGENS IM support

Change-Id: Iac8433aeb0f165070a09791fb406b61366b0e792
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

IBM: P12 kernel device tree addition

Added Huygens DTB file
Added Huygens json file

Change-Id: I030964db6398b506877eef84bb94374c90947708
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.c

IBM: P12 kernel device tree addition

Added Huygens DTB file
Added Huygens json file

Change-Id: I030964db6398b506877eef84bb94374c90947708
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I917f3a65c985f3df3bb4d7a1bef0a13da54ab7bd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

IBM: P11 :add systems

Added P11 IM into the systems.json

Change-Id: I74cb22832825fa92e2020746f03fd12968e7b02c
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

IBM:P11:support

Added IBM P11 device tree support

Change-Id: Ib2bf48a387f54984901594c9e491dd004ad121ca
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

Add missing port interface to config files

The commit adds missing connector.port interface in system config
JSONs.

Change-Id: Ia9d7705a15f10aa7d65411bafbf75983ce134e6a
Signed-off-by: Sunny Srivast

Add missing port interface to config files

The commit adds missing connector.port interface in system config
JSONs.

Change-Id: Ia9d7705a15f10aa7d65411bafbf75983ce134e6a
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Update cxp port functional status on CM

If the PCIe Card going through CM hosts object path for cxp_top
and cxp_bot as its subtree, then functional status for those
ports also needs to be toggled al

Update cxp port functional status on CM

If the PCIe Card going through CM hosts object path for cxp_top
and cxp_bot as its subtree, then functional status for those
ports also needs to be toggled along with that of card being
concurrently maintained.

Change-Id: Ia693f368a3eb1b3bd6f9ee1e62eabecaa3198803
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Iae81201889d1bb4ca324243b863948cb60420ae7
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Publish DRAM Manufacturer ID

The commit publishes DRAM manufacturer ID over D-Bus.

Dependent PDI commit:
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/71554

Change-Id: I8acb8f311

Publish DRAM Manufacturer ID

The commit publishes DRAM manufacturer ID over D-Bus.

Dependent PDI commit:
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/71554

Change-Id: I8acb8f311c83cfcbbd7cadc24e2e226f15824069
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Update pretty names of USB ports

Update pretty names of USB ports for Rainier and Everest JSON
as per IBM Knowledge center

Change-Id: I2169c066eb8c6123b3a9262d76f122c5bac29e27
Signed-off-by: Rekha

Update pretty names of USB ports

Update pretty names of USB ports for Rainier and Everest JSON
as per IBM Knowledge center

Change-Id: I2169c066eb8c6123b3a9262d76f122c5bac29e27
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Enable mux when setting symlink

Muxes, if required, are enabled again at the time of setting symlink
to system specific JSON.

This is done to avoid the scenario where, if system comes up with the
d

Enable mux when setting symlink

Muxes, if required, are enabled again at the time of setting symlink
to system specific JSON.

This is done to avoid the scenario where, if system comes up with the
default JSON, which will not have entry for muxes and will skip
enabling mux at the beginning, resulting in disabled mux.

This change ensures that if there is a change is system configuration
JSON symlink, same is picked and checked for required muxes to get
enabled.

Change-Id: I4e88f24f9ea5bd8e22fa90a50028686a67abc4a0
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Update the pretty names of inventory items in JSON

This commit updates the pretty names of certain DIMMs that were
mislabeled and fixes typo errors in the pretty names of inventory items

Change-Id:

Update the pretty names of inventory items in JSON

This commit updates the pretty names of certain DIMMs that were
mislabeled and fixes typo errors in the pretty names of inventory items

Change-Id: I499b6580effb3d39d0f1975061a2a26c1f5280dc
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Add Connector.Port interface

To populate the link between fabric adapters and port in bmcweb, ports
linked to them needs to implement Connector.Port interface as this
interface is being used to fetc

Add Connector.Port interface

To populate the link between fabric adapters and port in bmcweb, ports
linked to them needs to implement Connector.Port interface as this
interface is being used to fetch ports collection.

Change-Id: If9adcecddec1dfdc5bbec9dc999fa4d3571bd6ea
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Retry for file visibility in user space

In some corner cases, there is a delay between the parser code coming
up against udev generated due to binding the driver, and the file
appearing in user spac

Retry for file visibility in user space

In some corner cases, there is a delay between the parser code coming
up against udev generated due to binding the driver, and the file
appearing in user space.
As a result the check for file existence fails for those situations and
post fail action gets executed. This removes the GPIO line to the file.
Whereas, parser code will be in process of reading that file at the
same time. Hence closing the GPIO line causes file read error on
parser side.

The timer is to buy some time for file to appear in user space before
cutting off the GPIO line to it.

Test:
This was a script driven testing where system was brought down and
again restarted after random time interval.
Code has been tested against that script and it is working fine.

Change-Id: I8383372b27e48bf1cbc569562e396a0bceb908e5
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

VPD:collection: Fix BMC state check failure

we use the BMC state to check if we need to do a recollection and
in the case where the state manager is not up we get a failure.
when we get a failure ,

VPD:collection: Fix BMC state check failure

we use the BMC state to check if we need to do a recollection and
in the case where the state manager is not up we get a failure.
when we get a failure , since we do nto know the state we did not
populate anything and so did not do a recollect , this caused
certain preaction to not run and so some failure happened.we decided
to set the state as not ready on any failure getting state so that
the recollection will happen and we will have the preaction run.

Change-Id: I7887a5d45ae21ae16035a29609b74bbc30dfcdc1
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

show more ...