PEL to log failure in detecting system VPD

To capture any failure while initiating timer to detect system VPD on
DBus or in the initial stage of triggering collection from JSON. PEL is
logged with c

PEL to log failure in detecting system VPD

To capture any failure while initiating timer to detect system VPD on
DBus or in the initial stage of triggering collection from JSON. PEL is
logged with critical severity and required error type.

Change-Id: I5af76afb29cf61ee0e4e6d713c8c83be586af6df
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Update FRU part number for PowerVS systems

Error log makes use of FRU part number instead of part number in the
call outs.
Hence the code is updated to change FRU part number instead of part
number

Update FRU part number for PowerVS systems

Error log makes use of FRU part number instead of part number in the
call outs.
Hence the code is updated to change FRU part number instead of part
number in case of PowerVS systems.
Similarly, spare part number of Decorator.Asset interface is updated
instead of part number.

Change-Id: I31b57e23863b250f7fb036b23c7a192fc1bbec5c
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Update PN under asset interface

In case of powerVS configuration, PN is updated for some of the FRUs.
The same needs to be reflected under Asset interface to keep the values
in sync.

The commit imp

Update PN under asset interface

In case of powerVS configuration, PN is updated for some of the FRUs.
The same needs to be reflected under Asset interface to keep the values
in sync.

The commit implements changes to explicitly update the Asset interface
under PIM once the data has been successfully updated in EEPROM.

Change-Id: I945520bf7669e44d98202f903bd59efdea880a75
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Refactor exception handling for json_utility APIs

This commit adds code to handle exceptions for some of the json_utility
APIs. Each API will have output returned in case of error based on the
retur

Refactor exception handling for json_utility APIs

This commit adds code to handle exceptions for some of the json_utility
APIs. Each API will have output returned in case of error based on the
return type of the API instead of throwing an exception.

Also updated the caller of the json_utility APIs to handle the return
value.

Change-Id: I154a90d5edbbca7441f75a153b908914de83471d
Signed-off-by: RekhaAparna01 <vrekhaaparna@ibm.com>

show more ...

Process FRU only when present with specific CCIN

Some FRUs are only supported with specific CCINs in case of PowerVS
configuration.
The commit implements changes to check for presence of the FRU ba

Process FRU only when present with specific CCIN

Some FRUs are only supported with specific CCINs in case of PowerVS
configuration.
The commit implements changes to check for presence of the FRU based on
its Present property, if found checks for specific CCIN, if found
updates the PN else skips.

Change-Id: I1f3ff08f82788aed4d8153474cd38352e5cc2394
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Fix compilation issue

The commit fixes compilation error in case of non IBM systems.

Change-Id: I837934459b202e4346e23a891c2ad72bff870323
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

Check and update powerVS VPD

The commit adds implementation to check for existing VPD in the system
and if it is different from the VPD required in case of poewrVS
configuration, it updates it with

Check and update powerVS VPD

The commit adds implementation to check for existing VPD in the system
and if it is different from the VPD required in case of poewrVS
configuration, it updates it with the powerVS VPD.

Change-Id: I6092531936bf12d7a19df6acdf4dc73eb962c60e
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

JSON and API prototype to update powerVS VPD

The commit introduces JSON file to hold the VPD that needs to be
updated for systems with PowerVS configuration.

It also adds API to fetch JSON as per s

JSON and API prototype to update powerVS VPD

The commit introduces JSON file to hold the VPD that needs to be
updated for systems with PowerVS configuration.

It also adds API to fetch JSON as per system IM and prototype for API
which will checks the existing data and based on that will either skip
or update the VPD.

Change-Id: I5c279ce210831667be669c2a7c9c7d9c160de336
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

API to check powerVS configuration

The commit implements change to check for powerVS configuration.

It is a combination of system series and driver running on the system.
Once that is established,

API to check powerVS configuration

The commit implements change to check for powerVS configuration.

It is a combination of system series and driver running on the system.
Once that is established, only after that VPD vpdate will take place
w.r.t powerVS system.

Change-Id: I93fefcb79ced4f89bd6f5143666b4cd487897ac8
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Refactor exception handling for writeDbusProperty API

This commit refactors dbus_utility API used to update property value on
DBus to handle any exceptions thrown by it locally and return only
succe

Refactor exception handling for writeDbusProperty API

This commit refactors dbus_utility API used to update property value on
DBus to handle any exceptions thrown by it locally and return only
success or failure as the return type.

Also updated the caller of this API to handle the return value.

Change-Id: Ia92c1b0928d02cc0130a8b4e547ba3c6069d0d2f
Signed-off-by: RekhaAparna01 <vrekhaaparna@ibm.com>

show more ...

API to read IM from DBus

The commit implements utility method to read IM value from the DBus.

For now, it will be used to detect the system type before updating the
VPD for power VS systems.

Chang

API to read IM from DBus

The commit implements utility method to read IM value from the DBus.

For now, it will be used to detect the system type before updating the
VPD for power VS systems.

Change-Id: I425ebfc51721396cc1ca5f07d5725ef6617f4419
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

API prototype to process powerVS systems

The commit provides prototype for the API which will be called before
collection status is set to completed. It will check for power VS
configuration and wil

API prototype to process powerVS systems

The commit provides prototype for the API which will be called before
collection status is set to completed. It will check for power VS
configuration and will update the VPD if required.

Change-Id: Ia1d30a58001bd97003de2306d1959c8e734c809a
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

manager:CollectionStatus property update

This commit updates the CollectionStatus during single FRU VPD
collection execution.

Test:
1. busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager
com.ibm.V

manager:CollectionStatus property update

This commit updates the CollectionStatus during single FRU VPD
collection execution.

Test:
1. busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager
com.ibm.VPD.Manager CollectFRUVPD o /xyz/openbmc_project/
inventory/system/chassis/motherboard/lcd_op_panel_hill

CollectionStatus property value on success vpd collection:
s "com.ibm.VPD.Collection.Status.Success"

2. busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager
com.ibm.VPD.Manager CollectFRUVPD o /xyz/openbmc_project/
inventory/system/chassis/motherboard

Given FRU is neither replaceable at standby nor replaceable at runtime.
Single FRU VPD collection is not performed for
/xyz/openbmc_project/inventory/system/chassis/motherboard

3. busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager
com.ibm.VPD.Manager CollectFRUVPD o /xyz/openbmc_project/
inventory/system/chassis/motherboard/pcieslot0/pcie_card0

CollectionStatus property value when pcie_card not found:
s "com.ibm.VPD.Collection.Status.Failure"

Change-Id: I776edd0c5002ec516f656281d0325ecdc6acf00e
Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>

show more ...

Increase timer to reduce logs

Timer value has been increased to reduce the number of logs being
printed after every timer expiry.

Change-Id: Idf279942fdda9f94613c26ca1480487baf72c0ee
Signed-off-by:

Increase timer to reduce logs

Timer value has been increased to reduce the number of logs being
printed after every timer expiry.

Change-Id: Idf279942fdda9f94613c26ca1480487baf72c0ee
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Id8301a67d945f8a3d1ceb87ae59087100338119c
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Id8301a67d945f8a3d1ceb87ae59087100338119c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Remove redundant async call in collection threads

This commit removes the redundant std:async call in the detached thread
launched for parsing and publishing the VPD for an individual FRU. Since
we

Remove redundant async call in collection threads

This commit removes the redundant std:async call in the detached thread
launched for parsing and publishing the VPD for an individual FRU. Since
we have a dedicated detached thread for each FRU, we can do VPD parse
and publish in a synchronous manner from the detached thread itself,
instead of launching a asynchronous task which adds unnecessary
performance cost. This commit also handles any exception thrown while
launching the detached thread for a FRU. In case launching detached
thread for a FRU fails, we add the EEPROM path of the FRU to a "failed
EEPROM" list. This list can be handled by Manager later on.

Test:
```
- Install bitbaked image on Everest system.

- Check vpd-manager service status:
root@p10bmc:~# systemctl show vpd-manager -p NRestarts
NRestarts=0

- Check BMC reaches ready state:
root@p10bmc:~# obmcutil state
CurrentBMCState : xyz.openbmc_project.State.BMC.BMCState.Ready
CurrentPowerState : xyz.openbmc_project.State.Chassis.PowerState.On
CurrentHostState : xyz.openbmc_project.State.Host.HostState.Running
BootProgress : xyz.openbmc_project.State.Boot.Progress.
ProgressStages.OSRunning
OperatingSystemState: xyz.openbmc_project.State.OperatingSystem.Status.
OSStatus.Inactive

-Check CollectionStatus property of vpd-manager D-Bus service:
root@p10bmc:~# busctl get-property com.ibm.VPD.Manager /com/ibm/VPD/
Manager com.ibm.VPD.Manager CollectionStatus
s "Completed"

- Check execution time change
Measure the time between vpd-manager event loop start and
CollectionStatus = Completed on a Everest system. Following figures were
measured across 3 reboots:
- On current code, (with the extra async call) it is 61 secs.
- With the changes in this PR, it is 60.33 secs.
```

Change-Id: I86dd9f9f6a4c67b8159e4c90d6ffdb005568cf6b
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Scale down threads for collection at power on

In case where BMC reboots and VPD-Manager re-triggers the collection
process for the FRUs, number of threads has been restricted to 2 for
now (Just a lo

Scale down threads for collection at power on

In case where BMC reboots and VPD-Manager re-triggers the collection
process for the FRUs, number of threads has been restricted to 2 for
now (Just a lower value).

The thread count is configurable and can be updated as required.

This is required to scale down CPU utilization at power on.

Change-Id: I7dee6dabf073bc1f17ab4f9f672aa183b00e116a
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Revamped code for VPD parser

The commit removes all the pre-existing code from the branch
and pushes the revamped code.

Major modification includes:
- Movement from multi exe to single daemon model

Revamped code for VPD parser

The commit removes all the pre-existing code from the branch
and pushes the revamped code.

Major modification includes:
- Movement from multi exe to single daemon model.
- Multithreaded approach to parse FRU VPD.
- Better error handling.
- Refactored code for performance optimization.

Note: This code supports all the existing functionalities as it is.

Change-Id: I1ddce1f0725ac59020b72709689a1013643bda8b
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...