Change bad VPD dump directory

This commit changes the bad VPD dump directory from /tmp/bad-vpd to
/var/lib/vpd/dumps. This change is done to ensure bad VPD dumps persist
across BMC reboots. The pare

Change bad VPD dump directory

This commit changes the bad VPD dump directory from /tmp/bad-vpd to
/var/lib/vpd/dumps. This change is done to ensure bad VPD dumps persist
across BMC reboots. The parent directory /var/lib/vpd is created by
vpd-manager during genesis boot/factory reset.

This commit also updates references to the bad VPD dump directory in the
utility API used to dump bad VPD.

Change-Id: Ibdb53e38c1afd15d4324f7bc04dec4d35e70d46a
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

API to detect powerVS image

PowerVS systems mandate running of image with specific prefix.
The commit adds API to check for those prefix and confirm if it is a
powerVS image or not.

Change-Id: Ie1c

API to detect powerVS image

PowerVS systems mandate running of image with specific prefix.
The commit adds API to check for those prefix and confirm if it is a
powerVS image or not.

Change-Id: Ie1cb012d57068d77fbfeeb2cbd6e4e54a542d32f
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Refactor get keyword value API exception handling

This commit refactors vpd specific utility API used to read value of a
keyword,in order to handle any exceptions thrown by it locally. All
utility m

Refactor get keyword value API exception handling

This commit refactors vpd specific utility API used to read value of a
keyword,in order to handle any exceptions thrown by it locally. All
utility methods should handle exceptions locally and log a journal log
in case of failure. The caller of the utility APIs should check the
return value to detect success/failure.

This commit also changes the caller of this API throughout the repo, in
order to check the return value.

Test:

```
- Install bitbaked image on Everest system
- After BMC boots, BMC should reach Ready state
- Check vpd-manager service status, should be active(running)
- Check no restarts in vpd-manager service
- Check vpd-manager "CollectionStatus" = "Completed"
- Check extra interfaces are processed properly
- Check backup restore working properly
```

Change-Id: I965313f512553ed5d39373dd871754e1a8fed5f3
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Process FRU only when present with specific CCIN

Some FRUs are only supported with specific CCINs in case of PowerVS
configuration.
The commit implements changes to check for presence of the FRU ba

Process FRU only when present with specific CCIN

Some FRUs are only supported with specific CCINs in case of PowerVS
configuration.
The commit implements changes to check for presence of the FRU based on
its Present property, if found checks for specific CCIN, if found
updates the PN else skips.

Change-Id: I1f3ff08f82788aed4d8153474cd38352e5cc2394
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

API to check powerVS configuration

The commit implements change to check for powerVS configuration.

It is a combination of system series and driver running on the system.
Once that is established,

API to check powerVS configuration

The commit implements change to check for powerVS configuration.

It is a combination of system series and driver running on the system.
Once that is established, only after that VPD vpdate will take place
w.r.t powerVS system.

Change-Id: I93fefcb79ced4f89bd6f5143666b4cd487897ac8
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Refactor pass 1 planar API exception handling

This commit refactors vpd specific utility API used to check pass 1
planar, in order to handle any exceptions thrown by it locally. All
utility methods

Refactor pass 1 planar API exception handling

This commit refactors vpd specific utility API used to check pass 1
planar, in order to handle any exceptions thrown by it locally. All
utility methods should handle exceptions locally and log a journal log
in case of failure. The caller of the utility APIs should check the
return value to detect success/failure.

Change-Id: I79e38a15ac38e2de9844061c00e7a6d06da6f793
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor find CCIN in VPD API exception handling

This commit refactors vpd specific utility API used to find CCIN in VPD,
in order to handle any exceptions thrown by it locally. All utility
methods

Refactor find CCIN in VPD API exception handling

This commit refactors vpd specific utility API used to find CCIN in VPD,
in order to handle any exceptions thrown by it locally. All utility
methods should handle exceptions locally and log a journal log in case
of failure. The caller of the utility APIs should check the return value
to detect success/failure.

This commit also logs a PEL in case VINI record or empty CCIN is found
for any FRU.

Test:
```
- Install bitbaked image on Everest
- After BMC becomes ready, check vpd-manager log to check postAction
collection is successful for pcieslot2/pcie_card2
```

Change-Id: I19ef8e9d67bdfdaab9876c9df5c04fa6f0c08f79
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor insert or merge API exception handling

This commit refactors vpd specific utility API used to insert or merge
property map in interface map ,in order to handle any exceptions thrown
by it l

Refactor insert or merge API exception handling

This commit refactors vpd specific utility API used to insert or merge
property map in interface map ,in order to handle any exceptions thrown
by it locally. All utility methods should handle exceptions locally and
log a journal log in case of failure. The caller of the utility APIs
should check the return value to detect success/failure.

This commit also removes unnecessary declaration of this API in
worker.hpp

Test:
```
- Install bitbaked image on Everest
- Clear persistent PIM data on filesystem, restart PIM and then
vpd-manager services
- Check all interfaces under PIM like
LocationCode,Item,OperationalStatus,etc. are populated properly
```

Change-Id: Ie13882c0697d691f0593765f6f4dad5ac5eadea2
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor encode keyword API exception handling

This commit refactors vpd specific utility API used to encode value of a
keyword,in order to handle any exceptions thrown by it locally. All
utility me

Refactor encode keyword API exception handling

This commit refactors vpd specific utility API used to encode value of a
keyword,in order to handle any exceptions thrown by it locally. All
utility methods should handle exceptions locally and log a journal log
in case of failure. The caller of the utility APIs should check the
return value to detect success/failure.

Test:
```
- Install bitbaked image on Everest
- Clear persistent PIM data on filesystem, restart PIM and then
vpd-manager services
- Check MACAddress property is properly populated on PIM for ethernet0
and ethernet1
```

Change-Id: Idd2ec502081886937ab108fb4b19b9c359ecd000
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor dump bad VPD utility exception handling

This commit refactors vpd specific utility APIs used to dump bad VPD in
order to handle any exceptions thrown by them locally. All utility
methods sh

Refactor dump bad VPD utility exception handling

This commit refactors vpd specific utility APIs used to dump bad VPD in
order to handle any exceptions thrown by them locally. All utility
methods should handle exception locally and log a journal log in case of
failure. The caller of the utility APIs should check the return value to
detect success/failure.

Change-Id: I53addf47f717999aae9c86ec89d7561ebe8be879
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Id8301a67d945f8a3d1ceb87ae59087100338119c
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Id8301a67d945f8a3d1ceb87ae59087100338119c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Skip presence detect and PEL for pass1 PCIe cards

Presence pin on pass1 planar does not reflect the true state of the
slot. It does not guarantee if the card is actually present in the slot
or not.

Skip presence detect and PEL for pass1 PCIe cards

Presence pin on pass1 planar does not reflect the true state of the
slot. It does not guarantee if the card is actually present in the slot
or not. Hence, the presence pin check is irrelevant in these scenarios
and is being skipped before enabling the line for VPD collection.

Availability of EEPROM after enabling the line should confirm if the
card needs to be collected or not.

Also, PCIe cards on pass1 is expected to have invalid VPD, avoiding
logging of PELs for those error scenarios.

Change-Id: Ia646b7d442a94fadea6b4c78d1d97c5a214579cb
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Revamped code for VPD parser

The commit removes all the pre-existing code from the branch
and pushes the revamped code.

Major modification includes:
- Movement from multi exe to single daemon model

Revamped code for VPD parser

The commit removes all the pre-existing code from the branch
and pushes the revamped code.

Major modification includes:
- Movement from multi exe to single daemon model.
- Multithreaded approach to parse FRU VPD.
- Better error handling.
- Refactored code for performance optimization.

Note: This code supports all the existing functionalities as it is.

Change-Id: I1ddce1f0725ac59020b72709689a1013643bda8b
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...