clear stale data on DBus

When BMC goes for a reboot, FRU collection may fail, or the FRU may be
absent. In such cases, the DBus may still hold data from a previous
boot. This commit fixes the above

clear stale data on DBus

When BMC goes for a reboot, FRU collection may fail, or the FRU may be
absent. In such cases, the DBus may still hold data from a previous
boot. This commit fixes the above issue by clearing stale DBus data in
the above cases.

Updated the deleteFruVpd API to utilize resetObjTreeVpd API to clear
data on the FRU and sub FRUs.

Updated the resetDataUnderPIM API to clear presence state only if the
FRU presence is handled by vpd-manager.

Change-Id: I3f9057ed60527dffd8ba56add93389cfe90770dd
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Collection status util API : use PDI defined enums

This commit refactors setCollectionStatusProperty utility API to accept
collection status value from caller as an enum value parameter as
defined i

Collection status util API : use PDI defined enums

This commit refactors setCollectionStatusProperty utility API to accept
collection status value from caller as an enum value parameter as
defined in phsophor-dbus-interfaces instead of string. Using an enum
value instead of string restricts callers to use valid values for
collection status property.

Test:
'''
- Install build on rainier simics
- Wait for BMC to reach Ready state
- See LCD Op Panel is present and VPD has been collected
- Start dbus monitor on xyz.openbmc_project.Common.Progress interface
- Trigger deleteFruVpd for LCD Op Panel
- Observe xyz.openbmc_project.Common.Progress Status property for LCD
Op Panel becomes "NotStarted" after VPD deletion
- Trigger CollectFRUVPD for LCD Op Panel
- Observe xyz.openbmc_project.Common.Progress Status property for LCD
Op Panel becomes "InProgress" and then "Completed" after VPD
collection
'''

Change-Id: I23eeffc0f99e16b8a0807818ed915523fdf9023a
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor set collection status utility API

This commit refactors setCollectionStatusProperty utility API. The
current API implementation has two paths for handling EEPROM path and
inventory path. Th

Refactor set collection status utility API

This commit refactors setCollectionStatusProperty utility API. The
current API implementation has two paths for handling EEPROM path and
inventory path. This commit simplifies the implementation to
converge the two paths.

Test
'''
- Install build on rainier simics
- Wait for BMC to reach Ready state
- See /system/chassis/motherboard/ebmc_card_bmc is present and VPD has
been collected
- Start dbus monitor on xyz.openbmc_project.Common.Progress interface
- Trigger CollectAllFRUVPD
- Observe xyz.openbmc_project.Common.Progress Status property for
ebmc_card_bmc and its sub FRUs
becomes "NotStarted", then "InProgress" and then "Completed" after VPD
collection
'''

Change-Id: I65c7667c9e87929d71d9f3a3e7f52740b2febdad
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Error handling for isFieldModeEnabled API

This commit updates isFieldModeEnabled API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned

Error handling for isFieldModeEnabled API

This commit updates isFieldModeEnabled API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: I5afc616c80e4ede111e68298821c75e58a06ecc5
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Set collection status as a utility method

Move API to set collection status as a utility method.
This is required as it is required to be called from multiple files.

Change-Id: I5941741180ef601d833

Set collection status as a utility method

Move API to set collection status as a utility method.
This is required as it is required to be called from multiple files.

Change-Id: I5941741180ef601d833e6b7806cf18265f8da182
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Fix clearing of prettyName during deletion

PrettyName under the xyz.openbmc_project.Inventory.Item interface was
being set to an empty string when deleteFRUVPD was called for a FRU.
This should not

Fix clearing of prettyName during deletion

PrettyName under the xyz.openbmc_project.Inventory.Item interface was
being set to an empty string when deleteFRUVPD was called for a FRU.
This should not happen because name of the FRU is fixed, independent of
its presence state.

This commit fixes the above issue.

Test-
```
Before deletion, PrettyName on DBus
root@p11bmc:~# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot11/pcie_card11 xyz.openbmc_project.Inventory.Item
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Present property b true emits-change writable
.PrettyName property s "PCIe5 x8 adapter" emits-change writable

Call deleteFRUVPD
root@p11bmc:~# busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager com.ibm.VPD.Manager deleteFRUVPD o /xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot11/pcie_card11

After performing deletion, prettyName on DBus:
root@p11bmc:~# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot11/pcie_card11 xyz.openbmc_project.Inventory.Item
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Present property b false emits-change writable
.PrettyName property s "PCIe5 x8 adapter" emits-change writable
```

Change-Id: Icc8f05d150a365265332b6ff0beeff83c6c300ee
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Error code for convertToBinary API

This commit updates convertToBinary API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the A

Error code for convertToBinary API

This commit updates convertToBinary API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: Id914e65c1c75a3fdab793445491fc96c396ffcf7
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Handle file mode for system VPD collection

This commit adds changes to read system VPD from designated file
location in case VPD collection mode is 'file mode' for the system.

In non-field mode, VP

Handle file mode for system VPD collection

This commit adds changes to read system VPD from designated file
location in case VPD collection mode is 'file mode' for the system.

In non-field mode, VPD collection mode is determined by reading u-boot
variable "vpdmode".

```
Test:
Good path:
1. Updated u-boot vpdmode to file mode.
2. Copied the system VPD to designated location for file mode.
3. After system reboot, observed that system VPD is collected successfully.

Bad path:
1. Updated u-boot vpdmode to file mode.
2. Skipped copying system VPD to designated file location.
3. After system reboot, observed that vpd-manger logged a critical PEL as system VPD parsing is failed.

Part of info from PEL:
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"DESCRIPTION": "Standard runtime exception. Reason: System VPD parsing failed, from path [/var/lib/vpd/file/sys/bus/i2c/drivers/at24/8-0050/eeprom]. Either file doesn't exist or error occurred while parsing the file.",
"FileName": "/usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/oem-handler/ibm_handler.cpp",
"FunctionName": "performInitialSetup",
"InteranlRc": "0",
"UserData1": "",
"UserData2": ""
}
```

Change-Id: Iae4eb64fe91e608f9ae61ab7f88ae41d36bc1007
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Error code for getPrintableValue API

This commit updates getPrintableValue API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from t

Error code for getPrintableValue API

This commit updates getPrintableValue API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: I15ff039f781af2dfd7d507fcaaa875716232f00e
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Error handling for executeCmd API

This commit updates executeCmd API to set error code in case of error.
This helps the caller of API to take action based on the error code
returned from the API.

C

Error handling for executeCmd API

This commit updates executeCmd API to set error code in case of error.
This helps the caller of API to take action based on the error code
returned from the API.

Change-Id: Ie5b7804f5d486a278765d460eabaef0bd46d555e
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Move methods to utility

Couple of methods has been moved from worker class to utility file.
More suited in utility as it process VPD and provides generic
information like hw version and IM value of

Move methods to utility

Couple of methods has been moved from worker class to utility file.
More suited in utility as it process VPD and provides generic
information like hw version and IM value of the system.

Change-Id: I1aa51078c2ac9710b569faa3cf8e979abd3e6b73
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Remove empty VPD map check in getExpandedLocCode

This commit removes the empty VPD map check in getExpandedLocationCode
API because the location code can be obtained independently of the VPD
map.

C

Remove empty VPD map check in getExpandedLocCode

This commit removes the empty VPD map check in getExpandedLocationCode
API because the location code can be obtained independently of the VPD
map.

Change-Id: Ib13aafe3158173a57dfa62010c41fd2d56d53ee8
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Fix clearing of LocationCode after deleteFRUVPD

LocationCode in the com.ibm.ipzvpd.Location interface was being set to
an empty string when deleteFRUVPD was called for a FRU in vpd-manager.
This sho

Fix clearing of LocationCode after deleteFRUVPD

LocationCode in the com.ibm.ipzvpd.Location interface was being set to
an empty string when deleteFRUVPD was called for a FRU in vpd-manager.
This should not happen because the LocationCode is fixed for a FRU,
regardless of whether the FRU is present or not.

This commit fixes the above issue and updates the vpd-tool to use the
standard xyz interface to display the LocationCode instead of the
OEM-specific interface.

Test:
```
Dump object before delete FRU
root@rainvpdteam:~# vpd-tool -o -O /system/chassis/motherboard/lcd_op_panel_hill
[
{
"/system/chassis/motherboard/lcd_op_panel_hill": {
"CC": "6B87",
"DR": "CEC OP PANEL LCD",
"FN": "02WF367",
"LocationCode": "U78DA.ND0. -D1",
"PN": "02WF364",
"PrettyName": "Control panel display",
"SN": "YA30UF04R007",
"TYPE": "FRU",
"type": "xyz.openbmc_project.Inventory.Item.Panel"
}
}
]

Call delete FRU VPD:
root@rainvpdteam:~# busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager com.ibm.VPD.Manager deleteFRUVPD o /xyz/openbmc_project/inventory/system/chassis/motherboard/lcd_op_panel_hill

After Delete, Location code on DBus:
root@rainvpdteam:~# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/lcd_op_panel_hill xyz.openbmc_project.Inventory.Decorator.LocationCode
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.LocationCode property s "U78DA.ND0. -D1" emits-change writable

root@rainvpdteam:~# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/lcd_op_panel_hill com.ibm.ipzvpd.Location
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.LocationCode property s "U78DA.ND0. -D1" emits-change writable

Set FRU Present Property:
root@rainvpdteam:~# busctl set-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/lcd_op_panel_hill xyz.openbmc_project.Inventory.Item Present b true

Dump object details, with correct location code:
root@rainvpdteam:~# vpd-tool -o -O /system/chassis/motherboard/lcd_op_panel_hill
[
{
"/system/chassis/motherboard/lcd_op_panel_hill": {
"CC": "",
"DR": "",
"FN": "",
"LocationCode": "U78DA.ND0. -D1",
"PN": "",
"PrettyName": "",
"SN": "",
"TYPE": "FRU",
"type": "xyz.openbmc_project.Inventory.Item.Panel"
}
}
]
```

Change-Id: Ie6db0584b46f69b340034ecf63c06197f31f46af
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Move Eventlogger as an utility file

Event Logger class is used for creating PELs. With new logger class
implementation, logging API will take care of logging to journal, or
file or creating PEL base

Move Eventlogger as an utility file

Event Logger class is used for creating PELs. With new logger class
implementation, logging API will take care of logging to journal, or
file or creating PEL based on the place holder passed to logging API.

Hence moving event logger as an utility file, so logger class can call
these PEL creation APIs to log PEL.

Change-Id: I0bd59f0b5ceae01a47dcb7f31d9d5e85acbfdb3e
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

update vpd specific utility

Error code is initialized to 0 for each VPD utility function, this has
been done to remove caller's over head to set the variable before each
call, missing which can caus

update vpd specific utility

Error code is initialized to 0 for each VPD utility function, this has
been done to remove caller's over head to set the variable before each
call, missing which can cause error code from previous call to pop up
resulting in misleading error logging.

Change-Id: Idecf254c6ad7317960481d49f7753e26deeb50c4
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Update json utility methods

Error code is initialized to 0 for each json utility function, this has
been done to remove caller's over head to set the variable before each
call, missing which can cau

Update json utility methods

Error code is initialized to 0 for each json utility function, this has
been done to remove caller's over head to set the variable before each
call, missing which can cause error code from previous call to pop up
resulting in misleading error logging.

Change-Id: I1f8d0c5634cfda23d59003ce519b8e16bd50fdf5
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Error handling for getCommonInterfaceProperties API

This commit updates updateCiPropertyOfInheritedFrus and
getCommonInterfaceProperties APIs to set error code in case of error.
This helps the calle

Error handling for getCommonInterfaceProperties API

This commit updates updateCiPropertyOfInheritedFrus and
getCommonInterfaceProperties APIs to set error code in case of error.
This helps the caller of API to take action based on the error code
returned from the API

Change-Id: Iad1dba767447f501829c2fe6a98913f98d52671d
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Error code for findCcinInVpd API

This commit updates findCcinInVpd API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Error code for findCcinInVpd API

This commit updates findCcinInVpd API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: I9ce9ae7b9bf9b80766a2dc44836ecde51ce28255
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Error code for getCcinFromDbus API

This commit updates getCcinFromDbus API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the A

Error code for getCcinFromDbus API

This commit updates getCcinFromDbus API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: I0ff936ca3486c09921ab0d8deb61814d07ce70d3
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Error code for updateKwdOnInheritedFrus API

This commit updates updateKwdOnInheritedFrus API to set error code in
case of error. This helps the caller of API to take action based on the
error code r

Error code for updateKwdOnInheritedFrus API

This commit updates updateKwdOnInheritedFrus API to set error code in
case of error. This helps the caller of API to take action based on the
error code returned from the API.

Change-Id: I83e67e0c1fb51bbbd6df7ed7f5b01b091dbd2e18
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Error handling for isPass1Planar API

This commit updates isPass1Planar API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the A

Error handling for isPass1Planar API

This commit updates isPass1Planar API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: I3823e749d68e37f9d004b9f95c80693d1f7c5b41
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Check VPD collection mode in non field mode

This commit adds changes to read VPD collection mode in case system is
in not in field mode. In non field mode, VPD collection mode is
determined by readi

Check VPD collection mode in non field mode

This commit adds changes to read VPD collection mode in case system is
in not in field mode. In non field mode, VPD collection mode is
determined by reading u-boot variable "vpdmode".

Test:
```
- Put debug traces in worker constructor
- Install image on rainiest simics
- Check u-boot variable "fieldmode" is not defined
- Check u-boot variable "vpdmode" is not defined
- See worker is initialized with m_vpdCollectionMode = HARDWARE_MODE
- Check u-boot variable "fieldmode" is defined as "fieldmode=true"
- See worker is initialized with m_vpdCollectionMode = HARDWARE_MODE
- Check u-boot variable "fieldmode" is defined as "fieldmode=false"
- Check u-boot variable "vpdmode" is not defined
- See worker is initialized with m_vpdCollectionMode = HARDWARE_MODE
- Check u-boot variable "vpdmode" is defined as "vpdmode=hardware"
- See worker is initialized with m_vpdCollectionMode = HARDWARE_MODE
- Check u-boot variable "vpdmode" is defined as "vpdmode=file"
- See worker is initialized with m_vpdCollectionMode = FILE_MODE
- Check u-boot variable "vpdmode" is defined as "vpdmode=mixed"
- See worker is initialized with m_vpdCollectionMode = MIXED_MODE
```

Change-Id: I89e514c7c46cc409c0746cddfe66ce0a860220ee
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Error code for vpdSpecificUtility APIs

This commit updates getVpdDataInVector and getDbusPropNameForGivenKw
APIs to set error code in case of error. This helps the caller of API
to take action based

Error code for vpdSpecificUtility APIs

This commit updates getVpdDataInVector and getDbusPropNameForGivenKw
APIs to set error code in case of error. This helps the caller of API
to take action based on the error code returned from the API.

Change-Id: I77bcb4b81a8ebaa196a9bdef3050ad3dfebd07e0
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Error code for getExpandedLocationCode API

This commit updates getExpnadedLocationCode API to set error code in
case of error. This helps the caller of API to take action based on the
error code ret

Error code for getExpandedLocationCode API

This commit updates getExpnadedLocationCode API to set error code in
case of error. This helps the caller of API to take action based on the
error code returned from the API.

Change-Id: I1570e13ca782f9320f1fc7e43680807d232e6310
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Error code for insertorMerge API

This commit updates insertOrMerge API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Error code for insertorMerge API

This commit updates insertOrMerge API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: I4bd37c226a7f2f73076d811e641e39159eadf874
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...