Collection status util API : use PDI defined enums

This commit refactors setCollectionStatusProperty utility API to accept
collection status value from caller as an enum value parameter as
defined i

Collection status util API : use PDI defined enums

This commit refactors setCollectionStatusProperty utility API to accept
collection status value from caller as an enum value parameter as
defined in phsophor-dbus-interfaces instead of string. Using an enum
value instead of string restricts callers to use valid values for
collection status property.

Test:
'''
- Install build on rainier simics
- Wait for BMC to reach Ready state
- See LCD Op Panel is present and VPD has been collected
- Start dbus monitor on xyz.openbmc_project.Common.Progress interface
- Trigger deleteFruVpd for LCD Op Panel
- Observe xyz.openbmc_project.Common.Progress Status property for LCD
Op Panel becomes "NotStarted" after VPD deletion
- Trigger CollectFRUVPD for LCD Op Panel
- Observe xyz.openbmc_project.Common.Progress Status property for LCD
Op Panel becomes "InProgress" and then "Completed" after VPD
collection
'''

Change-Id: I23eeffc0f99e16b8a0807818ed915523fdf9023a
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor set collection status utility API

This commit refactors setCollectionStatusProperty utility API. The
current API implementation has two paths for handling EEPROM path and
inventory path. Th

Refactor set collection status utility API

This commit refactors setCollectionStatusProperty utility API. The
current API implementation has two paths for handling EEPROM path and
inventory path. This commit simplifies the implementation to
converge the two paths.

Test
'''
- Install build on rainier simics
- Wait for BMC to reach Ready state
- See /system/chassis/motherboard/ebmc_card_bmc is present and VPD has
been collected
- Start dbus monitor on xyz.openbmc_project.Common.Progress interface
- Trigger CollectAllFRUVPD
- Observe xyz.openbmc_project.Common.Progress Status property for
ebmc_card_bmc and its sub FRUs
becomes "NotStarted", then "InProgress" and then "Completed" after VPD
collection
'''

Change-Id: I65c7667c9e87929d71d9f3a3e7f52740b2febdad
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Error handling for isFieldModeEnabled API

This commit updates isFieldModeEnabled API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned

Error handling for isFieldModeEnabled API

This commit updates isFieldModeEnabled API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: I5afc616c80e4ede111e68298821c75e58a06ecc5
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Set collection status as a utility method

Move API to set collection status as a utility method.
This is required as it is required to be called from multiple files.

Change-Id: I5941741180ef601d833

Set collection status as a utility method

Move API to set collection status as a utility method.
This is required as it is required to be called from multiple files.

Change-Id: I5941741180ef601d833e6b7806cf18265f8da182
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

1210-ghe:rainiest: fix system vpd object path

system VPD is not part of planar on P12 machines
so the object path will not be of the planar, change
it to be the path of the system object itself.

Ch

1210-ghe:rainiest: fix system vpd object path

system VPD is not part of planar on P12 machines
so the object path will not be of the planar, change
it to be the path of the system object itself.

Change-Id: I917d625b14ed1df535b2888a94c87ab076586666
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

show more ...

Pass placeholder Collection type to logMessage

Add placeholder Collection type while calling logMessage in
collectFrusFromJson, skipPathForCollection, parseAndPublishVPD.
Based on this placeholder,

Pass placeholder Collection type to logMessage

Add placeholder Collection type while calling logMessage in
collectFrusFromJson, skipPathForCollection, parseAndPublishVPD.
Based on this placeholder, logMessage will log the messages to a file
if build time flag is enabled otherwise messages will go to the journal.
Also, changed the call from logging::logMessage to Logger::logMessage.

Test-
Patch has been tested on a rainier system.
- All the logs collected in collection_0.log

root@rain71bmc:~# cat /var/lib/vpd/collection_0.log |more

Change-Id: I5dddc902ebfdb822c450fe25f83df6852703ec2e
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Fix Worker class deleted method declarations

This commit fixes deleted method declarations in Worker class. Some of
the method declarations are improperly specified.

Change-Id: I68b034a11ee857f2753

Fix Worker class deleted method declarations

This commit fixes deleted method declarations in Worker class. Some of
the method declarations are improperly specified.

Change-Id: I68b034a11ee857f2753e59263bb16e242e63a287
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Initialize worker post initial set up

Worker initialization has been moved post initial set up.
The change is required as the correct system config JSON is detected and
set in the process of initial

Initialize worker post initial set up

Worker initialization has been moved post initial set up.
The change is required as the correct system config JSON is detected and
set in the process of initial set up and worker needs to be initialized
by the JSON which has been selected for the system.

Change-Id: I40ef4c2c853f2257f201076791262c45a181cde3
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Fix clearing of prettyName during deletion

PrettyName under the xyz.openbmc_project.Inventory.Item interface was
being set to an empty string when deleteFRUVPD was called for a FRU.
This should not

Fix clearing of prettyName during deletion

PrettyName under the xyz.openbmc_project.Inventory.Item interface was
being set to an empty string when deleteFRUVPD was called for a FRU.
This should not happen because name of the FRU is fixed, independent of
its presence state.

This commit fixes the above issue.

Test-
```
Before deletion, PrettyName on DBus
root@p11bmc:~# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot11/pcie_card11 xyz.openbmc_project.Inventory.Item
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Present property b true emits-change writable
.PrettyName property s "PCIe5 x8 adapter" emits-change writable

Call deleteFRUVPD
root@p11bmc:~# busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager com.ibm.VPD.Manager deleteFRUVPD o /xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot11/pcie_card11

After performing deletion, prettyName on DBus:
root@p11bmc:~# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot11/pcie_card11 xyz.openbmc_project.Inventory.Item
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Present property b false emits-change writable
.PrettyName property s "PCIe5 x8 adapter" emits-change writable
```

Change-Id: Icc8f05d150a365265332b6ff0beeff83c6c300ee
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Move symlink creation to OEM

Code to create symlink has been moved to OEM as it is specific to IBM
and is not mandatorily required for rest of the functionalities to work.

Change-Id: I8b2a1b3bcde69

Move symlink creation to OEM

Code to create symlink has been moved to OEM as it is specific to IBM
and is not mandatorily required for rest of the functionalities to work.

Change-Id: I8b2a1b3bcde692f02318a7f3c3d683ab1d43f95c
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Error code for convertToBinary API

This commit updates convertToBinary API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the A

Error code for convertToBinary API

This commit updates convertToBinary API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: Id914e65c1c75a3fdab793445491fc96c396ffcf7
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Handle file mode for system VPD collection

This commit adds changes to read system VPD from designated file
location in case VPD collection mode is 'file mode' for the system.

In non-field mode, VP

Handle file mode for system VPD collection

This commit adds changes to read system VPD from designated file
location in case VPD collection mode is 'file mode' for the system.

In non-field mode, VPD collection mode is determined by reading u-boot
variable "vpdmode".

```
Test:
Good path:
1. Updated u-boot vpdmode to file mode.
2. Copied the system VPD to designated location for file mode.
3. After system reboot, observed that system VPD is collected successfully.

Bad path:
1. Updated u-boot vpdmode to file mode.
2. Skipped copying system VPD to designated file location.
3. After system reboot, observed that vpd-manger logged a critical PEL as system VPD parsing is failed.

Part of info from PEL:
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"DESCRIPTION": "Standard runtime exception. Reason: System VPD parsing failed, from path [/var/lib/vpd/file/sys/bus/i2c/drivers/at24/8-0050/eeprom]. Either file doesn't exist or error occurred while parsing the file.",
"FileName": "/usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/oem-handler/ibm_handler.cpp",
"FunctionName": "performInitialSetup",
"InteranlRc": "0",
"UserData1": "",
"UserData2": ""
}
```

Change-Id: Iae4eb64fe91e608f9ae61ab7f88ae41d36bc1007
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Error code for getPrintableValue API

This commit updates getPrintableValue API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from t

Error code for getPrintableValue API

This commit updates getPrintableValue API to set error code in case of
error. This helps the caller of API to take action based on the error
code returned from the API.

Change-Id: I15ff039f781af2dfd7d507fcaaa875716232f00e
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Error handling for executeCmd API

This commit updates executeCmd API to set error code in case of error.
This helps the caller of API to take action based on the error code
returned from the API.

C

Error handling for executeCmd API

This commit updates executeCmd API to set error code in case of error.
This helps the caller of API to take action based on the error code
returned from the API.

Change-Id: Ie5b7804f5d486a278765d460eabaef0bd46d555e
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Move code to OEM

The commit moves publishing of system VPD and creation of asset tag to
OEM files.
System VPD and asset tag are specific to IBM systems, hence moved.

Change-Id: Id3c1a4da415c24ea74f

Move code to OEM

The commit moves publishing of system VPD and creation of asset tag to
OEM files.
System VPD and asset tag are specific to IBM systems, hence moved.

Change-Id: Id3c1a4da415c24ea74fba9cbf838ce45c6f14db4
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Move OEM specific code

IBM specific implementation is being moved to OEM handler.
This is being done to keep OEM specific code under specific OEM file,
keeping rest of the code generic.

Change-Id:

Move OEM specific code

IBM specific implementation is being moved to OEM handler.
This is being done to keep OEM specific code under specific OEM file,
keeping rest of the code generic.

Change-Id: I316bd6835566f79ffae1a4e1f804a986ee4b8983
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Logger:error handling enhancements

This commit adds following enhancements in Logger:
- add a try-catch block in Logger::logMessage to catch exceptions
locally. In case of any exception log messag

Logger:error handling enhancements

This commit adds following enhancements in Logger:
- add a try-catch block in Logger::logMessage to catch exceptions
locally. In case of any exception log message is redirected to journal
so that it is not lost.
- Enable filestream exceptions before opening the filestream. This
ensures that an exception is thrown if there is any error while
opening the file.

Change-Id: I35df92c33ef0c15b9f440651e271f31dfa13d5b3
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Move methods to utility

Couple of methods has been moved from worker class to utility file.
More suited in utility as it process VPD and provides generic
information like hw version and IM value of

Move methods to utility

Couple of methods has been moved from worker class to utility file.
More suited in utility as it process VPD and provides generic
information like hw version and IM value of the system.

Change-Id: I1aa51078c2ac9710b569faa3cf8e979abd3e6b73
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Flag based logger functions

Moved initiation and termination of FRU VPD collection logging under
compile time flag. User can decide whether to log in a file or journal
while building the bmc image b

Flag based logger functions

Moved initiation and termination of FRU VPD collection logging under
compile time flag. User can decide whether to log in a file or journal
while building the bmc image by setting/unsetting the particular flag.

Test:
Image loaded on a rainier system
- ls /var/lib/vpd/ - initially there was 1 collection log file
- Called CollectFRUVPD
- ls /var/lib/vpd/ - there were 2 collection log file
- Called CollectFRUVPD
- ls /var/lib/vpd/ - there were 3 collection log file
- Called CollectFRUVPD
- ls /var/lib/vpd/ - there were 3 collection log file, as max no is 3

Change-Id: I63238d63bea065f6b1c0fca6d66c87307a713f94
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Remove empty VPD map check in getExpandedLocCode

This commit removes the empty VPD map check in getExpandedLocationCode
API because the location code can be obtained independently of the VPD
map.

C

Remove empty VPD map check in getExpandedLocCode

This commit removes the empty VPD map check in getExpandedLocationCode
API because the location code can be obtained independently of the VPD
map.

Change-Id: Ib13aafe3158173a57dfa62010c41fd2d56d53ee8
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Use system specific correlated properties JSON

This commit adds changes to select system specific correlated
properties JSON. Certain PST systems have system specific correlated
properties JSON. The

Use system specific correlated properties JSON

This commit adds changes to select system specific correlated
properties JSON. Certain PST systems have system specific correlated
properties JSON. The specific correlated properties JSON path is read
from the respective system config JSON. If system config JSON does not
specify correlated properties JSON path, correlated properties listener
is not enabled.

Test:
- Installed BMC image on rainiest simics
- Saw log which says correlated properties listener is disabled as
correlated properties JSON is not defined in the system config JSON
- Edit the system config JSON and add tag
"correlatedPropertiesConfigPath"
- vpd-manager now enables correlated properties listener

Change-Id: I624bb6a7285a215b4812e5f2bdbaf0412074fb81
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Fix clearing of LocationCode after deleteFRUVPD

LocationCode in the com.ibm.ipzvpd.Location interface was being set to
an empty string when deleteFRUVPD was called for a FRU in vpd-manager.
This sho

Fix clearing of LocationCode after deleteFRUVPD

LocationCode in the com.ibm.ipzvpd.Location interface was being set to
an empty string when deleteFRUVPD was called for a FRU in vpd-manager.
This should not happen because the LocationCode is fixed for a FRU,
regardless of whether the FRU is present or not.

This commit fixes the above issue and updates the vpd-tool to use the
standard xyz interface to display the LocationCode instead of the
OEM-specific interface.

Test:
```
Dump object before delete FRU
root@rainvpdteam:~# vpd-tool -o -O /system/chassis/motherboard/lcd_op_panel_hill
[
{
"/system/chassis/motherboard/lcd_op_panel_hill": {
"CC": "6B87",
"DR": "CEC OP PANEL LCD",
"FN": "02WF367",
"LocationCode": "U78DA.ND0. -D1",
"PN": "02WF364",
"PrettyName": "Control panel display",
"SN": "YA30UF04R007",
"TYPE": "FRU",
"type": "xyz.openbmc_project.Inventory.Item.Panel"
}
}
]

Call delete FRU VPD:
root@rainvpdteam:~# busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager com.ibm.VPD.Manager deleteFRUVPD o /xyz/openbmc_project/inventory/system/chassis/motherboard/lcd_op_panel_hill

After Delete, Location code on DBus:
root@rainvpdteam:~# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/lcd_op_panel_hill xyz.openbmc_project.Inventory.Decorator.LocationCode
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.LocationCode property s "U78DA.ND0. -D1" emits-change writable

root@rainvpdteam:~# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/lcd_op_panel_hill com.ibm.ipzvpd.Location
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.LocationCode property s "U78DA.ND0. -D1" emits-change writable

Set FRU Present Property:
root@rainvpdteam:~# busctl set-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/lcd_op_panel_hill xyz.openbmc_project.Inventory.Item Present b true

Dump object details, with correct location code:
root@rainvpdteam:~# vpd-tool -o -O /system/chassis/motherboard/lcd_op_panel_hill
[
{
"/system/chassis/motherboard/lcd_op_panel_hill": {
"CC": "",
"DR": "",
"FN": "",
"LocationCode": "U78DA.ND0. -D1",
"PN": "",
"PrettyName": "",
"SN": "",
"TYPE": "FRU",
"type": "xyz.openbmc_project.Inventory.Item.Panel"
}
}
]
```

Change-Id: Ie6db0584b46f69b340034ecf63c06197f31f46af
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Move Eventlogger as an utility file

Event Logger class is used for creating PELs. With new logger class
implementation, logging API will take care of logging to journal, or
file or creating PEL base

Move Eventlogger as an utility file

Event Logger class is used for creating PELs. With new logger class
implementation, logging API will take care of logging to journal, or
file or creating PEL based on the place holder passed to logging API.

Hence moving event logger as an utility file, so logger class can call
these PEL creation APIs to log PEL.

Change-Id: I0bd59f0b5ceae01a47dcb7f31d9d5e85acbfdb3e
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Instantiate VPD write logger only on first use

This commit moves out the VPD write logger's instantiation from the
constructor of Logger. As part of VPD write logger instantiation, a log
file is cre

Instantiate VPD write logger only on first use

This commit moves out the VPD write logger's instantiation from the
constructor of Logger. As part of VPD write logger instantiation, a log
file is created, which is unnecessary until a message has to be logged.
Hence, VPD write logger is now instantiated only on first use.

Test:
'''
- Install BMC firmware image
- Delete /var/lib/vpd folder
- Restart vpd-manager service
- Observe vpd-manager service starts as expected, no error logs or PELs
with respect to manager instantiation
'''

Change-Id: I9244cd1e8b8ce09f0bae48fed0fd548445243f60
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

update vpd specific utility

Error code is initialized to 0 for each VPD utility function, this has
been done to remove caller's over head to set the variable before each
call, missing which can caus

update vpd specific utility

Error code is initialized to 0 for each VPD utility function, this has
been done to remove caller's over head to set the variable before each
call, missing which can cause error code from previous call to pop up
resulting in misleading error logging.

Change-Id: Idecf254c6ad7317960481d49f7753e26deeb50c4
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...