Move single FAB API under the separate class

SingleFab class provides functionalities to support single FAB feature.
This commit moves the single FAB related API under SingleFab class.

Change-Id: I

Move single FAB API under the separate class

SingleFab class provides functionalities to support single FAB feature.
This commit moves the single FAB related API under SingleFab class.

Change-Id: I8d55cd2134f5812f83f5fc5033df097ab1b1f8f2
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

API to get error type and error msg

Error type to be set should be strictly dependent on the type of
exception being caught. So that correct interface can be called from
message registry while loggi

API to get error type and error msg

Error type to be set should be strictly dependent on the type of
exception being caught. So that correct interface can be called from
message registry while logging a PEL.
Also, the error message logged should have a uniform format across
different kind of errors.

The commit implements API to get the pre-defined error type and message
format for a given exception.
The user needs to call this API and need not set error type on wish.

Change-Id: I3aeddd2986f12ff18b3a061533490db20ebede34
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Fix for AMM gets disabled after system reboot

Enable Active Memory Mirroring(AMM) mode in GUI memory tab under
‘Resource Management’. On reboot of the system and once system reaches
ready state, AMM

Fix for AMM gets disabled after system reboot

Enable Active Memory Mirroring(AMM) mode in GUI memory tab under
‘Resource Management’. On reboot of the system and once system reaches
ready state, AMM mode in the GUI shows as disabled.

Bios handler in VPD manager caused this issue as it’s comparing AMM VPD
as character value with wrong int value.

This commit implements changes to fix the above issue.

Change-Id: I758ede97e17ecf76fbd4ee05287172ce1534201c
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Refactor exception handling for json_utility APIs

This commit adds code to handle exceptions for some of the json_utility
APIs. Each API will have output returned in case of error based on the
retur

Refactor exception handling for json_utility APIs

This commit adds code to handle exceptions for some of the json_utility
APIs. Each API will have output returned in case of error based on the
return type of the API instead of throwing an exception.

Also updated the caller of the json_utility APIs to handle the return
value.

Change-Id: I154a90d5edbbca7441f75a153b908914de83471d
Signed-off-by: RekhaAparna01 <vrekhaaparna@ibm.com>

show more ...

Refactor get keyword value API exception handling

This commit refactors vpd specific utility API used to read value of a
keyword,in order to handle any exceptions thrown by it locally. All
utility m

Refactor get keyword value API exception handling

This commit refactors vpd specific utility API used to read value of a
keyword,in order to handle any exceptions thrown by it locally. All
utility methods should handle exceptions locally and log a journal log
in case of failure. The caller of the utility APIs should check the
return value to detect success/failure.

This commit also changes the caller of this API throughout the repo, in
order to check the return value.

Test:

```
- Install bitbaked image on Everest system
- After BMC boots, BMC should reach Ready state
- Check vpd-manager service status, should be active(running)
- Check no restarts in vpd-manager service
- Check vpd-manager "CollectionStatus" = "Completed"
- Check extra interfaces are processed properly
- Check backup restore working properly
```

Change-Id: I965313f512553ed5d39373dd871754e1a8fed5f3
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

API to get error info based on the exception

This commit implements an event logger API to extract the error info
based on the exception type.

Change-Id: I132306a6d3127253435e53f61328843fa8f1be24
S

API to get error info based on the exception

This commit implements an event logger API to extract the error info
based on the exception type.

Change-Id: I132306a6d3127253435e53f61328843fa8f1be24
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

API to read IM value from persisted location

This commit implements API to read IM value from PIM persisted
location.

Change-Id: I9cd4f6ed9ded2dd4f42c65902509f7bea9e15849
Signed-off-by: Anupama B R

API to read IM value from persisted location

This commit implements API to read IM value from PIM persisted
location.

Change-Id: I9cd4f6ed9ded2dd4f42c65902509f7bea9e15849
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Process FRU only when present with specific CCIN

Some FRUs are only supported with specific CCINs in case of PowerVS
configuration.
The commit implements changes to check for presence of the FRU ba

Process FRU only when present with specific CCIN

Some FRUs are only supported with specific CCINs in case of PowerVS
configuration.
The commit implements changes to check for presence of the FRU based on
its Present property, if found checks for specific CCIN, if found
updates the PN else skips.

Change-Id: I1f3ff08f82788aed4d8153474cd38352e5cc2394
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

JSON and API prototype to update powerVS VPD

The commit introduces JSON file to hold the VPD that needs to be
updated for systems with PowerVS configuration.

It also adds API to fetch JSON as per s

JSON and API prototype to update powerVS VPD

The commit introduces JSON file to hold the VPD that needs to be
updated for systems with PowerVS configuration.

It also adds API to fetch JSON as per system IM and prototype for API
which will checks the existing data and based on that will either skip
or update the VPD.

Change-Id: I5c279ce210831667be669c2a7c9c7d9c160de336
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

API to check powerVS configuration

The commit implements change to check for powerVS configuration.

It is a combination of system series and driver running on the system.
Once that is established,

API to check powerVS configuration

The commit implements change to check for powerVS configuration.

It is a combination of system series and driver running on the system.
Once that is established, only after that VPD vpdate will take place
w.r.t powerVS system.

Change-Id: I93fefcb79ced4f89bd6f5143666b4cd487897ac8
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Refactor pass 1 planar API exception handling

This commit refactors vpd specific utility API used to check pass 1
planar, in order to handle any exceptions thrown by it locally. All
utility methods

Refactor pass 1 planar API exception handling

This commit refactors vpd specific utility API used to check pass 1
planar, in order to handle any exceptions thrown by it locally. All
utility methods should handle exceptions locally and log a journal log
in case of failure. The caller of the utility APIs should check the
return value to detect success/failure.

Change-Id: I79e38a15ac38e2de9844061c00e7a6d06da6f793
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor find CCIN in VPD API exception handling

This commit refactors vpd specific utility API used to find CCIN in VPD,
in order to handle any exceptions thrown by it locally. All utility
methods

Refactor find CCIN in VPD API exception handling

This commit refactors vpd specific utility API used to find CCIN in VPD,
in order to handle any exceptions thrown by it locally. All utility
methods should handle exceptions locally and log a journal log in case
of failure. The caller of the utility APIs should check the return value
to detect success/failure.

This commit also logs a PEL in case VINI record or empty CCIN is found
for any FRU.

Test:
```
- Install bitbaked image on Everest
- After BMC becomes ready, check vpd-manager log to check postAction
collection is successful for pcieslot2/pcie_card2
```

Change-Id: I19ef8e9d67bdfdaab9876c9df5c04fa6f0c08f79
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor exception handling for writeDbusProperty API

This commit refactors dbus_utility API used to update property value on
DBus to handle any exceptions thrown by it locally and return only
succe

Refactor exception handling for writeDbusProperty API

This commit refactors dbus_utility API used to update property value on
DBus to handle any exceptions thrown by it locally and return only
success or failure as the return type.

Also updated the caller of this API to handle the return value.

Change-Id: Ia92c1b0928d02cc0130a8b4e547ba3c6069d0d2f
Signed-off-by: RekhaAparna01 <vrekhaaparna@ibm.com>

show more ...

Exception handling for json_utility APIs

This commit refactors some of the json_utility APIs to handle any
exceptions thrown by it locally and only return success or failure from
the API.

Change-Id

Exception handling for json_utility APIs

This commit refactors some of the json_utility APIs to handle any
exceptions thrown by it locally and only return success or failure from
the API.

Change-Id: If1d253367ad730e7f3049e8aa5d445d12ee0a057
Signed-off-by: RekhaAparna01 <vrekhaaparna@ibm.com>

show more ...

Refactor insert or merge API exception handling

This commit refactors vpd specific utility API used to insert or merge
property map in interface map ,in order to handle any exceptions thrown
by it l

Refactor insert or merge API exception handling

This commit refactors vpd specific utility API used to insert or merge
property map in interface map ,in order to handle any exceptions thrown
by it locally. All utility methods should handle exceptions locally and
log a journal log in case of failure. The caller of the utility APIs
should check the return value to detect success/failure.

This commit also removes unnecessary declaration of this API in
worker.hpp

Test:
```
- Install bitbaked image on Everest
- Clear persistent PIM data on filesystem, restart PIM and then
vpd-manager services
- Check all interfaces under PIM like
LocationCode,Item,OperationalStatus,etc. are populated properly
```

Change-Id: Ie13882c0697d691f0593765f6f4dad5ac5eadea2
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor encode keyword API exception handling

This commit refactors vpd specific utility API used to encode value of a
keyword,in order to handle any exceptions thrown by it locally. All
utility me

Refactor encode keyword API exception handling

This commit refactors vpd specific utility API used to encode value of a
keyword,in order to handle any exceptions thrown by it locally. All
utility methods should handle exceptions locally and log a journal log
in case of failure. The caller of the utility APIs should check the
return value to detect success/failure.

Test:
```
- Install bitbaked image on Everest
- Clear persistent PIM data on filesystem, restart PIM and then
vpd-manager services
- Check MACAddress property is properly populated on PIM for ethernet0
and ethernet1
```

Change-Id: Idd2ec502081886937ab108fb4b19b9c359ecd000
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Refactor dump bad VPD utility exception handling

This commit refactors vpd specific utility APIs used to dump bad VPD in
order to handle any exceptions thrown by them locally. All utility
methods sh

Refactor dump bad VPD utility exception handling

This commit refactors vpd specific utility APIs used to dump bad VPD in
order to handle any exceptions thrown by them locally. All utility
methods should handle exception locally and log a journal log in case of
failure. The caller of the utility APIs should check the return value to
detect success/failure.

Change-Id: I53addf47f717999aae9c86ec89d7561ebe8be879
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Exception handling for json_utility APIs

This commit adds code to handle exceptions for some of the json_utility
APIs. Each API will have output returned in case of error based on the
return type of

Exception handling for json_utility APIs

This commit adds code to handle exceptions for some of the json_utility
APIs. Each API will have output returned in case of error based on the
return type of the API instead of throwing an exception.

Also updated the caller of the json_utility APIs to handle the return
value.

Change-Id: Ib43028974b61c18a0edae96608a8764cb440234a
Signed-off-by: RekhaAparna01 <vrekhaaparna@ibm.com>

show more ...

API to read IM from DBus

The commit implements utility method to read IM value from the DBus.

For now, it will be used to detect the system type before updating the
VPD for power VS systems.

Chang

API to read IM from DBus

The commit implements utility method to read IM value from the DBus.

For now, it will be used to detect the system type before updating the
VPD for power VS systems.

Change-Id: I425ebfc51721396cc1ca5f07d5725ef6617f4419
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

API prototype to process powerVS systems

The commit provides prototype for the API which will be called before
collection status is set to completed. It will check for power VS
configuration and wil

API prototype to process powerVS systems

The commit provides prototype for the API which will be called before
collection status is set to completed. It will check for power VS
configuration and will update the VPD if required.

Change-Id: Ia1d30a58001bd97003de2306d1959c8e734c809a
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

worker::CollectionStatus for each inventory FRU

This commit populates CollectionStatus D-bus property under
com.ibm.VPD.Collection D-bus interface for each inventory D-bus object
path which represen

worker::CollectionStatus for each inventory FRU

This commit populates CollectionStatus D-bus property under
com.ibm.VPD.Collection D-bus interface for each inventory D-bus object
path which represents a FRU.

The property tells the current status of VPD collection for a given
FRU's D-bus object path.

The property takes the below enum values:

>>>com.ibm.VPD.Collection.Status.Success
-------------------------------------
This value is assigned when VPD collection is successful.

>>>com.ibm.VPD.Collection.Status.Failure
-------------------------------------
VPD collection failure due to VPD exceptions.

>>>com.ibm.VPD.Collection.Status.InProgress
----------------------------------------
This value is assigned when VPD collection starts for the given FRU.

>>>com.ibm.VPD.Collection.Status.NotStarted
----------------------------------------
This default value is assigned when we hit prime inventory path.

Test:
1. VPD parsing failed for /sys/bus/i2c/drivers/at24/0-0051
/eeprom due to error: Unable to determine VPD format

=>CollectionStatus property value for tpm_wilson
s "com.ibm.VPD.Collection.Status.Failure"

2. FRU not found
s "com.ibm.VPD.Collection.Status.Failure"

3. Successful collection of VPD
s "com.ibm.VPD.Collection.Status.Success"

Change-Id: Ia5010a181f720454bb51538d6fcf308daf6b75ca
Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>

show more ...

Fix Present property update in prime inventory

This commit adds changes in vpd-manager prime inventory flow to skip
updating Present property for FRUs for which vpd-manager doesn't
handle Present pr

Fix Present property update in prime inventory

This commit adds changes in vpd-manager prime inventory flow to skip
updating Present property for FRUs for which vpd-manager doesn't
handle Present property.

This commit also adds changes to skip updating Present property for a
FRU if vpd-manager is not supposed to handle Present property for the
FRU, in the scenario where VPD parsing fails for the FRU.

Test:
```
Tested on an Everest system.
- Reboot BMC with Chassis Off and fan3 plugged in.
After reboot, fan3 name and Present property appears properly on GUI.
- Reboot BMC with Chassis Off and fan3 plugged out.
After reboot, fan3 name and Present property appears properly on GUI.
Fan Health shows critical on GUI.
- Reboot BMC with Chassis On and fan3 plugged out.
After reboot, fan3 name and Present property appears properly on GUI.
fan3 Health shows critical on GUI.
- Reboot BMC with Chassis On and fan3 plugged in.
After reboot, fan3 name and Present property appears properly on GUI.
- Recreate genesis boot scenario and reboot BMC with fan3 plugged in.
After reboot, fan3 name and Present property appears properly on GUI.
- Recreate genesis boot scenario and reboot BMC with fan3 plugged out.
After reboot, fan3 name and Present property appears properly on GUI.
fan3 Health shows critical on GUI.
```

Change-Id: Ifa6a8909df059a7d3bddd34338d89f0fd8dd5098
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Id8301a67d945f8a3d1ceb87ae59087100338119c
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Id8301a67d945f8a3d1ceb87ae59087100338119c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

DDIMM & ISDIMM:Method to get manufacturer ID

This commit implements the logic to get manufacturer ID for ISDIMMs
and DDIMMs and add it to the Parsed vpd map

Change-Id: If8b707448f9c2485c8cf837bb63f

DDIMM & ISDIMM:Method to get manufacturer ID

This commit implements the logic to get manufacturer ID for ISDIMMs
and DDIMMs and add it to the Parsed vpd map

Change-Id: If8b707448f9c2485c8cf837bb63fc6df23531355
Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>

show more ...

Remove redundant async call in collection threads

This commit removes the redundant std:async call in the detached thread
launched for parsing and publishing the VPD for an individual FRU. Since
we

Remove redundant async call in collection threads

This commit removes the redundant std:async call in the detached thread
launched for parsing and publishing the VPD for an individual FRU. Since
we have a dedicated detached thread for each FRU, we can do VPD parse
and publish in a synchronous manner from the detached thread itself,
instead of launching a asynchronous task which adds unnecessary
performance cost. This commit also handles any exception thrown while
launching the detached thread for a FRU. In case launching detached
thread for a FRU fails, we add the EEPROM path of the FRU to a "failed
EEPROM" list. This list can be handled by Manager later on.

Test:
```
- Install bitbaked image on Everest system.

- Check vpd-manager service status:
root@p10bmc:~# systemctl show vpd-manager -p NRestarts
NRestarts=0

- Check BMC reaches ready state:
root@p10bmc:~# obmcutil state
CurrentBMCState : xyz.openbmc_project.State.BMC.BMCState.Ready
CurrentPowerState : xyz.openbmc_project.State.Chassis.PowerState.On
CurrentHostState : xyz.openbmc_project.State.Host.HostState.Running
BootProgress : xyz.openbmc_project.State.Boot.Progress.
ProgressStages.OSRunning
OperatingSystemState: xyz.openbmc_project.State.OperatingSystem.Status.
OSStatus.Inactive

-Check CollectionStatus property of vpd-manager D-Bus service:
root@p10bmc:~# busctl get-property com.ibm.VPD.Manager /com/ibm/VPD/
Manager com.ibm.VPD.Manager CollectionStatus
s "Completed"

- Check execution time change
Measure the time between vpd-manager event loop start and
CollectionStatus = Completed on a Everest system. Following figures were
measured across 3 reboots:
- On current code, (with the extra async call) it is 61 secs.
- With the changes in this PR, it is 60.33 secs.
```

Change-Id: I86dd9f9f6a4c67b8159e4c90d6ffdb005568cf6b
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...