use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more e

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more efficient and succinct.

Change-Id: Id72a3ca364a3a83f7b7685ac359997fbddfb0f5a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

1210-ghe:RBMC-prototype: Fix position check logic

Change-Id: I023035573bfe002c40e5b7efaf7abf639ee3b03d
Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>

Update RBMC system IM value

The IM value defined for the RBMC system was incorrect, which caused
the BMC position to be set incorrectly.
This commit updates the IM value to fix the issue.

Change-Id

Update RBMC system IM value

The IM value defined for the RBMC system was incorrect, which caused
the BMC position to be set incorrectly.
This commit updates the IM value to fix the issue.

Change-Id: Idf0fe45932bef3641e71bd59536bd6ee31edf38c
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Refactor pvm_keep_and_clear bios attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
pvm_keep_and_clear

Refactor pvm_keep_and_clear bios attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
pvm_keep_and_clear attribute. These values are now dynamically
retrieved from the Bios-map JSON file to improve maintainability and
flexibility.

Change-Id: I5fc771d5fd571a2b68ee0fae6911a0144aa1dfe7
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...

Refactor pvm_clear_nvram bios attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
pvm_clear_nvram attri

Refactor pvm_clear_nvram bios attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
pvm_clear_nvram attribute. These values are now dynamically retrieved
from the Bios-map JSON file to improve maintainability and
flexibility.

Change-Id: I09c05bfda86d14ce6680cd131b3b01a3a9885d19
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...

Refactor pvm_create_default_lpar attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
pvm_create_default

Refactor pvm_create_default_lpar attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
pvm_create_default_lpar attribute. These values are now dynamically
retrieved from the Bios-map JSON file to improve maintainability and
flexibility.

Change-Id: I00561cdef7b3e68179470a12577d8c8fb0dd3114
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...

Refactor hb_memory_mirror_mode bios attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
hb_memory_mirro

Refactor hb_memory_mirror_mode bios attr handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
hb_memory_mirror_mode attribute. These values are now dynamically
retrieved from the Bios-map JSON file to improve maintainability and
flexibility.

Change-Id: Ie1271ea81415e2f3e8d78a083ce864ba17460be5
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...

Logger Class Update

This commit is modifying logMessage API. The argument pelTuple changed
to optional, so that caller doesn't need to create the pelInfoTuple
structure. Instead, it can be created i

Logger Class Update

This commit is modifying logMessage API. The argument pelTuple changed
to optional, so that caller doesn't need to create the pelInfoTuple
structure. Instead, it can be created inside the logMessage API with
the sent details.

Test-
- Can see the PEL on PST simics.
```
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"DESCRIPTION": "ParseAndPublish VPD failed for [reason] Standard runtime exception. Reason: DBG: Alpana's patch testing",
"FileName": "/usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/src/worker.cpp",
"FunctionName": "std::tuple<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > vpd::Worker::parseAndPublishVPD(const std::string&)",
"InteranlRc": "0",
"UserData1": "",
"UserData2": ""
},

```

Change-Id: I3d5e3c749e93749f0ea7a88d88531a4b3faedc80
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

File mode support for system VPD

This commit adds code to support read and write of system VPD keywords
in file mode.

Test:
```
Value before updating keyword:
root@p11bmc:~# vpd-tool -r -O /sys/bu

File mode support for system VPD

This commit adds code to support read and write of system VPD keywords
in file mode.

Test:
```
Value before updating keyword:
root@p11bmc:~# vpd-tool -r -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -H -R VSYS -K RB
{
"/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"RB": "0001"
}
}

root@p11bmc:~# vpd-tool -r -O /system/chassis/motherboard -R VSYS -K RB
{
"/system/chassis/motherboard": {
"RB": "0001"
}
}
root@p11bmc:~# vpd-tool -r -O /system/chassis -R VSYS -K RB
{
"/system/chassis": {
"RB": "0001"
}
}

Update the keyword
root@p11bmc:~# vpd-tool -w -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -H -R VSYS -K RB --value "0003"
Data updated successfully

After updating the value:
root@p11bmc:~# vpd-tool -r -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -H -R VSYS -K RB
{
"/var/lib/vpd/file/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
"RB": "0003"
}
}

root@p11bmc:~# vpd-tool -r -O /system/chassis -R VSYS -K RB
{
"/system/chassis": {
"RB": "0003"
}
}
root@p11bmc:~# vpd-tool -r -O /system/chassis/motherboard -R VSYS -K RB
{
"/system/chassis/motherboard": {
"RB": "0003"
}
}
```

Change-Id: I1d723f931d8910a647c42f88a34d37ed794a1423
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Refactor hb_field_core_override bios attr handler handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
hb_fie

Refactor hb_field_core_override bios attr handler handler

Replace hardcoded constants with JSON configuration and updated the
logic to remove hardcoded constant keywords and record values for
hb_field_core_override attribute. These values are now dynamically
retrieved from the Bios-map JSON file to improve maintainability and
flexibility.

Change-Id: Ibc86f854070ff14affd47fedbba0f960f2054e70
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...

Write BMC position to file

Write the BMC position to the file /run/openbmc/bmc_position so that
applications that may have issues getting it from D-Bus can access it.

Because getBmcPosition() alway

Write BMC position to file

Write the BMC position to the file /run/openbmc/bmc_position so that
applications that may have issues getting it from D-Bus can access it.

Because getBmcPosition() always returns max() right now, it's value
shouldn't be used so there is a check to set the position back to zero
in that case. When that function is finished, this can be removed.

Tested:
Position is written:
```
root@huygens:~# cat /run/openbmc/bmc_position
0
```

Change-Id: Ie92509131391f0cce1208a2c532f022222402f00
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Revert "Logger Class Update"

The commit changes the signature of API resulting in all other calls to
fail. All the related changes need to be merged in a single shot.

This reverts commit 5c484e9e5a

Revert "Logger Class Update"

The commit changes the signature of API resulting in all other calls to
fail. All the related changes need to be merged in a single shot.

This reverts commit 5c484e9e5a399075ef26d6974ed5c1c7a486e45c.

Change-Id: If92cc13048878170f6ff883767752216410cf5c0
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Logger Class Update

This commit is modifying logMessage API. The argument pelTuple changed
to optional, so that caller doesn't need to create the pelInfoTuple
structure. Instead, it can be created i

Logger Class Update

This commit is modifying logMessage API. The argument pelTuple changed
to optional, so that caller doesn't need to create the pelInfoTuple
structure. Instead, it can be created inside the logMessage API with
the sent details.

Test-
- Can see the PEL on huygens simics.
```
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"DESCRIPTION": "ParseAndPublish VPD failed for [reason] Standard runtime exception. Reason: DBG: Alpana's patch testing",
"FileName": "/usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/src/worker.cpp",
"FunctionName": "std::tuple<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > vpd::Worker::parseAndPublishVPD(const std::string&)",
"InteranlRc": "0",
"UserData1": "",
"UserData2": ""
},

```

Change-Id: I1b617ca611507d15e7592bc88a2995200feee06c
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

BIOS JSON parsing and refactor Backup/Restore API

Updated IbmBiosHandler to extract the BIOS configuration file path from
The System Configuration JSON. Additionally, updated the
backUpOrRestoreBios

BIOS JSON parsing and refactor Backup/Restore API

Updated IbmBiosHandler to extract the BIOS configuration file path from
The System Configuration JSON. Additionally, updated the
backUpOrRestoreBiosAttributes API to align with these changes,ensuring
BIOS attributes are processed correctly based on the system-specific
configuration and bios json.

Change-Id: I9e97733b5c1440e8fb346ceb3fe7cb8328fb5684
Signed-off-by: Chanchal Tiwari <chanchaltiwari70021@gmail.com>

show more ...

GpioEventHandler :Handle uninitialized Worker

This commit adds changes in GpioEventHandler to handle the scenario
where Worker instant is not initialized. GpioEventHandler APIs depend on
Worker inst

GpioEventHandler :Handle uninitialized Worker

This commit adds changes in GpioEventHandler to handle the scenario
where Worker instant is not initialized. GpioEventHandler APIs depend on
Worker instance, so if Worker instance is not initialized, we should
fail GpioEventHandler instantiation as well.

Test:
```
- Build vpd-manager for rbmc-prototype
- Install vpd-manager binary on an rbmc-prototype system
- Restart vpd-manager
- Observe vpd-manager service started successfully
Jan 27 08:47:42 rbmc-prototype systemd[1]: Starting VPD Manager...
Jan 27 08:47:42 rbmc-prototype vpd-manager[29695]: ## Error: "fieldmode" not defined
Jan 27 08:47:42 rbmc-prototype vpd-manager[29696]: ## Error: "vpdmode" not defined
Jan 27 08:47:42 rbmc-prototype vpd-manager[29694]: FileName: /usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/oem-handler/ibm_handler.cpp, Line: 1174 Failed to set collection status for path /sys/bus/i2c/drivers/at24/1-0051/eepromReason: The FRU path is not found in the JSON.
Jan 27 08:47:42 rbmc-prototype vpd-manager[29694]: FileName: /usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/oem-handler/ibm_handler.cpp, Line: 198 Failed to initialize event listener. Error: Cannot instantiate Listener as Worker is not initialized
Jan 27 08:47:42 rbmc-prototype vpd-manager[29694]: FileName: /usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/src/manager_main.cpp, Line: 46 Start VPD-Manager event loop
Jan 27 08:47:42 rbmc-prototype systemd[1]: Started VPD Manager.
```

Change-Id: I7d42eaba602456a33c36ac55ff891338173ff9fa
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Listener: handle Worker not initialized scenario

This commit adds changes in Listener instantiation if Worker is not
initialized. Listener APIs require Worker instance, so if Worker
instance is not

Listener: handle Worker not initialized scenario

This commit adds changes in Listener instantiation if Worker is not
initialized. Listener APIs require Worker instance, so if Worker
instance is not initialized, Listener instantiation should also fail.

Test:
```
- Build vpd-manager for rbmc-prototype
- Install vpd-manager binary on an rbmc-prototype system
- Restart vpd-manager
- Observe vpd-manager service started successfully
Jan 27 08:47:42 rbmc-prototype systemd[1]: Starting VPD Manager...
Jan 27 08:47:42 rbmc-prototype vpd-manager[29695]: ## Error: "fieldmode" not defined
Jan 27 08:47:42 rbmc-prototype vpd-manager[29696]: ## Error: "vpdmode" not defined
Jan 27 08:47:42 rbmc-prototype vpd-manager[29694]: FileName: /usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/oem-handler/ibm_handler.cpp, Line: 1174 Failed to set collection status for path /sys/bus/i2c/drivers/at24/1-0051/eepromReason: The FRU path is not found in the JSON.
Jan 27 08:47:42 rbmc-prototype vpd-manager[29694]: FileName: /usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/oem-handler/ibm_handler.cpp, Line: 198 Failed to initialize event listener. Error: Cannot instantiate Listener as Worker is not initialized
Jan 27 08:47:42 rbmc-prototype vpd-manager[29694]: FileName: /usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/src/manager_main.cpp, Line: 46 Start VPD-Manager event loop
Jan 27 08:47:42 rbmc-prototype systemd[1]: Started VPD Manager.
```

Change-Id: Ibe16061051f5616683f118761d8748ca8106fbe7
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>

show more ...

Read VPD collection mode

VPD collection mode is used by multiple classes. Instead of reading it
in each class, the mode is read once in the manager class and passed to
other classes to avoid multipl

Read VPD collection mode

VPD collection mode is used by multiple classes. Instead of reading it
in each class, the mode is read once in the manager class and passed to
other classes to avoid multiple reads.

Change-Id: Ie5ee7f4b366625f8ed8c882b98756b83f05d1254
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

Add API to check JSON validity

The commit adds an API to check if the JSON passed in the constructor of
BackupAndRestore class in having all the required tags or not.

This has been added so that we

Add API to check JSON validity

The commit adds an API to check if the JSON passed in the constructor of
BackupAndRestore class in having all the required tags or not.

This has been added so that we detect any failure case right at the time
of initializing the class and fail early in case of any issue.

Change-Id: I618df4e787fc510c3b3cf8cddf9ea402a16dece7
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

callPIM replacement with publishVpdonDBus

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this comm

callPIM replacement with publishVpdonDBus

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.
With this commit these APIs has been updated -
setCollectionStatusProperty
checkAndUpdatePowerVsVpd
updateCorrelatedProperty
processPreAction
parseAndPublishVPD
setPresentProperty

Test:
```
vpd-manager/src/worker.cpp, Line: 954 DBG: parseAndPublishVPD via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus

vpd-manager/include/utility/vpd_specific_utility.hpp, Line: 1473 DBG: setCollectionStatusProperty via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
```

Change-Id: I0e9c8b95a924c34e781d195a2a175a3a2c675392
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

resetObjTreeVpd update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is repl

resetObjTreeVpd update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.

Test:
```
vpd-manager/src/worker.cpp, Line: 1290 DBG: deleteFruVpd via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus
vpd-manager/include/utility/json_utility.hpp, Line: 481 Setting GPIO: SLOT10_PRSNT_EN_RSVD to 0
vpd-manager/src/worker.cpp, Line: 1322 Successfully completed deletion of FRU VPD for /xyz/openbmc_project/inventory/system/chassis/motherboard/pcieslot10/pcie_card10
```

Change-Id: I50548be953ee9b031741fb93d799b5b73d8a9136
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

callPIM replacement with publishVpdonDBus

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this comm

callPIM replacement with publishVpdonDBus

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.
With this commit these APIs has been updated -
updateKwdOnInheritedFrus
updateCiPropertyOfInheritedFrus
updateVpdKeyword

Test:
```
vpd-manager/src/parser.cpp, Line: 223 DBG: updateVpdKeyword via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus

vpd-manager/include/utility/vpd_specific_utility.hpp, Line: 1217 DBG: updateCiPropertyOfInheritedFrus via callDbusMethod
vpd-manager/include/utility/dbus_utility.hpp, Line: 368 DBG:Alpana patch running
vpd-manager/include/utility/dbus_utility.hpp, Line: 325 DBG:callPimNotify called
vpd-manager/include/utility/dbus_utility.hpp, Line: 356 DBG:callPimNotify Done
vpd-manager/include/utility/dbus_utility.hpp, Line: 379 DBG:dbus method call completed, check the output on dbus

```

Change-Id: I2371cf3d4f00c73af32c09b65393be59113f60ca
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Refactor backup and restore for IPZ VPD

This commit split the IPZ VPD backup and restore logic into multiple
APIs to improve maintainability and avoid code duplication.

Change-Id: Ia36e7e84b910412f

Refactor backup and restore for IPZ VPD

This commit split the IPZ VPD backup and restore logic into multiple
APIs to improve maintainability and avoid code duplication.

Change-Id: Ia36e7e84b910412f6cf818ec92cef5812de44045
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

notifyFRUCollectionStatus update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callP

notifyFRUCollectionStatus update

We were using callPIM which calls the dbus method notifyPIM to update
the data on dbus. It's tightly coupled with phosphor-inventory-manager.
With this commit, callPIM is replaced with publishVpdonDBus, a generic
method, which will decide which service-method to call at runtime.

Change-Id: I439920e63dc00aba7c643e09d92beb5f0987efc0
Signed-off-by: Alpana Kumari <alpu8007@gmail.com>

show more ...

Refactor backup and restore

This change splits the logic into multiple APIs to improve code
maintainability and eliminate duplicate code in backup and restore.
It also updates log messages to use th

Refactor backup and restore

This change splits the logic into multiple APIs to improve code
maintainability and eliminate duplicate code in backup and restore.
It also updates log messages to use the logger instance.

Change-Id: Ie996cf7ef3781b4694b6817f8175da5e0734a0d7
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

Add utility API to determine BMC position

For PST systems, the BMC position will be determined based on the value
returned by the cable management service.
This commit adds a stub utility API to ret

Add utility API to determine BMC position

For PST systems, the BMC position will be determined based on the value
returned by the cable management service.
This commit adds a stub utility API to retrieve the BMC position using
the cable management service.

Change-Id: Iba97b97672fa642bf3b705497e3c5d6762f167a9
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...