switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: Ia3f5c607a348f062a0f112d5eae8b51ecc23fd37
Signed-off-by: J

switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: Ia3f5c607a348f062a0f112d5eae8b51ecc23fd37
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I66785e0aa71a93f9370db0168049cd62c1f69728
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I29672cb229bd07022b00f52105ac1d50ecacca62

show more ...

PHAL: Log Informational error for PEL created during poweroff

1)Log informational PELS in case system state is transitioning to
power-off for IPL procedures/hardware access failures

2) Don't add ca

PHAL: Log Informational error for PEL created during poweroff

1)Log informational PELS in case system state is transitioning to
power-off for IPL procedures/hardware access failures

2) Don't add callouts to PEL's created during transition to
power-off as the CEC will not be in expected state.

Tested: transition to poweroff
root@xxxbmc:/usr# peltool -lfh
{
"0x50003BEB": {
"SRC": "BD503001",
"Message": "Failure occurred during boot process",
"PLID": "0x50003BEB",
"CreatorID": "BMC",
"Subsystem": "CEC Hardware",
"Commit Time": "05/23/2022 13:57:53",
"Sev": "Informational Event",
"CompID": "0x3000"
}
}

root@xxxbmc:~# peltool -i 0x50003be0
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x3000",
"Created at": "05/23/2022 13:48:12",
"Committed at": "05/23/2022 13:48:12",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x50003BE0",
"Entry Id": "0x50003BE0",
"BMC Event Log Id": "510"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Informational Event",
"Event Type": "Miscellaneous, Informational Only",
"Action Flags": [
"Event not customer viewable",
"Report Externally"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},

.
.
.
Tested: transition to running
root@ever8bmc:/tmp# peltool -i 0x50003CF9
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x3000",
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Unrecoverable Error",
},

"User Data 0": {
"Created by": "0x2000",
"BMCState": "Ready",
"BootState": "Unspecified",
"ChassisState": "On",
"FW Version ID": "fw1020.00-57.7-2-gd86188a773",
"HostState": "TransitioningToRunning",
"Process Name": "/usr/bin/openpower-proc-control",
"System IM": "50003000"
},

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I078d5cba2e0fb705bf424d2f8f3010f2cd2063bb

show more ...

PHAL: Set HardwareIsolation policy before start the host

- The HardwareIsolation (aka guard) policy is used to prevent
the HardwareIsolation functionality during the boot of the host

PHAL: Set HardwareIsolation policy before start the host

- The HardwareIsolation (aka guard) policy is used to prevent
the HardwareIsolation functionality during the boot of the host
by the user.

- In this patch, using that policy flag to ignore the isolated hardware
records to apply during the start of the host from the BMC context.

- By default, it will be set as "true" before starting the host to boot
if the HardwareIsolation policy is not present or failed to read that
policy.

- Created the error log with procedure callout if failed to read
the HardwareIsolation policy.

Tested:
- Verified the HWAS_STATE of the isolated hardware, is not applied when
the HardwareIsolation policy is enabled.

- Verified the HWAS_STATE of the isolated hardware, is applied when
the HardwareIsolation policy is disabled.

- Verified the HWAS_STATE of the isolated hardware, is applied when
the HardwareIsolation policy is not present.

- PEL for the third test case.

```
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x3000",
...
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Unrecoverable Error",
"Event Type": "Not Applicable",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},
...
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x3000",
...
"Error Details": {
"Message": "Failure occured during boot process"
},
"Valid Word Count": "0x09",
"Reference Code": "BD503001",
...
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Medium Priority",
"Procedure": "BMC0001"
}]
}
...
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"REASON_FOR_PEL": "Failed to read the HardwareIsolation policy from the path [/xyz/openbmc_project/hardware_isolation/allow_hw_isolation] interface [xyz.openbmc_project.Object.Enable]. Continuing with default mode(allow_hw_isolation)",
"_PID": "681"
},
"User Data 2": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Priority": "M",
"Procedure": "BMC0001"
}
]
}
}
```

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I2d7e33ad1e6af69b150d6637619c17db5b9a7151

show more ...

PHAL: refactor startHostNormal procedure

selectBootSeeprom function not working correctly due to
order of calling this function in startHostNormal procedure path.
This function shoul

PHAL: refactor startHostNormal procedure

selectBootSeeprom function not working correctly due to
order of calling this function in startHostNormal procedure path.
This function should be called after phal_init.

This refactor help to fix the function invoking order in regular
ipl path. Also added PEL log for any Boot initialisation failure

Tested: verified regular and mpipl boot.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I9f6688dfdc6a3d69f4480127cf4b052cf0c99131

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia8f2ae95679f98f2fc3f32239bbf3b3578c35888

phal: ipl_error_callback_func prototype related changes

libipl ipl_error_callback_func prototype changed to support additional
error handling support. This commits includes the changes r

phal: ipl_error_callback_func prototype related changes

libipl ipl_error_callback_func prototype changed to support additional
error handling support. This commits includes the changes related to
this function prototype function.

Also made changes in internal error handling to make direct
call to processBootError instead of callback function.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I76aa1c4d41e4b2685b3c6534afe35988f35bc103

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I013d8a225f7a15601a5defa487d7030daad77270

show more ...

phal: move common_utils.cpp to extensions/phal

tested: verified build

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ib34b0ed54010cf9e4cc2d56bfaccdf23db28b11f

phal: Added extensions/phal folder

Added phal specific folder to keep all phal feature
based function in common place

Moved phal error specific source files to extensions/phal

phal: Added extensions/phal folder

Added phal specific folder to keep all phal feature
based function in common place

Moved phal error specific source files to extensions/phal

Tested: build verified.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Iabae2689444f355008802950a293e7c69cb19553

show more ...

primary-proc: move function to common utils

This is a useful function which can be utilized in upcoming work so move
to the common utilities

Signed-off-by: Andrew Geissler <geis

primary-proc: move function to common utils

This is a useful function which can be utilized in upcoming work so move
to the common utilities

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I87873b4dbedbeef0a18474eba39798fde298ea36

show more ...

set CLK NE termination site based on HW VPD keyword.

VINI Record "HW" keyword Byte 0's MSB bit indicates
proc or planar type. This type value is used for choosing
termination site at

set CLK NE termination site based on HW VPD keyword.

VINI Record "HW" keyword Byte 0's MSB bit indicates
proc or planar type. This type value is used for choosing
termination site attribute.

Reads the HW level VPD keyword planar VINI records,
compute SYS_CLK_NE_TERMINATION_SITE and set the
present processors ATTR_SYS_CLK_NE_TERMINATION_SITE
value.

This attribute initialisation should be happened prior
to set_ref_clock istep. Added this function before
istep execution in startHost procedure.

Tested: manually verified attribute values

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I56f88f92df2e5db9d204b7b3cc87f15d6759d07d

show more ...

phal: Added proc-pre-poweroff support

Changes:
-Adding new service which will be called during
chassis poweroff.

Test:
-Did poweroff to check, if the service file
is

phal: Added proc-pre-poweroff support

Changes:
-Adding new service which will be called during
chassis poweroff.

Test:
-Did poweroff to check, if the service file
is getting picked up or not and new added
procedure is getting called.

Signed-off-by: Chirag Sharma <chirshar@in.ibm.com>
Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Ic533433c4771216e5681b61cccf154f7ed029457

show more ...

build: update clang-format

Update to the latest OpenBMC clang-format.

Change-Id: I19424fe32f32900d21272e343a5bda8675edbe60
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.co

build: update clang-format

Update to the latest OpenBMC clang-format.

Change-Id: I19424fe32f32900d21272e343a5bda8675edbe60
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

fix compiler warnings

Fix a couple pedantic, format=, and unused-parameter warnings so we can
turn the warnings all the way up.

Change-Id: I7c6309e30147f54fc64ace99dc784fbd96c77

fix compiler warnings

Fix a couple pedantic, format=, and unused-parameter warnings so we can
turn the warnings all the way up.

Change-Id: I7c6309e30147f54fc64ace99dc784fbd96c77c70
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Skip changing boot seeprom in memory preserving reboot

In memory preserving reboot path skip updating the attributes
to switch the seeprom. The boot seeprom should be not changed
dur

Skip changing boot seeprom in memory preserving reboot

In memory preserving reboot path skip updating the attributes
to switch the seeprom. The boot seeprom should be not changed
during a memory preserving reboot

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I16a9a79df69d66c4cf03517f1a072f2e2c0e534e

show more ...

Add startHostMpReboot support to PHAL based booting

Add support for setting the boot type as MPIPL to skip the
normal reboot and execute memory preserving reboot specific
steps.

Add startHostMpReboot support to PHAL based booting

Add support for setting the boot type as MPIPL to skip the
normal reboot and execute memory preserving reboot specific
steps.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I477a01f2d0d3c3574a3e1335be666703b71713ab

show more ...

Select primary/secondary BOOT/MEASUREMENT SEEPROM based on boot count

Changes include:
1) selection of primary/secondary seeprom before booting host
2) structure name change fr

Select primary/secondary BOOT/MEASUREMENT SEEPROM based on boot count

Changes include:
1) selection of primary/secondary seeprom before booting host
2) structure name change from PACKED to PACK to avoid conflict with
attributes_info.H

Tests done :
- Verified the right bit set for Primary Vs Secondary Boot path
- Verified attribute GET/SET working good

Signed-off-by: Lakshminarayana R. Kammath <lkammath@in.ibm.com>
Change-Id: I3017b0e9118119cc0a5e478f262641ce539ac4ff

show more ...

procedures/phal/start_host: Initialized libpdbg, libekb and libipl

Currently ipl_init is initializing libpdbg and libekb but
as per recent design changes, phal expecting all phal library

procedures/phal/start_host: Initialized libpdbg, libekb and libipl

Currently ipl_init is initializing libpdbg and libekb but
as per recent design changes, phal expecting all phal library
initialization should just happen in application rather than
doing via ipl_init. so, same support added in this patch.

ipl_init expecting boot mode explicitly from application so,
setting IPL_AUTOBOOT (continuous ipling) to boot the system.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I38026082cfa2fb21e042b50ddb7c627956a317be

show more ...

Revert "Setting phal ipl_init as IPL_DEFAULT to boot the system"

Mode value is incorrect, it should IPL_BOOT.

This reverts commit 22de8ac1049d3e3fac3e52a6a88611adc8250666.

Revert "Setting phal ipl_init as IPL_DEFAULT to boot the system"

Mode value is incorrect, it should IPL_BOOT.

This reverts commit 22de8ac1049d3e3fac3e52a6a88611adc8250666.

Change-Id: I7859834580cf40094077645e539d18029ae08bcc

show more ...

Setting phal ipl_init as IPL_DEFAULT to boot the system

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I69c368b26ae7008985b55d9253b1e17124acfaf7

Create PEL for boot errors with error XML data and traces

Add callback method into boot library to receive
status of boot load.

Add callback method into PHAL library to get back

Create PEL for boot errors with error XML data and traces

Add callback method into boot library to receive
status of boot load.

Add callback method into PHAL library to get back
traces logged so that the same can be used in
creation of PEL during failure.

Tested:
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"CBS_CS_IDLE_VALUE": "00000002",
"CBS_CS_READ": "84000002",
"HWP Error description": "CBS did not complete (did not arrive in IDLE
state) within timeout",
"HW_DELAY": "0009c400",
"HwpReturnCode": "RC_CBS_NOT_IN_IDLE_STATE",
"LOG000 2020-03-08 06:26:34": "inf: p10_start_cbs:58 ",
"LOG001 2020-03-08 06:26:34": "p10_start_cbs: Entering ...",
"LOG002 2020-03-08 06:26:34": "err: CBS_NOT_IN_IDLE_STATE:36720 ",
"LOG003 2020-03-08 06:26:34": "CBS did not complete (did not arrive in IDLE
state) within timeout",
"LOG004 2020-03-08 06:26:34": "err: _setHwpError:114 ",
"LOG005 2020-03-08 06:26:34": "_setHwpError: Creating HWP error 0xa97f5",
"LOG006 2020-03-08 06:26:34": "err: p10_start_cbs:119 ",
"LOG007 2020-03-08 06:26:34": "ERROR: CBS HAS NOT REACHED IDLE STATE VALUE
0x002 ",
"LOOP_COUNT": "000000c8",
"_PID": "495"
}

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I06491f09041edcd16d8db5890c74a4db8d08e920

show more ...

Enabled pHAL infrastructure to boot the host

IPL (libipl) used for executing hardware procedures
to initilize the power processor based host.

Tested by:
1. ./configure

Enabled pHAL infrastructure to boot the host

IPL (libipl) used for executing hardware procedures
to initilize the power processor based host.

Tested by:
1. ./configure
2. ./configure --enable-phal --enable-openfsi

Change-Id: I57ff64595a757041ee60ccb420092975b064462d
Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>

show more ...