clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I299e3888aee418ddcf391a44cd9ba563edabfe83
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I06e9ad76b7e259a962f15f0b013d92a62f02a039
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

phal: fix ignoring attributes warning

This to fix the below compilation warnings with latest
yocto rebase .

einit_devtree.cpp:28:62: error: ignoring attributes
on template argument 'int (*)(FILE*

phal: fix ignoring attributes warning

This to fix the below compilation warnings with latest
yocto rebase .

einit_devtree.cpp:28:62: error: ignoring attributes
on template argument 'int (*)(FILE*)'
[-Werror=ignored-attributes]
| 28 | using FILE_Ptr =
std::unique_ptr<FILE, decltype(&std::fclose)>;

Change-Id: I12e0f4034eea80d19c0f1236102ab0bafd42432e
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: Ia3f5c607a348f062a0f112d5eae8b51ecc23fd37
Signed-off-by: J

switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: Ia3f5c607a348f062a0f112d5eae8b51ecc23fd37
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

gcc13 : fix argument format issues

gcc13 based build failed with below error.
error: static assertion failed: Cannot format an argument.
To make type T formattable provide a formatter<T> special

gcc13 : fix argument format issues

gcc13 based build failed with below error.
error: static assertion failed: Cannot format an argument.
To make type T formattable provide a formatter<T> specialization:
https://fmt.dev/latest/api.html#udt

Problem looks similar to https://github.com/fmtlib/fmt/issues/391

Fix is to convert the "enum" type to underlying_type in fmt::format function.

Change-Id: I155fc854428492462dfec3b3818d08daa16e36bf
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I66785e0aa71a93f9370db0168049cd62c1f69728
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

generate bmc dump if hw indicates host running

This situation has been hit a few times and it has been requested a BMC
dump be generated when the condition is hit. This dump will help debug
why the

generate bmc dump if hw indicates host running

This situation has been hit a few times and it has been requested a BMC
dump be generated when the condition is hit. This dump will help debug
why the BMC is unable to communicate with the host.

Tested:
- Caused the error path and verified a BMC dump was requested

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I44cc4066b9b7c4eddb04348c2caf6493fb3af31a

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I29672cb229bd07022b00f52105ac1d50ecacca62

show more ...

PHAL: mpreboot- exit with failure if no functional processor found

On some special cases noticed DeviceTree was returning no
functional processor when queried.

As there are no functional processors

PHAL: mpreboot- exit with failure if no functional processor found

On some special cases noticed DeviceTree was returning no
functional processor when queried.

As there are no functional processors present MPreboot was
not performed and no error/PEL was created to notify the user.
Rather the method was exiting with SUCCESS.

Now modified to log an error message and create a PEL if
no functional processors are found to perform MPReboot.

openpower-proc-control[3663]: Starting memory preserving reboot
openpower-proc-control[3663]: EnterMPReboot is not executed on any
processors
phosphor-log-manager[320]: Event not found in PEL message registry:
org.open_power.Processor.Error.MemoryPreservingReboot
phosphor-log-manager[320]: Created PEL 0x50014017 (BMC ID 750) with SRC BD752004

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: Id781fc1bc9fac869c96c29562f62260c1a7c909d

show more ...

PHAL: Log Informational error for PEL created during poweroff

1)Log informational PELS in case system state is transitioning to
power-off for IPL procedures/hardware access failures

2) Don't add ca

PHAL: Log Informational error for PEL created during poweroff

1)Log informational PELS in case system state is transitioning to
power-off for IPL procedures/hardware access failures

2) Don't add callouts to PEL's created during transition to
power-off as the CEC will not be in expected state.

Tested: transition to poweroff
root@xxxbmc:/usr# peltool -lfh
{
"0x50003BEB": {
"SRC": "BD503001",
"Message": "Failure occurred during boot process",
"PLID": "0x50003BEB",
"CreatorID": "BMC",
"Subsystem": "CEC Hardware",
"Commit Time": "05/23/2022 13:57:53",
"Sev": "Informational Event",
"CompID": "0x3000"
}
}

root@xxxbmc:~# peltool -i 0x50003be0
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x3000",
"Created at": "05/23/2022 13:48:12",
"Committed at": "05/23/2022 13:48:12",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x50003BE0",
"Entry Id": "0x50003BE0",
"BMC Event Log Id": "510"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Informational Event",
"Event Type": "Miscellaneous, Informational Only",
"Action Flags": [
"Event not customer viewable",
"Report Externally"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},

.
.
.
Tested: transition to running
root@ever8bmc:/tmp# peltool -i 0x50003CF9
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x3000",
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Unrecoverable Error",
},

"User Data 0": {
"Created by": "0x2000",
"BMCState": "Ready",
"BootState": "Unspecified",
"ChassisState": "On",
"FW Version ID": "fw1020.00-57.7-2-gd86188a773",
"HostState": "TransitioningToRunning",
"Process Name": "/usr/bin/openpower-proc-control",
"System IM": "50003000"
},

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I078d5cba2e0fb705bf424d2f8f3010f2cd2063bb

show more ...

PHAL: Additional callout support for sbe timeout error

Sbe Boot timeout or chip-op timeout case BMC should run
sbe_extract_rc procedure to identify the correct callout
and service action. Currently

PHAL: Additional callout support for sbe timeout error

Sbe Boot timeout or chip-op timeout case BMC should run
sbe_extract_rc procedure to identify the correct callout
and service action. Currently this procedure based callout
handling is not place. Adding callout recommended by RAS
team till the actual callout code in place.

Tested:

"Callout Count": "2",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this type as a unit",
"Procedure": "BMC0002"
}, {
"FRU Type": "Normal Hardware FRU",
"Priority": "Medium Priority",
"Location Code": "xxx", --> processor callout
"Part Number": "xxx",
"CCIN": "xxx",
"Serial Number": "xxx"

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I40444eb5da1a5f329b09dea1bce15e1bab53e1d8

show more ...

PHAL: Compute RO device tree file path from RW device tree symbolic link

Example:
RW file = /media/hostfw/running/DEVTREE -> 81e00672.lid
RO file = /media/hostfw/running-ro/ + 81e00672.lid

Compute

PHAL: Compute RO device tree file path from RW device tree symbolic link

Example:
RW file = /media/hostfw/running/DEVTREE -> 81e00672.lid
RO file = /media/hostfw/running-ro/ + 81e00672.lid

Compute the lid name by reading the RW symbolic link and use
it to comptue RO file.

Symbolic links cannot be created to RO files so using this approach

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I46101b8e246267c861edb5eae1ac24420cfc3c6d

show more ...

PHAL: Log informational type event for threadStopAll failure

currently threadStopAll command chip-op failure is marked as
unrecoverable type event. This is only called in
poweroff/error path, good c

PHAL: Log informational type event for threadStopAll failure

currently threadStopAll command chip-op failure is marked as
unrecoverable type event. This is only called in
poweroff/error path, good chance of chip-op failure in some
use-cases. Since there no service action required related to
this failure converting un-recoverable errors to informational

Tested: Verified PEL

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I04be09046967055579fc64980d81247e975a9c76

show more ...

PHAL: Set HardwareIsolation policy before start the host

- The HardwareIsolation (aka guard) policy is used to prevent
the HardwareIsolation functionality during the boot of the host
by the user

PHAL: Set HardwareIsolation policy before start the host

- The HardwareIsolation (aka guard) policy is used to prevent
the HardwareIsolation functionality during the boot of the host
by the user.

- In this patch, using that policy flag to ignore the isolated hardware
records to apply during the start of the host from the BMC context.

- By default, it will be set as "true" before starting the host to boot
if the HardwareIsolation policy is not present or failed to read that
policy.

- Created the error log with procedure callout if failed to read
the HardwareIsolation policy.

Tested:
- Verified the HWAS_STATE of the isolated hardware, is not applied when
the HardwareIsolation policy is enabled.

- Verified the HWAS_STATE of the isolated hardware, is applied when
the HardwareIsolation policy is disabled.

- Verified the HWAS_STATE of the isolated hardware, is applied when
the HardwareIsolation policy is not present.

- PEL for the third test case.

```
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x3000",
...
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Unrecoverable Error",
"Event Type": "Not Applicable",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},
...
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x3000",
...
"Error Details": {
"Message": "Failure occured during boot process"
},
"Valid Word Count": "0x09",
"Reference Code": "BD503001",
...
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Medium Priority",
"Procedure": "BMC0001"
}]
}
...
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"REASON_FOR_PEL": "Failed to read the HardwareIsolation policy from the path [/xyz/openbmc_project/hardware_isolation/allow_hw_isolation] interface [xyz.openbmc_project.Object.Enable]. Continuing with default mode(allow_hw_isolation)",
"_PID": "681"
},
"User Data 2": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Priority": "M",
"Procedure": "BMC0001"
}
]
}
}
```

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I2d7e33ad1e6af69b150d6637619c17db5b9a7151

show more ...

P9: threadStopall procedure support

This procedure is used to stop all instruction in the threads
for the p9 feature enabled systems. Here following best case
approach. Like issue processor level st

P9: threadStopall procedure support

This procedure is used to stop all instruction in the threads
for the p9 feature enabled systems. Here following best case
approach. Like issue processor level stop all chip-op with
ignore hardware error mode. Since this function is used in
power-off/error path.

Tested: verified procedure on p9 based systems

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I14af85340143d2383683d9fb823394b9ce7b56ca

show more ...

PHAL: threadStopall procedure support

This procedure is used to stop all instruction in the threads
for the phal feature enabled systems. Here following best case
approach. Like issue processor leve

PHAL: threadStopall procedure support

This procedure is used to stop all instruction in the threads
for the phal feature enabled systems. Here following best case
approach. Like issue processor level stop all chip-op with
ignore hardware error mode. Since this function is used in
power-off/error path

Tested: Verified success/error path
root@xxxx:/tmp# openpower-proc-control threadStopAll
PDBG Initilization started
Enter: threadStopProc(/proc0)
Enter: threadStopProc(/proc1)
SBE (/proc1) is not ready for chip-op: state(0x00000000)
Enter: threadStopProc(/proc2)
SBE (/proc2) is not ready for chip-op: state(0x00000000)
Enter: threadStopProc(/proc3)
SBE (/proc3) is not ready for chip-op: state(0x00000000)

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I654b0b7df209e618b3d7a8fba948c0e48b53a7e0

show more ...

PHAL: devtree file based attribute override support

This commits enables the file based devtree attribute override
attributes tool enabled feature to export attribute to override
file during "attrib

PHAL: devtree file based attribute override support

This commits enables the file based devtree attribute override
attributes tool enabled feature to export attribute to override
file during "attributes write" command.
During devtree re-initiaization service execution, enabled
to import attribute override file based data to the devtree.

User can also manually create attribute override file by creating
cronus attribute override format file.
Example:
target = k0
ATTR_FREQ_PAU_MHZ u32 0x000008ca

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I21335c0c81249f4d60b235ea204d0e90420fd29c

show more ...

PHAL: reinitialize the devtree attributes

In the regular host boot path devtree attribute need to
initialize the default data and also some of the selected
attributes need to preserve with previous

PHAL: reinitialize the devtree attributes

In the regular host boot path devtree attribute need to
initialize the default data and also some of the selected
attributes need to preserve with previous boot value.
Preserve attribute list is available BMC pre-defined location.
This function helps to meet the host ipl requirement
related to attribute persistency management for host ipl.

Steps involved
1. create attribute data file from devtree r/w version based on
the attribute list file installed in bmc.
2. create temporary copy of r/w version devtree for attributes
updates and initialise with r/o DEVTREE version
to default data.
3. apply step-1 attribute file on top of the temporary
copy file.
4. Incase any failure from step 1 to 3 log an error and
update r/w version with r/o version ( genesis boot).
5. Update DEVTREE r/w version with temporary version file.

Also added devtree libs part of the pdata repository to
export/import attributes devtree.

Tested: verified the devtree attribute values.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I20c17ba3013a0b4b01f9f8e0d4462c91489308e8

show more ...

PHAL: refactor startHostNormal procedure

selectBootSeeprom function not working correctly due to
order of calling this function in startHostNormal procedure path.
This function should be called afte

PHAL: refactor startHostNormal procedure

selectBootSeeprom function not working correctly due to
order of calling this function in startHostNormal procedure path.
This function should be called after phal_init.

This refactor help to fix the function invoking order in regular
ipl path. Also added PEL log for any Boot initialisation failure

Tested: verified regular and mpipl boot.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I9f6688dfdc6a3d69f4480127cf4b052cf0c99131

show more ...

PHAL: execute enterMPIPL only on valid sbe state

Allow enter_mpipl chip-op request only on the SBE's,
which got valid state's. If the SBE is not on valid
state, skips the chip-op requests on the spe

PHAL: execute enterMPIPL only on valid sbe state

Allow enter_mpipl chip-op request only on the SBE's,
which got valid state's. If the SBE is not on valid
state, skips the chip-op requests on the specific SBE.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I7789deb8dda4d6e2fe053be417b067566d12e717

show more ...

PHAL: collect SBE dump for enterMPIPL chip-op timeout

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ib0edbb655869628120081e821a2ceafc407a9623

PHAL: enterMPIPL chip-op failure handling support

Added new enterMpReboot procedure for PHAL feature enabled
systems to support libphal library API based chip-op
failure handling

Existing enterMpRe

PHAL: enterMPIPL chip-op failure handling support

Added new enterMpReboot procedure for PHAL feature enabled
systems to support libphal library API based chip-op
failure handling

Existing enterMpReboot procedure moved to non PHAL enabled systems.

Tested:
- Poitive Path 3 processor config
Starting Start memory preserving reboot host0...
Starting memory preserving reboot
Enter MPIPL completed on proc(2)
Enter MPIPL completed on proc(3)
Enter MPIPL completed on proc(0)
Finished Start memory preserving reboot host0.

- Error Path:
- Forced proc2 SBE invalid state.

Journal data
SBE (/proc2) is not ready for chip-op: state(0x00000000)

PEL data:
"SBE_ERR_MSG": "SBE chip-op not allowed",
"Message": "chipop request failure reported by SBE",
"SRC6": [
"0x2A901",
"[0:15] chip position, [16:23] command class,
[24:31] command type"
]
},

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ie0cb5abffd5116d44edfbbeb2fe3d8408bfb73e2

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia8f2ae95679f98f2fc3f32239bbf3b3578c35888

PHAL: disable attributes tool debug traces

Attributes "import" options prints debug data in the console.
currently tool is not providing no option to disable this.
This commits stop printing data in

PHAL: disable attributes tool debug traces

Attributes "import" options prints debug data in the console.
currently tool is not providing no option to disable this.
This commits stop printing data into journals to log unwanted
data in journal.

Tested: verified using command line option

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ia21ddeee9b13f0f999bfac88b5985999be762d2c

show more ...

PHAL: set PDATA_INFODB value during import devtree

PDATA recipe removed systemd global settings related to
PDATA_INFODB environment value. This commit enables the
application level support for the s

PHAL: set PDATA_INFODB value during import devtree

PDATA recipe removed systemd global settings related to
PDATA_INFODB environment value. This commit enables the
application level support for the same.

Tested: verified manually by running app.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ic6a9759a1d5c349f5f7cb6666fc3fbc79cb8b1f1

show more ...