af29f723 | 20-Oct-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I0354bf7192c66505b2173aaece3525940a5caa06 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
24bfa198 | 16-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
meson: Replace configure_file with fs.copyfile
configure_file is deprecated since 0.64.0, and replace it with fs.copyfile.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: If06241c070a7ee
meson: Replace configure_file with fs.copyfile
configure_file is deprecated since 0.64.0, and replace it with fs.copyfile.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: If06241c070a7ee06e60c0b346af41138d967bdcc
show more ...
|
8e95057d | 15-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
meson_options.txt: Support for reading options from meson.options
Support has been added for reading options from meson.options instead of meson_options.txt[1]. These are equivalent, but not using t
meson_options.txt: Support for reading options from meson.options
Support has been added for reading options from meson.options instead of meson_options.txt[1]. These are equivalent, but not using the .txt extension for a build file has a few advantages, chief among them many tools and text editors expect a file with the .txt extension to be plain text files, not build scripts.
[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I8dbc92fb4080008b6291ecf1d8dde599a4fe3f4b
show more ...
|
90475e74 | 12-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: upgrade to C++23
Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of the standard has been implemented. Upgrade the build to leverage it.
Change-Id: I65d6d7e3c6fda95b209a0
build: upgrade to C++23
Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of the standard has been implemented. Upgrade the build to leverage it.
Change-Id: I65d6d7e3c6fda95b209a02f9cc13380ad4aad027 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
b119dca1 | 26-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
fix GCC 13 issues
GCC 13 removes `uint*_t` family of types from one of the common includes so we need to explicitly include cstdint.
Change-Id: I05884edbaa38f3999fc6cd8234411d2c2c8a7429 Signed-off-
fix GCC 13 issues
GCC 13 removes `uint*_t` family of types from one of the common includes so we need to explicitly include cstdint.
Change-Id: I05884edbaa38f3999fc6cd8234411d2c2c8a7429 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
67dbb254 | 08-May-2023 |
Andrew Geissler <geissonator@yahoo.com> |
systemd: no installation in templated targets
Upstream yocto introduced a change via e510222 (systemd-systemctl: fix instance template WantedBy symlink construction).
This fixes a bug that we in Op
systemd: no installation in templated targets
Upstream yocto introduced a change via e510222 (systemd-systemctl: fix instance template WantedBy symlink construction).
This fixes a bug that we in OpenBMC had been taking advantage of in that we were able to document our templated target dependencies without it actually doing anything. The real installation of services within targets occurs in our bitbake recipes due to the complexity of chassis and host instances on a per machine basis.
Leave the dependency information in the service files but comment them out. It's useful to be able to look at a service and understand which targets it's going to be installed into by the bitbake recipes.
In some cases, we had hard coded the target instance, which does install the service correctly, but only in that one target. All services should be installed via the bitbake recipe to ensure the service is properly installed in all instances of the target (or service). Once the bump for this commit goes into openbmc/openbmc, I will ensure the recipe is updated to install all services correctly.
Change-Id: I6b1b3ebb9c1c3c2c5c03cf02ec5b74b9c2bcae2a Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
show more ...
|
7fb6c346 | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I4530f5b9df4f5898e26a2eef7efcf82e9728197f Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
eab7ca8e | 09-May-2023 |
Andrew Geissler <geissonator@yahoo.com> |
fix shellcheck failures
New shellcheck in CI has additional checks. Fix the following error:
SC2086 (info): Double quote to prevent globbing and word splitting.
Signed-off-by: Andrew Geissler <gei
fix shellcheck failures
New shellcheck in CI has additional checks. Fix the following error:
SC2086 (info): Double quote to prevent globbing and word splitting.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: I7150a2c379718afa0d32564ab279d14985674c26
show more ...
|
fe34ccd9 | 12-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In meson 0.58 the `get_variable` was enhanced to no longer require the `pkgconfig
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In meson 0.58 the `get_variable` was enhanced to no longer require the `pkgconfig` keyword argument. Ensure meson 0.58 is required and update the usage of all `get_pkgconfig_variable` and `get_variable` to be the modern variant.
Change-Id: Icc8dd9d7e7d229ec090eb631365e5952b8b755b4 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
9b837f61 | 23-Feb-2023 |
Adriana Kobylak <anoo@us.ibm.com> |
item_updater: Add Bonnell compatible system
Add support for the P10 Bonnell system, it was added to the EM Compatible Systems with: ``` https://github.com/openbmc/entity-manager/commit/0b5b122fe93f0
item_updater: Add Bonnell compatible system
Add support for the P10 Bonnell system, it was added to the EM Compatible Systems with: ``` https://github.com/openbmc/entity-manager/commit/0b5b122fe93f02fe79e0f8263a9c9e2c6d5c8c5e ```
Tested: Verified the symlinks were created on a Bonnell system.
Change-Id: I74cba7fd945365a990cdc23f89851c5751f73431 Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
show more ...
|
42fa0484 | 14-Feb-2023 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
treewide: remove dependencies on mapper.target
The mapper is dbus activated now, so these explicit dependency declarations are unnecessary and redundant.
Change-Id: I9e39d9cc7af6df22b5293e5579d9154
treewide: remove dependencies on mapper.target
The mapper is dbus activated now, so these explicit dependency declarations are unnecessary and redundant.
Change-Id: I9e39d9cc7af6df22b5293e5579d9154fd2b22cf9 Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
show more ...
|
6fa12d3d | 26-Jan-2023 |
Andrew Geissler <geissonator@yahoo.com> |
update service file deps in accordance with recent refactoring
As noted in the following mailing list thread: https://lists.ozlabs.org/pipermail/openbmc/2022-November/032457.html
and implemented vi
update service file deps in accordance with recent refactoring
As noted in the following mailing list thread: https://lists.ozlabs.org/pipermail/openbmc/2022-November/032457.html
and implemented via this series of commits: https://gerrit.openbmc.org/q/topic:op-power-control-ref
Some systemd services had their names changed. Update the service files in this repo to reflect this.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: I07e1d18a098398bca1038fd9012e53162846303d
show more ...
|
15513dbb | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
beautysh: re-format
beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh files to have a consistent formatting. Re-run the formatter on the whole repository.
Change-Id: I82c8272c4
beautysh: re-format
beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh files to have a consistent formatting. Re-run the formatter on the whole repository.
Change-Id: I82c8272c4838e848615995a864dff3301d53925f Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
d7cd1848 | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML files to have consistent formatting for these file types. Re-run the formatter on the whole repository.
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML files to have consistent formatting for these file types. Re-run the formatter on the whole repository.
Change-Id: Iac79637039eb3b6ecdefb4199f6cc4da0748e8cf Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
75352b42 | 20-Sep-2022 |
Nan Zhou <nanzhoumails@gmail.com> |
functions: change EM's ObjectManager path
EntityManager moves its ObjectManager in commit [1], this patch is to change accordingly. Please see [1] for why we made that change.
[1] https://gerrit.op
functions: change EM's ObjectManager path
EntityManager moves its ObjectManager in commit [1], this patch is to change accordingly. Please see [1] for why we made that change.
[1] https://gerrit.openbmc.org/c/openbmc/entity-manager/+/57279
Tested: code compiles. I don't know how to test this project. But code inspection can show that only ObjectManager path changed.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com> Change-Id: Iff4c5cc58daa29c8f1caa2c3faff0241d47c8b9a
show more ...
|
df092dd3 | 04-Aug-2022 |
Patrick Williams <patrick@stwcx.xyz> |
MAINTAINERS: remove file
The MAINTAINERS file is deprecated in favor of OWNERS.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ifc64eaf6b1332ecfd5158b98fd26696e3f76ab60
|
2b31497e | 01-Jul-2022 |
Marri Devender Rao <devenrao@in.ibm.com> |
Guard: Guarded DIMMS/CPU are not enabled back after factory reset
User not able to enable some of the guarded dimm/cpu after host factory reset even though host cleared the guards in the guard parti
Guard: Guarded DIMMS/CPU are not enabled back after factory reset
User not able to enable some of the guarded dimm/cpu after host factory reset even though host cleared the guards in the guard partition.
BMC will not know that host took a factory reset for it to clear the disabled flag for the earlier guarded dimm/cpu.
Modified to force enable all the cpu/dimm during host factory reset. Test result: openpower-update-manager[2001]:ItemUpdaterMMC::reset openpower-update-manager[2001]:GardResetMMC::reset openpower-update-manager[2001]:GardResetMMC::enableInventoryItems openpower-update-manager[2001]:GardResetMMC::enableInventoryItemsHelper openpower-update-manager[2001]:enable specified inventory items OBJ(/xyz/openbmc_project/inventory/system/chassis/motherboard/dcm0/cpu0/core13) openpower-update-manager[2001]:enable specified inventory items OBJ(/xyz/openbmc_project/inventory/system/chassis/motherboard/dcm0/cpu0/core14) openpower-update-manager[2001]:GardResetMMC::enableInventoryItemsHelper openpower-update-manager[2001]:enable specified inventory items OBJ(/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0)
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>` Change-Id: I7f7d3981d38cdc6cc7dda4e3ee49403c772dc5ef
show more ...
|
0dea1992 | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are for: * bus_t * exception_t * manager_t * match_t * message_t * object_t * slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: If9a7314dade153dd7dbd149a76352aca8257839d
show more ...
|
42580a42 | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
OWNERS: switch 'matches' to 'matchers'
The original OWNERS template had a mistake which used 'matches' instead of the field supported by the Gerrit plugin 'matchers'. Update the OWNERS file to have
OWNERS: switch 'matches' to 'matchers'
The original OWNERS template had a mistake which used 'matches' instead of the field supported by the Gerrit plugin 'matchers'. Update the OWNERS file to have the correct field.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I376e752adbcfdcf08a6f37cb1e59e8960895661f
show more ...
|
d38d3649 | 14-Jun-2022 |
zamiseck <zimzam17@gmail.com> |
Ensure No Unnecessary Errors During Code Update
This commit fixes the problem of partitions that have either been deleted or had their name changed. The partitions are only preserved if they exist i
Ensure No Unnecessary Errors During Code Update
This commit fixes the problem of partitions that have either been deleted or had their name changed. The partitions are only preserved if they exist in both the running and read only directories, otherwise, they are skipped and the error is not triggered.
Tested: Performed code update and verified that there were no errors called.
Signed-off-by: Zami Seck <zimzam17@gmail.com> Change-Id: I11288c4120247b443d4ddd61db34f723abf041c1
show more ...
|
295fce09 | 13-Jun-2022 |
Adriana Kobylak <anoo@us.ibm.com> |
mmc: reset: Add sleep before returning
Add a sleep call to the reset call to allow service files and reset operations to complete, so that the user can safely reboot the BMC or power on the system u
mmc: reset: Add sleep before returning
Add a sleep call to the reset call to allow service files and reset operations to complete, so that the user can safely reboot the BMC or power on the system until after the reset call returns.
Tested: Verified the curl command returned after 5s. The BMC takes about 3s to start the service files.
$ date; curl -k -H "X-Auth-Token: $token" -X POST https://${bmc}/redfish/v1/Systems/system/Bios/Actions/Bios.ResetBios -d '{"data":[]}'; date Mon 13 Jun 2022 03:50:08 PM UTC Mon 13 Jun 2022 03:50:13 PM UTC
Jun 13 15:35:20 p10bmc phosphor-log-manager[343]: Deleting all log entries ... Jun 13 15:35:23 p10bmc systemd[1]: Started OpenPOWER Host HardwareIsolation.
Change-Id: Ic36cd2f9de60d8f72dd75cd63d78189349210f05 Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
show more ...
|
c8ee4497 | 09-Jun-2022 |
Konstantin Aladyshev <aladyshev22@gmail.com> |
Correct link to the Software Architecture document
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com> Change-Id: I6ccc77858aa238adbbd93eb7cad9b9fed11c5305 |
6b9daf56 | 27-May-2022 |
Ed Tanous <edtanous@google.com> |
Include what you use
The code below relies on std::istream_iterator, but does not #include <iterator> where that class is declared.
Tested: Code compiles on latest rebase.
Signed-off-by: Ed Tanous
Include what you use
The code below relies on std::istream_iterator, but does not #include <iterator> where that class is declared.
Tested: Code compiles on latest rebase.
Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: Icb6c2c595ef703756a7a62a4c6c97a4503500f64
show more ...
|
1e01078e | 19-May-2022 |
zamiseck <zimzam17@gmail.com> |
Preserved Partition Change
This commit fixes the problem of corrupted or changed preserved partitions. If one of the partitions becomes corrupted, or it the size of the partition needs to be changes
Preserved Partition Change
This commit fixes the problem of corrupted or changed preserved partitions. If one of the partitions becomes corrupted, or it the size of the partition needs to be changes, these changes will allow for the copying of the old partition, forcing the new one to take its place.
Tested: When a PRESERVED partition is altered (corrupted or contents deleted) ensured that the contents was not copied into the prsv directory and the working partition appeared upon reboot.
Signed-off-by: Zami Seck <zimzam17@gmail.com> Change-Id: I473bdef12dd14913c385ccd43693ad7176567313
show more ...
|
f9a72a7a | 20-May-2022 |
Adriana Kobylak <anoo@us.ibm.com> |
mmc: Set clear NVRAM bios attribute during factory reset
During factory reset, instead of calling the PLDM services to delete the PHYP NVRAM files, set the pvm_clear_nvram bios attribute to Enabled
mmc: Set clear NVRAM bios attribute during factory reset
During factory reset, instead of calling the PLDM services to delete the PHYP NVRAM files, set the pvm_clear_nvram bios attribute to Enabled to signal the hypervisor to clear NVRAM when it starts up.
Add the nvram hostfw directory to the list of directories to preserve during a factory reset because the NVRAM files would now be cleared by the hypervisor after reading the bios attribute.
Tested: Verified the pvm_clar_nvram bios attribute was set to Enabled as part of factory reset. Verified a journal error message was logged if the attribute did not exist and the rest of the factory reset actions were executed.
Change-Id: Ia3c0f707e8fb8208b5e2bc1edb9a8aef3bb36a89 Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
show more ...
|