functions: Delete symlink if the target doesn't match

If the symlink does not point to the expected target, delete it so that
it gets recreated to the correct target. This can happen when the BMC is

functions: Delete symlink if the target doesn't match

If the symlink does not point to the expected target, delete it so that
it gets recreated to the correct target. This can happen when the BMC is
put on a different system or the system is converted to a different one
without performing a firmware update.

Tested: Manually changed a symlink and verified that it got restored to
the expected target.

Change-Id: Ia9fd49554030bad8d727304e2ff2122107c90476
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id6c141dd4eba2423f476499b999aec9cb42f6192
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

test/README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "

test/README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7f120915c474e9707e07061a078fd2b490b70e0c

show more ...

test/README.md: Fix MD004 warnings

The following warnings are generated by using markdownlint analysis:
```
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
```
Refer to markdo

test/README.md: Fix MD004 warnings

The following warnings are generated by using markdownlint analysis:
```
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
```
Refer to markdown-lint [1] to fix MD004
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/004-ul-style.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ie926528caaf9c82836fa9efffbb88c1382d88c77

show more ...

test/README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading

test/README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Instructions on how to execute..."]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iff7add9bc536168a651885fd8506889feb0d4d0d

show more ...

Add Blueridge and Fuji systems

Change-Id: I921838c9aa71568f877deb9be45d4c2113b36b70
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

generate-tar: Update private signing key

Updating from 1024 bits to 4096 bits for a more secure key

Change-Id: Ia73b7dcf280d729ed23e3e1113c257c68e979d25
Signed-off-by: Rashmica Gupta <rashmica@linu

generate-tar: Update private signing key

Updating from 1024 bits to 4096 bits for a more secure key

Change-Id: Ia73b7dcf280d729ed23e3e1113c257c68e979d25
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I014e7670ca4ba57f7e1b80e96c001474cf7a6676
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Recover host devtree file if corrupted

This commit addresses the issue where device tree file corruption could
lead to the failure of the BMC to boot up. Corruption of the file may
occur during a ke

Recover host devtree file if corrupted

This commit addresses the issue where device tree file corruption could
lead to the failure of the BMC to boot up. Corruption of the file may
occur during a kernel panic. In such instances, recovery of the previous
uncorrupted version of the file from the available read-only version is
now implemented.

A PEL is generated indicating the same and the BMC dump is generated.

Tested and working as expected.

```
peltool -i 0x50001C86
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc code management",
"Created at": "04/22/2024 08:37:41",
"Committed at": "04/22/2024 08:37:41",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x50001C86",
"Entry Id": "0x50001C86",
"BMC Event Log Id": "127"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "bmc error logging",
"Subsystem": "BMC Firmware",
"Event Scope": "Entire Platform",
"Event Severity": "Unrecoverable Error",
"Event Type": "Not Applicable",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Acked"
},
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc code management",
"SRC Version": "0x02",
"SRC Format": "0x55",
"Virtual Progress SRC": "False",
"I5/OS Service Event Bit": "False",
"Hypervisor Dump Initiated":"False",
"Backplane CCIN": "2E2D",
"Terminate FW Error": "False",
"Deconfigured": "False",
"Guarded": "False",
"Error Details": {
"Message": "Partition was not preserved
on reboot",
"CURRENT_FILE_SIZE": [
"0x100000",
"Size of the current running
partition"
],
"EXPECTED_FILE_SIZE": [
"0x65000",
"Size of the read only partition"
]
},
"Valid Word Count": "0x09",
"Reference Code": "BD8D360A",
"Hex Word 2": "00080055",
"Hex Word 3": "2E2D0010",
"Hex Word 4": "00000000",
"Hex Word 5": "00000000",
"Hex Word 6": "00100000",
"Hex Word 7": "00065000",
"Hex Word 8": "00000000",
"Hex Word 9": "00000000",
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this
type as a unit",
"Procedure": "BMC0001"
}]
}
},
"Extended User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Reporting Machine Type": "9105-22B",
"Reporting Serial Number": "139F210",
"FW Released Ver": "",
"FW SubSys Version": "fw1060.00-7",
"Common Ref Time": "00/00/0000 00:00:00",
"Symptom Id Len": "20",
"Symptom Id": "BD8D360A_2E2D0010"
},
"Failing MTMS": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Machine Type Model": "9105-22B",
"Serial Number": "139F210"
},
"User Data 0": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"BMCLoad": "1.35 1.02 0.76",
"BMCState": "Ready",
"BMCUptime": "0y 2d 13h 38m 12s",
"BootState": "Unspecified",
"ChassisState": "Off",
"FW Version ID": "fw1060.00-7-2-g4d0fcde41f",
"HostState": "Off",
"System IM": "50001001"
},
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"CURRENT_FILE_SIZE": "1048576",
"EXPECTED_FILE_SIZE": "413696",
"FILE_NAME": "81e00672.lid"
}
}
```

Change-Id: I2ce9c7a471f6e1ba43ac5b061a62e27cfd61da23
Signed-off-by: deepakala-k <deepakala.karthikeyan@ibm.com>

show more ...

vpnor: updatesymlinks: Disable rate limiting

This service can be restarted multiple times in a row after a BMC reboot
due to its WantedBy dependencies, causing this service to fail with a
start-limi

vpnor: updatesymlinks: Disable rate limiting

This service can be restarted multiple times in a row after a BMC reboot
due to its WantedBy dependencies, causing this service to fail with a
start-limit-hit systemd error because it exceeds the default burst
limit.
Disable the rate limiting to avoid this error since this service is
designed to be started as many times as required.

Tested: Restarted pldmd and mboxd multiple times and the start-limit-hit
error is not seeing anymore.

Change-Id: I437cc70d3cf70cd8d59d17b7cb2f4b8995a278c8
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

OWNERS: Update Gunnar's email address

I have multiple email addresses in my Gerrit account but as
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69506 shows my Preferred
email has to match the OWNERS

OWNERS: Update Gunnar's email address

I have multiple email addresses in my Gerrit account but as
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69506 shows my Preferred
email has to match the OWNERS file, do that.

More discussion in Discord at
[1] https://discord.com/channels/775381525260664832/817151035197358081/1209585278025601094

Tested: With https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69549 my +2
means something again.

Change-Id: I97d75054c68674ed5342df983e338ea524f60412
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

functions: Replace IBMCompatibleSystem with Compatible

The Compatible interface will be replacing the IBMCompatibleSystem
interface. Reference:
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-int

functions: Replace IBMCompatibleSystem with Compatible

The Compatible interface will be replacing the IBMCompatibleSystem
interface. Reference:
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/68125
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/68128

Tested: Verified the symlinks for the PNOR files were created
successfully on a Rainier 4U system with the new Compatible interface
changes.

Change-Id: Idf2511d6616723bd21c945fe228499ae9eaf2fea
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

prefer std::format over fmt

Use std::format and remove the dependency on fmt.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2d25b542c03c213727d872c5d36114fc59efc8fc

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: Ia7640469aa92a6fac3a11dd55a2d3b9eea0e637a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: disable oe-sdk by default

The meson option oe-sdk is used in rare scenarios. Having it
non-defaulted turns it into an `auto` feature, which is not desired.
Explicitly disable it by default.

meson: disable oe-sdk by default

The meson option oe-sdk is used in rare scenarios. Having it
non-defaulted turns it into an `auto` feature, which is not desired.
Explicitly disable it by default.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I975964a1c316438e9ee358b84ff1b9a5c72de763

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I0354bf7192c66505b2173aaece3525940a5caa06
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: Replace configure_file with fs.copyfile

configure_file is deprecated since 0.64.0, and replace it with
fs.copyfile.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: If06241c070a7ee

meson: Replace configure_file with fs.copyfile

configure_file is deprecated since 0.64.0, and replace it with
fs.copyfile.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: If06241c070a7ee06e60c0b346af41138d967bdcc

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I8dbc92fb4080008b6291ecf1d8dde599a4fe3f4b

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I65d6d7e3c6fda95b209a0

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I65d6d7e3c6fda95b209a02f9cc13380ad4aad027
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

fix GCC 13 issues

GCC 13 removes `uint*_t` family of types from one of the common
includes so we need to explicitly include cstdint.

Change-Id: I05884edbaa38f3999fc6cd8234411d2c2c8a7429
Signed-off-

fix GCC 13 issues

GCC 13 removes `uint*_t` family of types from one of the common
includes so we need to explicitly include cstdint.

Change-Id: I05884edbaa38f3999fc6cd8234411d2c2c8a7429
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in Op

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in OpenBMC had been taking advantage of in that
we were able to document our templated target dependencies without it
actually doing anything. The real installation of services within
targets occurs in our bitbake recipes due to the complexity of chassis
and host instances on a per machine basis.

Leave the dependency information in the service files but comment them
out. It's useful to be able to look at a service and understand which
targets it's going to be installed into by the bitbake recipes.

In some cases, we had hard coded the target instance, which does install
the service correctly, but only in that one target. All services should
be installed via the bitbake recipe to ensure the service is properly
installed in all instances of the target (or service). Once the bump for
this commit goes into openbmc/openbmc, I will ensure the recipe is
updated to install all services correctly.

Change-Id: I6b1b3ebb9c1c3c2c5c03cf02ec5b74b9c2bcae2a
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I4530f5b9df4f5898e26a2eef7efcf82e9728197f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

fix shellcheck failures

New shellcheck in CI has additional checks. Fix the following error:

SC2086 (info): Double quote to prevent globbing and word splitting.

Signed-off-by: Andrew Geissler <gei

fix shellcheck failures

New shellcheck in CI has additional checks. Fix the following error:

SC2086 (info): Double quote to prevent globbing and word splitting.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I7150a2c379718afa0d32564ab279d14985674c26

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: Icc8dd9d7e7d229ec090eb631365e5952b8b755b4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

item_updater: Add Bonnell compatible system

Add support for the P10 Bonnell system, it was added to the EM
Compatible Systems with:
```
https://github.com/openbmc/entity-manager/commit/0b5b122fe93f0

item_updater: Add Bonnell compatible system

Add support for the P10 Bonnell system, it was added to the EM
Compatible Systems with:
```
https://github.com/openbmc/entity-manager/commit/0b5b122fe93f02fe79e0f8263a9c9e2c6d5c8c5e
```

Tested: Verified the symlinks were created on a Bonnell system.

Change-Id: I74cba7fd945365a990cdc23f89851c5751f73431
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...