Add Test for getId()

Added a unit test for Version::getId().
A similar test is already in phosphor-bmc-code-mgmt.

Change-Id: I8ead5111017356c6a7063b6e31bee10fada78ade
Signed-off-by: Gunnar Mills <g

Add Test for getId()

Added a unit test for Version::getId().
A similar test is already in phosphor-bmc-code-mgmt.

Change-Id: I8ead5111017356c6a7063b6e31bee10fada78ade
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Update Journal Variable Names

Journal entry variable names should be uppercase.
https://www.freedesktop.org/software/systemd/man/sd_journal_print.html

Change-Id: I1e7f6872d6f4be24f92458d6c1c4bab3b7

Update Journal Variable Names

Journal entry variable names should be uppercase.
https://www.freedesktop.org/software/systemd/man/sd_journal_print.html

Change-Id: I1e7f6872d6f4be24f92458d6c1c4bab3b7dbcda0
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Revert "item_updater: Add a log to indicate duplicate image upload."

The item_updater is called multiple times to createActivation
object when a new image is uploaded. This ends up producing a
log i

Revert "item_updater: Add a log to indicate duplicate image upload."

The item_updater is called multiple times to createActivation
object when a new image is uploaded. This ends up producing a
log in the journal suggesting the image was already uploaded
even if the image didn't exist before.

Change-Id: Ied54ca39d2b837a0647c617287acae9bde565241
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

remove Delete from Version

- Since the Activation object inherits Delete and implements a Delete
method, we don't need to do so for the Version object.

Change-Id: I1da26c3475872c1324a25b92ad8891ff8

remove Delete from Version

- Since the Activation object inherits Delete and implements a Delete
method, we don't need to do so for the Version object.

Change-Id: I1da26c3475872c1324a25b92ad8891ff8d3cabbc
Signed-off-by: Eddie James <eajames@us.ibm.com>

show more ...

Use sha512 to calcualte the versionID for images.

- We needed a hash algorithm that can be replicated on
multiple platforms and across multiple programming languages.
- This would allow the user t

Use sha512 to calcualte the versionID for images.

- We needed a hash algorithm that can be replicated on
multiple platforms and across multiple programming languages.
- This would allow the user to calculate the versionID by
executing the following command to obtain correct versionID.
echo -n "<versionID>" | sha512sum | cut -b 1-8
- This is part of the change required for openbmc/openbmc#2323

Change-Id: I799a9a2b83fdf35beaf61b9df5ed69162f610d2f
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

Host reset: Change deletes to clears

This commit changes the behavior of the host factory reset to
clear affected read-write and preserved volumes, rather than
deleting them.

Resolves openbmc/openb

Host reset: Change deletes to clears

This commit changes the behavior of the host factory reset to
clear affected read-write and preserved volumes, rather than
deleting them.

Resolves openbmc/openbmc#2322

Change-Id: Ib08f6ef039e32034ce18d80ce82e8a75021f81c2
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>

show more ...

Delete the pnor version that doesn't have a valid pnor.toc

- When a pnor ro volume is corrupted, it no longer has a valid
pnor.toc. This had caused the Host.Updater service to core-dump.
We need

Delete the pnor version that doesn't have a valid pnor.toc

- When a pnor ro volume is corrupted, it no longer has a valid
pnor.toc. This had caused the Host.Updater service to core-dump.
We need to delete corrupted volumes in order to prevent such
versions from filling up the space on chip.

Resolves openbmc/openbmc#2359

Change-Id: I173409b03f9f7a38fb30e4c8b2eac19064cece70
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

Delete orphaned pnor read-write volumes.

We have seen many instances where the read-only volumes were
deleted but the read-write partitions were preserved. This
had causes subsequent PNOR updates to

Delete orphaned pnor read-write volumes.

We have seen many instances where the read-only volumes were
deleted but the read-write partitions were preserved. This
had causes subsequent PNOR updates to fail as the space on
PNOR chip was occupied by these orphaned rw volumes.

Resolves openbmc/openbmc#2376

Change-Id: Id0d750680e4e972ee991d95e8b00f4c6cc1fa72e
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

Change to pass by reference

removeActiveAssociation and createActiveAssociation should be
pass by reference.

Change-Id: I5d4bb8a15714dcae5f2b71c5151262940cc91f49
Signed-off-by: Gunnar Mills <gmills

Change to pass by reference

removeActiveAssociation and createActiveAssociation should be
pass by reference.

Change-Id: I5d4bb8a15714dcae5f2b71c5151262940cc91f49
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Create functional association on startup

Look at /var/lib/phosphor-software-manager/pnor/ro
to determine if there is a funcitonal image, if so
create a functional association.

Resolves openbmc/open

Create functional association on startup

Look at /var/lib/phosphor-software-manager/pnor/ro
to determine if there is a funcitonal image, if so
create a functional association.

Resolves openbmc/openbmc#2279

Change-Id: I6e576e2e21a592a98d843eb45cdab8bba8f55192
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Style and comment changes in item_updater.hpp

Style and comment changes only.

Change-Id: I9861c3ebfe615010c3f5b26cd7146f56465cbefa
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Style changes in serialize.cpp

Style only changes

Change-Id: I5b414d154d55cf2553fc79c28d94c0aa08dbe48b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Style and comment changes in version.hpp

Style and comment changes only.
Made more clear the difference between the version id (e.g. ad324adb)
and the version string (e.g. v1.99.10-19 or
IBM-withers

Style and comment changes in version.hpp

Style and comment changes only.
Made more clear the difference between the version id (e.g. ad324adb)
and the version string (e.g. v1.99.10-19 or
IBM-witherspoon-sequoia-ibm-OP9_v1.18_1.54)

Change-Id: I16b21c8665b413b26ca3a639118505c667d120e2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Call updateFunctionalAssociation on symlink change

Call updateFunctionalAssociation, to change the functional
association to the new "running" PNOR image, on a symlink change.
The symlink change occ

Call updateFunctionalAssociation on symlink change

Call updateFunctionalAssociation, to change the functional
association to the new "running" PNOR image, on a symlink change.
The symlink change occurs on chassis poweron.
Look at the RO symlink, /var/lib/phosphor-software-manager/pnor/ro,
for a symlink change.

Change-Id: I2c673635af55da1c642e6d96ab6e12951b3a4fd3
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Host updater: Add function to delete all versions

As a part of openbmc/openbmc#2264, implements a DeleteAll for all
non-functional host versions in the host updater.

Change-Id: I2943df248463ba8b453

Host updater: Add function to delete all versions

As a part of openbmc/openbmc#2264, implements a DeleteAll for all
non-functional host versions in the host updater.

Change-Id: I2943df248463ba8b4537096cf08f902d758c24a0
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>

show more ...

Create PNOR Functional Association

Created the function updateFunctionalAssociation to update
the functional association for the "running" PNOR image.
This function will be called by the inotify cod

Create PNOR Functional Association

Created the function updateFunctionalAssociation to update
the functional association for the "running" PNOR image.
This function will be called by the inotify code.

Change-Id: I871624044fbb11800de4d13e6a4b174494c68f13
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Style changes in version.cpp

Style only changes

Change-Id: I0eb3dedf400a734619bc0419c7c8bd398d912b03
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

PNOR Serialize: Change create_directory to create_directories

Core dumps were observed when serialize attempts to create the
directory /var/lib/obmc/openpower-pnor-code-mgmt because the parent
direc

PNOR Serialize: Change create_directory to create_directories

Core dumps were observed when serialize attempts to create the
directory /var/lib/obmc/openpower-pnor-code-mgmt because the parent
directory /var/lib/obmc did not exist. This commit changes the
create_directory call to create_directories so that any missing
parent directories will be created.

Change-Id: I051fb854b4bf770abec8e0f03f74c194339cc227
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>

show more ...

Add checks for currently running host image before erasing

- Check for Host state and the Active image. If the image we're trying to
erase matches the Active image and the host is running, fail to e

Add checks for currently running host image before erasing

- Check for Host state and the Active image. If the image we're trying to
erase matches the Active image and the host is running, fail to erase the
image.

Resolves openbmc/openbmc#1986

Change-Id: Ia9488c9ede585494fa4449ef0e83af35d50d03f8
Signed-off-by: Eddie James <eajames@us.ibm.com>

show more ...

Create active association on startup

Create active association on startup for
active PNOR versions.

Change-Id: I8f7657e6c332759642ecc8f42c9caab14db1289b
Signed-off-by: Gunnar Mills <gmills@us.ibm.c

Create active association on startup

Create active association on startup for
active PNOR versions.

Change-Id: I8f7657e6c332759642ecc8f42c9caab14db1289b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Combine the creation of ro and rw partition in one service file

- Use the combine ubimount service file that creates both
rw and ro partition.

Change-Id: I40438bc16ac4f5734a749b7bf218ea5c6f628339

Combine the creation of ro and rw partition in one service file

- Use the combine ubimount service file that creates both
rw and ro partition.

Change-Id: I40438bc16ac4f5734a749b7bf218ea5c6f628339
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

Switch FWD and REV association names

The forward association should be inventory.
The reverse association should be activation.

Change-Id: I3ab94ca60290dfbc3b2cb4fe17f738f8bdaf96d1
Signed-off-by: G

Switch FWD and REV association names

The forward association should be inventory.
The reverse association should be activation.

Change-Id: I3ab94ca60290dfbc3b2cb4fe17f738f8bdaf96d1
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Create active association

Create an association between an active image
and the active image's version object.
This change includes code to remove the active
association if the image is deleted.

Ch

Create active association

Create an association between an active image
and the active image's version object.
This change includes code to remove the active
association if the image is deleted.

Change-Id: Id5b2d353d7df05854b035641765e1066d64a3ef5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove nodist_noinst_HEADER

nodist_noinst_HEADER is not needed for
org/openbmc/Associations/server.hpp.
The header file by default is not installed.
More information can be found at
https://www.gnu.

Remove nodist_noinst_HEADER

nodist_noinst_HEADER is not needed for
org/openbmc/Associations/server.hpp.
The header file by default is not installed.
More information can be found at
https://www.gnu.org/software/automake/manual/html_node/Headers.html

Change-Id: I8db66c2b337e704a5d190e5a17a922fdfb08640c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add "noinst" for generated header

Change-Id: Ia5e02c6bc90599b10fd4a4ddce569d83d05af5c7
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>