std::variant: Fix forgotten conversion

Change-Id: Ie802ac340ebc0fde965bd84e18d2af9391136626
Signed-off-by: William A. Kennington III <wak@google.com>

Fix std::variant usage

Use the std::get() interface instead of mapbox specific .get() member
interface.

Change-Id: I4ce467c49ea418adba422bbd09fa829acd53da3c
Signed-off-by: William A. Kennington III

Fix std::variant usage

Use the std::get() interface instead of mapbox specific .get() member
interface.

Change-Id: I4ce467c49ea418adba422bbd09fa829acd53da3c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

msl_verify: Read the functional version from D-Bus

The VERSION partition may have a secure boot header, so
the version string would not be the first line.
Instead of adding logic to parse the VERSIO

msl_verify: Read the functional version from D-Bus

The VERSION partition may have a secure boot header, so
the version string would not be the first line.
Instead of adding logic to parse the VERSION partition
and to protect against future changes, read the version
string from D-Bus instead by querying the functional
association.

Tested: The functional version was read successfully.

Change-Id: Icf0a9bd9f360ef9f0732579fa073f8661b8c57bd
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

item_updater: Call remove association on delete

The remove association function was supposed to be called
on delete but was never implemented so if the associations
are queried but the version has b

item_updater: Call remove association on delete

The remove association function was supposed to be called
on delete but was never implemented so if the associations
are queried but the version has been deleted, that'd be
false information, so call to remove the associations on delete,
also rename it to delete all associations, because the
functional pnor version can be deleted if the chassis state
is off and the delete function already made that determination.

Tested: Verified all associations (active and functional) are
deleted with a DeleteAll call.

Change-Id: I6e5589256dd8f62ac2ecf7574b9d08920b8b5e3d
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

msl_verify: Add support for multiple MSL values

There are scenarios where the BMC can support multiple PNOR MSL
values, such as v1.2 and v.1.4.9. Support multiple values
separated by a space.

Chang

msl_verify: Add support for multiple MSL values

There are scenarios where the BMC can support multiple PNOR MSL
values, such as v1.2 and v.1.4.9. Support multiple values
separated by a space.

Change-Id: Id65c43872db33538e2f02f6f60b4571a5231717b
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

msl_verify: Create error log when verify fails

Create a Version::Incompatible error log when the verification
fails to make the failure more visible to the user.

Tested: Verified a new error log wa

msl_verify: Create error log when verify fails

Create a Version::Incompatible error log when the verification
fails to make the failure more visible to the user.

Tested: Verified a new error log was created with the metadata.
"/xyz/openbmc_project/logging/entry/4": {
"AdditionalData": [
"_PID=1540",
"ACTUAL_VERSION=IPCS-FP5295G2-OP9-v2.0.8-2.8",
"MIN_VERSION=v2.2",
"VERSION_PURPOSE=xyz.openbmc_project.Software.Version.VersionPurpose.Host"
],
"Message": "xyz.openbmc_project.Software.Version.Error.Incompatible",

Change-Id: I3d13265b4a7e6a9a58cbd7cd619a162fb11da164
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

msl_verify: Initial commit

Create a new binary that checks the msl (minimum ship level)
of the PNOR and logs an error message if the version on the
system is older. The msl can be specified via a co

msl_verify: Initial commit

Create a new binary that checks the msl (minimum ship level)
of the PNOR and logs an error message if the version on the
system is older. The msl can be specified via a config flag.

Change-Id: I6f477400f7a8cf56557bd0caf5d6e08d73320028
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Switch to C++17

Change-Id: I804e86172696dd541290d4af33c6a893ae8f0506
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

MAINTAINERS: Update my email and IRC

Updated to correct IRC username and preferred email address.

Change-Id: I470c6ec9f422777552f975b480c2fd910912a32f
Signed-off-by: Gunnar Mills <gmills@us.ibm.co

MAINTAINERS: Update my email and IRC

Updated to correct IRC username and preferred email address.

Change-Id: I470c6ec9f422777552f975b480c2fd910912a32f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

clang-format: Update to match docs repo

Update the .clang-format file and run clang-format-6.0.
This .clang-format matches the example one in
https://github.com/openbmc/docs/blob/master/cpp-style-an

clang-format: Update to match docs repo

Update the .clang-format file and run clang-format-6.0.
This .clang-format matches the example one in
https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#clang-formatting

Change-Id: I289513571fe020bd407f23f2a88a01e11b5ff96f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

clang-format: Update to match docs repo

Update the .clang-format file.
Now includes header sorting and updating PointerAlignment.

Change-Id: I7119c12f1cc0a461cb7e4576dff6a02dcc95cbc4
Signed-off-by:

clang-format: Update to match docs repo

Update the .clang-format file.
Now includes header sorting and updating PointerAlignment.

Change-Id: I7119c12f1cc0a461cb7e4576dff6a02dcc95cbc4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

image_verify: Add support for OpenSSL 1.1.0

With OpenSSL 1.1.0, some of the functions were renamed, for
example EVP_MD_CTX_create() and EVP_MD_CTX_destroy() were
renamed to EVP_MD_CTX_new() and EVP_

image_verify: Add support for OpenSSL 1.1.0

With OpenSSL 1.1.0, some of the functions were renamed, for
example EVP_MD_CTX_create() and EVP_MD_CTX_destroy() were
renamed to EVP_MD_CTX_new() and EVP_MD_CTX_free().
Reference: https://wiki.openssl.org/index.php/OpenSSL_1.1.0_Changes
Abstract them to support old and new APIs.

Resolves openbmc/openbmc#3137

Tested: Verified the signature verification was successful.

Change-Id: If8b3f185666c3db59567c4ee3bdfa168c501d3da
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

version: Check Chassis changed for Delete intf

The chassis path contains multiple properties. The code checks for
chassis state to decide if the Delete interface is added or removed.
If a different

version: Check Chassis changed for Delete intf

The chassis path contains multiple properties. The code checks for
chassis state to decide if the Delete interface is added or removed.
If a different property was modified, the chassis state would be
empty, leading to always removing the Delete interface in this
scenario. Check that chassis state was populated before modifying the
Delete interface.

Tested: Verified the Delete interface was added back during power off.

Change-Id: Iee32de8917930e2f9081ab369ad4998766f21cff
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Add -flto to CXXFLAGS

Per openbmc/openbmc#3364, adding -flto to CXX flags
in order to reduce overall library and binary sizes.

Ref: https://gcc.gnu.org/wiki/LinkTimeOptimization

Tested: Verified i

Add -flto to CXXFLAGS

Per openbmc/openbmc#3364, adding -flto to CXX flags
in order to reduce overall library and binary sizes.

Ref: https://gcc.gnu.org/wiki/LinkTimeOptimization

Tested: Verified it compiled and booted to Ready in QEMU

Change-Id: I64ffa450d8cd964e01d78ce5bbc97b93df47509d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

deleteAll: Delete functional version if chassis off

The deleteAll function was skipping to delete the functional
version, which should be allowed if the chassis state is not on.
The erase function a

deleteAll: Delete functional version if chassis off

The deleteAll function was skipping to delete the functional
version, which should be allowed if the chassis state is not on.
The erase function already supports that so the user can
individually delete the functional version, just the delete
would not work via the DeleteAll call.

Tested: All PNOR versions, including the functional one, get
deleted at chassis power off via the DeleteAll method.

Change-Id: Ib390545f3ade68e2a3182064549e05994e7f7191
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

reset: Call Suspend / Resume mbox

During factory reset, call to suspend and resume mbox
to notify the host that it should not access the flash
during this operation.

Closes openbmc/openbmc#3210

Te

reset: Call Suspend / Resume mbox

During factory reset, call to suspend and resume mbox
to notify the host that it should not access the flash
during this operation.

Closes openbmc/openbmc#3210

Tested: Ran factory reset with host running and verified
there were no error messages or failed services.

Change-Id: Id881e5b4021744637d3988e57f784223957562b5
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

reset: Replace service files with filesystem APIs

In the factory reset function, the read-write and preserved
partitions are cleared via systemd service files. The call
to run these services is asyn

reset: Replace service files with filesystem APIs

In the factory reset function, the read-write and preserved
partitions are cleared via systemd service files. The call
to run these services is asynchronous.
Replace these services files with C++ filesystem APIs so
that it is known when the file deletion starts and completes
to be able to notify the host when a reset operation is
taking place.

Part of openbmc/openbmc#3210

Tested: Verified factory reset still clears the read-write
and preserved partitions.

Change-Id: I7575a2e97a544b1e8692148e8664bdd14fdfb90f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

activation: Add error handling in deleteImageManagerObject

Handle exceptions from the sdbusplus method call API.

The call to Delete an object from the image manager fails with:
sd_bus_call: System.

activation: Add error handling in deleteImageManagerObject

Handle exceptions from the sdbusplus method call API.

The call to Delete an object from the image manager fails with:
sd_bus_call: System.Error.ELOOP: Too many levels of symbolic links

Catch the error so the app doesn't core dump. Issue
openbmc/openbmc#3311 will track root cause of the error.

Tested: A PNOR code update operation succeeds without core dumps
or error messages.

Change-Id: Ib384a16436bbb0521d247b7b6157b8877db5a4cb
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

activation: Improve error handling in Subscribe

Handle exceptions from the sdbusplus method call_noreply API.

The Activation constructor was subscribing to systemd signals, which
would cause an "Al

activation: Improve error handling in Subscribe

Handle exceptions from the sdbusplus method call_noreply API.

The Activation constructor was subscribing to systemd signals, which
would cause an "Already Subscribed" error when creating multiple
Activation instances because the bus is common.

There is no reason to subscribe to systemd signals in the constructor,
since the signals are only triggered during the activation process.
Move the Subscribe call to the activation process which calls
Unsubscribe at the end.

There's a scenario where there could still be an "Already Subscribed"
error if the activation fails, so add error handling there.

This is very similar to:
https://gerrit.openbmc-project.xyz/#/c/11428/

Tested: Code updated an image.
Change-Id: Ia35b7f2fc24c0b605692bc534c54e18742027061
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

generate-squashfs: Handle a signed VERSION partition

If VERSION is signed it will be 8K instead of 4K to accomodate the
header. Skip past the header so the version name can still be parsed.

Change-

generate-squashfs: Handle a signed VERSION partition

If VERSION is signed it will be 8K instead of 4K to accomodate the
header. Skip past the header so the version name can still be parsed.

Change-Id: I07f0bd136a42e94e5b4e59eaa0eb59c1aacf2e87
Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>

show more ...

Use s.c_str() in log messages

Part of a series of commits that resolve openbmc 2905

Here is something funny: in item_updater.cpp:300 is a string
and on line 316 it is const char*. It may be confu

Use s.c_str() in log messages

Part of a series of commits that resolve openbmc 2905

Here is something funny: in item_updater.cpp:300 is a string
and on line 316 it is const char*. It may be confusing to
have the same variable name with two different related types.

Tested: static_assert only

Change-Id: I59556fc184ef1f1047bd8a76062598b7518c36ae
Signed-off-by: Joseph Reynolds <jrey@us.ibm.com>

show more ...

Add MAINTAINERS file

Change-Id: I084bd67fd5179c7abe6d79e990e46cebd300cce6
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Revert "Name reverse functional association "functional""

This reverts commit ee697121c78a262c456293b10c4f2d4e2873cff0.

The functional association goes away after activating a new image
(issue open

Revert "Name reverse functional association "functional""

This reverts commit ee697121c78a262c456293b10c4f2d4e2873cff0.

The functional association goes away after activating a new image
(issue openbmc/openbmc#3038). The workaround is to keep the reverse
association names the same for the active and functional ones
until the issue is resolved.

Change-Id: I1ce1440e4c612e0efb553695f05db8adea171a77
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

PNOR Signature validation failure handling based on field mode

Added support to stop the codeupdate only for the fieldmode
enabled systems, for signature validation failures.

Resolves openbmc/openb

PNOR Signature validation failure handling based on field mode

Added support to stop the codeupdate only for the fieldmode
enabled systems, for signature validation failures.

Resolves openbmc/openbmc#3047

Change-Id: Idf47b122a60d5d14e6e7f134d8067d20e09e7c76
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

Make the name of the signature verify feature unique

The verify_signature feature name is the same as the one used
in the phosphor-software-manager repo which manages the BMC
firmware updates. Chang

Make the name of the signature verify feature unique

The verify_signature feature name is the same as the one used
in the phosphor-software-manager repo which manages the BMC
firmware updates. Change the name to make it different to
be able to control enabling the feature individually via recipes,
since enabling it on the phosphor recipe enables it for the
pnor code as well (due to the recipe dependency on
virtual-obmc-image-manager).

Change-Id: I73e446dd6d5f0995132bc60403e08d16d07703bd
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...