vpnor: updatesymlinks: Disable rate limiting

This service can be restarted multiple times in a row after a BMC reboot
due to its WantedBy dependencies, causing this service to fail with a
start-limi

vpnor: updatesymlinks: Disable rate limiting

This service can be restarted multiple times in a row after a BMC reboot
due to its WantedBy dependencies, causing this service to fail with a
start-limit-hit systemd error because it exceeds the default burst
limit.
Disable the rate limiting to avoid this error since this service is
designed to be started as many times as required.

Tested: Restarted pldmd and mboxd multiple times and the start-limit-hit
error is not seeing anymore.

Change-Id: I437cc70d3cf70cd8d59d17b7cb2f4b8995a278c8
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in Op

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in OpenBMC had been taking advantage of in that
we were able to document our templated target dependencies without it
actually doing anything. The real installation of services within
targets occurs in our bitbake recipes due to the complexity of chassis
and host instances on a per machine basis.

Leave the dependency information in the service files but comment them
out. It's useful to be able to look at a service and understand which
targets it's going to be installed into by the bitbake recipes.

In some cases, we had hard coded the target instance, which does install
the service correctly, but only in that one target. All services should
be installed via the bitbake recipe to ensure the service is properly
installed in all instances of the target (or service). Once the bump for
this commit goes into openbmc/openbmc, I will ensure the recipe is
updated to install all services correctly.

Change-Id: I6b1b3ebb9c1c3c2c5c03cf02ec5b74b9c2bcae2a
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

fix shellcheck failures

New shellcheck in CI has additional checks. Fix the following error:

SC2086 (info): Double quote to prevent globbing and word splitting.

Signed-off-by: Andrew Geissler <gei

fix shellcheck failures

New shellcheck in CI has additional checks. Fix the following error:

SC2086 (info): Double quote to prevent globbing and word splitting.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I7150a2c379718afa0d32564ab279d14985674c26

show more ...

update service file deps in accordance with recent refactoring

As noted in the following mailing list thread:
https://lists.ozlabs.org/pipermail/openbmc/2022-November/032457.html

and implemented vi

update service file deps in accordance with recent refactoring

As noted in the following mailing list thread:
https://lists.ozlabs.org/pipermail/openbmc/2022-November/032457.html

and implemented via this series of commits:
https://gerrit.openbmc.org/q/topic:op-power-control-ref

Some systemd services had their names changed. Update the service files
in this repo to reflect this.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I07e1d18a098398bca1038fd9012e53162846303d

show more ...

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I82c8272c4

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I82c8272c4838e848615995a864dff3301d53925f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

mmc: Add nvram hostfw directory

Created an nvram directory to store the hypervisor's NVRAM files.
Create a symlink to that directory for apps like PLDM to access it.
Add a dependency to the symlink

mmc: Add nvram hostfw directory

Created an nvram directory to store the hypervisor's NVRAM files.
Create a symlink to that directory for apps like PLDM to access it.
Add a dependency to the symlink service to start before the PLDM
services that would make use of the new NVRAM directory start.

Tested: Verified the directory and symlink got created. Verified the
PLDM services started after the symlink one.

Change-Id: I8cdef7cc2176ed10096712918a743efd304df6c1
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Fix shellcheck errors

Change-Id: I71f8e41f73ce998fe351bdabbdc291f1aa006dcf
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

mmc: Handle missing pnor.toc file

The pnor.toc file is a mboxd implemenation, and therefore will not exist
once the host uses PLDM instead, which uses .lid files instead of pnor
partition files. As

mmc: Handle missing pnor.toc file

The pnor.toc file is a mboxd implemenation, and therefore will not exist
once the host uses PLDM instead, which uses .lid files instead of pnor
partition files. As part of the transition, the pnor.toc file is being
built into a .lid file for images that do not contain pnor partition
files. Handle this transition by creating a symlink from pnor partition
file to .lid file. This would remain in place until all the PLDM support
from the hostboot side is in place and mboxd is removed.

Tested: Verified rainier powers on and mboxd starts successfully, and
the volatile partition gets cleared.

Change-Id: I59364c0abf100dab5a38d277f0587d0dd221b53d
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

meson: Remove autotools support and update READMEs

Tested: Ran CI.

Change-Id: Ie1327e27e07c0304ceb7c3fcfad4bc8f1b18b89c
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

vpnor/obmc-vpnor-util: fix shellcheck warnings

Tested: Verified the PNOR symlinks were created successfully.

Change-Id: Ieb0887b654bd6389e6314aa703e9c372b02ea0f8
Signed-off-by: Adriana Kobylak <ano

vpnor/obmc-vpnor-util: fix shellcheck warnings

Tested: Verified the PNOR symlinks were created successfully.

Change-Id: Ieb0887b654bd6389e6314aa703e9c372b02ea0f8
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

ensure hostboot volatile not cleared on warm reboots

A while back, the obmc-vpnor-enable-clearvolatile@.service was added to
the obmc-chassis-poweron@.target. This was done to ensure the volatile
da

ensure hostboot volatile not cleared on warm reboots

A while back, the obmc-vpnor-enable-clearvolatile@.service was added to
the obmc-chassis-poweron@.target. This was done to ensure the volatile
data was cleared on any chassis power on to handle situations where the
user is using debug tools like istep or cronus to boot the system after
the chassis power was turned on. Prior to that, the clear was done only
when obmc-host-start@.target was started.

Adding this service to the obmc-chassis-poweron@target had an unintended
consequence though. The chassis power on target is called during a warm
reboot. The assumption was that all services were already running so it
was a "warm" reboot because none of those service were re-run. The
obmc-vpnor-enable-clearvolatile@.service however is a onetime service
that did not remain after exit. This means this service was run during
this warm reboot which breaks the design point of not clearing the host
volatile data on a warm reboot.

This commit now makes this service continue after it has run and only
stops it when a chassis power off is issued. This ensures the host
volatile data is only ever cleared after a system has its chassis
powered off.

Tested:
- Verified that a warm reboot now results in the service not running
- Verified that a normal host reboot (chassis power cycle) still results
in the service running as expected

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ifad75b4d0f7a4e1162d4a45a1c346e622a458240

show more ...

mmc: Add staging directory

Add a staging directory for PLDM to use as a temporary
holding space during inband update where the host would
send individual image files and PLDM needs to reconstruct
th

mmc: Add staging directory

Add a staging directory for PLDM to use as a temporary
holding space during inband update where the host would
send individual image files and PLDM needs to reconstruct
the code update tarball before calling the BMC updater
to do an update.

Clear the directory after a successful update. This cleanup
will eventually be handled by PLDM.

Tested: New directory and symlink created.

Change-Id: I9a2eacb0f57696e799e983625c2a32efbe122e89
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

mmc: Support a patch directory for each version

Create a patch directory for the running and alternate hostfw
versions. Otherwise the patches may not be compatible if a
side switch occurs.

Also don

mmc: Support a patch directory for each version

Create a patch directory for the running and alternate hostfw
versions. Otherwise the patches may not be compatible if a
side switch occurs.

Also don't delete patches when updating the running version
because it's not known if it's just a side switch. This should
be handled by the code update app which currently is done by
the BMC updater.

Change-Id: Ie975e5f8176ad97ee5ed2dd7594a83ba8c57bdb3
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

mmc: Add read-only directory to support mboxd

The mboxd implementation assumes that there is a read-only and
read-write directory. During a write request, mboxd copies the
contents of the read-only

mmc: Add read-only directory to support mboxd

The mboxd implementation assumes that there is a read-only and
read-write directory. During a write request, mboxd copies the
contents of the read-only to the read-write directory. To continue
to support mboxd, mount a read-only directory of the hostfw image
for mboxd to use. Otherwise the write command fails (can't copy
the file to itself) and mboxd exits.

Tested: Verified mboxd didn't fail and system powered on.

Change-Id: Idcb8ff0c5eee0179d5d70e60e5e01c7d0f76b880
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

vpnor: Add hostfw symlinks

On eMMC, in addition to the PNOR files, there are hostfw
files. Create symlinks for the 2 versions on flash, so that
pldm (which will replace mboxd) can read/write.

Teste

vpnor: Add hostfw symlinks

On eMMC, in addition to the PNOR files, there are hostfw
files. Create symlinks for the 2 versions on flash, so that
pldm (which will replace mboxd) can read/write.

Tested: Both pnor and hostfw links are created:
root@rainier:~# ls -l /var/lib/phosphor-software-manager/*
/var/lib/phosphor-software-manager/hostfw:
lrwxrwxrwx 1 root root 23 Jul 16 20:37 alternate -> /media/hostfw/alternate
lrwxrwxrwx 1 root root 21 Jul 16 20:37 running -> /media/hostfw/running

/var/lib/phosphor-software-manager/pnor:
lrwxrwxrwx 1 root root 21 Jul 16 20:37 prsv -> /media/hostfw/running
lrwxrwxrwx 1 root root 21 Jul 16 20:37 ro -> /media/hostfw/running
lrwxrwxrwx 1 root root 21 Jul 16 20:37 rw -> /media/hostfw/running

Change-Id: I2fe726641611112bc7a447eed5c2d64db268ce8e
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

vpnor: Move clearvolatile services to vpnor

The clearvolatile services were originally in the ubi layout, but
the functionality is purely for vpnor, not tied to a filesystem
layout. Move them to the

vpnor: Move clearvolatile services to vpnor

The clearvolatile services were originally in the ubi layout, but
the functionality is purely for vpnor, not tied to a filesystem
layout. Move them to the vpnor layer where non-UBI layouts that use
virtual pnor such as eMMC have this functionality.

Tested: Verified on witherspoon that the renamed services were
included in the image and ran during a power on.

Change-Id: I6e9e9e4f5a8a7690a46872ee2fdc0fc96e621482
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Move updatesymlinks to new vpnor feature

The updatesymlinks functionality is to support virtual pnor and it
does not depend on the filesystem type. Move it to a new vpnor
feature so that users can m

Move updatesymlinks to new vpnor feature

The updatesymlinks functionality is to support virtual pnor and it
does not depend on the filesystem type. Move it to a new vpnor
feature so that users can make use of this feature without being
tied to UBI, for example on a eMMC that has a combined BMC+PNOR
image.

Tested: Verified that the witherspoon image contained the new
script and service file and that it powered on to the host.

Change-Id: Ic5e51dfde81718e5e285f010be67afbd58eac2e1
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...