sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If9a7314dade153dd7dbd149a76352aca8257839d

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit` or `action::emit_interface_added`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id3689b24f8719bafa9e5a67960848edff4ddf8c5

show more ...

style: update clang-format

Pull the most recent OpenBMC style rules and run clang-format.

Change-Id: Ifecce87b6aa64a2800dab3ba1e09ae415accb548
Signed-off-by: Brad Bishop <bradle

style: update clang-format

Pull the most recent OpenBMC style rules and run clang-format.

Change-Id: Ifecce87b6aa64a2800dab3ba1e09ae415accb548
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

string: ensure string included

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

string: ensure string included

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ic1bf10e15071227582e5738336f632d33705c80b

show more ...

cleanup the code related to emit_interface_added

sdbusplus now supports action::emit_interface_added() when an object is
constructed, so the code that manually invokes emit_interface_add

cleanup the code related to emit_interface_added

sdbusplus now supports action::emit_interface_added() when an object is
constructed, so the code that manually invokes emit_interface_added()
could be cleaned up and use the above action instead.

Tested:Tested on fp5280g2,and pnor code update works fine.

Signed-off-by: Albert Zhang <zhanghaodi@inspur.com>
Change-Id: I5a68090d7e1bbd31c0df351d553ef6fa6d63e277

show more ...

Refactor: Fix issues found by cppcheck

Resolve several issues found by cppcheck:

[msl_verify.hpp:28]: (style) Class 'MinimumShipLevel' has a constructor with 1 argument that is

Refactor: Fix issues found by cppcheck

Resolve several issues found by cppcheck:

[msl_verify.hpp:28]: (style) Class 'MinimumShipLevel' has a constructor with 1 argument that is not explicit.
[ubi/watch.hpp:21]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[item_updater_main.cpp:22] -> [item_updater_main.cpp:49]: (style) Local variable rc shadows outer symbol
[serialize.cpp:19]: (performance) Function parameter 'versionId' should be passed by const reference.
[ubi/watch.hpp:43]: (style) Struct 'CustomFd' has a constructor with 1 argument that is not explicit.
[serialize.cpp:52]: (performance) Function parameter 'versionId' should be passed by const reference.
[serialize.cpp:116]: (performance) Function parameter 'versionId' should be passed by const reference.
[activation.cpp:115] -> [activation.cpp:152]: (style) Local variable mapperResponseMsg shadows outer symbol
[version.hpp:114]: (performance) Variable 'eraseCallback' is assigned in constructor body. Consider performing initialization in initialization list.
[image_verify.hpp:53]: (style) Struct 'CustomFd' has a constructor with 1 argument that is not explicit.
[ubi/item_updater_ubi.cpp:192]: (performance) Function parameter 'versionId' should be passed by const reference.
[ubi/item_updater_ubi.cpp:203]: (performance) Function parameter 'versionId' should be passed by const reference.

Tested: Verify the code compiles and cppcheck does not report the above
issues.

Change-Id: I096392a2a7a283fe198c9c29185125e61295e10f
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Read PNOR VERSION using pflash

Use pflash to read VERSION partition to get the PNOR version
Add code to parse pflash's VERSION partition string.

Tested: Verify th

Static layout: Read PNOR VERSION using pflash

Use pflash to read VERSION partition to get the PNOR version
Add code to parse pflash's VERSION partition string.

Tested: Verify that the version and extended version are
retrieved correctly on Romulus and Palmetto.

Change-Id: Ia053c1683a5a969be0773d251cb88c4c5c9b6c60
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

clang-format: Update to match docs repo

Update the .clang-format file.
Now includes header sorting and updating PointerAlignment.

Change-Id: I7119c12f1cc0a461cb7e4576dff6a02dcc9

clang-format: Update to match docs repo

Update the .clang-format file.
Now includes header sorting and updating PointerAlignment.

Change-Id: I7119c12f1cc0a461cb7e4576dff6a02dcc95cbc4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Enable clang code format

Change-Id: I4490e930459a7eab6f6dd15198418c5314755d3f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

PNOR: Fix the delete implementation

- In order to remove the delete object from functional
image, the delete interface is moved inside the
version class so that both item_updater

PNOR: Fix the delete implementation

- In order to remove the delete object from functional
image, the delete interface is moved inside the
version class so that both item_updater and image_manager
can make use of the same implementation.
- To avoid having two delete objects attached to the same
HOST version (item_updater and image_manager), we are now
deleting the image_manager object once the activation
is complete.

Partially resolves openbmc/openbmc#2490

Change-Id: Ie515cc01d5f154e6e55b9a3fb71d831730cd46f6
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

remove Delete from Version

- Since the Activation object inherits Delete and implements a Delete
method, we don't need to do so for the Version object.

Change-Id: I1da26c3475872

remove Delete from Version

- Since the Activation object inherits Delete and implements a Delete
method, we don't need to do so for the Version object.

Change-Id: I1da26c3475872c1324a25b92ad8891ff8d3cabbc
Signed-off-by: Eddie James <eajames@us.ibm.com>

show more ...

Style and comment changes in version.hpp

Style and comment changes only.
Made more clear the difference between the version id (e.g. ad324adb)
and the version string (e.g. v1.99.10-1

Style and comment changes in version.hpp

Style and comment changes only.
Made more clear the difference between the version id (e.g. ad324adb)
and the version string (e.g. v1.99.10-19 or
IBM-witherspoon-sequoia-ibm-OP9_v1.18_1.54)

Change-Id: I16b21c8665b413b26ca3a639118505c667d120e2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

item_updater : Implementing Object.Delete for version

Change-Id: If962dec1da2d2fe925374bb37f89ed23f04c5ab6
Signed-off-by: Leonel Gonzalez <lgonzalez@us.ibm.com>

Create Version and Activation objects for current PNOR image

On BMC boot, create the Software version and activation that
points to the current PNOR version by reading:
/var/lib/phos

Create Version and Activation objects for current PNOR image

On BMC boot, create the Software version and activation that
points to the current PNOR version by reading:
/var/lib/phosphor-software-manager/pnor/ro

Resolves openbmc/openbmc#1762

Change-Id: I46ddb37491a1a230699da9f3acbd3fcff23dc538
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...

item_updater: Add version dbus object.

Need to create the Version object under itemUpdater
class to retain the version of the active images
after the bmc is rebooted and the image_di

item_updater: Add version dbus object.

Need to create the Version object under itemUpdater
class to retain the version of the active images
after the bmc is rebooted and the image_dir no
longer holds the image files.

Change-Id: Iac78d577b970c6fa766b94041742f77077b14e62
Signed-off-by: Saqib Khan <khansa@us.ibm.com>

show more ...