| #
b119dca1 |
| 26-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
fix GCC 13 issues
GCC 13 removes `uint*_t` family of types from one of the common
includes so we need to explicitly include cstdint.
Change-Id: I05884edbaa38f3999fc6cd8234411d2c2c8a7429
Signed-off-
fix GCC 13 issues
GCC 13 removes `uint*_t` family of types from one of the common
includes so we need to explicitly include cstdint.
Change-Id: I05884edbaa38f3999fc6cd8234411d2c2c8a7429
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| #
1db9adf3 |
| 05-Mar-2019 |
Lei YU <mine260309@gmail.com> |
Refactor: Fix issues found by cppcheck
Resolve several issues found by cppcheck:
[msl_verify.hpp:28]: (style) Class 'MinimumShipLevel' has a constructor with 1 argument that is
Refactor: Fix issues found by cppcheck
Resolve several issues found by cppcheck:
[msl_verify.hpp:28]: (style) Class 'MinimumShipLevel' has a constructor with 1 argument that is not explicit.
[ubi/watch.hpp:21]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[item_updater_main.cpp:22] -> [item_updater_main.cpp:49]: (style) Local variable rc shadows outer symbol
[serialize.cpp:19]: (performance) Function parameter 'versionId' should be passed by const reference.
[ubi/watch.hpp:43]: (style) Struct 'CustomFd' has a constructor with 1 argument that is not explicit.
[serialize.cpp:52]: (performance) Function parameter 'versionId' should be passed by const reference.
[serialize.cpp:116]: (performance) Function parameter 'versionId' should be passed by const reference.
[activation.cpp:115] -> [activation.cpp:152]: (style) Local variable mapperResponseMsg shadows outer symbol
[version.hpp:114]: (performance) Variable 'eraseCallback' is assigned in constructor body. Consider performing initialization in initialization list.
[image_verify.hpp:53]: (style) Struct 'CustomFd' has a constructor with 1 argument that is not explicit.
[ubi/item_updater_ubi.cpp:192]: (performance) Function parameter 'versionId' should be passed by const reference.
[ubi/item_updater_ubi.cpp:203]: (performance) Function parameter 'versionId' should be passed by const reference.
Tested: Verify the code compiles and cppcheck does not report the above
issues.
Change-Id: I096392a2a7a283fe198c9c29185125e61295e10f
Signed-off-by: Lei YU <mine260309@gmail.com>
show more ...
|
| #
c67a9457 |
| 04-Mar-2019 |
Lei YU <mine260309@gmail.com> |
Refactor: Move serialize to ubi
Functions in serialize are specific to UBI, move it to ubi dir.
Tested: On the last commit of the patch series, run code update and
facto
Refactor: Move serialize to ubi
Functions in serialize are specific to UBI, move it to ubi dir.
Tested: On the last commit of the patch series, run code update and
factory reset on Witherspoon and all work fine.
Change-Id: I9176e638d9f3bfe0d424b57f8da4667a751cb5bd
Signed-off-by: Lei YU <mine260309@gmail.com>
show more ...
|