clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id6c141dd4eba2423f476499b999aec9cb42f6192
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I014e7670ca4ba57f7e1b80e96c001474cf7a6676
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I4530f5b9df4f5898e26a2eef7efcf82e9728197f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If9a7314dade153dd7dbd149a76352aca8257839d

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If9ecc60e370b7ab62e58dc1c3bfdd4051ee9c435

show more ...

meson: Remove autotools support and update READMEs

Tested: Ran CI.

Change-Id: Ie1327e27e07c0304ceb7c3fcfad4bc8f1b18b89c
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

fix compiler warnings

Fix a couple unused-parameter warnings so we can turn the warnings all
the way up.

Change-Id: I36c611da5a10732dbb89e289e42a870c902dd245
Signed-off-by: Brad Bishop <bradleyb@fu

fix compiler warnings

Fix a couple unused-parameter warnings so we can turn the warnings all
the way up.

Change-Id: I36c611da5a10732dbb89e289e42a870c902dd245
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

style: update clang-format

Pull the most recent OpenBMC style rules and run clang-format.

Change-Id: Ifecce87b6aa64a2800dab3ba1e09ae415accb548
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.co

style: update clang-format

Pull the most recent OpenBMC style rules and run clang-format.

Change-Id: Ifecce87b6aa64a2800dab3ba1e09ae415accb548
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pnor: Add updatable association to active PNOR FW

Add 'updateable' association to the active PNOR
firmware version object. This 'updateable' association
can be used to mark all the firmware componen

pnor: Add updatable association to active PNOR FW

Add 'updateable' association to the active PNOR
firmware version object. This 'updateable' association
can be used to mark all the firmware components
which can be programmable from pnor interfaces like
Redfish.

Signed-off-by: Miguel Gomez <mgomez@mx1.ibm.com>
Change-Id: I33f7ac70c8bfa446aeb045c65c741e2d72ce108a

show more ...

string: ensure string included

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-off-by: An

string: ensure string included

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ic1bf10e15071227582e5738336f632d33705c80b

show more ...

Fix ECC usage of being cleaned partitions

Reset procedure of PNOR works improperly for our P8 based VESNIN
hardware and makes the host unbootable.

The problem is in incorrect partition cleaning.

H

Fix ECC usage of being cleaned partitions

Reset procedure of PNOR works improperly for our P8 based VESNIN
hardware and makes the host unbootable.

The problem is in incorrect partition cleaning.

Hostboot for P8 has no support for CLEARECC bit and PNOR flash has no
partitions with flag 'C'.

P9 based hardware is not affected until PNOR has partitions with ECC
flag only.

This commit modifies the reset procedure to make it use the flag 'E'
(ECC) instead of 'C' (CLEARECC).

* The flag 'E' means that the partition requires ECC.
* The flag 'C' means that the partition might be cleaned by hostboot
when ECC is wrong.

For details see:
https://github.com/open-power/hostboot/blob/75c0908b91275dc10bd17cb0f10b452f32ce0b91/src/include/usr/pnor/pnor_const.H#L128

Tested: All PNOR partitions with enabled flags 'E' and 'F' should be
cleaned with ECC.

Change-Id: I632e90c8e256df3445fc3d1f45c830d155a1d208
Signed-off-by: Alexander Filippov <a.filippov@yadro.com>

show more ...

Static layout: support image verification

Add support of image verification for static layout PNOR code update.

Tested: Verify the PNOR code update succeeds with valid-signed PNOR;
and fail

Static layout: support image verification

Add support of image verification for static layout PNOR code update.

Tested: Verify the PNOR code update succeeds with valid-signed PNOR;
and fails with invalid-signed PNOR or a PNOR tarball without
signature.

Change-Id: I1aafeb4e8e07eaa16c170f33f4f21940f7c9c146
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Refactor: Use hiomapd instead of mboxd

mbox service is renamed to hiomapd and provides "Suspend" and
"Resume" method calls, which is more appropriate for raw "cmd" calls.

Use the new methods to sus

Refactor: Use hiomapd instead of mboxd

mbox service is renamed to hiomapd and provides "Suspend" and
"Resume" method calls, which is more appropriate for raw "cmd" calls.

Use the new methods to suspend and resume hiomapd.
Move "getService()" function into utils so it is shared by multiple
files.

Tested: Verify the reset works on Romulus

Change-Id: I8f89de134b13126697bfc69a21a3148a01c34cca
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

test: Add test for getPartsToClear

Add the test for getPartsToClear(), and fix issues found by the unit
test case with malformed input.

Tested: Verify test builds and passes.

Change-Id: I67c8bbd18

test: Add test for getPartsToClear

Add the test for getPartsToClear(), and fix issues found by the unit
test case with malformed input.

Tested: Verify test builds and passes.

Change-Id: I67c8bbd184e7e0c0f7f0f0fca678d1952a07cd66
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

test: Add sources of static PNOR

Add sources in static dir to test.
It generates a link error about duplcated GardReset::reset().

Then an issue is found that GardReset::~GardReset() is not virtual,

test: Add sources of static PNOR

Add sources in static dir to test.
It generates a link error about duplcated GardReset::reset().

Then an issue is found that GardReset::~GardReset() is not virtual,
this will casuse the destructor not calling its super class' dtor.

To fix the above link error, add GardReset[Ubi|Static] to make
ubi/static specific implementation in its own class.

Tested: Verify the test build works fine.

Change-Id: I41bd4d522e8b9c4053283c0cf4373807ef4f2d1c
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Do not crash on empty PNOR

When PNOR is empty, or corrupted and it fails to retrieve the version,
the service throws an exception.
This is not good because it should run on a corrupte

Static layout: Do not crash on empty PNOR

When PNOR is empty, or corrupted and it fails to retrieve the version,
the service throws an exception.
This is not good because it should run on a corrupted or empty PNOR,
which then could be used to re-program the PNOR.

This commit fixes the issue, by not throwing on the above case.

Tested: Verify the service does not crash on a corrupted VERSION
partition, and could be used to do code update to fix the
corruption.

Change-Id: Ic6a413a81ad13894a9c7f039df71fff9b9d4b2ad
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Do not update PNOR when host is on

Static layout only has 1 active and functional PNOR. When host is
running, do not update PNOR.
This is done by checking the return value of freeSpac

Static layout: Do not update PNOR when host is on

Static layout only has 1 active and functional PNOR. When host is
running, do not update PNOR.
This is done by checking the return value of freeSpace(), and if it
returns false, it means there is no space for PNOR because the host is
running and erase() returns false.

Tested: Verify the status becomes Failed when trying to activate a PNOR
while host is running.

Change-Id: Ie2986b0c6fd29557685f67eb77ccc29709e1669a
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Use pflash to get partitions to clear

Use pflash -i to get partitions that should be cleared during factory
reset, instead of hard-coded ones.

Tested: From log verify the partitions

Static layout: Use pflash to get partitions to clear

Use pflash -i to get partitions that should be cleared during factory
reset, instead of hard-coded ones.

Tested: From log verify the partitions with REPROVISION flag are cleared
during factory reset.

Change-Id: I5f1681d0c5092e89a4a964ce41991b116252b9dd
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Implement factory reset

Tested: Verify the partitions hard-coded are cleared during factory
reset.

Change-Id: I70febe5f8245a299d4e2a782414662dbf09e84cb
Signed-off-by: Lei YU

Static layout: Implement factory reset

Tested: Verify the partitions hard-coded are cleared during factory
reset.

Change-Id: I70febe5f8245a299d4e2a782414662dbf09e84cb
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Implement gard reset

Use pflash to clear GUARD partition.

Tested: Verify GUARD partition is cleared on gard reset.

Change-Id: I54f77a30d728dc80aa40dfd58a17152b936a6a6d
Signed-off-by

Static layout: Implement gard reset

Use pflash to clear GUARD partition.

Tested: Verify GUARD partition is cleared on gard reset.

Change-Id: I54f77a30d728dc80aa40dfd58a17152b936a6a6d
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Implement PNOR code update

Implement the PNOR code update by pflash tool in openpower-pnor-update
service, and update the related associations.

Tested: Verify PNOR code update succee

Static layout: Implement PNOR code update

Implement the PNOR code update by pflash tool in openpower-pnor-update
service, and update the related associations.

Tested: Verify PNOR code update succeeds.

Change-Id: I53781d6420071200ac2ed6837f7a79bf5e1162c2
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Add dummy activation_static

Add ActivationStatic inherits Activation, which will be used to do PNOR
code update for statis layout.

Tested: Verify code compiles.

Change-Id: I5d90c84b

Static layout: Add dummy activation_static

Add ActivationStatic inherits Activation, which will be used to do PNOR
code update for statis layout.

Tested: Verify code compiles.

Change-Id: I5d90c84b63797e37fa309caeb9b23035f3c76f9f
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Read PNOR VERSION using pflash

Use pflash to read VERSION partition to get the PNOR version
Add code to parse pflash's VERSION partition string.

Tested: Verify that the version and e

Static layout: Read PNOR VERSION using pflash

Use pflash to read VERSION partition to get the PNOR version
Add code to parse pflash's VERSION partition string.

Tested: Verify that the version and extended version are
retrieved correctly on Romulus and Palmetto.

Change-Id: Ia053c1683a5a969be0773d251cb88c4c5c9b6c60
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Static layout: Add dummy item_updater

This commit only adds the functions without implementation.

Tested: Verify the code compiles with or without static layout.

Change-Id: Id57640b367f9594d07e678

Static layout: Add dummy item_updater

This commit only adds the functions without implementation.

Tested: Verify the code compiles with or without static layout.

Change-Id: Id57640b367f9594d07e6780d446479eb7ac06007
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Refactor: Split item_updater to common and ubi

The existing item_updater is highly coupled with ubifs.
It will support static layout and ubi in future.
So split the functions in to common ones and u

Refactor: Split item_updater to common and ubi

The existing item_updater is highly coupled with ubifs.
It will support static layout and ubi in future.
So split the functions in to common ones and ubi specific ones, and move
the ubi specific code in ubi dir.

1. Keep common functions and make them virtual for extension.
createActiveAssociation()
updateFunctionalAssociation()
removeAssociation()
erase()
2. Create ubi/item_updater_ubi and move other functions into it.
3. Change updateFunctionalAssociation() parameter for future use.

To support static layout, a new item_updater_static will be written.

Tested: On the last commit of the patch series, run code update and
factory reset on Witherspoon and all work fine.

Change-Id: I4cc55b31ee3f37c5b27168611305dee8ce02880a
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...