Use format_as rather than operator << overload

format_as seems to be the preferred way to handle enums
according to fmtlib documentation.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Change-I

Use format_as rather than operator << overload

format_as seems to be the preferred way to handle enums
according to fmtlib documentation.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Change-Id: I46946b711468d8bd572669a7b182e6df2326f757

show more ...

Update fmtlib fix

The actual operator overload was missing from the previous fix.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Change-Id: I64fc9c347ce3ed16eb8bf8d944fbf066b4c923b8

Provide a fmtlib ostream formatter for SysPwrMode enum

fmtlib removed support for automatically formatting enums as integers
in version 9. See https://github.com/fmtlib/fmt/issues/1841.

Signed-off-

Provide a fmtlib ostream formatter for SysPwrMode enum

fmtlib removed support for automatically formatting enums as integers
in version 9. See https://github.com/fmtlib/fmt/issues/1841.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Change-Id: I6a5d04187e55c94d39d8b5ee334f9a37c93081ce

show more ...

Add journal traces to occ-control PELs

When creating a PEL, the last lines of the journal for the app will get
saved into the PEL for additional debug.

Change-Id: Ifa05a00ffdc57833859d719d0e7d8b81c

Add journal traces to occ-control PELs

When creating a PEL, the last lines of the journal for the app will get
saved into the PEL for additional debug.

Change-Id: Ifa05a00ffdc57833859d719d0e7d8b81ccadb5c8
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Commit OCC related errors as informational

Since the PELs generated by occ-control will end up triggering a PM
Complex reset, they can get logged as informational. Hostboot/HTMGT will
determine when

Commit OCC related errors as informational

Since the PELs generated by occ-control will end up triggering a PM
Complex reset, they can get logged as informational. Hostboot/HTMGT will
determine when recovery attempts has been exhausted and will log an
unrecoverable 2616 PEL indicating the system is in safe mode.

Change-Id: Iab3d3a5d1605a4fea7362b96f5e05570cd0a1746
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

yaml: move to subdirectory

A pending sdbusplus change (I38b69bc67b6a3d80cda1b508a76e106a50d8ab93)
is going to require YAML to be in a specific subdirectory and not in
the root. Move here in prep fo

yaml: move to subdirectory

A pending sdbusplus change (I38b69bc67b6a3d80cda1b508a76e106a50d8ab93)
is going to require YAML to be in a specific subdirectory and not in
the root. Move here in prep for that change.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I42cd6599f751b34284243080dd213be3254d147c

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibd9a665865abe7b08ccf177c2bcfe448d3db48db

sdbusplus:p10: object: don't use 'bool' argument constructor

These were missed in the prior commit to handle this due to this file
only being built when p10 is enabled.

Signed-off-by: Andrew Geissl

sdbusplus:p10: object: don't use 'bool' argument constructor

These were missed in the prior commit to handle this due to this file
only being built when p10 is enabled.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ia1a67026467279468569db1a6137a576b28be089

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9541d521bf67882215a4a66dce020e38ac2df065

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic38a5b5399bef968127e3dd4bea9d07785ecafcd

show more ...

Re-fetch StateSensors if unable to find sensor

Saw defect after BMC reset/reload where occ-control only saw PDR for
first OCC. Code change will re-fetch the sensors in the case where an
expected PDR

Re-fetch StateSensors if unable to find sensor

Saw defect after BMC reset/reload where occ-control only saw PDR for
first OCC. Code change will re-fetch the sensors in the case where an
expected PDR was not found.

Testing:
Forced removal of sensors which triggered the fetch and saw recovery.

Change-Id: I6e180f23b5817bc9ea0575674a318a2673f66f3d
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Validate user power cap changes fall within limits

Add validation of the user power cap when changed via Redfish or during
boot. Validation also needs to ensure the correct power types are being
co

Validate user power cap changes fall within limits

Add validation of the user power cap when changed via Redfish or during
boot. Validation also needs to ensure the correct power types are being
compared (input/AC vs output/DC).

Verified on hardware with limits set via GUI and Redfish.

Change-Id: Ic0d8ce2df6fdb803bbede7e42f10f34c142c6b07
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Revert clearing PDRs if host power is off

Code was added to clear the PDRs when the host was powered off, but the
next power on occ-control never saw the OCC StateSensor updates.
This change will be

Revert clearing PDRs if host power is off

Code was added to clear the PDRs when the host was powered off, but the
next power on occ-control never saw the OCC StateSensor updates.
This change will be reverted to resolve this issue.

Tested on multiple machines with multiple reboots and guarded procs

Change-Id: Ibea28ede25c81f22e4e9fe2574c1668c4a81352c
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Fix correlation between OCC StateSensorPDRs and procs

occ-control was not correlating the OCC Active sensors with the correct
processor. Code change will now use the Sensor ID to know which
OCC/proc

Fix correlation between OCC StateSensorPDRs and procs

occ-control was not correlating the OCC Active sensors with the correct
processor. Code change will now use the Sensor ID to know which
OCC/proc is active. Hostboot will also be making a change to ensure that
the Sensor IDs are always numbered according to processor order (p0, p1,
etc)

Wait for PHYP to start before reading PLDM sensors:
occ-control caches the PLDM sensor IDs to limit the dbus queries.
The cache was supposed to be cleared when the OS was powered off, but
the existing code only cleared it when CurrentHostState was Off.
Got a defect where occ-control was using invalid/old sensor IDs when
getting notifications of OCC Active sensors. This causes the app to try
communicating with the wrong or invalid OCC.

Code change will clear the sensor cache anytime PHYP is not running, and
will populate the cache once PHYP is running.

Tested on hardware with various boot types and resets.

Change-Id: I4b32aa848768296065d6570466475f5b17771d2e
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Add support for power mode locking

This change adds support for preventing changes to the power mode based
on a mode setting lock. The default state of the lock is unlocked. The
state is changed fro

Add support for power mode locking

This change adds support for preventing changes to the power mode based
on a mode setting lock. The default state of the lock is unlocked. The
state is changed from unlocked to locked using a dbus method call and
can only be unlocked by setting it back to the default state through a
factory reset.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: I9d8fac5a6f74357efe36efd86c9f97776004385f

show more ...

Reuse MCTP instance IDs for PLDM retries

occ-control will request a new instance ID when it times out waiting for
the PLDM response. Code change will not request a new ID unless the
prior response w

Reuse MCTP instance IDs for PLDM retries

occ-control will request a new instance ID when it times out waiting for
the PLDM response. Code change will not request a new ID unless the
prior response was received successfully.

Change-Id: I8a3509d7ea583bb706ad2ef41bf90cc5d0f0275b
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Restart discover timer to ensure recovery is attempted

The discovery timer was being deleted, so then it was not getting
resarted when a failure was detected.
This commit will disable (instead of de

Restart discover timer to ensure recovery is attempted

The discovery timer was being deleted, so then it was not getting
resarted when a failure was detected.
This commit will disable (instead of delete) and then ensure the that
timer gets restarted while waiting for OCC status.

Verified on HW

Change-Id: Ibcb93d6d22f42b89282378d7b8904807b4150041
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Add safe mode to user interface

putting in code that puts safe mode onto dbus.
Tested: inject error that puts in safe mode, dbus CMD
to read dbus safeMode.
Signed-off-by: Sheldon Bailey <baileysh@us

Add safe mode to user interface

putting in code that puts safe mode onto dbus.
Tested: inject error that puts in safe mode, dbus CMD
to read dbus safeMode.
Signed-off-by: Sheldon Bailey <baileysh@us.ibm.com>
Change-Id: I48c5b41a48d0883a8d1e2916da8725391a7bcbc2

show more ...

Log a PEL for communication, presence mismatch, and safe state errors

Add code to log a PEL in various error scenarios. Refactor some of the
error handling to get the return code out of the driver.

Log a PEL for communication, presence mismatch, and safe state errors

Add code to log a PEL in various error scenarios. Refactor some of the
error handling to get the return code out of the driver.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Change-Id: Ifd91cfc063718e484ec8886df8357d115c6b41e3

show more ...

Fix Max fan speed with Deconfigured DIMM

Fan Speeds Remain at Maximum Speed With Deconfigured DIMMs
Tested: Injected Errors on DIMMs.
Signed-off-by: Sheldon Bailey <baileysh@us.ibm.com>
Change-Id: I

Fix Max fan speed with Deconfigured DIMM

Fan Speeds Remain at Maximum Speed With Deconfigured DIMMs
Tested: Injected Errors on DIMMs.
Signed-off-by: Sheldon Bailey <baileysh@us.ibm.com>
Change-Id: I797698f888cd9fb431d4f490c144eb5ad942bcd8

show more ...

Prevent using stale data when active sensors were queued

When the OCC active sensor data gets queued (prior to OCC status objects
being created), the code ended up attempting to stop a timer that wa

Prevent using stale data when active sensors were queued

When the OCC active sensor data gets queued (prior to OCC status objects
being created), the code ended up attempting to stop a timer that was
already stopped.
Code will only stop timer if started.

Tested on hardware

Change-Id: I2fcc5b5e540078c4e6ae1773ade1c43f428c2c8f
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Prevent repeatedly reading PLDM sensors when proc garded

If a processor was garded, the OCC sensor would never be enabled.
The prior could would continue to try reading a sensor until it became
enab

Prevent repeatedly reading PLDM sensors when proc garded

If a processor was garded, the OCC sensor would never be enabled.
The prior could would continue to try reading a sensor until it became
enabled.
Code change will stop attempting to read a sensor once a signal or valid
response has been received.

Tested on HW

Change-Id: I9c43840fb25803af4f320ae9de00e896daf190f6
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

failure to get OCC temp 0

Failure to get OCC temp 0 as a (temperature is no longer available)
instead code gets a file read error with errno = 11 (Resource
temporarily unavailable). This will indica

failure to get OCC temp 0

Failure to get OCC temp 0 as a (temperature is no longer available)
instead code gets a file read error with errno = 11 (Resource
temporarily unavailable). This will indicate temp is no longer
available 0 for Fan Control.
Tested: HW error inject on DIMM to cause OCC to send a temp 0 to BMC.
Signed-off-by: Sheldon Bailey <baileysh@us.ibm.com>
Change-Id: I64e5b0fddcabe82e4642e9a3d2eae3232149d51f

show more ...

Ensure occActive called after device enabled

I noticed that the power cap bounds was not getting updated. This
was caused because the device.master() call was made before setting the
occActive flag.

Ensure occActive called after device enabled

I noticed that the power cap bounds was not getting updated. This
was caused because the device.master() call was made before setting the
occActive flag.

The device object now prevents the device from triggering sysfs reads
if the occActive flag is not set.
This change will set occActive right after enabling the device.

Also prevent extra calls to checkAllActiveSensors by only setting the
waitingForAll flag once.

Change-Id: If19771e53b64dd1d5e27e7ae153bd56e0e070aff
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Queue active sensor updates before status objs created

If an OCC Active sensor update comes in before the Status objects have
been created, the value is lost. This commit will save that sensor
valu

Queue active sensor updates before status objs created

If an OCC Active sensor update comes in before the Status objects have
been created, the value is lost. This commit will save that sensor
value until the status objects are created.
Also, prevent querying the master sysfs file if OCCs are not yet activated.

Change-Id: I8c0d2686024278ec7435e19cf99f59802e1ecceb
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...