Fixed bare URLs in README.md

Fix markdown-lint rule 034-no-bare-urls.md

Change-Id: I084d9c62ef090cacad62a41b36e3f69f8d4313ee
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

Increase timeout before logging PEL when OCC sensors unavailable

Existing code waits up to 5 minutes for the OCC active sensors PDRs to
be available. If not available after 5 minutes, a BD8D2685 PEL

Increase timeout before logging PEL when OCC sensors unavailable

Existing code waits up to 5 minutes for the OCC active sensors PDRs to
be available. If not available after 5 minutes, a BD8D2685 PEL will get
logged and occ-control will continue to wait for the PDRs.

This change will increase that timeout to 40 minutes.

Change-Id: Idfffd03d731bd35a0f5d1ba7fe04e2f635444d74
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Prevent missing sensor PEL when host is not running

occ-control will create a PEL if the OCC sensors PDRs have not been
found after 5 mintues.
This change will prevent creating that PEL if the host

Prevent missing sensor PEL when host is not running

occ-control will create a PEL if the OCC sensors PDRs have not been
found after 5 mintues.
This change will prevent creating that PEL if the host is not at
runtime.
This condition can happen if the host is powered on and then powered off
before all sensors have been found.

Change-Id: I885f2148b7527ef9b577a60dd33ac9af3618e831
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Update PEL to Predictive when unable to get OCC PDRs

Originally created PEL as informational, but it needs to be predictive
to make it visible.

PEL is created when the PDRs have not been found afte

Update PEL to Predictive when unable to get OCC PDRs

Originally created PEL as informational, but it needs to be predictive
to make it visible.

PEL is created when the PDRs have not been found after 5 minutes.

Change-Id: If9ea66333ea63f1d1d2c6950c16b0401e50949c4
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Create PEL if unable to get the OCC PDRs

The OCC PDRs are required so occ-control will know when the OCCs are
available and ready to communicate. If the PDRs never become available
there is currentl

Create PEL if unable to get the OCC PDRs

The OCC PDRs are required so occ-control will know when the OCCs are
available and ready to communicate. If the PDRs never become available
there is currently no indication other than the OCC sensors not being
available.
This code change will create a PEL when the PDRs have not been found
after 5 minutes. The service will continue looking for the PDRs after
logging the PEL.

Change-Id: Ia2200273d04b91cba9cad3cf8465cc9cada73428
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Handle other PLDM_STATE_SET_OPERATIONAL states

- Code will no longer assume the OCC is not running if an unexpected
state is received. It will continue to look for a good/known state.
- Added code t

Handle other PLDM_STATE_SET_OPERATIONAL states

- Code will no longer assume the OCC is not running if an unexpected
state is received. It will continue to look for a good/known state.
- Added code that will throttle the occ-control pldm journal traces
if unable to read the OCC active sensor states. In some error
conditions, this tracing would flood the trace and the repeated traces
are not helpful for debug.
- Change some journal entries to ERR when the state indicated that the
system was in safe mode (OCCs disabled)
- If request for occ active sensor state was sent, and then a PLDM
sensor event comes in for that instance, the event status is used and
the response is ignored.
- Added README for occ-control

Signed-off-by: Chris Cain <cjcain@us.ibm.com>
Change-Id: Ic26f1d0c4dc59e7a61b965b052d649e4bc152fde

show more ...

test: fix power10-mode compile errors

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I44a90cfbca3804de4a7fe169fa567a4672a48e78

occ_manager: add missing PLDM check

The configuration POWER10 does not explicitly depend on PLDM, but there
were a few calls to the pldmHandle outside a PLDM guard. Add the PLDM
guards in.

Signed-

occ_manager: add missing PLDM check

The configuration POWER10 does not explicitly depend on PLDM, but there
were a few calls to the pldmHandle outside a PLDM guard. Add the PLDM
guards in.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1ae1a6a6ade375acc7ba4e59ddf0d8e0c5b7a711

show more ...

meson: fix libpldm move to its own repository

The libpldm moved into its own repository separate from pldm proper.
Update the wrap file and meson.build accordingly.

Signed-off-by: Patrick Williams

meson: fix libpldm move to its own repository

The libpldm moved into its own repository separate from pldm proper.
Update the wrap file and meson.build accordingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9559f361de3fb66a73ab6d18611ec34753377585

show more ...

meson: simplify dependencies

The preferred way for identifying dependency fallback variables is
for the subproject wrap files to express them. Move from the
meson.build to the corresponding wrap fi

meson: simplify dependencies

The preferred way for identifying dependency fallback variables is
for the subproject wrap files to express them. Move from the
meson.build to the corresponding wrap files.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I83284ee1c6892503ff436c8280c1c5aeaf4149c0

show more ...

meson: add missing cereal dependency

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie9d814f17a1089ccbbbd9888efe1ca272a62297d

occ_command: switch to std::formatter for enums

Commit 48002498740996ce57bce399960b0f6f2ff6d1df switched to std::format
but missed changing the custom formatter from fmt to std::format. Add
std::fo

occ_command: switch to std::formatter for enums

Commit 48002498740996ce57bce399960b0f6f2ff6d1df switched to std::format
but missed changing the custom formatter from fmt to std::format. Add
std::formatter overrides for the enums.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I59e727c42cf8d91d1841daee64bd4d9e066e5151

show more ...

Populate AllowedPowerModes

AllowedPowerModes is a new dbus property that will be used by Redfish to
publish the supported modes.

'''
busctl -l introspect org.open_power.OCC.Control /xyz/openbmc_pro

Populate AllowedPowerModes

AllowedPowerModes is a new dbus property that will be used by Redfish to
publish the supported modes.

'''
busctl -l introspect org.open_power.OCC.Control /xyz/openbmc_project/control/host0/power_mode
...
xyz.openbmc_project.Control.Power.Mode interface - - -
.AllowedPowerModes property as 3 "xyz.openbmc_project.Control.Power.Mode.PowerMode.MaximumPerformance" "xyz.openbmc_project.Control.Power.Mode.PowerMode.PowerSaving" "xyz.openbmc_project.Control.Power.Mode.PowerMode.Static" const
.PowerMode property s "xyz.openbmc_project.Control.Power.Mode.PowerMode.MaximumPerformance" emits-change writable
.SafeMode property b false emits-change
'''

Change-Id: I67ab6c2f8545c327dd7ab437f892ad5796a194c5
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

prefer std::format over fmt

Switch to std::format to remove the dependency on fmt.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id3a1295ba8a90fb756cfc500892dcc5b3235e27b

Add Eco mode support

Add support for new modes:
- Efficiency Favor Performance
- Efficiency Favor Power
- Balanced Performance
- Non-Deterministic (lab only)

Tested on Rainier by setting/reading al

Add Eco mode support

Add support for new modes:
- Efficiency Favor Performance
- Efficiency Favor Power
- Balanced Performance
- Non-Deterministic (lab only)

Tested on Rainier by setting/reading all new/old modes.

Change-Id: I5479a3016bce962127a3ecbec2db155994dd26b0
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Force fans to high when no valid temp from sensors

DDR5 DDIMS can have redundant DRAM thermal sensors. If a valid
temperature is not available for either of these sensors, and
one of the sensors fai

Force fans to high when no valid temp from sensors

DDR5 DDIMS can have redundant DRAM thermal sensors. If a valid
temperature is not available for either of these sensors, and
one of the sensors failed, the fans should be set to max.
If both DRAM sensors are reporting 0 (not available), fans are
not set to max.

No change if there are not redundant sensors:
If there are not redundant sensors and the temperature is:
- 0/not available: don't use sensor for fan control
- error: fans will be set to high speed

Tested on HW by forcing invalid address
OCC reported temps:
D0010004 01 29 59 00 (41C membuf)
D0010004 07 00 55 00 (0C pmic)
D0010004 02 00 45 00 (0C dimm)
D0010004 02 FF 45 00 (ERROR dimm)
Fans ramped up:
TARGET SENSOR TARGET(RPM) FEEDBACK SENSOR FEEDBACK(RPM)
===============================================================
fan0_0 10400 fan0_0 10190
fan1_0 10400 fan1_0 10330

Change-Id: I6ae920a4c45f3cc44dd3c1d614c495dad138b62c
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Add the .Error. segment to error names

Add the '.Error.' segment in the hardcoded error name strings to match
the standard. This way the ReadFailure error string also matches the
error string gener

Add the .Error. segment to error names

Add the '.Error.' segment in the hardcoded error name strings to match
the standard. This way the ReadFailure error string also matches the
error string generated by report<ReadFailure>().

Change-Id: Ieb64c9754a275ec52afee6346ab34e85c7675333
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

meson: adjust nlohmann-json dependency

Simplify nlohmann-json dependency in meson.build and align wrap file
with other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I

meson: adjust nlohmann-json dependency

Simplify nlohmann-json dependency in meson.build and align wrap file
with other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ieb23001ee8c105c012664ec1d347d4785261e955

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I1f8f77d3cd06d82c4d5390a910593f5e88c5581f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Correct PLDM service name

There is no service "xyz.openbmc_project.PLDM.service"
The correct service should be pldmd.service.

systemd[1]: /lib/systemd/system/org.open_power.OCC.Control.service:7: F

Correct PLDM service name

There is no service "xyz.openbmc_project.PLDM.service"
The correct service should be pldmd.service.

systemd[1]: /lib/systemd/system/org.open_power.OCC.Control.service:7: Failed to add dependency on xyz.openbmc_project.PLDM, ignoring: Invalid argument

Tested on p10bmc:
Issued: systemctl daemon-reload
and verified error disappeared.

Change-Id: Ie6f7baaeeee829b672641fd7a218037e3c7409db
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I2a0dacdd2b53e30b96c53dce904b3fb1bf3f827a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Create sensors for DIMM DVFS temps

Like it does for the processor, the OCC also sends down the throttle
(DVFS) temperatures for all of the DIMM related temp sensors in the
'_max' sysfs files.

This

Create sensors for DIMM DVFS temps

Like it does for the processor, the OCC also sends down the throttle
(DVFS) temperatures for all of the DIMM related temp sensors in the
'_max' sysfs files.

This commit makes D-Bus sensors out of them as well so that fan control
can use them.

They are named:
- dimm_intmb_dvfs_temp
- dimm_dram_dvfs_temp
- dimm_dram_extmb_dvfs_temp
- dimm_pmic_dvfs_temp
- dimm_extmb_dvfs_temp}

Tested:
On a Rainier 2U with 3 types of DIMM temps available:
$ busctl get-property org.open_power.OCC.Control
/xyz/openbmc_project/sensors/temperature/dimm_dram_dvfs_temp
xyz.openbmc_project.Sensor.Value Value
d 69

$ busctl get-property org.open_power.OCC.Control
/xyz/openbmc_project/sensors/temperature/dimm_pmic_dvfs_temp
xyz.openbmc_project.Sensor.Value Value
d 85

$ busctl get-property org.open_power.OCC.Control
/xyz/openbmc_project/sensors/temperature/dimm_intmb_dvfs_temp
xyz.openbmc_project.Sensor.Value Value
d 89

Change-Id: Ia4417fa05dc2ecef1a54110c639a8ef51891b272
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Support multiple sensors of same fru_type/label

There are some DDR5 DIMMs that have multiple DRAM temperature sensors,
of which we only care about the hotter one.

As the OCC reports these with the

Support multiple sensors of same fru_type/label

There are some DDR5 DIMMs that have multiple DRAM temperature sensors,
of which we only care about the hotter one.

As the OCC reports these with the same fru_type and label values, the
code will need to read them both, and then just put the maximum value on
D-Bus.

Support this generically by first looping through all of the sysfs files
and saving the temperature values along with the calculated D-Bus object
path, handling the multiple sensor case by only storing the maximum
value, and then looping through the saved values and putting them on
D-Bus.

Tested:
Found sensors 33 and 34 are the same fru type and label:

temp33_fru_type:2
temp33_label:3489726464
temp33_input:38000

temp34_fru_type:2
temp34_label:3489726464
temp34_input:39000

Before change, the cooler one was on D-Bus:
```
d 38
```

After change, the hotter one was:

```
temp33_input:39000
temp34_input:41000

d 41
```

Change-Id: Ida632b9784209079d9d1bfc6c21918cd65be6a1f
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

meson: remove install-error-yaml option

We are no longer containing local error-yaml, so there is no
need to install it. Remove the meson option.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz

meson: remove install-error-yaml option

We are no longer containing local error-yaml, so there is no
need to install it. Remove the meson option.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If2b4c8ae7aa81653e9c30568e1f078b52ba1f8fc

show more ...

meson: Replace configure_file with fs.copyfile

configure_file is deprecated since 0.64.0, and replace it with
fs.copyfile.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I0e0a066519bba9

meson: Replace configure_file with fs.copyfile

configure_file is deprecated since 0.64.0, and replace it with
fs.copyfile.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I0e0a066519bba9b3f4b78e9c6139cd754d3c2b75

show more ...