systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in Op

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in OpenBMC had been taking advantage of in that
we were able to document our templated target dependencies without it
actually doing anything. The real installation of services within
targets occurs in our bitbake recipes due to the complexity of chassis
and host instances on a per machine basis.

Leave the dependency information in the service files but comment them
out. It's useful to be able to look at a service and understand which
targets it's going to be installed into by the bitbake recipes.

In some cases, we had hard coded the target instance, which does install
the service correctly, but only in that one target. All services should
be installed via the bitbake recipe to ensure the service is properly
installed in all instances of the target. Once the bump for this commit
goes into openbmc/openbmc, I will ensure the recipe is updated to
install all services correctly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I182abdebeb8983ae11817025cf0466581a80546c

show more ...

treewide: remove dependencies on mapper.target

The mapper is dbus activated now, so these explicit dependency
declarations are unnecessary and redundant.

Change-Id: I0b5aa5d1748b0a3796438f8be0fd026

treewide: remove dependencies on mapper.target

The mapper is dbus activated now, so these explicit dependency
declarations are unnecessary and redundant.

Change-Id: I0b5aa5d1748b0a3796438f8be0fd026cf3aa15ac
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Stop ATTN service before instruction stop

Ensuring that ATTN service is stopped after PHYP has completed the power
off process. PHYP must be done before starting instruction stop. So that
is a good

Stop ATTN service before instruction stop

Ensuring that ATTN service is stopped after PHYP has completed the power
off process. PHYP must be done before starting instruction stop. So that
is a good target to use.

Tested: Verify that during soft-off attention handler will service
attentions (inject error during graceful shutdown).

Signed-off-by: Zane Shelley <zshelle@us.ibm.com>
Change-Id: I9611546d3133c444fe62500fc76750558945baf7

show more ...

Attention handler configuration file support

The default behavior of the attention handler can be overriden by
modifying the config file contents. The behavior can also be defined
by the associated

Attention handler configuration file support

The default behavior of the attention handler can be overriden by
modifying the config file contents. The behavior can also be defined
by the associated build option. The default behavior remains
unchanged. The intent of this change is to allow other components to
change the attention handler behavior by updating the configuration file
and restarting the attention handler service.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: I8f73004c926a3a070c5feb690ee5684429f922c5

show more ...

attn: Make attn handler restart less restrictive

Return back to the default service restart limit behavior which is
is a maximum of two failures within 30 seconds before the
attention handler is con

attn: Make attn handler restart less restrictive

Return back to the default service restart limit behavior which is
is a maximum of two failures within 30 seconds before the
attention handler is considered failed. This change is needed as it
seems that the restart count is incremented for every restart not just
the restart after failure. Making the restart more restrictive had the
side effect of the attention handler reaching the restart limit if the
host was restarted more than two times in 10 minutes even though the
attention handler was not restarted due to failure.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: I427d60451dce6b613c6e004a063cea5ad06f8fb5

show more ...

attn: Add dependency to service file

Start the attn_handler.service after the
openpower-update-bios-attr-table.service since that's the service that
sets up the DEVTREE file. Also update the path to

attn: Add dependency to service file

Start the attn_handler.service after the
openpower-update-bios-attr-table.service since that's the service that
sets up the DEVTREE file. Also update the path to DEVTREE since pnor is
being deprecated.

Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Change-Id: Ia160ea5d529acb618690f8fa6e586bc0ef0729c0

show more ...

attn: Make restart after fail more restrictive

Override the default service restart after fail behavior. The current
behavior is maximum of two failures within 30 seconds before the
attention handle

attn: Make restart after fail more restrictive

Override the default service restart after fail behavior. The current
behavior is maximum of two failures within 30 seconds before the
attention handler is considered failed. The new behavior is maximum of
two failures within 10 minutes before the attention handler is
considered failed. This avoids a potential endless fail and restart
loop due to analyses possibly taking longer than 15 seconds during which
time the attention handler could potentially crash, avoiding the current
30 second fail time window. The 10 minute value is an arbitrarily
large value as we expect the cause of the attention handler crash to
immediately go away or not at all.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: Ia3a6e9ee849733655273f3a82c4fbef46c808525

show more ...

stop ATTN service during watchdog time out handling

A watchdog time out will initiate a dump. As a side-effect, the dump
will likely trigger a checkstop attention. We do not want ATTN to

stop ATTN service during watchdog time out handling

A watchdog time out will initiate a dump. As a side-effect, the dump
will likely trigger a checkstop attention. We do not want ATTN to handle
this attention. So we are stopping the ATTN service before initiating
the dump. The ATTN service will be restarted on the next IPL.

Signed-off-by: Zane Shelley <zshelle@us.ibm.com>
Change-Id: If98ce1b3dfbf31896808b1a43ecc007efb6ea8f8

show more ...

Fix for setting PDBG_DTB environment variable

The code for setting PDBG_DTB environment variable conditionally in the
service file was not working correctly which resulted in the environ

Fix for setting PDBG_DTB environment variable

The code for setting PDBG_DTB environment variable conditionally in the
service file was not working correctly which resulted in the environment
variable not getting set. This was fixed.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: If4f3b97166541b1b3755efc63006371df70a98d5

show more ...