meson: switch code dependency to libsystemd

For a while now systemd has packaged a separate `libsystemd`. For
meson dependency, `systemd` should be used when looking for systemd
service file paths

meson: switch code dependency to libsystemd

For a while now systemd has packaged a separate `libsystemd`. For
meson dependency, `systemd` should be used when looking for systemd
service file paths and `libsystemd` should be used for `sd_*` functions.

Update the dependency accordingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6cd50bda0f02315469fac81d5a110a6383feb327

show more ...

OWNERS: Remove Andrew, promote Adriana

I'm no-longer employed by IBM, and this repo is tied into the depths of
their platform boot code. It needs to be maintained by someone internal
to IBM.

Change

OWNERS: Remove Andrew, promote Adriana

I'm no-longer employed by IBM, and this repo is tied into the depths of
their platform boot code. It needs to be maintained by someone internal
to IBM.

Change-Id: Ifd1439a3236f875b5a7ff6158c868d7ba783bc38
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I729d80cbcef16e9603f881163b54cc8b8f60b36f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

OWNERS: Update Andrew's email address

Change-Id: Ib9858cba1c26ed426fcd567a1f63228bf0e1c611
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I737d5075893d37975ab190217e3a5836f2a5987d
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ie4e7e86dbfcb0b90d5b5838a7095e739c1865c77
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I8322ecdc9a3482525adba74cbe94cd751180be48

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I96dfaff39d5361fb2a1d5

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I96dfaff39d5361fb2a1d5b8cb17a1b54d5879b00
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ie377be65aa7205089b44e4c0caf4674ea8797e13
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Ibdbcc466780f4a2303c4c0879937d690cbac8d06
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9ded3cc082b5880b4f9a08056e2468d7a1d8dbdf

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia40a8258d162ca5fbb07d91a652f5521f2465cda

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7c7b9612264a04ce4c071d8d1e6252159102178b

show more ...

build: Convert project to meson due to ipmid dependencies

Cleanedup all build warnings and updated the header to point to the
latest ipmid.

Tested:
Build BMC image with witherspoon and was fine.

C

build: Convert project to meson due to ipmid dependencies

Cleanedup all build warnings and updated the header to point to the
latest ipmid.

Tested:
Build BMC image with witherspoon and was fine.

Change-Id: Ib00d9ef44b176aec5d2a92a24c6f26b7794051c8
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

build: enable C++20

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icd1eb71dc2fc2a13edbfb47954023eb85982dc5c

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I07bc898dd3518548a3a55dda4ce08037beed047f

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7e6f9e0a9d2c91fb5cd82e7a77a3416d1f07247f

show more ...

MAINTAINERS: update email address for Deepak

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I10c0aecd6a8447d4335763c99c9f481a269a38e3

bootstrap: fix shellcheck warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86ef079c9632e5563a1a56d6a2e23aad59ecbc57

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8c6fbef06cc2f208b3b6498bc6a4e099a34f9fb0

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I40c4c90fcebf4c984201653a1ac4d6f203d82eb2

configure: remove unused dependency on sdbus++

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If6517671c0adbfdff2ec4698bc73e0cd08ccd34d

hiomap: Unblock SIGTERM on reset path

When IPMI is terminated, the SIGTERM signal was not re-enabled on the
hiomap's reset path, causing IPMI to not be terminated.

Tested:
- Without change:
Apr 16

hiomap: Unblock SIGTERM on reset path

When IPMI is terminated, the SIGTERM signal was not re-enabled on the
hiomap's reset path, causing IPMI to not be terminated.

Tested:
- Without change:
Apr 16 20:46:43 witherspoon systemd[1]: Stopping Phosphor MBOX Daemon...
Apr 16 20:46:45 witherspoon ipmid[1471]: Blocked SIGTERM
...
Apr 16 20:47:15 witherspoon ipmid[1471]: Unblocked SIGTERM
Apr 16 20:48:15 witherspoon systemd[1]: phosphor-ipmi-host.service: State 'stop-sigterm' timed out. Killing.
Apr 16 20:48:15 witherspoon systemd[1]: phosphor-ipmi-host.service: Killing process 1471 (ipmid) with signal SIGKILL.

- With change:
Apr 16 21:11:23 witherspoon ipmid[1493]: Blocked SIGTERM
Apr 16 21:11:23 witherspoon ipmid[1493]: Received signal; quitting
Apr 16 21:11:23 witherspoon systemd[1]: Stopping Phosphor Inband IPMI...
Apr 16 21:11:23 witherspoon systemd[1]: Stopped Phosphor Inband IPMI.

Fixes: openbmc/openbmc#3465
Change-Id: Ie234b045664db4c63ba6674894be875d31d86cb4
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Use new ipmid signal handling interface

This changes out the old signal handling for the new boost::asio
signal handing mechanism that the core ipmid is now using.

Tested:
Verified host powers on w

Use new ipmid signal handling interface

This changes out the old signal handling for the new boost::asio
signal handing mechanism that the core ipmid is now using.

Tested:
Verified host powers on with the latest ipmid changes.
Verified the block/unblock signal scenarios:
1. When hiomap unblocks SIGTERM (return continue to ipmid), kill ipmid
and verify it exits:

Mar 21 20:53:59 witherspoon ipmid[2711]: Unblocked SIGTERM
root@witherspoon:~# killall -15 ipmid
Mar 21 20:54:15 witherspoon ipmid[2711]: ipmid: Pushing cmd on to queue
Mar 21 20:54:15 witherspoon ipmid[2711]: Asserting SMS Attention
Mar 21 20:54:15 witherspoon ipmid[2711]: SMS Attention asserted
Mar 21 20:54:15 witherspoon ipmid[2711]: Received signal; quitting

2. When hiomap blocks SIGTERM (return break to ipmid), kill ipmid
and verify it doesn't exit (this was done at power off so the failure
to deliver to host msg is expected):

Mar 21 20:54:22 witherspoon ipmid[2722]: Blocked SIGTERM
Mar 21 20:54:22 witherspoon ipmid[2722]: ipmid: Pushing cmd on to queue
Mar 21 20:54:22 witherspoon ipmid[2722]: Asserting SMS Attention
root@witherspoon:~# killall -15 ipmid
Mar 21 20:54:27 witherspoon ipmid[2722]: ipmid: Pushing cmd on to queue
Mar 21 20:54:27 witherspoon ipmid[2722]: Command in process, no attention
Mar 21 20:54:52 witherspoon ipmid[2722]: Host control timeout hit!
Mar 21 20:54:52 witherspoon ipmid[2722]: Failed to deliver host command
Mar 21 20:54:52 witherspoon ipmid[2722]: Unblocked SIGTERM

Change-Id: I6b05b4ac3cda19dea76b19074f548b60bca40584
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Ic65159cab8b703cf31ae6c5b04b82

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Ic65159cab8b703cf31ae6c5b04b82f1b75652a0f
Signed-off-by: Patrick Venture <venture@google.com>

show more ...