Implementing Phosphor-Logging/LG2 logging

This commit introduces changes in the openpower-debug-collector
repository to implement structured logging using the LG2
framework. The existing log calls i

Implementing Phosphor-Logging/LG2 logging

This commit introduces changes in the openpower-debug-collector
repository to implement structured logging using the LG2
framework. The existing log calls in the repository,
have been replaced with LG2 logging, facilitates better
log tracking and troubleshooting by offering improved
detail in JSON object values.

Change-Id: Iabea1d0044d27a286f73e34588205b45952ae146
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

elog-errors: remove generated file

Move the error YAML definition to phosphor-dbus-interfaces and rely
on the real elog-errors.hpp from phosphor-logging rather than a
generated one.

Signed-off-by:

elog-errors: remove generated file

Move the error YAML definition to phosphor-dbus-interfaces and rely
on the real elog-errors.hpp from phosphor-logging rather than a
generated one.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944430fc63e2e1ea169947ae43d061f19458f9fc

show more ...

switch fmt::format to use std::format

The fmt::format is supported directly in std now. Swap it out and
remove the unnecessary dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Chang

switch fmt::format to use std::format

The fmt::format is supported directly in std now. Swap it out and
remove the unnecessary dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie278c6328239928198fd87f5007468d401e44a21

show more ...

watchdog: Update host watchdog event name triggered

When the watchdog timer hits, if the hostboot-dump-collection is
disabled, the org.open_power.Host.Boot.Error.WatchdogTimedOut event is
triggered.

watchdog: Update host watchdog event name triggered

When the watchdog timer hits, if the hostboot-dump-collection is
disabled, the org.open_power.Host.Boot.Error.WatchdogTimedOut event is
triggered.

If the hostboot-dump-collection is enabled, the
org.open_power.Host.Boot.Error.WatchdogTimeout event is triggered

Due to this, when host dump collection is disabled, the event did not
match any entry in registry entry. Changing the event name and the
message registry in both enabled and disabled cases to
org.open_power.Host.Boot.Error.WatchdogTimedOut to see the expected PEL.

Fix: Update the event name to
org.open_power.Host.Boot.Error.WatchdogTimedOut

Test: Tested and verified that in both scenarios it creates the BD5EC101
PEL

Change-Id: Ib29e5c17dd81533370122bb2e08c30f856900496
Signed-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>

show more ...

Request hostboot dump when Host State is 'Running'

When CurrentHostStatus is not in 'Running' state, either host is 'Off'
or current state is changed by HW dump to a state other than 'Running'
and m

Request hostboot dump when Host State is 'Running'

When CurrentHostStatus is not in 'Running' state, either host is 'Off'
or current state is changed by HW dump to a state other than 'Running'
and may have initiated/created the dump. In these cases, there is
no need to initiate hostboot dump. This commit allows initiating
hostboot dump collection when the current host state is 'Running'
and the watchdog times out.

Testing:
Run watchdog_timeout and check the following entries in the journal log:
'Running' state:
Mar 03 12:22:34 <xxxx> watchdog_timeout[3626]: Host did not respond
within watchdog timeout interval
Mar 03 12:22:34 <xxxx> watchdog_timeout[3626]: Handle Hostboot boot
failure
Mar 03 12:22:34 <xxxx> watchdog_timeout[3626]: hostboot dump
requested
Mar 03 12:23:26 <xxxx> watchdog_timeout[3626]:
/xyz/openbmc_project/dump/hostboot/entry/20000028
Mar 03 12:23:26 <xxxx> watchdog_timeout[3626]:
xyz.openbmc_project.Common.Progress.OperationStatus.Completed
Mar 03 12:23:26 <xxxx> watchdog_timeout[3626]: dump collection
completed

'Quiesced' state:
Mar 03 12:26:04 <xxxx> watchdog_timeout[3917]: Host did not respond
within watchdog timeout interval
Mar 03 12:26:04 <xxxx> watchdog_timeout[3917]: Host is not in
'Running' state. Dump maybe already occurring, skipping this dump
request...

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I7245fef1639299bf501667eef48e275a93307c00

show more ...

Watchdog timeout support in SBE boot window

Added support to handle SBE boot failure when watchdog
times out in the SBE boot window. FFDC information from SBE
is captured using libph

Watchdog timeout support in SBE boot window

Added support to handle SBE boot failure when watchdog
times out in the SBE boot window. FFDC information from SBE
is captured using libphal provided API, and the SBE specific
PEL for a valid FFDC is created. In case the error is related
to SBE timeout or no FFDC data then SBE dump to capture additional
debug data is initiated.

Tested: verified PEL log
root@p10bmc:~# peltool -l
{
"0x50000332": {
"SRC": "BD123504",
"Message": "timeout reported during SBE boot
process",
"PLID": "0x50000332",
"CreatorID": "BMC",
"Subsystem": "Processor Chip Cache",
"Commit Time": "10/04/2021 18:25:27",
"Sev": "Unrecoverable Error",
"CompID": "0x3500"
}
}

- Verified SBE dump was collected
Steps used:
1. obmcutil poweroff
2. istep -s0
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check journal log to see SBE dump requested, dump entry created
and the dump is completed
journalctl -f -t watchdog_timeout
6. Verify the SBE dump:
ls /var/lib/phosphor-debug-collector/sbedump/<dump-entry-id>

- Verified Hostboot dump was collected
Steps Used:
1. obmcutil poweroff
2. istep -s0..6
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check journal log to see Hostboot dump requested, dump entry
created and the dump is completed
journalctl -f -t watchdog_timeout
6. Verify the SBE dump:
ls /var/lib/phosphor-debug-collector/hostbootdump/<dump-entry-id>

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Ibfe7cc6619cd99f303c6106e617bc636632d0940

show more ...

watchdog: Collect hostboot dump when watchdog times out

The hostboot dump collection to be initiated by watchdog_timeout
is disabled by default. When watchdog times out, only error
m

watchdog: Collect hostboot dump when watchdog times out

The hostboot dump collection to be initiated by watchdog_timeout
is disabled by default. When watchdog times out, only error
message corresponding to watchdog timeout is logged. To enable
hostboot dump collection whenever watchdog times out, the meson
option 'hostboot-dump-collection' must be enabled.

Testing - with meson option 'hostboot-dump-collection' enabled:
Ran watchdog_timeout:
case-1: CurrentHostState - off, AutoReboot - false
- Verified PEL object was not created
- Verified hostboot dump was not created
- Verified the Host State changed to Quiesce

case-2: CurrentHostState - off, AutoReboot - true
- Verified PEL object was created
- Verified hostboot dump was not created
- Verified the Host State changed to Running

case-3: CurrentHostState - Running, AutoBoot - false
- Verified PEL object was not created
- Verified hostboot dump was not created
- Verified the Host State changed to Quiesce

case-4: CurrentHostState - Running, AutoBoot - true, default timeout = 300s
- Verified PEL object was created
- Verified hostboot dump was created
- Observed Host state moving to either Running or Quiesce

case-5: CurrentHostState - Running, AutoBoot - true, specified timeout = 5s
- Verified PEL object was created
- Verified hostboot dump was created
- Observed Host state moving to either Running or Quiesce

Docker Unit test: passed

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Ib92d0c2f282816fb742cf07c1cb876b2cc093c12

show more ...

Build: Add support building with meson

Testing:
- Verified all code build as expected in CI and unit tests passed
- Done docker Unit testing

Signed-off-by: Shantappa Teekapp

Build: Add support building with meson

Testing:
- Verified all code build as expected in CI and unit tests passed
- Done docker Unit testing

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Iaa296f85353ceddfd40cd860d41e0a6e3abfac49

show more ...

Enable clang code format

Change-Id: Idbac4c9f663ba887a82a7706a2f8274e18bd747f
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

Renamed error yaml due to clash with error yaml in openpower-dbus

To fix duplicate "Event" string in error message ""Message":
"org.open_power.Error.Host.Event.Event"", renamed error yam

Renamed error yaml due to clash with error yaml in openpower-dbus

To fix duplicate "Event" string in error message ""Message":
"org.open_power.Error.Host.Event.Event"", renamed error yaml
in dbus interfaces from org/open_power/Host/Event.errors.yaml
to org/open_power/Host.errors.yaml.

Renaming of error yaml file in dbus interfaces clashes with the
error yaml file name in openpower-debug-collector.

To fix the clash renaming openpower-debug-collector error yaml from
org/open_power/Host.errors.yaml to org/open_power/Host/Boot.errors.yaml

Change-Id: Ib5fc0cd176b5d9dc2f47f35b008277434855a711
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Generate local elog-errors header file

Use elog-gen.py, elog-gen-template.mako.hpp, error yaml files
from SDK to build local elog-errors.hpp file

Change-Id: I9e22633c8b6a8eacc75

Generate local elog-errors header file

Use elog-gen.py, elog-gen-template.mako.hpp, error yaml files
from SDK to build local elog-errors.hpp file

Change-Id: I9e22633c8b6a8eacc754771883de82e8b476def3
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Add Error definition for host watchdog timeout

When the host watchdog times out, we need an errorlog to report it.
This commit adds that support.

Change-Id: I0ebb792b768b2ce10e2

Add Error definition for host watchdog timeout

When the host watchdog times out, we need an errorlog to report it.
This commit adds that support.

Change-Id: I0ebb792b768b2ce10e2019fcc24a4d171d3f38fb
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...