clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ica4e7ec03b12307de07581f50e03afefd0054d0f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

watchdog: Update host watchdog event name triggered

When the watchdog timer hits, if the hostboot-dump-collection is
disabled, the org.open_power.Host.Boot.Error.WatchdogTimedOut event is
triggered.

watchdog: Update host watchdog event name triggered

When the watchdog timer hits, if the hostboot-dump-collection is
disabled, the org.open_power.Host.Boot.Error.WatchdogTimedOut event is
triggered.

If the hostboot-dump-collection is enabled, the
org.open_power.Host.Boot.Error.WatchdogTimeout event is triggered

Due to this, when host dump collection is disabled, the event did not
match any entry in registry entry. Changing the event name and the
message registry in both enabled and disabled cases to
org.open_power.Host.Boot.Error.WatchdogTimedOut to see the expected PEL.

Fix: Update the event name to
org.open_power.Host.Boot.Error.WatchdogTimedOut

Test: Tested and verified that in both scenarios it creates the BD5EC101
PEL

Change-Id: Ib29e5c17dd81533370122bb2e08c30f856900496
Signed-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>

show more ...

Callout support for SBE when watchdog times out

This commit provides additional callout support for SBE when the
host does not respond within watchdog timeout interval during SBE
boot window.

Testi

Callout support for SBE when watchdog times out

This commit provides additional callout support for SBE when the
host does not respond within watchdog timeout interval during SBE
boot window.

Testing:
Steps used:
1. obmcutil poweroff
2. istep -s0
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check the journal log, and get the PEL id to print PEL info

PEL info:
"Callout Section": {
"Callout Count": "2",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this type
as a unit",
"Procedure": "BMC0002"
}, {
"FRU Type": "Normal Hardware FRU",
"Priority": "Medium Priority",
"Location Code": "xxxxxxxxxxxxx",
"Part Number": "xxxxx",
"CCIN": "xxxx",
"Serial Number": "xxxxxxx"
}
...
"User Data 2": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Priority": "H",
"Procedure": "BMC0002"
},
{
"Deconfigured": false,
"Guarded": false,
"LocationCode": "Ufcs-xx-xxx",
"Priority": "M"
}
]
}

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I5e182cb415a807d97c98812a6713905d39fdbc9a

show more ...

Watchdog timeout support in SBE boot window

Added support to handle SBE boot failure when watchdog
times out in the SBE boot window. FFDC information from SBE
is captured using libph

Watchdog timeout support in SBE boot window

Added support to handle SBE boot failure when watchdog
times out in the SBE boot window. FFDC information from SBE
is captured using libphal provided API, and the SBE specific
PEL for a valid FFDC is created. In case the error is related
to SBE timeout or no FFDC data then SBE dump to capture additional
debug data is initiated.

Tested: verified PEL log
root@p10bmc:~# peltool -l
{
"0x50000332": {
"SRC": "BD123504",
"Message": "timeout reported during SBE boot
process",
"PLID": "0x50000332",
"CreatorID": "BMC",
"Subsystem": "Processor Chip Cache",
"Commit Time": "10/04/2021 18:25:27",
"Sev": "Unrecoverable Error",
"CompID": "0x3500"
}
}

- Verified SBE dump was collected
Steps used:
1. obmcutil poweroff
2. istep -s0
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check journal log to see SBE dump requested, dump entry created
and the dump is completed
journalctl -f -t watchdog_timeout
6. Verify the SBE dump:
ls /var/lib/phosphor-debug-collector/sbedump/<dump-entry-id>

- Verified Hostboot dump was collected
Steps Used:
1. obmcutil poweroff
2. istep -s0..6
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check journal log to see Hostboot dump requested, dump entry
created and the dump is completed
journalctl -f -t watchdog_timeout
6. Verify the SBE dump:
ls /var/lib/phosphor-debug-collector/hostbootdump/<dump-entry-id>

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Ibfe7cc6619cd99f303c6106e617bc636632d0940

show more ...

Remove checks for AutoReboot in watchdog timeout

Dump collector component collects the dump depending on system dump
policy setting. If the dump policy setting is Enabled, it collects th

Remove checks for AutoReboot in watchdog timeout

Dump collector component collects the dump depending on system dump
policy setting. If the dump policy setting is Enabled, it collects the
dump even when AutoReboot property is disabled. So, removing the check
for AutoReboot which was initially used as a workaround to determine
dump collection when watchdog times out.

Tested:
Disabled AutoReboot property using busctl command, and verified that
the hostboot dump was collected.

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Iddc67f19b70461424c696754c04e2d26434247b8

show more ...

watchdog: Create PEL when AutoReboot is false and watchdog times out

Testing brought to light that an error should always be logged
when the host watchdog times out

Testing:

watchdog: Create PEL when AutoReboot is false and watchdog times out

Testing brought to light that an error should always be logged
when the host watchdog times out

Testing:
Excecuted watchdog_timeout command manually after setting AutoReboot
property to false, and used peltool to verify the PEL was created.

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I8e92676021dd4243d51daca567d8dccc6c56fa7d

show more ...

watchdog: Collect hostboot dump when watchdog times out

The hostboot dump collection to be initiated by watchdog_timeout
is disabled by default. When watchdog times out, only error
m

watchdog: Collect hostboot dump when watchdog times out

The hostboot dump collection to be initiated by watchdog_timeout
is disabled by default. When watchdog times out, only error
message corresponding to watchdog timeout is logged. To enable
hostboot dump collection whenever watchdog times out, the meson
option 'hostboot-dump-collection' must be enabled.

Testing - with meson option 'hostboot-dump-collection' enabled:
Ran watchdog_timeout:
case-1: CurrentHostState - off, AutoReboot - false
- Verified PEL object was not created
- Verified hostboot dump was not created
- Verified the Host State changed to Quiesce

case-2: CurrentHostState - off, AutoReboot - true
- Verified PEL object was created
- Verified hostboot dump was not created
- Verified the Host State changed to Running

case-3: CurrentHostState - Running, AutoBoot - false
- Verified PEL object was not created
- Verified hostboot dump was not created
- Verified the Host State changed to Quiesce

case-4: CurrentHostState - Running, AutoBoot - true, default timeout = 300s
- Verified PEL object was created
- Verified hostboot dump was created
- Observed Host state moving to either Running or Quiesce

case-5: CurrentHostState - Running, AutoBoot - true, specified timeout = 5s
- Verified PEL object was created
- Verified hostboot dump was created
- Observed Host state moving to either Running or Quiesce

Docker Unit test: passed

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Ib92d0c2f282816fb742cf07c1cb876b2cc093c12

show more ...