clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ie029f7917035731dc2a3fd61c8bbd55685de6278
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Update the request dump methods

- Watchdog change
The dump request path of OpenPOWER dumps are updated
from /org/openpower/dump to /xyz/openbmc_project/dump/system

- Dump change
The dump type param

Update the request dump methods

- Watchdog change
The dump request path of OpenPOWER dumps are updated
from /org/openpower/dump to /xyz/openbmc_project/dump/system

- Dump change
The dump type parameter is added instead of dump path.

Change-Id: Ic08e3c5fc99eaed116b97ceaf6c41f05a3503859
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ib615c5fe1dfb01fc0adedd692524fe145c8c4e82
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Implementing Phosphor-Logging/LG2 logging

This commit introduces changes in the openpower-debug-collector
repository to implement structured logging using the LG2
framework. The existing log calls i

Implementing Phosphor-Logging/LG2 logging

This commit introduces changes in the openpower-debug-collector
repository to implement structured logging using the LG2
framework. The existing log calls in the repository,
have been replaced with LG2 logging, facilitates better
log tracking and troubleshooting by offering improved
detail in JSON object values.

Change-Id: Iabea1d0044d27a286f73e34588205b45952ae146
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I680b06b216e5069f203352c240553a7595ac5b9a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

switch fmt::format to use std::format

The fmt::format is supported directly in std now. Swap it out and
remove the unnecessary dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Chang

switch fmt::format to use std::format

The fmt::format is supported directly in std now. Swap it out and
remove the unnecessary dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie278c6328239928198fd87f5007468d401e44a21

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ica4e7ec03b12307de07581f50e03afefd0054d0f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

watchdog: Update host watchdog event name triggered

When the watchdog timer hits, if the hostboot-dump-collection is
disabled, the org.open_power.Host.Boot.Error.WatchdogTimedOut event is
triggered.

watchdog: Update host watchdog event name triggered

When the watchdog timer hits, if the hostboot-dump-collection is
disabled, the org.open_power.Host.Boot.Error.WatchdogTimedOut event is
triggered.

If the hostboot-dump-collection is enabled, the
org.open_power.Host.Boot.Error.WatchdogTimeout event is triggered

Due to this, when host dump collection is disabled, the event did not
match any entry in registry entry. Changing the event name and the
message registry in both enabled and disabled cases to
org.open_power.Host.Boot.Error.WatchdogTimedOut to see the expected PEL.

Fix: Update the event name to
org.open_power.Host.Boot.Error.WatchdogTimedOut

Test: Tested and verified that in both scenarios it creates the BD5EC101
PEL

Change-Id: Ib29e5c17dd81533370122bb2e08c30f856900496
Signed-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: If6caa27a8c0597732050487d30ab4e8f7a05caaa
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Request hostboot dump when Host State is 'Running'

When CurrentHostStatus is not in 'Running' state, either host is 'Off'
or current state is changed by HW dump to a state other than 'Running'
and m

Request hostboot dump when Host State is 'Running'

When CurrentHostStatus is not in 'Running' state, either host is 'Off'
or current state is changed by HW dump to a state other than 'Running'
and may have initiated/created the dump. In these cases, there is
no need to initiate hostboot dump. This commit allows initiating
hostboot dump collection when the current host state is 'Running'
and the watchdog times out.

Testing:
Run watchdog_timeout and check the following entries in the journal log:
'Running' state:
Mar 03 12:22:34 <xxxx> watchdog_timeout[3626]: Host did not respond
within watchdog timeout interval
Mar 03 12:22:34 <xxxx> watchdog_timeout[3626]: Handle Hostboot boot
failure
Mar 03 12:22:34 <xxxx> watchdog_timeout[3626]: hostboot dump
requested
Mar 03 12:23:26 <xxxx> watchdog_timeout[3626]:
/xyz/openbmc_project/dump/hostboot/entry/20000028
Mar 03 12:23:26 <xxxx> watchdog_timeout[3626]:
xyz.openbmc_project.Common.Progress.OperationStatus.Completed
Mar 03 12:23:26 <xxxx> watchdog_timeout[3626]: dump collection
completed

'Quiesced' state:
Mar 03 12:26:04 <xxxx> watchdog_timeout[3917]: Host did not respond
within watchdog timeout interval
Mar 03 12:26:04 <xxxx> watchdog_timeout[3917]: Host is not in
'Running' state. Dump maybe already occurring, skipping this dump
request...

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I7245fef1639299bf501667eef48e275a93307c00

show more ...

Build fails for p10bmc machine type

The commit, eebcf900a23b41df24d0985240a4da83bffa8a54, to move yaml
files to a specific subdirectory caused build failure for p10bmc
mchine type.

Tested: build su

Build fails for p10bmc machine type

The commit, eebcf900a23b41df24d0985240a4da83bffa8a54, to move yaml
files to a specific subdirectory caused build failure for p10bmc
mchine type.

Tested: build succeeds with this change.

Signed-off-by: Shantappa Teekappanavar <shantappa.teekappanavar@ibm.com>
Change-Id: I52a5f3911b1bc5a96de35cc98a2a03a18c8691dd

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3be9475e7639ae8f52bceb1d5ff843a8dffde0a5

show more ...

SBE watchdog times out callout support enhancement

Curently all the SBE timeout use case default callout is included
In the PEL. This commit is used to add the callout for SBE timeout
Without SBE F

SBE watchdog times out callout support enhancement

Curently all the SBE timeout use case default callout is included
In the PEL. This commit is used to add the callout for SBE timeout
Without SBE FFDC use case. If SBE provides FFDC during watchdog
Timeout case , BMC need to honour the callout provided by SBE.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I4523d35913965e9f55c7ae28eb728e8927b650e6

show more ...

Callout support for SBE when watchdog times out

This commit provides additional callout support for SBE when the
host does not respond within watchdog timeout interval during SBE
boot window.

Testi

Callout support for SBE when watchdog times out

This commit provides additional callout support for SBE when the
host does not respond within watchdog timeout interval during SBE
boot window.

Testing:
Steps used:
1. obmcutil poweroff
2. istep -s0
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check the journal log, and get the PEL id to print PEL info

PEL info:
"Callout Section": {
"Callout Count": "2",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this type
as a unit",
"Procedure": "BMC0002"
}, {
"FRU Type": "Normal Hardware FRU",
"Priority": "Medium Priority",
"Location Code": "xxxxxxxxxxxxx",
"Part Number": "xxxxx",
"CCIN": "xxxx",
"Serial Number": "xxxxxxx"
}
...
"User Data 2": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Priority": "H",
"Procedure": "BMC0002"
},
{
"Deconfigured": false,
"Guarded": false,
"LocationCode": "Ufcs-xx-xxx",
"Priority": "M"
}
]
}

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I5e182cb415a807d97c98812a6713905d39fdbc9a

show more ...

Watchdog timeout support in SBE boot window

Added support to handle SBE boot failure when watchdog
times out in the SBE boot window. FFDC information from SBE
is captured using libphal provided API,

Watchdog timeout support in SBE boot window

Added support to handle SBE boot failure when watchdog
times out in the SBE boot window. FFDC information from SBE
is captured using libphal provided API, and the SBE specific
PEL for a valid FFDC is created. In case the error is related
to SBE timeout or no FFDC data then SBE dump to capture additional
debug data is initiated.

Tested: verified PEL log
root@p10bmc:~# peltool -l
{
"0x50000332": {
"SRC": "BD123504",
"Message": "timeout reported during SBE boot
process",
"PLID": "0x50000332",
"CreatorID": "BMC",
"Subsystem": "Processor Chip Cache",
"Commit Time": "10/04/2021 18:25:27",
"Sev": "Unrecoverable Error",
"CompID": "0x3500"
}
}

- Verified SBE dump was collected
Steps used:
1. obmcutil poweroff
2. istep -s0
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check journal log to see SBE dump requested, dump entry created
and the dump is completed
journalctl -f -t watchdog_timeout
6. Verify the SBE dump:
ls /var/lib/phosphor-debug-collector/sbedump/<dump-entry-id>

- Verified Hostboot dump was collected
Steps Used:
1. obmcutil poweroff
2. istep -s0..6
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check journal log to see Hostboot dump requested, dump entry
created and the dump is completed
journalctl -f -t watchdog_timeout
6. Verify the SBE dump:
ls /var/lib/phosphor-debug-collector/hostbootdump/<dump-entry-id>

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Ibfe7cc6619cd99f303c6106e617bc636632d0940

show more ...

Remove checks for AutoReboot in watchdog timeout

Dump collector component collects the dump depending on system dump
policy setting. If the dump policy setting is Enabled, it collects the
dump even

Remove checks for AutoReboot in watchdog timeout

Dump collector component collects the dump depending on system dump
policy setting. If the dump policy setting is Enabled, it collects the
dump even when AutoReboot property is disabled. So, removing the check
for AutoReboot which was initially used as a workaround to determine
dump collection when watchdog times out.

Tested:
Disabled AutoReboot property using busctl command, and verified that
the hostboot dump was collected.

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Iddc67f19b70461424c696754c04e2d26434247b8

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If105f4bf34fbfa8c1e337caf10ead322099840f3

show more ...

watchdog: Create PEL when AutoReboot is false and watchdog times out

Testing brought to light that an error should always be logged
when the host watchdog times out

Testing:
Excecuted watchdog_time

watchdog: Create PEL when AutoReboot is false and watchdog times out

Testing brought to light that an error should always be logged
when the host watchdog times out

Testing:
Excecuted watchdog_timeout command manually after setting AutoReboot
property to false, and used peltool to verify the PEL was created.

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I8e92676021dd4243d51daca567d8dccc6c56fa7d

show more ...

watchdog: Collect hostboot dump when watchdog times out

The hostboot dump collection to be initiated by watchdog_timeout
is disabled by default. When watchdog times out, only error
message correspon

watchdog: Collect hostboot dump when watchdog times out

The hostboot dump collection to be initiated by watchdog_timeout
is disabled by default. When watchdog times out, only error
message corresponding to watchdog timeout is logged. To enable
hostboot dump collection whenever watchdog times out, the meson
option 'hostboot-dump-collection' must be enabled.

Testing - with meson option 'hostboot-dump-collection' enabled:
Ran watchdog_timeout:
case-1: CurrentHostState - off, AutoReboot - false
- Verified PEL object was not created
- Verified hostboot dump was not created
- Verified the Host State changed to Quiesce

case-2: CurrentHostState - off, AutoReboot - true
- Verified PEL object was created
- Verified hostboot dump was not created
- Verified the Host State changed to Running

case-3: CurrentHostState - Running, AutoBoot - false
- Verified PEL object was not created
- Verified hostboot dump was not created
- Verified the Host State changed to Quiesce

case-4: CurrentHostState - Running, AutoBoot - true, default timeout = 300s
- Verified PEL object was created
- Verified hostboot dump was created
- Observed Host state moving to either Running or Quiesce

case-5: CurrentHostState - Running, AutoBoot - true, specified timeout = 5s
- Verified PEL object was created
- Verified hostboot dump was created
- Observed Host state moving to either Running or Quiesce

Docker Unit test: passed

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Ib92d0c2f282816fb742cf07c1cb876b2cc093c12

show more ...