Faultlog: Add support to install Faultlog

Add faultlog to bmcdump plugins and include faultlog in dreport_op.conf
which shall install the plugin from meta-ibm layer in openbmc repo
and creates sym-l

Faultlog: Add support to install Faultlog

Add faultlog to bmcdump plugins and include faultlog in dreport_op.conf
which shall install the plugin from meta-ibm layer in openbmc repo
and creates sym-link.

Test Results:
Verified that openpower-debug-collector recipe installs faultlog script

sysroot-destdir$ ls usr/share/dreport.d/pl_faultdata.d
E10faultlog

Change-Id: I46ece91a04d4d40a3bd72771d6fea11468e5e403
Signed-off-by: Gopichand Paturi <gopichandpaturi@gmail.com>

show more ...

opfunctions: Fix dumpId length

Dump Id in BMC Dump Filename is padded to 7 digits instead of 8 digits.
This is causing file name mismatch between the dump offloaded to
HMC/OS and the dump stored on

opfunctions: Fix dumpId length

Dump Id in BMC Dump Filename is padded to 7 digits instead of 8 digits.
This is causing file name mismatch between the dump offloaded to
HMC/OS and the dump stored on BMC. Fixing this issue by padding Dump
Id to 8 digits.

Test Results:

Before:
root@p10bmc:/var/lib/phosphor-debug-collector/dumps/6# ls
BMCDUMP.13ECF8X.0000006.20241001051003

After:
root@p10bmc:/var/lib/phosphor-debug-collector/dumps/17# ls
BMCDUMP.1012345.00000017.20330125023119

Change-Id: I04c469ad3aaf6480c5732445ba7f8e644357262e
Signed-off-by: SwethaParasa <parasa.swetha1@ibm.com>

show more ...

opdreport: Eliminate undeclared variable; use existing variable instead

The variable 'id' is not declared anywhere in the code, but it is
used for determining the dump content type in the code. Beca

opdreport: Eliminate undeclared variable; use existing variable instead

The variable 'id' is not declared anywhere in the code, but it is
used for determining the dump content type in the code. Because of
this, dump content type is not populated correctly which is causing
a failure in determining dump type when the dump is parsed using
'makedump' tool. So, removing usage of variable 'id' and using
'dump_id' instead of it to solve this issue.

Test Results:

Before:
>>>> Processing dump files
  Processing: SYSDUMP.13E09F0.00000007.20240913135832
  Dump Type is: UNKNOWN

>>>> Processing dump files
  Processing: SYSDUMP.13ECF8X.20000008.20240916083507
Dump Type is: UNKNOWN

After:
>>>> Processing dump files
Processing: SYSDUMP.1012345.00000008.20240903113715
Dump Type is: SCS

>>>> Processing dump files
Processing: SYSDUMP.1012345.20000007.20240903113517
Dump Type is: HB

>>>> Processing dump files
Processing: SYSDUMP.1012345.20000010.20240903140425
Dump Type is: HB

>>>> Processing dump files
Processing: SYSDUMP.1012345.00000011.20240903140502
Dump Type is: SCS

Change-Id: If41f2d652a2b75cce78f50cb64bbf5ff56b87e98
Signed-off-by: SwethaParasa <parasa.swetha1@ibm.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ie029f7917035731dc2a3fd61c8bbd55685de6278
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add OCMB SBE dump support

OCMB SBE dump is another SBE dump with a different dump id prefix.
Adding support for detecting the OCMB SBE dump and passing to
dump-collect application to collect the rig

Add OCMB SBE dump support

OCMB SBE dump is another SBE dump with a different dump id prefix.
Adding support for detecting the OCMB SBE dump and passing to
dump-collect application to collect the right dump.

Change-Id: Ic11f55fc1ef8bd099cec685ec24c2781e1c42fec
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Update the request dump methods

- Watchdog change
The dump request path of OpenPOWER dumps are updated
from /org/openpower/dump to /xyz/openbmc_project/dump/system

- Dump change
The dump type param

Update the request dump methods

- Watchdog change
The dump request path of OpenPOWER dumps are updated
from /org/openpower/dump to /xyz/openbmc_project/dump/system

- Dump change
The dump type parameter is added instead of dump path.

Change-Id: Ic08e3c5fc99eaed116b97ceaf6c41f05a3503859
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Add systemd service for OpenPOWER Dump Monitor

This commit introduces a new systemd service for the OpenPOWER Dump
Monitor. The service is responsible for monitoring and handling dump
collection on

Add systemd service for OpenPOWER Dump Monitor

This commit introduces a new systemd service for the OpenPOWER Dump
Monitor. The service is responsible for monitoring and handling dump
collection on OpenPOWER systems.

Key changes:
- Added `openpower-dump-monitor.service` to manage the OpenPOWER Dump
Monitor process.
- Updated the meson build system to install the new service file and
create necessary symlinks.

Change-Id: Ie4495631c4dbf399e4acbe7bfd47c7b11bc43fc3
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Add support for system dump

When a system dump entry is encountered, a crash target is
set to start the memory preserving reboot.

Change-Id: I8f69a780e8a76b25b0936efb3c1a5ea10b285518
Signed-off-by:

Add support for system dump

When a system dump entry is encountered, a crash target is
set to start the memory preserving reboot.

Change-Id: I8f69a780e8a76b25b0936efb3c1a5ea10b285518
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ib615c5fe1dfb01fc0adedd692524fe145c8c4e82
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Move dump scripts from phosphor-debug-collector

This commit is intended to move the dump collection
scripts from openbmc/phosphor-debug-collector repository.
Following are the scripts that are pulle

Move dump scripts from phosphor-debug-collector

This commit is intended to move the dump collection
scripts from openbmc/phosphor-debug-collector repository.
Following are the scripts that are pulled from the
specified paths of openbmc/phosphor-debug-collector.

1. tools/dreport.d/ibm.d/package
2. tools/dreport.d/ibm.d/plugins.d/pels
3. tools/dreport.d/ibm.d/plugins.d/badpel
4. tools/dreport.d/ibm.d/plugins.d/vpd_data
5. tools/dreport.d/openpower.d/plugins.d/cfam
6. tools/dreport.d/openpower.d/plugins.d/dumpfilelist
7. tools/dreport.d/openpower.d/plugins.d/guardlist
8. tools/dreport.d/openpower.d/plugins.d/obmcconsole1
9. tools/dreport.d/openpower.d/plugins.d/occ
10.tools/dreport.d/openpower.d/plugins.d/phal_devtree

Also the following 3 patches have been applied.
1.https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/56428
2.https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/52436
3.https://gerrit.openbmc.org/c/openbmc/phosphor-debug-collector/+/47917

Also, added meson changes to install the scripts.

Test:
Verified that the scripts are getting installed correctly on BMC.

Change-Id: Iaddf909efaa138db06c877e5ca6a80608feb5baf
Signed-off-by: Gopichand Paturi <gopichandpaturi@gmail.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: Ib65d5374951ab754090a72a9535b7ecf83c431e3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add Dump Monitoring Support

This commit introduces the DumpMonitor class to monitor DBus signals
for dump creation and manage the collection process. It aims to
abstract the complexities of dump col

Add Dump Monitoring Support

This commit introduces the DumpMonitor class to monitor DBus signals
for dump creation and manage the collection process. It aims to
abstract the complexities of dump collection from the
phosphor-dump-collector and consolidate system-specific handling
within the openpower-dump-collector.

Rationale:
- By moving dump collection responsibilities to the
openpower-dump-collector, we ensure that the
phosphor-dump-collector` remains focused solely on hosting dump
entries and interacting with external interfaces.
- The openpower-dump-collector now handles all system-specific
dump collection, reducing potential impacts on the
phosphor-dump-collector.
- Simplified Management: This change simplifies the overall management
of dumps by centralizing dump collection logic in one place.

Key Changes:
1. A new DumpMonitor class monitors DBus signals for dump creation.
2. The executeCollectionScript function handles the actual dump
collection and copies the dump to a specified location for the
phosphor-dump-manager to pick up.
3. Once the dump is copied to the specific folder, the phosphor dump
manager will pick up the file and update its status.
3. In the case of collection failure, the monitor updates the progress
status to indicate that the dump collection failed.

Change-Id: Id5bac5f3fbc8ef7a4bd9e93ac91796206b3cfda9
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Add '0x' Prefix to Indicate Hexadecimal Values

When setting the SRC6 as a hexadecimal number, the '0x' prefix was
missing, causing incorrect values in the PEL. Additionally, changed
'enabled' to 'al

Add '0x' Prefix to Indicate Hexadecimal Values

When setting the SRC6 as a hexadecimal number, the '0x' prefix was
missing, causing incorrect values in the PEL. Additionally, changed
'enabled' to 'allowed' when checking for conditional compilation.

Change-Id: I6d4375edc89d53450bf26848584285a37d6a0c77
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Dump id needs to be hex dump files

The dump ID is written as decimal in the dump files collected from SBE,
this needs to be in hexadecimal to display properly.

Change-Id: I9b2ab2fe3887992328f28c3fa

Dump id needs to be hex dump files

The dump ID is written as decimal in the dump files collected from SBE,
this needs to be in hexadecimal to display properly.

Change-Id: I9b2ab2fe3887992328f28c3fa7469add615d2a49
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Add script to generate dump info file

This commit introduces the gendumpinfo script which generates the
info.yaml file containing metadata about the dump. It also updates
the meson.build files to in

Add script to generate dump info file

This commit introduces the gendumpinfo script which generates the
info.yaml file containing metadata about the dump. It also updates
the meson.build files to include this script in the build process
and ensures it gets installed correctly.

Change-Id: Idcd550ceac912ff42ce2df2bfcb333b4c8b8644b
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Add opdreport tool to OpenPOWER Debug Collector

This commit introduces the opdreport tool, which creates an archive
consisting of host dump files and applies headers on top of it. The
tool includes

Add opdreport tool to OpenPOWER Debug Collector

This commit introduces the opdreport tool, which creates an archive
consisting of host dump files and applies headers on top of it. The
tool includes options to specify the name, directory, dump ID,
maximum allowed size, failing unit, error log ID, and type of the dump
to be collected.

Changes:
- Added meson.build files to integrate opdreport tool.
- Updated meson.build to conditionally include the dump subdirectory
based on the dump-collection option.
- Added opdreport script to the tools/opdump directory.
- Modified meson.build to handle installation of opdreport.

Change-Id: I1a83b2bf4ffa6f8f47191df17b35f8d5b13e4115
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Create Dump Header for IBM Systems

Creating a dump header for IBM systems involves adding a new script to
generate these headers specifically for IBM. This change only impacts
IBM-specific systems a

Create Dump Header for IBM Systems

Creating a dump header for IBM systems involves adding a new script to
generate these headers specifically for IBM. This change only impacts
IBM-specific systems and does not alter the existing dump package format
for other systems. For IBM systems, the generated header will be
appended to the dump, ensuring compatibility with the existing dump
process. Non-IBM systems will continue to use the current dump format
without any modifications. This enhancement maintains the integrity and
format of dumps across different systems while providing a consistent
and specific dump format for IBM systems.

Change-Id: Id6540c90d7519cdd3a96af691a32d906c5e5b63e
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Log all PELs as informational

Hardware failure dumps or boot failure dumps are collected when
the systems are in a critically bad state. Additional errors that
occur during the dump collection may b

Log all PELs as informational

Hardware failure dumps or boot failure dumps are collected when
the systems are in a critically bad state. Additional errors that
occur during the dump collection may be side effects of the prior
failures. Thus, logging all such errors as informational helps
avoid unwanted alerts.

Change-Id: Ie00d7689fcdae4ac1398f3bda36ecc581b305a95
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: Ifaeaafa5bbe57eb6c15803d63d0a9a176bd42f33
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Implement support for POZ FFDC with multiple FFDC packets

This commit implements support for POZ FFDC, where multiple FFDC packets
can be returned after executing an SBE chip-op. This differs from t

Implement support for POZ FFDC with multiple FFDC packets

This commit implements support for POZ FFDC, where multiple FFDC packets
can be returned after executing an SBE chip-op. This differs from the
processor SBE chip-op, which typically returns only a single FFDC packet
upon a chip-op failure.

Key aspects of the implementation:
- Each FFDC packet is associated with a unique SLID id, allowing for the
identification of separate and unrelated FFDC packets within the
collection.
- Each unique SLID is treated as an independent PEL, ensuring that each
FFDC packet is logged separately.
- FFDC data may be present even if the chip-op completes successfully.
In such cases, PELs are logged, but the chip-op is not considered a
failure.

Tests:
Testing the proc FFDC to make sure no regression
Testing POZ FFDC and making sure multiple PELs are logged
Testing FFDC with chip-op success

Change-Id: I8c70bc8df9249c5b9841baef7b5dbe0a6f22e08d
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Support for hardware dump collection from OCMB

This commit introduces the capability to collect hardware dumps from
Odyssey-based OCMB chips in addition to existing processor dump.
This commit addre

Support for hardware dump collection from OCMB

This commit introduces the capability to collect hardware dumps from
Odyssey-based OCMB chips in addition to existing processor dump.
This commit addresses the need for additional failure data across
both processors and their associated OCMB chips.

Key changes include:
- Enabled hardware dump collection specifically for Odyssey OCMB chips.
- Optimized the collection process to occur only when the chip clock
is on to minimize overall dump collection time.
- Sequential dump collection from OCMB chips associated with each
processor.

Change-Id: Iea70912f9fef9c337ba5ca7c508728586be25af8
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Support for memory buffer SBE dump

This commit adds support for collecting memory buffer
SBE in the dump collect application

Change-Id: I8cde59d5fdea042db86356bbf6baea0270cb74e2
Signed-off-by: Dhru

Support for memory buffer SBE dump

This commit adds support for collecting memory buffer
SBE in the dump collect application

Change-Id: I8cde59d5fdea042db86356bbf6baea0270cb74e2
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Add support for performance dump

Performance dump is a collection of hardware performance data
stored in the hardware registers. This commit adds support for
collecting the performance data from the

Add support for performance dump

Performance dump is a collection of hardware performance data
stored in the hardware registers. This commit adds support for
collecting the performance data from the hardware.

Test:

/tmp/dump-collect --type 3 --id 1 \
--path /tmp/dd/plat_dump/ \
--failingunit 1
PDBG Initialization started
Enter: getDump(3) on /proc3
Enter: getDump(3) on /proc0
Enter: getDump(3) on /proc1
Enter: getDump(3) on /proc2

Collected contents
plat_dump/00000001.SbeDataClocksOn.node0.proc0
plat_dump/00000001.SbeDataClocksOn.node0.proc1
plat_dump/00000001.SbeDataClocksOn.node0.proc2
plat_dump/00000001.SbeDataClocksOn.node0.proc3

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I45d021b8ea109e4c7def4b92ccef9dcf0df7ae4c

show more ...

Stop instructions before collecting dump

The instructions need to be stopped before attempting to collect
the hostboot dump. This commit calls stop instructions chip-op
on each processor SBE to make

Stop instructions before collecting dump

The instructions need to be stopped before attempting to collect
the hostboot dump. This commit calls stop instructions chip-op
on each processor SBE to make sure the instructions are stopped
before collecting the dump.
If some SBEs are not ready to accept the chip-op or timed out
the hostboot dump will not be collected from those SBEs and an
SBE dump will lbe collected in the case of a timeout.

Tests:
Tested hardware dump and hostboot dump successfully

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I0b0ff9e6c6d62187a680395931de0a4dfaff579a

show more ...

Collect SBE dump during chip-op timeouts

Add support for collecting SBE dump during dump chip-op
failure.
- Request SBE dump in the case of a chip-op timeout
- Wait for the dump to complete the ti

Collect SBE dump during chip-op timeouts

Add support for collecting SBE dump during dump chip-op
failure.
- Request SBE dump in the case of a chip-op timeout
- Wait for the dump to complete the timeout

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I2f6693a3136803f3555d7e5dc00528bb9d004cdf

show more ...