meta-phosphor: clean up ROOTFS_POSTPROCESS_COMMAND

`ROOTFS_POSTPROCESS_COMMAND` are not required to have semi-colons
anymore. Clean them up to avoid confusion.

Signed-off-by: Patrick Williams <pat

meta-phosphor: clean up ROOTFS_POSTPROCESS_COMMAND

`ROOTFS_POSTPROCESS_COMMAND` are not required to have semi-colons
anymore. Clean them up to avoid confusion.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8d6e3edf778ec5dbdc34eb9be460386476acd127

show more ...

meta-phosphor: remove obmc-fru-ipmi IMAGE_FEATURE

There is currently a lot of complexity of setting up an image feature
which is only used to enable the fru-device feature of entity-manager.
Simplif

meta-phosphor: remove obmc-fru-ipmi IMAGE_FEATURE

There is currently a lot of complexity of setting up an image feature
which is only used to enable the fru-device feature of entity-manager.
Simplify this by using RRECOMMENDS, in entity-manager, and eliminating
the IMAGE_FEATURE.

Tested:

Ran `bitbake entity-manager -ne` and observed the following on two
affected platforms:

In witherspoon:
```
# $PACKAGECONFIG [5 operations]
# :remove[pn-entity-manager] openbmc/openbmc/meta-ibm/conf/machine/witherspoon.conf:41
# "ipmi-fru"
# set openbmc/openbmc/meta/conf/documentation.conf:321
# [doc] "This variable provides a means of enabling or disabling features of a recipe on a per-recipe basis."
# set openbmc/openbmc/meta-phosphor/recipes-phosphor/configuration/entity-manager_git.bb:14
# [_defaultval] "ipmi-fru"
# set openbmc/openbmc/meta-phosphor/recipes-phosphor/configuration/entity-manager_git.bb:15
# [ipmi-fru] "-Dfru-device=true, -Dfru-device=false, i2c-tools,"
# set openbmc/openbmc/meta-phosphor/recipes-phosphor/configuration/entity-manager_git.bb:18
# [validate-json] "-Dvalidate-json=true, -Dvalidate-json=false, ${PYTHON_PN}-jsonschema-native"
# pre-expansion value:
# "ipmi-fru"
PACKAGECONFIG=""
```

In p10bmc:
```
# $PACKAGECONFIG [7 operations]
# :append[pn-debug-trigger] openbmc/openbmc/meta-ibm/conf/machine/p10bmc.conf:72
# " triggers"
# :remove[pn-entity-manager] openbmc/openbmc/meta-ibm/conf/machine/p10bmc.conf:75
# "ipmi-fru"
# set openbmc/openbmc/meta/conf/documentation.conf:321
# [doc] "This variable provides a means of enabling or disabling features of a recipe on a per-recipe basis."
# set openbmc/openbmc/meta-phosphor/recipes-phosphor/configuration/entity-manager_git.bb:14
# [_defaultval] "ipmi-fru"
# set openbmc/openbmc/meta-phosphor/recipes-phosphor/configuration/entity-manager_git.bb:15
# [ipmi-fru] "-Dfru-device=true, -Dfru-device=false, i2c-tools,"
# set openbmc/openbmc/meta-phosphor/recipes-phosphor/configuration/entity-manager_git.bb:18
# [validate-json] "-Dvalidate-json=true, -Dvalidate-json=false, ${PYTHON_PN}-jsonschema-native"
# override[pn-opkg]:set openbmc/openbmc/meta-ibm/conf/machine/p10bmc.conf:74
# "curl openssl ssl-curl"
# pre-expansion value:
# "ipmi-fru"
PACKAGECONFIG=""
```

Built an image for yosemite4 and confirmed that fru-device is still
installed:

```
root@yosemite4:~# systemctl | grep -i Fru
xyz.openbmc_project.FruDevice.service loaded active running Fru Device
root@yosemite4:~# systemctl status xyz.openbmc_project.FruDevice.service
* xyz.openbmc_project.FruDevice.service - Fru Device
Loaded: loaded (/usr/lib/systemd/system/xyz.openbmc_project.FruDevice.service; enabled; preset: enabled)
Active: active (running) since Tue 2024-02-27 09:26:26 PST; 8 months 1 day ago
Main PID: 368 (fru-device)
CPU: 757ms
CGroup: /system.slice/xyz.openbmc_project.FruDevice.service
`-368 /usr/libexec/entity-manager/fru-device
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iaa3d9a8c2a2cf521816b42e36e15de21cf2a0bc2

show more ...

meta-phosphor: remove obmc-rng feature

Since Linux 5.6, the entropy generation provided by rng-tools is now
in the kernel directly. Yocto has removed all dependencies on rng-tools
for packages that

meta-phosphor: remove obmc-rng feature

Since Linux 5.6, the entropy generation provided by rng-tools is now
in the kernel directly. Yocto has removed all dependencies on rng-tools
for packages that use to use it, such as ssh[1]. There isn't any reason
for us to explicitly include rng-tools any longer. Remove the feature
and package group that we had that included it.

[1]: https://lore.kernel.org/openembedded-core/20221209070538.72901-1-xiangyu.chen@eng.windriver.com/

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I85cbe7f30bb41045b7fd1170391a083db9e378b7

show more ...

webui: add new IMAGE_FEATURE

Lots of machines bring the webui in via an RDEPENDS on something
like the "extras" package. The webui for most OpenBMC machines is a
standard feature (as seen in the amo

webui: add new IMAGE_FEATURE

Lots of machines bring the webui in via an RDEPENDS on something
like the "extras" package. The webui for most OpenBMC machines is a
standard feature (as seen in the amount of .bbappend files used to bring
it in) so lets make it an official image feature.

Do not include this new image feature by default in all OpenBMC images
as building the package is non-standard in how it builds. It directly
calls NPM to install required packages so it can not be built offline
and it complicates the software bill of materials.

Tested:
- Confirmed that system1 has webui by default with this when including
the new IMAGE_FEATURE

Change-Id: Icc9fd5d1025f7c385b0aa0f6a9dd74e3a7354c7b
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

meta-ibm: p10bmc: add a MCTP DISTRO_FEATURES switch

The switch enables AF_MCTP and adds the `mctp` tool and `mctpd` so we
can setup and manage an in-kernel MCTP network.

Enable it for p10bmc and al

meta-ibm: p10bmc: add a MCTP DISTRO_FEATURES switch

The switch enables AF_MCTP and adds the `mctp` tool and `mctpd` so we
can setup and manage an in-kernel MCTP network.

Enable it for p10bmc and also add CONFIG_TUN so we can use a tun device
to transport packets between the kernel and the astlpc interface
implemented in libmctp.

Change-Id: I21d0af9e751f91975c760b4b4708b3b401b95417
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>

show more ...

meta-phosphor: remove obmc-system-mgmt from qemu

It was reported that after 5a5f33c729e6b5869362172b63595422eb84a418 the
qemu images are not buildable. Treat qemu systems like an 'evb' so that
the

meta-phosphor: remove obmc-system-mgmt from qemu

It was reported that after 5a5f33c729e6b5869362172b63595422eb84a418 the
qemu images are not buildable. Treat qemu systems like an 'evb' so that
the obmc-system-mgmt package is not included. Make a minor change to
how evb is specified so that it is treated as a MACHINEOVERRIDE that can
be leveraged in multiple recipes.

Tested by ensuring that `evb-ast2600` still successfully resolves all
package dependencies (with `bitbake -p`).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iff4573aa3d4aac30a6681ed75741a6e351bda982

show more ...

Partially revert "treewide: remove obmc-system-mgmt feature"

The obmc-system-mgmt feature is currently used in the image to trigger
inclusion of a virtual-provider which provides a number of package

Partially revert "treewide: remove obmc-system-mgmt feature"

The obmc-system-mgmt feature is currently used in the image to trigger
inclusion of a virtual-provider which provides a number of packages many
systems need. Partially revert the removal of this feature so that
the outcome is:

1. The empty obmc-phosphor-sysd package is still removed.
2. By default the 'obmc-system-mgmt' feature is included, unless
specifically exempted.
3. All EVB platforms remove the 'obmc-system-mgmt' feature since
they have no system they are managing.

This partially reverts commit 060ad3ff7fcc30aff78a9e504efee9d8fa0d4526.

Tested:

* Built `bletchley` and confirmed `packagegroup-fb-apps-system` and
`entity-manager` are present.

```
entity-manager armv7ahf-vfpv4d16 0.1+git0+6bf41588ab-r0
packagegroup-fb-apps-system all 1.0-r1
```
* Built `witherspoon` and confirmed `packagegroup-op-apps-system` and
`pdbg` are present.

```
packagegroup-op-apps-system noarch 1.0
pdbg arm1176jzs 3.3
```

* Ran `bitbake -p` on `evb-ast2600` to confirm the undefined
`virtual-obmc-system-mgmt` is not being included in the image.

Change-Id: I8b7804d5101cc84a2c57473b3f85672bf7767c67
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

treewide: remove obmc-system-mgmt feature

Every machine layer treats 'system-management' as either part of a
package-group or removes the feature. The sample implementation in
meta-phosphor is a do

treewide: remove obmc-system-mgmt feature

Every machine layer treats 'system-management' as either part of a
package-group or removes the feature. The sample implementation in
meta-phosphor is a do-nothing shell script (and up until recently was a
Python script). There appears to be no useful purpose to this feature
as a stand-alone concept, so remove it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I20ca1fa8ff3cb01cac2d07d4ded84e0769e4514b

show more ...

meta-phosphor: prep for new override syntax

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I588025b614416c43aa2d053765ab53bacf890cb5

Enable Systemd NSS module to support DynamicUsers

DynamicUsers flag in systemd service configuration file required to create,
handle and recycle temporary users.

This is essential module for upcomi

Enable Systemd NSS module to support DynamicUsers

DynamicUsers flag in systemd service configuration file required to create,
handle and recycle temporary users.

This is essential module for upcoming daemons' privilege separation work.

Reference: https://github.com/openbmc/openbmc/issues/3383

Signed-off-by: Anton D. Kachalov <gmouse@google.com>
Change-Id: Iabd709c4a20f754fc6ea505e640b2d361aba0be2

show more ...

meta-phosphor: obmc-apps: Add telemetry

Added telemetry package to obmc package groups. Added telemetry
to image features for easy opt-out.

Change-Id: I66be3a545a1ce1cfb2c2c241629168c5b8d56c0d
Sign

meta-phosphor: obmc-apps: Add telemetry

Added telemetry package to obmc package groups. Added telemetry
to image features for easy opt-out.

Change-Id: I66be3a545a1ce1cfb2c2c241629168c5b8d56c0d
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>

show more ...

meta-phosphor: remove ssh test keys class from default image

The phosphor-deploy-ssh-keys.bbclass was intended to be an optional
method to add additional SSH keys into a test image, but the way it
w

meta-phosphor: remove ssh test keys class from default image

The phosphor-deploy-ssh-keys.bbclass was intended to be an optional
method to add additional SSH keys into a test image, but the way it
was implemented the class is always creating warnings like:

WARNING: obmc-phosphor-image-1.0-r0 do_image: Trying to deploy SSH keys
but input variable is empty (SSH_KEYS)

Remove the inherit in the phosphor-image. If a user wants this feature
they can edit their `conf/local.conf` to add:

INHERIT += "phosphor-deploy-ssh-keys"

They are likely doing something similar anyhow with the SSH_KEYS
variable (adding it to the conf/local.conf).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id06e25ba0d22f021d81ee2cd0110d696591c1f59

show more ...

systemd: remove SYSTEMD_PAGER= profile settings

There was support to inject an empty "SYSTEMD_PAGER=" variable
into the profile. This was to workaround ANSI control characters
being injected into t

systemd: remove SYSTEMD_PAGER= profile settings

There was support to inject an empty "SYSTEMD_PAGER=" variable
into the profile. This was to workaround ANSI control characters
being injected into the default systemd tool output, but has a
side-effect of disabling the pager for useful commands like
`journalctl`.

The underlying cause of these control characters was that busybox less
was missing features that systemd relies on. Many of these busybox
features say "this is essential for less applet to work with ...
systemd": https://git.busybox.net/busybox/tree/miscutils/less.c#n103

These are now enabled so this empty environment variable can be removed.

(From meta-phosphor rev: d8f8d70f7e4771eb295fff3ca80182b6636411b6)

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idc2fef9ccfb28e7956caf4efc141698940879f65
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

meta-phosphor: bbclass to deploy test SSH keys

(From meta-phosphor rev: 75c8dc6f5fc565a92da9129291ea09319e8593a6)

Change-Id: I375e188abbf3115e00d3ace1ad201d9fc11214d9
Signed-off-by: Jean-Marie Verd

meta-phosphor: bbclass to deploy test SSH keys

(From meta-phosphor rev: 75c8dc6f5fc565a92da9129291ea09319e8593a6)

Change-Id: I375e188abbf3115e00d3ace1ad201d9fc11214d9
Signed-off-by: Jean-Marie Verdun <jean-marie.verdun@hpe.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

meta-phosphor: fru-device: add package

Add a fru-device package, packagegroup, and image feature.

Remove the ipmi-fru distro feature, since adding it in the first place
was a mistake - no projects

meta-phosphor: fru-device: add package

Add a fru-device package, packagegroup, and image feature.

Remove the ipmi-fru distro feature, since adding it in the first place
was a mistake - no projects have conditional ipmi-fru feature flags.

(From meta-phosphor rev: 4525a9d01a5f65438342a894f27c82f0dd61642c)

Change-Id: I6928ac67d4acb4568359a308b45cb0734d116054
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

meta-phosphor: obmc-apps: Add health monitoring

Add phosphor-health-monitor packages to obmc packagroups and create
IMAGE_FEATURES for easy opt-out.

(From meta-phosphor rev: 67a3c577eced35685ec373b

meta-phosphor: obmc-apps: Add health monitoring

Add phosphor-health-monitor packages to obmc packagroups and create
IMAGE_FEATURES for easy opt-out.

(From meta-phosphor rev: 67a3c577eced35685ec373b30a1419be5f3d3827)

Change-Id: I912610933a2e73530e862feff684134dce9dfe99
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

meta-phosphor: ldap: nsswitch: add rootfs posthook

An ldap image feature was recently added. If the image feature is used
without the distro feature, nsswitch will have the wrong content and the
fu

meta-phosphor: ldap: nsswitch: add rootfs posthook

An ldap image feature was recently added. If the image feature is used
without the distro feature, nsswitch will have the wrong content and the
function won't work. Move this logic to a rootfs post hook so that the
distro feature is not required (and can be deprecated) and because this
is the expected way to make these sorts of modifications to base files
anyway.

(From meta-phosphor rev: 22de160c862b4cf4fee2a3f62e9bd7fad807344d)

Change-Id: I1bc69a96e833801c58bebce68b633e8550982fb8
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

meta-phosphor: obmc-apps: Avoid extras

Much like CORE_IMAGE_EXTRA_INSTALL, packagegroup-obmc-apps-extras is a
dumping ground. Move packages to proper packagroups (bmcweb, ikvm,
dbus-monitor, ldap)

meta-phosphor: obmc-apps: Avoid extras

Much like CORE_IMAGE_EXTRA_INSTALL, packagegroup-obmc-apps-extras is a
dumping ground. Move packages to proper packagroups (bmcweb, ikvm,
dbus-monitor, ldap) and create IMAGE_FEATURES for easy opt-out.

(From meta-phosphor rev: 7463d6daf6868dcad47070c35c1abaec5cf3d2a5)

Change-Id: Ic4209059ac6e22aac18ef95010c7da1439686962
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

phosphor-image: Avoid CORE_IMAGE_EXTRA_INSTALL

CORE_IMAGE_EXTRA_INSTALL is a dumping ground. Move packages to proper
packagroups (console/sol, rng) and create IMAGE_FEATURES for easy
opt-out.

Move

phosphor-image: Avoid CORE_IMAGE_EXTRA_INSTALL

CORE_IMAGE_EXTRA_INSTALL is a dumping ground. Move packages to proper
packagroups (console/sol, rng) and create IMAGE_FEATURES for easy
opt-out.

Move the ffdc application to the debugging packagegroup. Move the
pam-access plugin to the user management packagegroup.

(From meta-phosphor rev: 94bf53d44193b6c5d123c462333fdedf91613370)

Change-Id: If43af92f9bfcb6e0eef08adefbce077defd90b8d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

obmc-phosphor-image: devtools refactoring

Move i2c tools to the devtools package, right next to gpio tools.

Rename extrasdevtools to just devtools. "Extra" doesn't convey any
useful information.

obmc-phosphor-image: devtools refactoring

Move i2c tools to the devtools package, right next to gpio tools.

Rename extrasdevtools to just devtools. "Extra" doesn't convey any
useful information. We can get away with this rename since noone is
touching the package.

Add an IMAGE_FEATURE for devtools, for easy opt-out.

(From meta-phosphor rev: 113fe568c65247e4dc99513b679b74c049178d36)

Change-Id: I28e8e6444e7d5d8c5c6b7c0fb6666587027b3a7b
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pam-ipmi: move to netipmi

There is no reason to install the pam-ipmi module if net-ipmi isn't
being installed.

(From meta-phosphor rev: 26921a3944fe1a7d223212c9715e6b50dd53f666)

Change-Id: Ibb4a41

pam-ipmi: move to netipmi

There is no reason to install the pam-ipmi module if net-ipmi isn't
being installed.

(From meta-phosphor rev: 26921a3944fe1a7d223212c9715e6b50dd53f666)

Change-Id: Ibb4a418f710f41d85472f7224fd9e480ca881296
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

obmc-phosphor-image: move license

Move the LICENSE directive to the image recipe so other recipes could
have their own license, and because this is how oe-core is organized.

(From meta-phosphor rev

obmc-phosphor-image: move license

Move the LICENSE directive to the image recipe so other recipes could
have their own license, and because this is how oe-core is organized.

(From meta-phosphor rev: 92cadf349fb2948e64e44fba73b5eba1944886e2)

Change-Id: I6cc0499b9874ac38852cde05cb44fd32f8871204
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

obmc-phosphor-image: move rootfs cmds to recipe

Similar to IMAGE_FEATURES, move the rootfs modifications to the image
recipe to open up the possibility of other image recipes using
obmc-phosphor-ima

obmc-phosphor-image: move rootfs cmds to recipe

Similar to IMAGE_FEATURES, move the rootfs modifications to the image
recipe to open up the possibility of other image recipes using
obmc-phosphor-image.bbclass. Leave the rootfs command definitions in
the class for use by other image recipes.

(From meta-phosphor rev: 1e92fefdf8c8da253a4ed0ae35256af7592da0b6)

Change-Id: I814f73e24fda19c7fd5393252b660b20079e66c7
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

obmc-phoshor-image: move IMAGE_FEATURES

IMAGE_FEATURES should be set by the image recipe that inherits the
class. This emulates oe-core and opens up the possibility of other
image recipes using obm

obmc-phoshor-image: move IMAGE_FEATURES

IMAGE_FEATURES should be set by the image recipe that inherits the
class. This emulates oe-core and opens up the possibility of other
image recipes using obmc-phosphor-image.bbclass.

(From meta-phosphor rev: 758f9693593a4502012923f6c493323af709515f)

Change-Id: I0dd7bc99618f89becc9192b25f61951d28a09d42
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

meta-phosphor: drop feature check wrappers

These pointless wrappers don't do anything other than obfuscate intent
to readers that have experience with bitbake metadata.

(From meta-phosphor rev: 536

meta-phosphor: drop feature check wrappers

These pointless wrappers don't do anything other than obfuscate intent
to readers that have experience with bitbake metadata.

(From meta-phosphor rev: 536cee986517bf14226feb2f412928bc1904f950)

Change-Id: I92b12b6d675acb65d67f442c6331560cb20c88e6
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...