Revert "Add socket-id for the first console"

This reverts commit ec7cab9378f548e94ee4af83946b2583d1fc7194.

ec7cab9378f5 ("Add socket-id for the first console") was only a partial
fixup of the obmc-

Revert "Add socket-id for the first console"

This reverts commit ec7cab9378f548e94ee4af83946b2583d1fc7194.

ec7cab9378f5 ("Add socket-id for the first console") was only a partial
fixup of the obmc-console configurations found in the tree. For
historical reasons not all platforms that support multiple consoles
install a client configuration file for all consoles. Instead they relied
on some default behaviour that was removed in obmc-console's 4e7186918599
("Fixed broken dbus interface for multiple consoles"). Applying the
configuration changes in the manner of ec7cab9378f5 ("Add socket-id for
the first console") resulted in an asymmetric configuration between the
client and server, breaking some SSH SOL instances.

As of ae2460d0b8e8 ("obmc-console: Provide a default value for
`console-id`.") in obmc-console the requirement to specify
`socket-id`[^1] is lifted. Instead, the configuration can choose to
override a default value. This restores the original behaviour and
unbreaks SSH SOL.

[^1]: Now an alias of the `console-id` configuration key

Websocket and IPMI consoles remain broken. A fix is under development
that also takes a proper approach to supporting multiple consoles in
bmcweb, and the same solution pattern can be applied in ipmid.

More discussion of the problems involved can be found here:

https://amboar.github.io/notes/2023/05/08/happenings-in-obmc-console.html

Change-Id: I274284c791758f336da6d6301dc523bac2b5dd69
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

Add socket-id for the first console

This drop adds socket-id for first console. This was left out before
but with the new design this parameter is required and enforced by
obmc-console code. It is d

Add socket-id for the first console

This drop adds socket-id for first console. This was left out before
but with the new design this parameter is required and enforced by
obmc-console code. It is decided to set "socket-id = console0"
initially because that is the current path used by bmcweb but in future
you can change this value to whatever is appropriate.

The console information is now available through the DBUS interface.
Each console server register it's object path on DBUS. The leaf node of
the object path is used to create a console path. For example in the
following console0 the leaf node "console0" is used to make up the
console path and the GUI will use console path "/console/console0" to
connect to the console.

busctl tree xyz.openbmc_project.Console.console0
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/console
`-/xyz/openbmc_project/console/console0

Here is a discord thread where new design was discussed.
https://discord.com/channels/775381525260664832/1083551792094249051

Tested:
Tested on the rainier system.

Related commits:
1) phosphor-dbus-interface: https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/61486
2) obmc-console: https://gerrit.openbmc.org/c/openbmc/obmc-console/+/62496
3) bmcweb: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/62525

Change-Id: I5fd06f3aac69872a3e5032d592a9b59711795cfe
Signed-off-by: Ninad Palsule <ninadpalsule@us.ibm.com>

show more ...

[Subtree] Bring openbmc machines to top level

The new subtree model brings the subtrees up from the openbmc-machines
layer.

Change-Id: I58a03ae1be374bc79ae1438e65e888375d12d0c0

[Subtree] Bring openbmc machines to top level

The new subtree model brings the subtrees up from the openbmc-machines
layer.

Change-Id: I58a03ae1be374bc79ae1438e65e888375d12d0c0
Signed-off-by: Dave Cobbley <david.j.cobbley@linux.intel.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...