prepare-emmc-qemu: Check if xzdec is present

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: Iee33c50e23cb5c4c46c7c326b65457aea594d5c7

overlay: Print error message to stderr

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie9f40997bc6a87ef4eb8f157e9b764a2b2e6a641

overlay: Accept multiple targets for add and remove subcommands

Make operating on overlays less tedious

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I29897c85adec7987e0302ee17802280c3

overlay: Accept multiple targets for add and remove subcommands

Make operating on overlays less tedious

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I29897c85adec7987e0302ee17802280c3ab591c0

show more ...

overlay: Be explicit about the subcommand

This allows us to treat the remaining arguments as a list tail. However
for now assume we have just the one tail element.

Signed-off-by: Andrew Jeffery <an

overlay: Be explicit about the subcommand

This allows us to treat the remaining arguments as a list tail. However
for now assume we have just the one tail element.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id6ef984e37c5d4b6dace6ca338db58716aee86e8

show more ...

overlay: Lift remove implementation to overlay_remove()

Improve readability by isolating the implementation

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie0fc7857a9d882c29d0406445afa0

overlay: Lift remove implementation to overlay_remove()

Improve readability by isolating the implementation

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie0fc7857a9d882c29d0406445afa053e3adeb591

show more ...

overlay: Lift add implementation to overlay_add()

Isolate the functionality to improve readability

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I1f0abdd33291aa14f53c0220fb5c714b181acb

overlay: Lift add implementation to overlay_add()

Isolate the functionality to improve readability

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I1f0abdd33291aa14f53c0220fb5c714b181acb97

show more ...

dbus-vis: bump electron.js from 8.2.4 to 11.5.0

Dependabot reports a vulnerability with the old version (8.2.4) of
electron.js:

GHSA-mpjm-v997-c4h4
moderate severity
Vulnerable versions: < 11.5.0
P

dbus-vis: bump electron.js from 8.2.4 to 11.5.0

Dependabot reports a vulnerability with the old version (8.2.4) of
electron.js:

GHSA-mpjm-v997-c4h4
moderate severity
Vulnerable versions: < 11.5.0
Patched version: 11.5.0
Impact: This vulnerability allows a sandboxed renderer to request a
"thumbnail" image of an arbitrary file on the user's system. The
thumbnail can potentially include significant parts of the original
file, including textual data in many cases.

Updating electron to 11.5.0 fixes this issue.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I86e5797d689e2b4b3e5643e587dc7ed7e482c659

show more ...

dbus-vis: fix errors and clean up preload.js

This change fixes two errors and does some clean-up:

1. After updating Electron to 11.5.0, "enableRemoteModule: true" is
needed for require('electron').

dbus-vis: fix errors and clean up preload.js

This change fixes two errors and does some clean-up:

1. After updating Electron to 11.5.0, "enableRemoteModule: true" is
needed for require('electron').remote to work.

2. Add handler for stderr in parsing output

Sometimes when a Malformed packet is encountered, the error message does
not get out and the parsing process gets stuck. Adding the handlers can
enable the processes to continue executing in these situations.

3. Removed the unused "preload.js" file.

4. Now clicking the time line after panning the time axis will not cause
an accidental zoom-in to an interval starting with -999.

The cause of this bug is due to HighlightedRegion.t1 being set to the
current mouse location by the OnMouseMove function. This can be
fixed by ensuring that MouseState.hoveredSide must be "timeline".

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: Ib07cf7a33591ee506ab502b206f0351063ef6eea

show more ...

dbus-vis: Initial commit

dbus-vis visualizes PCAP files captured by busctl as well as
text-format outputs from busctl.

dbus-vis displays the visualized results in horizontal
timelines, where each h

dbus-vis: Initial commit

dbus-vis visualizes PCAP files captured by busctl as well as
text-format outputs from busctl.

dbus-vis displays the visualized results in horizontal
timelines, where each horizontal bar represents a DBus request, or
an IPMI request (an IPMI request is a specific kind of DBus request
sent to the IPMI daemon.)
The requests may be grouped by one or more fields including
type, sender, destination, path, interface, member.

In addition, if the BMC console is available, dbus-vis can connect
to the BMC console and capture DBus/IPMI requests in real time.

dbus-vis is in the form of a web page and is wrapped using Electron
to run as a desktop app.

Basic usage:
* Mouse click and drag:
* If mouse is over time axis: drag timeline horizontally
* If mouse is over vertical scroll bar: scroll up/down
* Otherwise: select a region for measuring time & zooming in
* Mouse Scroll wheel:
* If mouse is over time axis: zoom in/out
* Otherwise: scroll up/down
* Click on the expandable headers will expand/collapse the entries under
that particular header.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I863c2ba80025d10efb44fd12868e37912fae9a47

show more ...

Add prepare-emmc-qemu

prepare-emmc-qemu is a script that assembles a bootable eMMC image from
the WIC and u-boot artefacts of an eMMC-based build of OpenBMC:

```
andrew@mistburn:~/src/openbmc/openb

Add prepare-emmc-qemu

prepare-emmc-qemu is a script that assembles a bootable eMMC image from
the WIC and u-boot artefacts of an eMMC-based build of OpenBMC:

```
andrew@mistburn:~/src/openbmc/openbmc/build/p10bmc $ prepare-emmc-qemu -h
NAME
prepare-emmc-qemu: Assemble an OpenBMC eMMC image that can be booted under QEMU

SYNOPSYS
prepare-emmc-qemu <TARGET> <BUILDDIR> [IMAGESIZE]

DESCRIPTION
TARGET: The name of the target machine, used to locate the required images.
BUILDDIR: The path to the OpenBMC build directory.
IMAGESIZE: The output image size, may be specified with units. Defaults to 16G.

EXAMPLE:
prepare-emmc-qemu p10bmc ~/src/openbmc/openbmc/build/p10bmc
andrew@mistburn:~/src/openbmc/openbmc/build/p10bmc $ prepare-emmc-qemu p10bmc .
+ target=p10bmc
+ build_dir=.
+ image_size=16G
+ fw_dir=./tmp/deploy/images/p10bmc
+ wicxz=./tmp/deploy/images/p10bmc/obmc-phosphor-image-p10bmc.wic.xz
+ mmc=mmc-p10bmc.img
+ dd of=mmc-p10bmc.img if=/dev/zero bs=1M count=128
128+0 records in
128+0 records out
134217728 bytes (134 MB, 128 MiB) copied, 0.115718 s, 1.2 GB/s
+ dd of=mmc-p10bmc.img if=./tmp/deploy/images/p10bmc/u-boot-spl.bin conv=notrunc
107+0 records in
107+0 records out
54784 bytes (55 kB, 54 KiB) copied, 0.00642483 s, 8.5 MB/s
+ dd of=mmc-p10bmc.img if=./tmp/deploy/images/p10bmc/u-boot.bin conv=notrunc bs=1K seek=64
411+1 records in
411+1 records out
421275 bytes (421 kB, 411 KiB) copied, 0.0129515 s, 32.5 MB/s
+ xzdec ./tmp/deploy/images/p10bmc/obmc-phosphor-image-p10bmc.wic.xz
+ dd of=mmc-p10bmc.img conv=notrunc bs=1M seek=2
0+1846910 records in
0+1846910 records out
15167689728 bytes (15 GB, 14 GiB) copied, 100.126 s, 151 MB/s
+ truncate --size 16G mmc-p10bmc.img
+ set +x

For an AST2600-based machine, invoke QEMU with the following parameters:

-drive file=/home/andrew/src/openbmc/openbmc/build/p10bmc/mmc-p10bmc.img,if=sd,format=raw,index=2
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I9dff01b4f85aa51e3253a6989bcd80bb2c48b6a9

show more ...

dbus-pcap: Adjust offset by the length of the alignment

As we have a a bytes() rather than an iterator we can measure the length
of the achieved alignment size rather than assuming the requested
ali

dbus-pcap: Adjust offset by the length of the alignment

As we have a a bytes() rather than an iterator we can measure the length
of the achieved alignment size rather than assuming the requested
alignment size.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ida0448d7a3b51e98ed3d547cb70e8689372f37c0

show more ...

dbus-pcap: Use MalformedPacketError instead of assert

This allows us to continue in the face of bad packets while still
reporting them.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia

dbus-pcap: Use MalformedPacketError instead of assert

This allows us to continue in the face of bad packets while still
reporting them.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia85d63bc32af969e3673276e702c27a42ac4ce94

show more ...

dbus-pcap: Print error information to stderr

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id659c280a2a01eb2e18ae950e8908063b7bb95fd

Add overlay script

`overlay` does the tedious work of setting up and tearing down the
environment required for overlay filesystems. Example use:

```
root@bmc:~# touch /usr/share/vpd/foo
touch: /usr

Add overlay script

`overlay` does the tedious work of setting up and tearing down the
environment required for overlay filesystems. Example use:

```
root@bmc:~# touch /usr/share/vpd/foo
touch: /usr/share/vpd/foo: Read-only file system
root@bmc:~# ./overlay add /usr/share/vpd
[53864.956641] overlayfs: upper fs does not support xattr, falling back to index=off and metacopy=off.
root@bmc:~# touch /usr/share/vpd/foo
root@bmc:~# ls -l /usr/share/vpd/foo
-rw-r--r-- 1 root root 0 Sep 6 23:55 /usr/share/vpd/foo
root@bmc:~# rm /usr/share/vpd/foo
root@bmc:~# ls -l /usr/share/vpd/foo
ls: /usr/share/vpd/foo: No such file or directory
root@bmc:~# ./overlay remove /usr/share/vpd
root@bmc:~# touch /usr/share/vpd/foo
touch: /usr/share/vpd/foo: Read-only file system
```

The `rm -rf` specifically removes the temporary directories specified
in the mount options:

```
root@bmc:~# ./overlay add /usr/share/vpd
root@bmc:~# sh -x ./overlay remove /usr/share/vpd
+ set -eu
+ '[' 2 -lt 2 ']'
+ case $1 in
+ o_lowerdir=/usr/share/vpd
++ fstab_fs_mntopt /usr/share/vpd
++ awk '"overlay" == $1 && "/usr/share/vpd" == $2 { printf("%s\n", $4)
}'
+
o_options=rw,relatime,lowerdir=/usr/share/vpd,upperdir=/tmp/tmp.v8vJ35,workdir=/tmp/tmp.6v1YJY
+ umount /usr/share/vpd
+ '[' -z
rw,relatime,lowerdir=/usr/share/vpd,upperdir=/tmp/tmp.v8vJ35,workdir=/tmp/tmp.6v1YJY
']'
+ fstab_option_iter
+ tr , '\n'
+ echo
rw,relatime,lowerdir=/usr/share/vpd,upperdir=/tmp/tmp.v8vJ35,workdir=/tmp/tmp.6v1YJY
+ read FS_MNTOPT
+ case $FS_MNTOPT in
+ read FS_MNTOPT
+ case $FS_MNTOPT in
+ read FS_MNTOPT
+ case $FS_MNTOPT in
+ read FS_MNTOPT
+ case $FS_MNTOPT in
++ echo upperdir=/tmp/tmp.v8vJ35
++ fstab_option_value
++ cut -d= -f2
+ rm -rf /tmp/tmp.v8vJ35
+ read FS_MNTOPT
+ case $FS_MNTOPT in
++ fstab_option_value
++ cut -d= -f2
++ echo workdir=/tmp/tmp.6v1YJY
+ rm -rf /tmp/tmp.6v1YJY
+ read FS_MNTOPT
root@bmc:~#
```

It also safely handles bad remove invocations:

```
root@bmc:~# sh -x ./overlay remove /asdf
+ set -eu
+ '[' 2 -lt 2 ']'
+ case $1 in
+ o_lowerdir=/asdf
++ fstab_fs_mntopt /asdf
++ awk '"overlay" == $1 && "/asdf" == $2 { printf("%s\n", $4) }'
+ o_options=
+ umount /asdf
umount: /asdf: no mount point specified.
root@bmc:~# sh -x ./overlay remove /
+ set -eu
+ '[' 2 -lt 2 ']'
+ case $1 in
+ o_lowerdir=/
++ fstab_fs_mntopt /
++ awk '"overlay" == $1 && "/" == $2 { printf("%s\n", $4) }'
+ o_options=
+ umount /
+ '[' -z '' ']'
+ echo / is not an overlay
/ is not an overlay
+ exit 1
root@bmc:~#
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I0118c645d9edf391d9670aacc889f31d1e1b2f5f

show more ...

dbus-pcap: Handle UNIX_FD and Array of UINT32

1) This message captured on a desktop system caused an error in
AlignedStream.align, so lines 169 and 170 are added to fix the error:

(CookedMessage(he

dbus-pcap: Handle UNIX_FD and Array of UINT32

1) This message captured on a desktop system caused an error in
AlignedStream.align, so lines 169 and 170 are added to fix the error:

(CookedMessage(header=CookedHeader()]), body=['org.freedesktop.
NetworkManager.IP6Config', [['Addresses', [[[x, x, ..., x], x, ... ],
['AddressData', [[['address', 'some ipv6 addr'], ['prefix', x]], ...],
['Routes', [[[x, x, x, x, x, x, x], x, ...],
['RouteData', [[['dest', 'some ipv6 addr'], ['prefix', x], ['metric',
x]], ['next-hop', 'some ipv6 address'], ['metric', x]], ]]]]]]]])

2) This message captured on a desktop system contains a UNIX_FD, line
128 is added to make the parse process pass:

(CookedMessage(header=CookedHeader(fixed=FixedHeader(endian=108,
type=2, flags=1, version=1, length=8, cookie=3541), fields=
[Field(type=<MessageFieldType.REPLY_SERIAL: 5>, data=40),
Field(type=<MessageFieldType.DESTINATION: 6>, data=':1.67459'),
Field(type=<MessageFieldType.SIGNATURE: 8>, data='hb'),
Field(type=<MessageFieldType.UNIX_FDS: 9>, data=1),
Field(type=<MessageFieldType.SENDER: 7>, data=':1.1')]), body=[0, 0])

Change-Id: I02ba32b026ebf5346937aa8b264338dd91d91b98
Signed-off-by: Sui Chen <suichen6@gmail.com>

show more ...

Introduce pdrdump.sh

This script will walk the PDR repository using the pldmtool
and print all of the PDR details output to a text file.

Signed-off-by: Christian Geddes <crgeddes@us.ibm.com>
Change

Introduce pdrdump.sh

This script will walk the PDR repository using the pldmtool
and print all of the PDR details output to a text file.

Signed-off-by: Christian Geddes <crgeddes@us.ibm.com>
Change-Id: I413085b7e162085ca3f2ddde6e08d606bac7d100

show more ...

maintainers: remove Tuple usage

Avoid 'Tuple[List[str],List[str]]' type by creating a well-defined
NamedTuple of the results of parsing the maintainer list.

Signed-off-by: Patrick Williams <patrick

maintainers: remove Tuple usage

Avoid 'Tuple[List[str],List[str]]' type by creating a well-defined
NamedTuple of the results of parsing the maintainer list.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ieb7befa2f3d15d7d43a5006057b0626be09d18f6

show more ...

maintainers: move MAINTAINER parsing to module

In prep for supporting 'OWNERS' move maintainers parsing
details to the appropriate submodule.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Cha

maintainers: move MAINTAINER parsing to module

In prep for supporting 'OWNERS' move maintainers parsing
details to the appropriate submodule.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I38aa703f36a82cc0ed34cc78d9ece76150f73b01

show more ...

maintainers: add command to retrieve reviewers only

Add a subcommand which only retrieves the 'reviewers' portion
of the refspec annotation instead of performing a full push.
This subcommand can be

maintainers: add command to retrieve reviewers only

Add a subcommand which only retrieves the 'reviewers' portion
of the refspec annotation instead of performing a full push.
This subcommand can be used in workflows which do not already use
the 'obmc-gerrit' tool to push by `$(obmc-gerrit reviewers)`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ce961b45997093f5a3074d40ab594d340dd1310

show more ...

maintainers: split maintainers and reviewers in refspec

Gerrit has (for a while) two different refspec push arguments:
r - "reviewers"
cc - "cc"

Modify the tool to put maintainers on 'r' an

maintainers: split maintainers and reviewers in refspec

Gerrit has (for a while) two different refspec push arguments:
r - "reviewers"
cc - "cc"

Modify the tool to put maintainers on 'r' and reviewers on 'cc'
rather than everyone on 'r'.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I890926991568fee40765d0f352f88872dbaa6057

show more ...

maintainers: fix static type checking

Ran 'mypy' and fixed issues reported.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I883e3b6a17482631f8150701bddd91a011b1b631

maintainers: reformat with black

A number of pep8/pycodestyle issues were reported with the
existing code, so reformat with 'black'.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I

maintainers: reformat with black

A number of pep8/pycodestyle issues were reported with the
existing code, so reformat with 'black'.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8c3a103c1600ab06dde07ff0a469c83ffbd6573f

show more ...

obmc-gerrit: disable python caching

Set the `-B` option to Python to disable caching. This prevents
it from polluting the repository with cache files. Since this
script isn't used in performance c

obmc-gerrit: disable python caching

Set the `-B` option to Python to disable caching. This prevents
it from polluting the repository with cache files. Since this
script isn't used in performance critical paths, this seems
reasonable.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1f935129f2abc0e1bc1211f6e21e6ead385ae9a5

show more ...

autobump: add an allowed file suffix list

It doesn't ever make sense to put a SRC_URI in a bbappend but it
happened anyway:

https://github.com/openbmc/openbmc/commit/2d392adf8491fbc6a75d160bbc41755

autobump: add an allowed file suffix list

It doesn't ever make sense to put a SRC_URI in a bbappend but it
happened anyway:

https://github.com/openbmc/openbmc/commit/2d392adf8491fbc6a75d160bbc41755a54da7921

This is far outside the intended scope of the script and the parsing
logic falls apart. Avoid the problem by filtering the git grep results
and only process files that end in bb, inc or bbclass.

Change-Id: I01d646f26f11e0167e9b983251405bd28969f0bc
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

autobump: style fix

Fix an instance of:
E501: line too long (85 > 79 characters)

Fixes: d125d76eabe1484766135c34c8d6e9e6f681acb7
Change-Id: I8d7e9e6c93491762b5e1eb0fcbe7c207f2f37f5d
Signed-off-by

autobump: style fix

Fix an instance of:
E501: line too long (85 > 79 characters)

Fixes: d125d76eabe1484766135c34c8d6e9e6f681acb7
Change-Id: I8d7e9e6c93491762b5e1eb0fcbe7c207f2f37f5d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...