libvoters: handle missing reviewer

In a recent Gerrit change[1], it appears as though a user has been
deleted, which makes the `reviewer` dictionary empty in the data.
Handle this by ignoring that r

libvoters: handle missing reviewer

In a recent Gerrit change[1], it appears as though a user has been
deleted, which makes the `reviewer` dictionary empty in the data.
Handle this by ignoring that reviewer comment.

[1]: https://gerrit.openbmc.org/c/openbmc/openpower-debug-collector/+/82617

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If75fb799e94264f8c9ba618e063ed860b3637196

show more ...

tof-votes: acceptable: load from YAML

Set the regex pattern file to be loaded from YAML rather than
embedded in Python. This allows it to be referenced from
elsewhere, if needed, such as by the ope

tof-votes: acceptable: load from YAML

Set the regex pattern file to be loaded from YAML rather than
embedded in Python. This allows it to be referenced from
elsewhere, if needed, such as by the openbmc-bot[1].

[1]: https://lore.kernel.org/openbmc/aM9suaMKrCk9PY-T@heinlein/

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1941e3bb48227e8171575326603dd440fe722d22

show more ...

tof-votes: adjust acceptable.py

Add more files to reject based on latest development patterns. We
generally do not "count" files which are company specific, OEM, or
generated.

Signed-off-by: Patri

tof-votes: adjust acceptable.py

Add more files to reject based on latest development patterns. We
generally do not "count" files which are company specific, OEM, or
generated.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibd3a3105c8dbf9a95699244c468d10c618a19b1f

show more ...

tof-votes: add subcmd to show the rejected files status

In order to test changes against `acceptable.py`, it is useful to have
a way to display the current rejected status for each file that was
tou

tof-votes: add subcmd to show the rejected files status

In order to test changes against `acceptable.py`, it is useful to have
a way to display the current rejected status for each file that was
touched in a Gerrit data set. Add this command.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie2f98bdfceea02b3ee2a587a971a0093656618fe

show more ...

meson: simplify sdbusplus dependency

There is a lot of cruft in the sdbusplus dependency that is no longer
needed:

1. Use "dependency" with wrap file support rather than "subproject".

2. R

meson: simplify sdbusplus dependency

There is a lot of cruft in the sdbusplus dependency that is no longer
needed:

1. Use "dependency" with wrap file support rather than "subproject".

2. Remove "include_type: system" since this is part of sdbusplus
itself now.

3. Leverage wrap file "provides" directives for dependency variable
lookup.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86945b57a146f5ac178f0982071cec9e69ee54dd

show more ...

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated alias[1]. Move to the non-deprecated /
underscore-separated variant.

[1]: https://github.com/systemd/systemd/commit/4908de44b0a0409f84a7cdc5641b114d6ce8ba03

Change-Id: I4e8c96d699449b78457a52c3f6602df125f120a9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

prettier: minor format change for 3.6.2

Make a minor format change per prettier-3.6.2.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7a28c32800b103e0e3ff3c702dc0978e50cbf57f

Add UTC-aware timestamp format with usec precision

- Replaced time.ctime(), which formats time in local timezone with only
seconds-level precision, with strftime(...) from datetime module to
ena

Add UTC-aware timestamp format with usec precision

- Replaced time.ctime(), which formats time in local timezone with only
seconds-level precision, with strftime(...) from datetime module to
enable formatting with full microsecond precision and control over
time zone representation.
- Defaulted the time to display in UTC.
- Introduced --localtime command-line option to print timestamp in
local timezone.
- Ensured timestamps match journalctl -o short-precise format
(e.g., Jun 10 04:53:00.966670).

Change-Id: I468c980ab9e3d9aaa391bb7ec6d663e6448b14ff
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

openbmctool.py: Update session cookie name

At https://gerrit.openbmc.org/c/openbmc/bmcweb/+/77539 we are going to
rename the BMCWEB session cookie to be BMCWEB-SESSION.

This tool hasn't been update

openbmctool.py: Update session cookie name

At https://gerrit.openbmc.org/c/openbmc/bmcweb/+/77539 we are going to
rename the BMCWEB session cookie to be BMCWEB-SESSION.

This tool hasn't been updated in 5 years, it uses the old D-Bus REST API
but might as well update it.

Tested: None. Inspection only.

Change-Id: I62564feb7d302bc4889c27eaa69a737171d42eb3
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Make CI happy

Format analyze-reviews.py

Change-Id: Ibd2d874c042aa86822a49f62bda1a0431497de2c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add journal checking script

This is to support https://gerrit.openbmc.org/c/openbmc/bmcweb/+/72873

Which is complicated to test.

Change-Id: I5d59dd0423490e74c7c261f60aaf4448d98c670c
Signed-off-by:

Add journal checking script

This is to support https://gerrit.openbmc.org/c/openbmc/bmcweb/+/72873

Which is complicated to test.

Change-Id: I5d59dd0423490e74c7c261f60aaf4448d98c670c
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

i2c: add tree.py to parse i2c bus info to tree

The i2c topo is so complex if there are many i2c buses and muxes,
it's hard to understand the i2c bus info from the output of
"i2cdetect -l". This patc

i2c: add tree.py to parse i2c bus info to tree

The i2c topo is so complex if there are many i2c buses and muxes,
it's hard to understand the i2c bus info from the output of
"i2cdetect -l". This patch adds a python script to parse the i2c bus
info to a tree, which is easy to understand.

ps: maybe add a tree view to the i2ctools, but it's not easy to me.

Example:
```
ssh user@<ip> "i2cdetect -l" | python tree.py
root
├── i2c-4
│ ├── i2c-16
│ │ ├── i2c-129
│ │ ├── i2c-130
│ │ ├── i2c-131
│ │ └── i2c-132
│ ├── i2c-17
│ │ ├── i2c-113
│ │ ├── i2c-114
│ │ ├── i2c-115
│ │ ├── i2c-116
│ │ ├── i2c-117
│ │ ├── i2c-118
│ │ ├── i2c-119
│ │ └── i2c-120
│ ├── i2c-18
│ │ ├── i2c-105
│ │ ├── i2c-106
│ │ ├── i2c-107
│ │ ├── i2c-108
....
```

Change-Id: Ia434b093c7ccff80ea52ad7416bcda609890cecd
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

ipkdbg: Add zstd support

The ipk using zstd to archive, add zstd support.

Since v0.5.0[0], the opkg support zstd.

[0]: https://git.yoctoproject.org/opkg/commit/?id=5dead41
~ git tag --contains=5de

ipkdbg: Add zstd support

The ipk using zstd to archive, add zstd support.

Since v0.5.0[0], the opkg support zstd.

[0]: https://git.yoctoproject.org/opkg/commit/?id=5dead41
~ git tag --contains=5dead41
```
v0.5.0
v0.6.0
v0.6.1
v0.6.2
v0.6.3
```

Change-Id: I92f19b703bb5e19bfb501b30ee4f2867f0fe781e
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

dbus-pcap: Track method call error responses

DBus uses a different type value in the fixed header for error responses
vs method call returns, despite the fact that the response is returning
an error

dbus-pcap: Track method call error responses

DBus uses a different type value in the fixed header for error responses
vs method call returns, despite the fact that the response is returning
an error. Avoid confusion by tracking the error case as well.

Change-Id: Icaa1492db5ded0f95801fdefcd0fecc72627fbfe
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

OWNERS: Update Andrew's preferred email

We're having some grief with non-preferred emails in Gerrit[1]. I now
prefer project-related content goes to my work email address, so use my
non-preferred em

OWNERS: Update Andrew's preferred email

We're having some grief with non-preferred emails in Gerrit[1]. I now
prefer project-related content goes to my work email address, so use my
non-preferred email to implement the switch.

[1]: https://issues.gerritcodereview.com/issues/317345953

Change-Id: Ice7e87bbe7d08640818e50d967d97c48ab73fcc9
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I08759aad9dda3e45b55d8

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I08759aad9dda3e45b55d8602618f4b400ba9c22d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

tof-voters: Record name and email in analysis

With this we can make the data a little easier to consume.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id1cc858dc002adfdf35e2a7bb790dc48

tof-voters: Record name and email in analysis

With this we can make the data a little easier to consume.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id1cc858dc002adfdf35e2a7bb790dc4872d9c570

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: Ic35c323182e32b7d780aa36228214094a416c45b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

dbus-top: remove dbus-top from openbmc-tools

dbus-top has "graduated" from openbmc-tools and existing code has been
migrated to https://github.com/openbmc/dbus-top, so removing its folder
from openb

dbus-top: remove dbus-top from openbmc-tools

dbus-top has "graduated" from openbmc-tools and existing code has been
migrated to https://github.com/openbmc/dbus-top, so removing its folder
from openbmc-tools.

Signed-off-By: Sui Chen <suichen@google.com>
Change-Id: I1bccd8c01aa24f26b9904d5d5e7ae14205df5a84

show more ...

openbmc-autobump: use recipe branch for revision

Yocto recipes are now all required to have a branch in the
SRC_URI. Some openbmc repositories now use 'main' and some use
'master' so we need to use

openbmc-autobump: use recipe branch for revision

Yocto recipes are now all required to have a branch in the
SRC_URI. Some openbmc repositories now use 'main' and some use
'master' so we need to use this information to determine the
correct branch reference to use for finding the latest revision.
Update the script to pull the "branch=" segment out of the SRC_URI
and utilize it for revision search.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0313e2681625f9adbac1b9956fb66556e97fe1e0

show more ...

Fix two CI code formatting errors

The CI reports the following two errors:
* typing.Any unused in tof-voters/libvoters/subcmd/analyzer-commits.py
* the "function" keyword in prepare-emmc-qemu is not

Fix two CI code formatting errors

The CI reports the following two errors:
* typing.Any unused in tof-voters/libvoters/subcmd/analyzer-commits.py
* the "function" keyword in prepare-emmc-qemu is not needed

Fixing as suggested by the CI.

Tested: Ran the CI locally, the CI passes.

Signed-off-By: Sui Chen <suichen6@gmail.com>
Change-Id: Idbd3c47895c6ec6f923ede264264006ffc08e2f7

show more ...

treewide: lint and format

Run all the latest linters and formatters from openbmc-build-scripts.
These were all robotically generated except for fixes due to
markdownlint warnings.

Signed-off-by: Pa

treewide: lint and format

Run all the latest linters and formatters from openbmc-build-scripts.
These were all robotically generated except for fixes due to
markdownlint warnings.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If16d2fd802a2d452234d8b56b41e79d030138a6b

show more ...

shellcheck: add ignore for files currently failing

Soon shellcheck will be enabled by default on all repositories.
Add the currently failing files to the .shellcheck-ignore so the
repository continu

shellcheck: add ignore for files currently failing

Soon shellcheck will be enabled by default on all repositories.
Add the currently failing files to the .shellcheck-ignore so the
repository continues to pass CI in its current state.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie026586e0c372f9a9e36a8167863b6cc2a2f0bb3

show more ...

python: fix flake8 warnings and format with black

Most of the flake8 warnings in this repository were fairly trivial,
so fixed them. The "openbmctool" is 7000+ lines of pretty heavily
warned code,

python: fix flake8 warnings and format with black

Most of the flake8 warnings in this repository were fairly trivial,
so fixed them. The "openbmctool" is 7000+ lines of pretty heavily
warned code, so just disabling that one. Format everything with
black.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icb3f6ee9bf03dece58785f7af00617c87a84aa65

show more ...

python2: remove old scripts

These scripts are python2 and have not been updated after a few years,
so I assume they're not really used at this point. Delete them.

Signed-off-by: Patrick Williams <

python2: remove old scripts

These scripts are python2 and have not been updated after a few years,
so I assume they're not really used at this point. Delete them.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6d86088e3790c62bb18cc59696d5d804a5074317

show more ...