Add journal checking script

This is to support https://gerrit.openbmc.org/c/openbmc/bmcweb/+/72873

Which is complicated to test.

Change-Id: I5d59dd0423490e74c7c261f60aaf4448d98c670c
Signed-off-by:

Add journal checking script

This is to support https://gerrit.openbmc.org/c/openbmc/bmcweb/+/72873

Which is complicated to test.

Change-Id: I5d59dd0423490e74c7c261f60aaf4448d98c670c
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

i2c: add tree.py to parse i2c bus info to tree

The i2c topo is so complex if there are many i2c buses and muxes,
it's hard to understand the i2c bus info from the output of
"i2cdetect -l". This patc

i2c: add tree.py to parse i2c bus info to tree

The i2c topo is so complex if there are many i2c buses and muxes,
it's hard to understand the i2c bus info from the output of
"i2cdetect -l". This patch adds a python script to parse the i2c bus
info to a tree, which is easy to understand.

ps: maybe add a tree view to the i2ctools, but it's not easy to me.

Example:
```
ssh user@<ip> "i2cdetect -l" | python tree.py
root
├── i2c-4
│ ├── i2c-16
│ │ ├── i2c-129
│ │ ├── i2c-130
│ │ ├── i2c-131
│ │ └── i2c-132
│ ├── i2c-17
│ │ ├── i2c-113
│ │ ├── i2c-114
│ │ ├── i2c-115
│ │ ├── i2c-116
│ │ ├── i2c-117
│ │ ├── i2c-118
│ │ ├── i2c-119
│ │ └── i2c-120
│ ├── i2c-18
│ │ ├── i2c-105
│ │ ├── i2c-106
│ │ ├── i2c-107
│ │ ├── i2c-108
....
```

Change-Id: Ia434b093c7ccff80ea52ad7416bcda609890cecd
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

ipkdbg: Add zstd support

The ipk using zstd to archive, add zstd support.

Since v0.5.0[0], the opkg support zstd.

[0]: https://git.yoctoproject.org/opkg/commit/?id=5dead41
~ git tag --contains=5de

ipkdbg: Add zstd support

The ipk using zstd to archive, add zstd support.

Since v0.5.0[0], the opkg support zstd.

[0]: https://git.yoctoproject.org/opkg/commit/?id=5dead41
~ git tag --contains=5dead41
```
v0.5.0
v0.6.0
v0.6.1
v0.6.2
v0.6.3
```

Change-Id: I92f19b703bb5e19bfb501b30ee4f2867f0fe781e
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

dbus-pcap: Track method call error responses

DBus uses a different type value in the fixed header for error responses
vs method call returns, despite the fact that the response is returning
an error

dbus-pcap: Track method call error responses

DBus uses a different type value in the fixed header for error responses
vs method call returns, despite the fact that the response is returning
an error. Avoid confusion by tracking the error case as well.

Change-Id: Icaa1492db5ded0f95801fdefcd0fecc72627fbfe
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

OWNERS: Update Andrew's preferred email

We're having some grief with non-preferred emails in Gerrit[1]. I now
prefer project-related content goes to my work email address, so use my
non-preferred em

OWNERS: Update Andrew's preferred email

We're having some grief with non-preferred emails in Gerrit[1]. I now
prefer project-related content goes to my work email address, so use my
non-preferred email to implement the switch.

[1]: https://issues.gerritcodereview.com/issues/317345953

Change-Id: Ice7e87bbe7d08640818e50d967d97c48ab73fcc9
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I08759aad9dda3e45b55d8

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I08759aad9dda3e45b55d8602618f4b400ba9c22d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

tof-voters: Record name and email in analysis

With this we can make the data a little easier to consume.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id1cc858dc002adfdf35e2a7bb790dc48

tof-voters: Record name and email in analysis

With this we can make the data a little easier to consume.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id1cc858dc002adfdf35e2a7bb790dc4872d9c570

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: Ic35c323182e32b7d780aa36228214094a416c45b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

dbus-top: remove dbus-top from openbmc-tools

dbus-top has "graduated" from openbmc-tools and existing code has been
migrated to https://github.com/openbmc/dbus-top, so removing its folder
from openb

dbus-top: remove dbus-top from openbmc-tools

dbus-top has "graduated" from openbmc-tools and existing code has been
migrated to https://github.com/openbmc/dbus-top, so removing its folder
from openbmc-tools.

Signed-off-By: Sui Chen <suichen@google.com>
Change-Id: I1bccd8c01aa24f26b9904d5d5e7ae14205df5a84

show more ...

openbmc-autobump: use recipe branch for revision

Yocto recipes are now all required to have a branch in the
SRC_URI. Some openbmc repositories now use 'main' and some use
'master' so we need to use

openbmc-autobump: use recipe branch for revision

Yocto recipes are now all required to have a branch in the
SRC_URI. Some openbmc repositories now use 'main' and some use
'master' so we need to use this information to determine the
correct branch reference to use for finding the latest revision.
Update the script to pull the "branch=" segment out of the SRC_URI
and utilize it for revision search.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0313e2681625f9adbac1b9956fb66556e97fe1e0

show more ...

Fix two CI code formatting errors

The CI reports the following two errors:
* typing.Any unused in tof-voters/libvoters/subcmd/analyzer-commits.py
* the "function" keyword in prepare-emmc-qemu is not

Fix two CI code formatting errors

The CI reports the following two errors:
* typing.Any unused in tof-voters/libvoters/subcmd/analyzer-commits.py
* the "function" keyword in prepare-emmc-qemu is not needed

Fixing as suggested by the CI.

Tested: Ran the CI locally, the CI passes.

Signed-off-By: Sui Chen <suichen6@gmail.com>
Change-Id: Idbd3c47895c6ec6f923ede264264006ffc08e2f7

show more ...

treewide: lint and format

Run all the latest linters and formatters from openbmc-build-scripts.
These were all robotically generated except for fixes due to
markdownlint warnings.

Signed-off-by: Pa

treewide: lint and format

Run all the latest linters and formatters from openbmc-build-scripts.
These were all robotically generated except for fixes due to
markdownlint warnings.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If16d2fd802a2d452234d8b56b41e79d030138a6b

show more ...

shellcheck: add ignore for files currently failing

Soon shellcheck will be enabled by default on all repositories.
Add the currently failing files to the .shellcheck-ignore so the
repository continu

shellcheck: add ignore for files currently failing

Soon shellcheck will be enabled by default on all repositories.
Add the currently failing files to the .shellcheck-ignore so the
repository continues to pass CI in its current state.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie026586e0c372f9a9e36a8167863b6cc2a2f0bb3

show more ...

python: fix flake8 warnings and format with black

Most of the flake8 warnings in this repository were fairly trivial,
so fixed them. The "openbmctool" is 7000+ lines of pretty heavily
warned code,

python: fix flake8 warnings and format with black

Most of the flake8 warnings in this repository were fairly trivial,
so fixed them. The "openbmctool" is 7000+ lines of pretty heavily
warned code, so just disabling that one. Format everything with
black.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icb3f6ee9bf03dece58785f7af00617c87a84aa65

show more ...

python2: remove old scripts

These scripts are python2 and have not been updated after a few years,
so I assume they're not really used at this point. Delete them.

Signed-off-by: Patrick Williams <

python2: remove old scripts

These scripts are python2 and have not been updated after a few years,
so I assume they're not really used at this point. Delete them.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6d86088e3790c62bb18cc59696d5d804a5074317

show more ...

pretty-journal: convert to python3 and format

It was reported by a user that they still use this. Convert it to
python3, fix the flake8 issues, and format with black. Tested by
running on a few `j

pretty-journal: convert to python3 and format

It was reported by a user that they still use this. Convert it to
python3, fix the flake8 issues, and format with black. Tested by
running on a few `journalctl -o json-pretty` entries from my own
system.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2689b0e21fb1aae9564c531e0eda69e8eeead571

show more ...

dbus-top: Add design doc

This design doc is copied from
https://gerrit.openbmc.org/c/openbmc/docs/+/44779.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I29f1713553224af4364481707b578bc10

dbus-top: Add design doc

This design doc is copied from
https://gerrit.openbmc.org/c/openbmc/docs/+/44779.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I29f1713553224af4364481707b578bc1017ced41

show more ...

maintainers: remove unused tool

We no longer use MAINTAINERS files. The openbmc-build-scripts
repository has a replacement tool which can be used to interact
with OWNERS files. Delete this tool si

maintainers: remove unused tool

We no longer use MAINTAINERS files. The openbmc-build-scripts
repository has a replacement tool which can be used to interact
with OWNERS files. Delete this tool since it is no longer used.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id731e7c0d598104d5e33727c085f56a23d059888

show more ...

tools: ipkdbg: Generate gdb environments from opkg package archives

ipkdbg serves interactive debugging and coredump analysis of split-debug
binaries by exploiting bitbake's runtime package manageme

tools: ipkdbg: Generate gdb environments from opkg package archives

ipkdbg serves interactive debugging and coredump analysis of split-debug
binaries by exploiting bitbake's runtime package management support
outside the context of the BMC.

To enable ipkdbg in your environment you will need to be familiar with
bitbake's support of [package feeds][package-feeds].

[package-feeds]: https://docs.yoctoproject.org/dev-manual/common-tasks.html?highlight=package+feed#using-runtime-package-management

ipkdbg MUST have access to an appopriate opkg.conf that identifies the
location of the ipk package archive from which the binary under
inspection was installed. ipkdbg supports fetching opkg.conf from a
well-known, remote location if required.

ipkdbg MUST have access to a gdb binary that supports multi-arch for
cross-architecture debugging.

It is RECOMMENDED that ipkdbg also has access to the opkg database used
for populating the rootfs of the BMC firmware image. This is used for
reverse-mapping of absolute binary paths to the package that installed
the binary. With this capability, it is no-longer necessary to list the
set of packages to include in the debug rootfs on the ipkdbg
command-line when processing a core dump, they are automatically
discovered through extracting the path of the failed binary from the
core file.

To make bitbake retain the opkg database for a given build, set
[`INC_IPK_IMAGE_GEN = "1"`][incremental-builds] in your bitbake
configuration, and capture
`./tmp/work/*/obmc-phosphor-image/1.0-r0/temp/saved` as a build artefact
using the following incantation:

$ tar -cJf opkg-database.tar.xz \
-C ./tmp/work/*/obmc-phosphor-image/1.0-r0/temp/saved/target/ \
info lists status

[incremental-builds]: https://git.openembedded.org/openembedded-core/commit/?id=adf587e55c0f9bc74f0bef415273c937401baebb

Finally, opkg binaries are not provided directly due to licensing and
distribution concerns. The binaries should be built and copied into a
bin/ directory alongside `ipkdbg.in` using the
${arch}/${release_id}/${release_version_id}/opkg scheme outlined in the
code:

```
ipkdbg_opkg_path() {
...
local arch=$(uname -m)
local release_id=$(. /etc/os-release; echo $ID)
local release_version_id=$(. /etc/os-release; echo $VERSION_ID)
local p=${root}/bin/${arch}/${release_id}/${release_version_id}/opkg
...
```

Once placed in bin/ the Makefile handles stripping and archiving them
for packaging into the final `ipkdbg` script.

A helper script for building opkg, `build-opkg`, is provided in place of
the binaries themselves.

Help output:

$ ./ipkdbg -h
NAME
ipkdbg - debug OpenBMC applications from an (internally) released firmware

SYNOPSIS
ipkdbg [-q] RELEASE FILE CORE [PACKAGE...]

DESCRIPTION
RELEASE is the firmware release whose packages to install
FILE is the absolute path to the binary of interest in the target environment
CORE is an optional core file generated by FILE. Pass '-' for no core file
PACKAGES will be used to populate a temporary rootfs for debugging FILE

OPTIONS
-h
Print this help.

-q
Quit gdb once done. Intended for use in a scripting environment in combination
with a core file, as the backtrace will be printed as an implicit first command.

ENVIRONMENT
There are several important environment variables controlling the behaviour of
the script:

IPKDBG_OPKG_CACHE
A package cache directory for opkg. Defaults to empty, disabling the cache.

IPKDBG_CONF_HOST
Hostname for access to opkg.conf over the web interface

Defaults to 'host.local'

IPKDBG_CONF_MNT
Mount-point for access to opkg.conf

Defaults to 'mountpoint'

IPKDBG_CONF_LOC
Geo-location for access to opkg.conf

Defaults to 'themoon'

IPKDBG_CONF_ROOT
Path to the directory containing build artifacts, for access to opkg.conf

Defaults to 'path'

IPKDBG_CONF_USER
Username for access to opkg.conf over the web interface

Defaults to $USER (andrew)

IPKDBG_GDB
The gdb(1) binary to invoke. Automatically detected if unset.

IPKDBG_WGET_OPTS
User options to pass to wget(1) when fetching opkg.conf. Defaults to
'--quiet'

IPKDBG_ZSTD
The zstd(1) binary to extract the compressed core dump. Automatically
detected if unset.

EXAMPLE
ipkdbg 1020.2206.20220208a \
/usr/bin/nvmesensor - \
dbus-sensors dbus-sensors-dbg

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib5a7619d0c657754bc0fa2e04cd97e64e4b6da47

show more ...

dbus-vis: Show message arguments in pop-up window

Messages show up in the pop-window like the following:

Message type: sig
Serial : 123456
Sender : :1.234
Destination : <none>
Path

dbus-vis: Show message arguments in pop-up window

Messages show up in the pop-window like the following:

Message type: sig
Serial : 123456
Sender : :1.234
Destination : <none>
Path : /xyz/openbmc_project/sensors/temperature/SomeSensor
Interface : org.freedesktop.DBus.Properties
Member : PropertiesChanged
args[0]: Value, 38.625

This is very convenient for quickly seeing what is in the DBus messages,
and makes debugging certain bugs, for example, sensor-related ones, more
convenient.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I29d52d5b8da315f7de1025b7f266b69ce32edb09

show more ...

dbus-top: use mvwaddstr when no arguments are needed

Currently, some of the code uses mvwprintw to print a string without
using a format string, this causes the following errors:

error: format not

dbus-top: use mvwaddstr when no arguments are needed

Currently, some of the code uses mvwprintw to print a string without
using a format string, this causes the following errors:

error: format not a string literal and no format arguments
[-Werror=format-security]

The fix is to use mvwaddstr when no arguments are needed.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: Ib17ad7a7795cb7bf77161f8730139f38216b7aba

show more ...

Remove .vscode/settings.json

This file is redundant, so removing it.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: Id5e94bfd22ca44d5cbe0096f4b8e8e5d221908d2

Revert "Allow script to be used without a git alias"

This reverts commit 6b4b9df44144c1cc2072eb1847a9fb335d326710.

The change switches from using an SSH alias to using a direct
hostname / port argu

Revert "Allow script to be used without a git alias"

This reverts commit 6b4b9df44144c1cc2072eb1847a9fb335d326710.

The change switches from using an SSH alias to using a direct
hostname / port argument in the claims that it is better for most
users, but it is not.

- The original 'openbmc.gerrit' SSH alias has been documented
forever in openbmc/docs:CONTRIBUTING.md and it is expected that
everyone has it set up as it is part of our gerrit documentation.

- Almost no one runs their system with their Unix ID matching their
Github ID, which means the SSH also needs a username argument
in order to be useful for most people (which was not added by
this previous commit).

As we already document having some kind of SSH alias for interacting
with Gerrit, using an SSH alias is necessary for the majority of users
anyhow, and the SSH alias chosen by default is the project-wide
documented suggestion, I am reverting this back to the previous
behavior.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I78947c75ce689d443d2b08475a35328be296784b

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7d88cbaf4d67632c90bce3b8aac96569c2b60471

OWNERS: add file

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I397b60d2040dd21f3402ec4888d5b201e8b29364