sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib85aa0eb518f1d0e5989d3e8f622f89a796a0082

show more ...

dbus-top: initial commits

This commit covers the basic functionalities of the dbus-top tool.

The UI is divided into 3 windows as follows:

+--------------------------+ Window list
| Wi

dbus-top: initial commits

This commit covers the basic functionalities of the dbus-top tool.

The UI is divided into 3 windows as follows:

+--------------------------+ Window list
| Window A | A: Summary statistics
+------------+-------------+ B: Sensor list or detail
| Window B | Window C | C: Detailed statistics
+------------+-------------+

To navigate the UI:
* Use tab to navigate each window

When a window is highlighted:
In Window B:
* Press esc key 3 times to leave the current sensor selection

In Window C:
* Press [Enter] to show/hide pop-up menu for column selectio
* Press [Left] to move highlight cursor to the left
* Press [Right] to move highlight cursor to the right
* Press [A] to sort by the highlighted column in ascending order
* Press [D] to sort by the highlighted column in descending order

To add recipe to Yocto and build the recipe:
1) Copy and paste the content of the .bb file into a folder that can be
detected by bitbake, such as meta-phosphor/recipes-phosphor/ipmi.
2) run "devtool modify -n dbus-top (path_to_openbmc_tools)/dbus-top/".

Signed-off-by: Adedeji Adebisi <adedejiadebisi01@gmail.com>
Change-Id: Id58ba30b815cfd9d18f54cf477d749dbdbc4545b

show more ...

dbus-vis: A floating detail info window

Adds a draggable floating window for showing information regarding
highlighted messages.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: If35cdd8962f

dbus-vis: A floating detail info window

Adds a draggable floating window for showing information regarding
highlighted messages.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: If35cdd8962f102934934677d6160a555b56df99c

show more ...

dbus-vis: Fix "display row" upper bound

In this affected line, j should go up to "number of visual lines"
minus 1. This can be more than "this.Intervals.length" due to the
headers.

Signed-off-by: S

dbus-vis: Fix "display row" upper bound

In this affected line, j should go up to "number of visual lines"
minus 1. This can be more than "this.Intervals.length" due to the
headers.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I34b5975fb1b06393427397f7f1d165305243b35a

show more ...

dbus-vis: Fix counts for overlapped entries

For dbus method calls that overlap in time, the Render() routine used to
only report counts from the last row. This has been corrected such that
the sum o

dbus-vis: Fix counts for overlapped entries

For dbus method calls that overlap in time, the Render() routine used to
only report counts from the last row. This has been corrected such that
the sum of the counts from all rows belonging to the same same are added
together.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I6c87a0f52c6ab766ecd452305f989ad819b886a5

show more ...

dbus-vis: bump Electron version from 11.5.0 to 18.2.4

`npm` reports a vulnerability with Electron 11.5.0, bumping to the new
version fixes the vulnerability.

Signed-off-by: Sui Chen <suichen@google

dbus-vis: bump Electron version from 11.5.0 to 18.2.4

`npm` reports a vulnerability with Electron 11.5.0, bumping to the new
version fixes the vulnerability.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I456a8f4f4aeb4d61ddc435341dd94616267e5a47

show more ...

dbus-vis: Use IPC for open file dialog

Previously, the "open file" dialog is opened in the renderer thread
running "initialization.js".

This change moves the dialog to the main thread (main.js) so

dbus-vis: Use IPC for open file dialog

Previously, the "open file" dialog is opened in the renderer thread
running "initialization.js".

This change moves the dialog to the main thread (main.js) so that the
renderer thread emits a "file-request" request and the main thread
answers with a "filename" response.

This IPC paradigm is required for newer versions of Electron, because
the "dialog" module cannot be imported in renderer threads in those
newer versions.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: Ifd324688bb8a4dbdc6a5f86082fb3d205af0d77a

show more ...

Implement a performance testing tool for sensors

There are a lot of hypothesis being made about how to improve the
performance of the sensor subsystem within OpenBMC. There are a number
of statemen

Implement a performance testing tool for sensors

There are a lot of hypothesis being made about how to improve the
performance of the sensor subsystem within OpenBMC. There are a number
of statements being made about dbus performance that actually seem
likely to be related to the efficiency of specific implementations of
certain sensors within OpenBMC. Blocking calls, non blocking calls,
asio, bulk collection, eventing, threads and other design decisions all
can have an effect on the performance of a sensor application.

This commit attempts to write a small, portable daemon that publishes
sensor interfaces read from memory in a relatively simple and
controllable manner. This allows running it on a bmc (with services
unloaded) to determine some theoretical "max" performance
characteristics, assuming 0 cost for grabbing actual values.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I27f1560ba13492ccff6a01013c3a1d5ee210cef0

show more ...

overlay: Give metadata dirs the same permissions as the target

This fixes an issue where overlaying directories such as /lib would
break non-root users because the permissions would be restricted to

overlay: Give metadata dirs the same permissions as the target

This fixes an issue where overlaying directories such as /lib would
break non-root users because the permissions would be restricted to
0700 as a byproduct of `mktemp -d`.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id52112200ba4198cab095559c06bd0caf3635240

show more ...

Remove some errant semicolons from report script

Found by autopep8.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I79004eda034aa3549f954edc49092582b946fad5

Allow script to be used without a git alias

The script as it exists today relies on an ssh alias, which leads to
non-obvious error messages if it's not set up. This is a case where
99% of the time

Allow script to be used without a git alias

The script as it exists today relies on an ssh alias, which leads to
non-obvious error messages if it's not set up. This is a case where
99% of the time people will be using the defaults, so we should make the
defaults as helpful as we can.

Tested:
Ran the commands in the README and saw that they succeeded.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I754b31ad9dae47af20c7cd8f4bbb4951119d061d

show more ...

Multithread rootfs_size

I dug this out of the Disney vault on my machine, as something I did to
make this script run quite a bit faster. It probably needs some
cleanups, and I'm sure suffers from m

Multithread rootfs_size

I dug this out of the Disney vault on my machine, as something I did to
make this script run quite a bit faster. It probably needs some
cleanups, and I'm sure suffers from my usual "I stopped when it got the
job done", but with any luck, it might be useful to someone.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ic4d9b5e2f363d487b1bbdf443aec2c28dc068039

show more ...

pep8 rootfs_size.py

Not that important, but might as well be consistent.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I83f95a039c321833c64a5e5ce019fd6d33011043

bbdbg: Add libarchive-native to LD_LIBRARY_PATH

libarchive.so.13 is also required by opkg. This dependency was hidden as
I had the SO installed as a system component in my distro.

Signed-off-by: An

bbdbg: Add libarchive-native to LD_LIBRARY_PATH

libarchive.so.13 is also required by opkg. This dependency was hidden as
I had the SO installed as a system component in my distro.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia21b64796dabe2166fd14db6189681410cb66f44

show more ...

tof-voters: simplify sub-command loading

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I10a0ba59fda4c40680ee1445f28a98d9eee2ff67

tof-voters: enable openpower repositories

Based on private discussion with other TOF members, enabling openpower
repositories but disable:
- 'openpower-libhei' chip data.
- 'openpower-hw-dia

tof-voters: enable openpower repositories

Based on private discussion with other TOF members, enabling openpower
repositories but disable:
- 'openpower-libhei' chip data.
- 'openpower-hw-diags' chip data.
- 'openpower-hw-diags' PEL code.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4a9c06fd3712d76046fb3b388b517e1da2b14f18

show more ...

tof-voters: add README

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie7853f06d1ae969f660e600775774324a2ef06a6

tof-voters: add report subcommand

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic8c4321cfee847a6ac19924cb5c8e2716468cb0f

tof-voters: add review analysis subcommand

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icc571370c3fa961518948b9b63e5d7359963289b

tof-voters: add commit analysis subcommand

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6e56202c014a52d16773415edf59d4e6a7ecdf59

tof-voters: begin tool for voter membership

The TOF voting requires looking at Gerrit data to determine who is
eligible to vote. Start a tool that can be used to dump and analyze
this data.

First

tof-voters: begin tool for voter membership

The TOF voting requires looking at Gerrit data to determine who is
eligible to vote. Start a tool that can be used to dump and analyze
this data.

First sub-command added is a method to dump all Gerrit data after a
certain date (typically the cut-off for the previous election).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I02b22c9dcb81b570ac3872d7c38f838d61690c83

show more ...

bbdbg: Set source directory location

This allows gdb to resolve source lines by installation of source IPKs.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3e5bab6ff6fb97ec2a74ac67f6f4

bbdbg: Set source directory location

This allows gdb to resolve source lines by installation of source IPKs.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3e5bab6ff6fb97ec2a74ac67f6f4ccfb8a6a2cbe

show more ...

bbdbg: Debug a target environment generated by bitbake

bbdbg does the legwork to give you a gdb instance tailored for a target
environment generated from a local bitbake build tree. This saves
the t

bbdbg: Debug a target environment generated by bitbake

bbdbg does the legwork to give you a gdb instance tailored for a target
environment generated from a local bitbake build tree. This saves
the time otherwise spent by building and installing an SDK for the same.

Documentation:

```
3 15:52:42 andrew@mistburn:~/src/openbmc/openbmc-tools/bbdbg (bbdbg) $ ./bbdbg
./bbdbg: 26: 1: parameter not set
NAME
bbdbg - debug applications in a target environment built by bitbake

SYNOPSIS
bbdbg PATH FILE CORE PACKAGES

DESCRIPTION
PATH is the path to the root of a bitbake build directory
FILE is the absolute path to the binary of interest in the target environment
CORE is an optional core file generated by FILE. Pass '-' for no core file
PACKAGES will be used to populate a temporary rootfs for debugging FILE

EXAMPLE
bbdbg ~/src/openbmc/openbmc/build/p10bmc \
/usr/bin/nvmesensor - \
dbus-sensors dbus-sensors-dbg
```

Example use:

```
3 15:50:40 andrew@mistburn:~/src/openbmc/openbmc-tools/bbdbg (bbdbg) $ ./bbdbg ~/src/openbmc/openbmc/build/p10bmc /usr/bin/nvmesensor obmcdump_3_1641877435/core.nvmesensor.0.db0e4de236a6448e9005e85a0dffb348.1554.1641877432000000 dbus-sensors dbus-sensors-dbg
+ bbdbg_opkg update
+ LD_LIBRARY_PATH=/home/andrew/src/openbmc/openbmc/build/p10bmc/tmp/sysroots-components/x86_64/libsolv-native/usr/lib /home/andrew/src/openbmc/openbmc/build/p10bmc/tmp/sysroots-components/x86_64/opkg-native/usr/bin/opkg -V0 -f /home/andrew/src/openbmc/openbmc/build/p10bmc/tmp/work/p10bmc-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/opkg.conf -o /tmp/bbdbg.375 update
+ bbdbg_opkg install dbus-sensors dbus-sensors-dbg
+ LD_LIBRARY_PATH=/home/andrew/src/openbmc/openbmc/build/p10bmc/tmp/sysroots-components/x86_64/libsolv-native/usr/lib /home/andrew/src/openbmc/openbmc/build/p10bmc/tmp/sysroots-components/x86_64/opkg-native/usr/bin/opkg -V0 -f /home/andrew/src/openbmc/openbmc/build/p10bmc/tmp/work/p10bmc-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/opkg.conf -o /tmp/bbdbg.375 install dbus-sensors dbus-sensors-dbg
+ [ - = obmcdump_3_1641877435/core.nvmesensor.0.db0e4de236a6448e9005e85a0dffb348.1554.1641877432000000 ]
+ echo obmcdump_3_1641877435/core.nvmesensor.0.db0e4de236a6448e9005e85a0dffb348.1554.1641877432000000
+ gdb-multiarch -q -iex set solib-absolute-prefix /tmp/bbdbg.375 -iex add-auto-load-safe-path /tmp/bbdbg.375 /tmp/bbdbg.375/usr/bin/nvmesensor obmcdump_3_1641877435/core.nvmesensor.0.db0e4de236a6448e9005e85a0dffb348.1554.1641877432000000
Reading symbols from /tmp/bbdbg.375/usr/bin/nvmesensor...
Reading symbols from /tmp/bbdbg.375/usr/bin/.debug/nvmesensor...
[New LWP 1554]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/bin/nvmesensor'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x76b88f50 in epoll_wait (epfd=<optimised out>, events=0x7edf1478, maxevents=128, timeout=-1) at ../sysdeps/unix/sysv/linux/epoll_wait.c:30
30 ../sysdeps/unix/sysv/linux/epoll_wait.c: No such file or directory.
(gdb) bt
#0 0x76b88f50 in epoll_wait (epfd=<optimised out>, events=0x7edf1478, maxevents=128, timeout=-1) at ../sysdeps/unix/sysv/linux/epoll_wait.c:30
#1 0x0044adf4 in boost::asio::detail::epoll_reactor::run (ops=..., usec=<optimised out>, this=<optimised out>) at /usr/include/boost/asio/detail/impl/epoll_reactor.ipp:501
#2 boost::asio::detail::scheduler::do_run_one (ec=..., this_thread=..., lock=<synthetic pointer>..., this=0x17b1ea8) at /usr/include/boost/asio/detail/impl/scheduler.ipp:470
#3 boost::asio::detail::scheduler::run (ec=..., this=0x17b1ea8) at /usr/include/boost/asio/detail/impl/scheduler.ipp:204
#4 boost::asio::io_context::run (this=0x7edf1234, this=0x7edf1234) at /usr/include/boost/asio/impl/io_context.ipp:63
#5 main () at ../../../../../../workspace/sources/dbus-sensors/src/NVMeSensorMain.cpp:274
(gdb) quit
+ set +x
3 15:51:10 andrew@mistburn:~/src/openbmc/openbmc-tools/bbdbg (bbdbg) $
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I82f5872742253351c7ac8d25b479ac8194e07afd

show more ...

prepare-emmc-qemu: Use xz or xzdec

This enhances prepare-emmc-qemu to use whichever of the xz or xzdec
commands is available. (It stops if neither is available.)

Tested: Ran successfully under bas

prepare-emmc-qemu: Use xz or xzdec

This enhances prepare-emmc-qemu to use whichever of the xz or xzdec
commands is available. (It stops if neither is available.)

Tested: Ran successfully under bash with xz available.

Signed-off-by: Joseph Reynolds <joseph-reynolds@charter.net>
Change-Id: I3e4e12f8de3b32433d554502db86ca41e8809ff2

show more ...

adcapp: added support for ast2600 platform

In ast2600, ADC engine has two Analog-to-Digital Convertor.
Each one has 8 voltage sensing channels.Current adcapp able to read
device0 only. Adcapp should

adcapp: added support for ast2600 platform

In ast2600, ADC engine has two Analog-to-Digital Convertor.
Each one has 8 voltage sensing channels.Current adcapp able to read
device0 only. Adcapp should read all channel values for ast2600. By
this changes, adcapp tool can be used for both ast2600 and ast2500
bmc platform.

Tested:

Read the raw data from sysfs entry and tried to read the same values
from adcapp,validated on both ast2600 and ast2500 platform.
Adcapp able to read all the channel values.

Signed-off-by: Raghul R <raghulr@ami.com>
Change-Id: I8adec7c784102794a1acb85f2745e92ad3206a2e

show more ...