dbus-pcap: Track method call responses, option to opt out

The filtering was previously strict on how it matched packets, however
this typically isn't what's desired when tracking down method calls:

dbus-pcap: Track method call responses, option to opt out

The filtering was previously strict on how it matched packets, however
this typically isn't what's desired when tracking down method calls:
Ideally we want to output the response as well.

Enable this by maintaining a set of outstanding method calls identified
by the packet's cookie and sender fields (the tuple is unique across
method calls). Once a corresponding reply is found the tuple is removed
from the call set and the packet yielded.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I6b168bf067e4ec93df2626e65b99edf4dccf6e30

show more ...

dbus-pcap: Add values to AlignedStream assertion output

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I020f9db7c8100cbc216d019dbe73c7ae06f8d834

dbus-pcap: Align while processing array elements

But we only want to align if we're still inside the array, so guard the
alignment appropriately.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Cha

dbus-pcap: Align while processing array elements

But we only want to align if we're still inside the array, so guard the
alignment appropriately.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I1a42e504cb93d24e0522387422686adabf9432ea

show more ...

dbus-pcap: Put json output behind --json option

That way we get the pretty output to eyeball by default.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I5c85033792684180a4dc5c1682ed67c1

dbus-pcap: Put json output behind --json option

That way we get the pretty output to eyeball by default.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I5c85033792684180a4dc5c1682ed67c1f34cffb6

show more ...

reboot-ping-pong: Cope with new petitboot PS1

It appears to have removed the path element, so make it optional in the
pexpect regex.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ice5a

reboot-ping-pong: Cope with new petitboot PS1

It appears to have removed the path element, so make it optional in the
pexpect regex.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ice5a253895690edda2d1bef80b010fbcb693f512

show more ...

reboot-ping-pong: Cope with un-encodable output sequences

By dropping them on the floor.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3af6820dd00c7c81b2a3f91853f8f22d55d520ca

New Policy table entries for changed i2c addresses

This update provides new policy table entries for a change in the way
i2c addresses are called out with the latest Open BMC patch set.
Specifically

New Policy table entries for changed i2c addresses

This update provides new policy table entries for a change in the way
i2c addresses are called out with the latest Open BMC patch set.
Specifically this will account for the change from i2c@<addr> to
bus@<addr>. The original entries are left in place for backwards
compatibility.

Signed-off-by: Justin Thaler <thalerj@us.ibm.com>
Change-Id: I55c846066c6297ebec36e3a25e198d5e92788ceb

show more ...

Update mismatched entries in policyTable

This updates the policy table entries for an alert that had event types
mismatched. This now provides consistency.

Signed-off-by: Justin Thaler <thalerj@us.

Update mismatched entries in policyTable

This updates the policy table entries for an alert that had event types
mismatched. This now provides consistency.

Signed-off-by: Justin Thaler <thalerj@us.ibm.com>
Change-Id: Ia6f1a9ebdb06b982c282c2dcc94771614a2798d9

show more ...

Remove doubly used ID from policyTable

The policy table had two different entries using the same event ID. This
patch corrects the issue and creates a new ID.

Signed-off-by: Justin Thaler <thalerj@

Remove doubly used ID from policyTable

The policy table had two different entries using the same event ID. This
patch corrects the issue and creates a new ID.

Signed-off-by: Justin Thaler <thalerj@us.ibm.com>
Change-Id: I05060a76dbc908ed7c9b2c41ff0b331056188131

show more ...

reboot: Add `--wait` option to `obmcutil` invocations

Otherwise we may overlap the poweroff/poweron requests and not get the
desired result.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-I

reboot: Add `--wait` option to `obmcutil` invocations

Otherwise we may overlap the poweroff/poweron requests and not get the
desired result.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ibaf29f423cbfac40eb2d172f9ffb76e8e6aecc8a

show more ...

dbus-pcap: Add SPDX header and copyright

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia82f7799dd06fd8252174c32db983e68ff9d130a

dbus-pcap: A DBus packet parser and matcher for pcap captures

busctl(1) offers a `capture` option that's useful for recording DBus
traffic on a system. The resulting pcap can be loaded into wireshar

dbus-pcap: A DBus packet parser and matcher for pcap captures

busctl(1) offers a `capture` option that's useful for recording DBus
traffic on a system. The resulting pcap can be loaded into wireshark
where it can be analysed, but the wireshark dissector has (had?)
limitations (only parsed header fields and not the body of the packet).

dbus-pcap will parse the pcap using scapy to read the packets, then
implements a dbus wire-format dissector with DBus match expression
support to filter the packet stream according to the supplied match
rules.

Here's an example invocation that extracts IPMI transport messages during the
boot process of an OpenPOWER OpenBMC system:

> $ ./dbus-pcap witherspoon-boot.pcap "type='signal',path='/org/openbmc/HostIpmi/1'"
>
> [[[108, 4, 1, 1, 14, 9982], [[1, "/org/openbmc/HostIpmi/1"], [2, "org.openbmc.HostIpmi"], [3, "ReceivedMessage"], [8, "yyyyay"], [7, ":1.14"]]], [206, 58, 0, 90, [4, 56, 28, 19, 2, 0]]]
> [[[108, 4, 1, 1, 14, 9984], [[1, "/org/openbmc/HostIpmi/1"], [2, "org.openbmc.HostIpmi"], [3, "ReceivedMessage"], [8, "yyyyay"], [7, ":1.14"]]], [207, 58, 0, 90, [4, 57, 125, 16, 2, 0]]]
> [[[108, 4, 1, 1, 14, 9986], [[1, "/org/openbmc/HostIpmi/1"], [2, "org.openbmc.HostIpmi"], [3, "ReceivedMessage"], [8, "yyyyay"], [7, ":1.14"]]], [208, 58, 0, 90, [4, 58, 134, 17, 2, 0]]]

The messages are emitted in JSON form and can be parsed by `jq`.

Zero or more DBus match expressions can be provided. A match occurs when
the current packet matches all rules in an expression, for any
expression supplied on the commandline. If no expressions are provided
then all packets are matched by default. Neither argN nor namespace
match rules are supported in this initial patch.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3130426451207f556f33a17d540d6b32794e8503

show more ...

Fix command output display

When dictionaries were displayed a json formatted blob that was not
pretty was provided. This patch ensures json is pretty printed
again for methods that returned a dictio

Fix command output display

When dictionaries were displayed a json formatted blob that was not
pretty was provided. This patch ensures json is pretty printed
again for methods that returned a dictionary.

Signed-off-by: Justin Thaler <thalerj@us.ibm.com>
Change-Id: I1a272a4283aede29989a2eed98d237fa20eed45a

show more ...

Fix FW list command

This provides a fix for issue #48 where the firmware list command failed
when an image needed to be activated. These images now properly appear
in the "Needs Activated" section.

Fix FW list command

This provides a fix for issue #48 where the firmware list command failed
when an image needed to be activated. These images now properly appear
in the "Needs Activated" section.

Signed-off-by: Justin Thaler <thalerj@us.ibm.com>
Change-Id: Idab7e417d6a127f890d6b5cb154bc0c3aa48d075

show more ...

Reboot ping-pong for OpenPOWER systems

Boot the host, then reboot the BMC and then the host ad infinitum.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ife6eb6372a94aad162f6b2471b7ca7d

Reboot ping-pong for OpenPOWER systems

Boot the host, then reboot the BMC and then the host ad infinitum.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ife6eb6372a94aad162f6b2471b7ca7dbd8538923

show more ...

openbmctool: Add setting thermal control mode

Allows an user a method to enable a supported thermal control mode.
A list of supported thermal control modes are defined available by the
thermal contr

openbmctool: Add setting thermal control mode

Allows an user a method to enable a supported thermal control mode.
A list of supported thermal control modes are defined available by the
thermal control application where a user can set the current mode to any
of those that are supported. Each mode is handled implementation
specific by the thermal control application.

Bumped tool version to 1.13

Tested:
Used to set the current mode on zone 0 of an air cooled wspoon
Error message presented when invalid zone given
Error message given for attempting to set to an unsupported mode

Change-Id: I0969e2dc2c8d6cf861d32e85595d4798dee87d10
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Update OpenBMC tool version to 1.12

This patch updates the version number reported by openbmctool to 1.12.

Change-Id: I1ccd8c741d65f37ff51299451a397d9cb2c1b83f
Signed-off-by: Justin Thaler <thalerj

Update OpenBMC tool version to 1.12

This patch updates the version number reported by openbmctool to 1.12.

Change-Id: I1ccd8c741d65f37ff51299451a397d9cb2c1b83f
Signed-off-by: Justin Thaler <thalerj@us.ibm.com>

show more ...

Overhaul collect_service_data func. for robustness

This update splits the collect service data function into several
functions, each adding the capability to retry a command to the BMC up
to 3 times

Overhaul collect_service_data func. for robustness

This update splits the collect service data function into several
functions, each adding the capability to retry a command to the BMC up
to 3 times. Exception handling has also been improved to ensure whatever
data that can be collected is collected.

Change-Id: If043d50e3d1dd0ea144f35f70608bfda07dcb756
Signed-off-by: Justin Thaler <thalerj@us.ibm.com>

show more ...

Adjust timeout to improve robustness

Adjusts the timeouts for various REST API calls to improve the
robustness of the tool.

Change-Id: I6d18a7b0bd98dc6b331a9e376db23d80fd7ec592
Signed-off-by: Justi

Adjust timeout to improve robustness

Adjusts the timeouts for various REST API calls to improve the
robustness of the tool.

Change-Id: I6d18a7b0bd98dc6b331a9e376db23d80fd7ec592
Signed-off-by: Justin Thaler <thalerj@us.ibm.com>

show more ...

Use requests json parser

Makes a switch to use the requests json parser instead of getting the
text of the response and running it through the json library.
Specifically a requests library bug emerg

Use requests json parser

Makes a switch to use the requests json parser instead of getting the
text of the response and running it through the json library.
Specifically a requests library bug emerges where sometimes the
response.text option returns "<200: OK>" instead of the actual response
from the BMC. This can result in a hang in the json library when trying
to parse that specific string.

Change-Id: If38dfd9572324b57ad6f3bf5b556c83641ebad4b
Signed-off-by: Justin Thaler <thalerj@us.ibm.com>

show more ...

Fix license in RPM spec file

Updates the RPM spec file to call out the Apache 2.0 license and align
with the headers on the code file for openbmctool.

Change-Id: If3bb3f0b038e25417bdb888e06c700bc38

Fix license in RPM spec file

Updates the RPM spec file to call out the Apache 2.0 license and align
with the headers on the code file for openbmctool.

Change-Id: If3bb3f0b038e25417bdb888e06c700bc38e7d253
Signed-off-by: Justin Thaler <thalerj@us.ibm.com>

show more ...

Update results.txt with a current one

Change-Id: I36481330b1a81d014bb406074a728d24abae24b0
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

Add python3 shebang

Python3 is required for this, so add the shebang so that people have a
chance of knowing that.

Tested By:
Launched tool with ./rootfs_size.py and observed that it launched
corre

Add python3 shebang

Python3 is required for this, so add the shebang so that people have a
chance of knowing that.

Tested By:
Launched tool with ./rootfs_size.py and observed that it launched
correctly.

Change-Id: I88f4d6a506809a48f6688a11128536b8eca842a0
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Add command line args and run pep8

Change-Id: Id07ece2431bdaac5465fe751bd146ba1f1208fdd
Signed-off-by: Michael Shepos <shepos@us.ibm.com>

openbmctool: Update 200 status check

The bmcweb REST server doesn't return a '200 OK'
in the response text like the old REST server did,
so just explicitly check the status_code variable.

Tested:

openbmctool: Update 200 status check

The bmcweb REST server doesn't return a '200 OK'
in the response text like the old REST server did,
so just explicitly check the status_code variable.

Tested: Tested on both old and new REST servers

Change-Id: I0813248f05c874e18042ab37552c500ef0ec6112
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...