treewide: lint and format

Run all the latest linters and formatters from openbmc-build-scripts.
These were all robotically generated except for fixes due to
markdownlint warnings.

Signed-off-by: Pa

treewide: lint and format

Run all the latest linters and formatters from openbmc-build-scripts.
These were all robotically generated except for fixes due to
markdownlint warnings.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If16d2fd802a2d452234d8b56b41e79d030138a6b

show more ...

python: fix flake8 warnings and format with black

Most of the flake8 warnings in this repository were fairly trivial,
so fixed them. The "openbmctool" is 7000+ lines of pretty heavily
warned code,

python: fix flake8 warnings and format with black

Most of the flake8 warnings in this repository were fairly trivial,
so fixed them. The "openbmctool" is 7000+ lines of pretty heavily
warned code, so just disabling that one. Format everything with
black.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icb3f6ee9bf03dece58785f7af00617c87a84aa65

show more ...

dbus-vis: Show message arguments in pop-up window

Messages show up in the pop-window like the following:

Message type: sig
Serial : 123456
Sender : :1.234
Destination : <none>
Path

dbus-vis: Show message arguments in pop-up window

Messages show up in the pop-window like the following:

Message type: sig
Serial : 123456
Sender : :1.234
Destination : <none>
Path : /xyz/openbmc_project/sensors/temperature/SomeSensor
Interface : org.freedesktop.DBus.Properties
Member : PropertiesChanged
args[0]: Value, 38.625

This is very convenient for quickly seeing what is in the DBus messages,
and makes debugging certain bugs, for example, sensor-related ones, more
convenient.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I29d52d5b8da315f7de1025b7f266b69ce32edb09

show more ...

dbus-vis: A floating detail info window

Adds a draggable floating window for showing information regarding
highlighted messages.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: If35cdd8962f

dbus-vis: A floating detail info window

Adds a draggable floating window for showing information regarding
highlighted messages.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: If35cdd8962f102934934677d6160a555b56df99c

show more ...

dbus-vis: Fix "display row" upper bound

In this affected line, j should go up to "number of visual lines"
minus 1. This can be more than "this.Intervals.length" due to the
headers.

Signed-off-by: S

dbus-vis: Fix "display row" upper bound

In this affected line, j should go up to "number of visual lines"
minus 1. This can be more than "this.Intervals.length" due to the
headers.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I34b5975fb1b06393427397f7f1d165305243b35a

show more ...

dbus-vis: Fix counts for overlapped entries

For dbus method calls that overlap in time, the Render() routine used to
only report counts from the last row. This has been corrected such that
the sum o

dbus-vis: Fix counts for overlapped entries

For dbus method calls that overlap in time, the Render() routine used to
only report counts from the last row. This has been corrected such that
the sum of the counts from all rows belonging to the same same are added
together.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I6c87a0f52c6ab766ecd452305f989ad819b886a5

show more ...

dbus-vis: bump Electron version from 11.5.0 to 18.2.4

`npm` reports a vulnerability with Electron 11.5.0, bumping to the new
version fixes the vulnerability.

Signed-off-by: Sui Chen <suichen@google

dbus-vis: bump Electron version from 11.5.0 to 18.2.4

`npm` reports a vulnerability with Electron 11.5.0, bumping to the new
version fixes the vulnerability.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I456a8f4f4aeb4d61ddc435341dd94616267e5a47

show more ...

dbus-vis: Use IPC for open file dialog

Previously, the "open file" dialog is opened in the renderer thread
running "initialization.js".

This change moves the dialog to the main thread (main.js) so

dbus-vis: Use IPC for open file dialog

Previously, the "open file" dialog is opened in the renderer thread
running "initialization.js".

This change moves the dialog to the main thread (main.js) so that the
renderer thread emits a "file-request" request and the main thread
answers with a "filename" response.

This IPC paradigm is required for newer versions of Electron, because
the "dialog" module cannot be imported in renderer threads in those
newer versions.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: Ifd324688bb8a4dbdc6a5f86082fb3d205af0d77a

show more ...

dbus-vis: bump electron.js from 8.2.4 to 11.5.0

Dependabot reports a vulnerability with the old version (8.2.4) of
electron.js:

GHSA-mpjm-v997-c4h4
moderate severity
Vulnerable versions: < 11.5.0
P

dbus-vis: bump electron.js from 8.2.4 to 11.5.0

Dependabot reports a vulnerability with the old version (8.2.4) of
electron.js:

GHSA-mpjm-v997-c4h4
moderate severity
Vulnerable versions: < 11.5.0
Patched version: 11.5.0
Impact: This vulnerability allows a sandboxed renderer to request a
"thumbnail" image of an arbitrary file on the user's system. The
thumbnail can potentially include significant parts of the original
file, including textual data in many cases.

Updating electron to 11.5.0 fixes this issue.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I86e5797d689e2b4b3e5643e587dc7ed7e482c659

show more ...

dbus-vis: fix errors and clean up preload.js

This change fixes two errors and does some clean-up:

1. After updating Electron to 11.5.0, "enableRemoteModule: true" is
needed for require('electron').

dbus-vis: fix errors and clean up preload.js

This change fixes two errors and does some clean-up:

1. After updating Electron to 11.5.0, "enableRemoteModule: true" is
needed for require('electron').remote to work.

2. Add handler for stderr in parsing output

Sometimes when a Malformed packet is encountered, the error message does
not get out and the parsing process gets stuck. Adding the handlers can
enable the processes to continue executing in these situations.

3. Removed the unused "preload.js" file.

4. Now clicking the time line after panning the time axis will not cause
an accidental zoom-in to an interval starting with -999.

The cause of this bug is due to HighlightedRegion.t1 being set to the
current mouse location by the OnMouseMove function. This can be
fixed by ensuring that MouseState.hoveredSide must be "timeline".

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: Ib07cf7a33591ee506ab502b206f0351063ef6eea

show more ...

dbus-vis: Initial commit

dbus-vis visualizes PCAP files captured by busctl as well as
text-format outputs from busctl.

dbus-vis displays the visualized results in horizontal
timelines, where each h

dbus-vis: Initial commit

dbus-vis visualizes PCAP files captured by busctl as well as
text-format outputs from busctl.

dbus-vis displays the visualized results in horizontal
timelines, where each horizontal bar represents a DBus request, or
an IPMI request (an IPMI request is a specific kind of DBus request
sent to the IPMI daemon.)
The requests may be grouped by one or more fields including
type, sender, destination, path, interface, member.

In addition, if the BMC console is available, dbus-vis can connect
to the BMC console and capture DBus/IPMI requests in real time.

dbus-vis is in the form of a web page and is wrapped using Electron
to run as a desktop app.

Basic usage:
* Mouse click and drag:
* If mouse is over time axis: drag timeline horizontally
* If mouse is over vertical scroll bar: scroll up/down
* Otherwise: select a region for measuring time & zooming in
* Mouse Scroll wheel:
* If mouse is over time axis: zoom in/out
* Otherwise: scroll up/down
* Click on the expandable headers will expand/collapse the entries under
that particular header.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I863c2ba80025d10efb44fd12868e37912fae9a47

show more ...