test_openbmc_setup.robot: fix format

Changes:
- Fix code directive extraneous * clean up and
code alignment.
Tested:
- Ran from sandbox.

Change-Id: I11d636d4190677455894a5fe776d14456c

test_openbmc_setup.robot: fix format

Changes:
- Fix code directive extraneous * clean up and
code alignment.
Tested:
- Ran from sandbox.

Change-Id: I11d636d4190677455894a5fe776d14456cf65ee9
Signed-off-by: Steven Cho <cho.steven@inventec.com>

show more ...

Update template test suite

Changes:
- Remove legacy REST check test.
- Default to redfish test option
- Add tags

Tested:
- Ran from sandbox

Change-Id: I4fceecd033fa68fe6a1e7e57

Update template test suite

Changes:
- Remove legacy REST check test.
- Default to redfish test option
- Add tags

Tested:
- Ran from sandbox

Change-Id: I4fceecd033fa68fe6a1e7e57a5b54556b256d4f4
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Handle return value in test_openbmc_setup.robot for Test SSH

Added validation for the following cases
- Run script with valid username and password (passing case)
- Run script with valud username an

Handle return value in test_openbmc_setup.robot for Test SSH

Added validation for the following cases
- Run script with valid username and password (passing case)
- Run script with valud username and empty password (faling case)

Tested: Run robot templates/test_openbmc_setup.robot

Signed-off-by: Utpal Patel <utpalp@ami.com>
Change-Id: I4b781fcff0c9addf9a7f005e139c7508654711ce

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Signed-off-by: Patric

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I584c76da2eb35af2177a97d5cd4b882f9881fb80

show more ...

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or
# Once this commit is merged.
pip3 install -r requirements.txt

Version latest:
robotframework-requests 0.9.3

Refer Documentation:
https://marketsquare.github.io/robotframework-requests/doc/RequestsLibrary.html

What is not changed:
- The test cases under directory tests/ is not modified and is
deprecated but you can continue using it with older package
and configuration using

git clone -b v3.0-stable https://github.com/openbmc/openbmc-test-automation

Tested:
Upstream HW_CI test list, firmware code update and few other
test suite like ipmi, certificate, dumps, ffdc and redfish
test suites.

Note: I have not tested end to end, so it is likely there could be
grey areas where it could fail but should be minor w.r.t
response data format.

Resolves: openbmc/openbmc-test-automation#2105

Change-Id: Ie03b25ff88948bcccb09e9d82f8da86e28c92697
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Test setup template to skip REST vs redfish

The 'Skip If' keyword is in higher level
robotframework 4.1.3

Resolves openbmc/openbmc-test-automation#2175

Change-Id: Ib1edb2ed8bb76973abde41fecd17db6

Test setup template to skip REST vs redfish

The 'Skip If' keyword is in higher level
robotframework 4.1.3

Resolves openbmc/openbmc-test-automation#2175

Change-Id: Ib1edb2ed8bb76973abde41fecd17db6b2697e752
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add check for test setup template execution

Changes:
- REST and Redfish unliekly to work at the same time.
- Skip the check based on if it supports REST or Redfish

Resolves: openbmc/openbmc

Add check for test setup template execution

Changes:
- REST and Redfish unliekly to work at the same time.
- Skip the check based on if it supports REST or Redfish

Resolves: openbmc/openbmc-test-automation#2170
Change-Id: I87928eb146463ba37147d64444d52d2f846eb3a6
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
py

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Minor changes to python_pgm_template

Change-Id: Ia27858a0b3d45fba263c1b6725f8c2271231f12c
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

python_pgm_template exit_function fix

It is not correct for exit_function to have arguments since no
arguments are ever passed to it.

Change-Id: I4981e6071927e0ec8cb3337d2487a4bd61857777
Signed-off

python_pgm_template exit_function fix

It is not correct for exit_function to have arguments since no
arguments are ever passed to it.

Change-Id: I4981e6071927e0ec8cb3337d2487a4bd61857777
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Robot coding guideline fixes

Changes:
- Remove excessive new line entries.
- Fix line char 110 exceeding.

Change-Id: I06d99185d1507c704bd77d1b6998ed29b8df2e4e
Signed-off-by: George Keishing

Robot coding guideline fixes

Changes:
- Remove excessive new line entries.
- Fix line char 110 exceeding.

Change-Id: I06d99185d1507c704bd77d1b6998ed29b8df2e4e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

OpenBMC Test setup test suite for readiness update

Changes:
- Added Redfish test.
- Restructure to individual test cases to isolate failures
during execution.

Change-Id: Id1f2908390b6932

OpenBMC Test setup test suite for readiness update

Changes:
- Added Redfish test.
- Restructure to individual test cases to isolate failures
during execution.

Change-Id: Id1f2908390b6932d0b8f02beb2a9bd1c85f02fc4
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Code spell typo fix

Change-Id: I85d799ab664fe4af3cff32a89c2f7f0c635275f3
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Change several python and robot files to 110 chars

Taking advantage of current team limit of 110 chars.

Change-Id: If7ab51fe894889967b8c8bb2f2fa4664f01117d5
Signed-off-by: Michael Walsh <micwalsh@u

Change several python and robot files to 110 chars

Taking advantage of current team limit of 110 chars.

Change-Id: If7ab51fe894889967b8c8bb2f2fa4664f01117d5
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Improved py template

- General streamlining
- exit_function: New comments to indicate that this function is
optional
- signal_handler: Removed this function. This is now handled by
gen_args' g

Improved py template

- General streamlining
- exit_function: New comments to indicate that this function is
optional
- signal_handler: Removed this function. This is now handled by
gen_args' gen_signal_handler.
- validate_parms: New comments to indicate that this function is
optional
- Replaced old calls with a single call to gen_setup().

Change-Id: I8b19ea4242429330ec8a989269ea1fa5043bed26
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

pgm_template change print to qprint

Change-Id: I318fdec45f5fa20481de156ed901deec28f70731
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Add gen_robot_valid.py to pgm_template.robot

Change-Id: Ia36270ce1abbf545020c2ee22e6f91b9bb66d88b
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Change Rvalid to Valid

Change all references to keywords like "Rvalid Values" to "Valid Values".
"Rvalid Values" has been deprecated.

Change-Id: I1b418fa69e5753c8bfb9e6a06a8b566359e10cae
Signed-off

Change Rvalid to Valid

Change all references to keywords like "Rvalid Values" to "Valid Values".
"Rvalid Values" has been deprecated.

Change-Id: I1b418fa69e5753c8bfb9e6a06a8b566359e10cae
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

pgm_template: Resource bmc_redfish_resource.robot

Most programs now use redfish so adding bmc_redfish_resource.robot to
template.

Change-Id: Ibef98577482289e21409e53141f214eaff328916
Signed-off-by:

pgm_template: Resource bmc_redfish_resource.robot

Most programs now use redfish so adding bmc_redfish_resource.robot to
template.

Change-Id: Ibef98577482289e21409e53141f214eaff328916
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Alter main doc string for python_pgm_template

Change-Id: I068a2acbc53c60d5048807765b694ba5ffae9f0f
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Replace resource.txt with resource.robot

Change-Id: I4d2afd35645880e33a31644cd717bbeae55666f0
Signed-off-by: Sandhya Somashekar <sansomas@in.ibm.com>

Enforced robotframework standards.

- The standards are enforced using the rflint static anylysis tool.
- More standards will be added in future commits but this is a base
starting point.

Change-I

Enforced robotframework standards.

- The standards are enforced using the rflint static anylysis tool.
- More standards will be added in future commits but this is a base
starting point.

Change-Id: I7dd8a2b0b42a51327b748cb730609d7ee2538de3
Signed-off-by: Joy Onyerikwu <onyekachukwu.joy.onyerikwu@ibm.com>

show more ...