Add ERROR_RESPONSE_MSG for user specific message

Changes:
- Added ERROR_RESPONSE_MSG variable for user
to key in the string.

Tested:
- Ran from the sandbox with the changes

Resolves

Add ERROR_RESPONSE_MSG for user specific message

Changes:
- Added ERROR_RESPONSE_MSG variable for user
to key in the string.

Tested:
- Ran from the sandbox with the changes

Resolves openbmc/openbmc-test-automation#2249

Change-Id: I677fa335bd97327dac952ab62a14fb9d95ec8b26
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add re-try for redfish GET request for targets

Changes:
- This retries is added to improve the success rate
for the GET request in case returns JSON errors
for the following URI duri

Add re-try for redfish GET request for targets

Changes:
- This retries is added to improve the success rate
for the GET request in case returns JSON errors
for the following URI during operation
/redfish/v1/Systems/ and /redfish/v1/Managers/

- Added other places in code to handle exceptions.
- Fix IPMI import paths in test suite

Tested:
- Ran from sandbox.

Change-Id: Ie37dbdd9c7572e0003a56e65a7b5f0a4c3b26a1a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf30

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf305754b247b995a05d8da3b9de9ed613ecae2
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

Fix for redfishtool certificate, snmp and session management

Changes:
- Set cert_id as test variable
- Remove colon in snmp destination when the snmp port is empty
- Fix redfish_delete_session

Fix for redfishtool certificate, snmp and session management

Changes:
- Set cert_id as test variable
- Remove colon in snmp destination when the snmp port is empty
- Fix redfish_delete_sessions assign location
- Set REDFISH_DELETE_SESSIONS to 0 in suite setup
- Set REDFISH_DELETE_SESSIONS back to 1 in suite teardown

Tested:
- redfish/service_root/test_sessions_management.robot
- redfish/dmtf_tools/test_redfishtool_certificate.robot
- redfish/events/test_bmc_snmp_trap.robot

Change-Id: Ibb16d52b5874484f8cf169456e2feb4ba7593e71
Signed-off-by: Wilson Suen <wilsons@supermicro.com>

show more ...

Set system, chassis, and bmc as global variables

Changes:
- Add SYSTEM_ID as a global variable and set to default value system
- Replace redfish/v1/Systems/system to redfish/v1/Systems/SYSTEM_ID

Set system, chassis, and bmc as global variables

Changes:
- Add SYSTEM_ID as a global variable and set to default value system
- Replace redfish/v1/Systems/system to redfish/v1/Systems/SYSTEM_ID
- Replace redfish/v1/Chassis/chassis to redfish/v1/Chassis/CHASSIS_ID
- Replace redfish/v1/Managers/bmc to redfish/v1/Managers/MANAGER_ID

Tested:
- Tested on sandbox with the changes with sample test run with
sample test ID runs
1. without SYSTEM_ID provided
2. with -v SYSTEM_ID:system1
3. with export SYSTEM_ID=""
3. with export SYSTEM_ID="system2"

Change-Id: Ifc412b20038cef1eba632caaa6c300be328259bd
Signed-off-by: Wilson Suen <wilsons@supermicro.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add missing HTTPS_PORT reference

Without this reference all tests in this section fail
on non-standard ports.

Change-Id: I90db7c345d35f328d875fe4fad1791c563f73600
Signed-off-by: Matt Fischer <matth

Add missing HTTPS_PORT reference

Without this reference all tests in this section fail
on non-standard ports.

Change-Id: I90db7c345d35f328d875fe4fad1791c563f73600
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

Add new force tags for test suites

Comments:
- Added new tags for the test suites

Tested:
- NA

Change-Id: Ibd7eb9e821290c44bd1255d47a52e596e6135cbf
Signed-off-by: George Keishing <gkeishin@i

Add new force tags for test suites

Comments:
- Added new tags for the test suites

Tested:
- NA

Change-Id: Ibd7eb9e821290c44bd1255d47a52e596e6135cbf
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

HTTPS response header security update changes

Refer: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/64205
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection
Changes:

HTTPS response header security update changes

Refer: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/64205
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection
Changes:
- Update the HTTPS response header paramters for checking

Tested:
- Upstream build and ran from sandbox changes

Change-Id: I4ce367a812d4843c1e4c961ca0a804b8b8c76105
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot
- Replaced all the Managers/bmc to Managers/${MANAGER_ID} across all the scripts
- Also in data/variables.py updated chassis id for the few redfish uri.

Tested:
- Ran All The Scripts Successfully

Change-Id: Iff3673aae27657e0799dec5cb94c1651a0cd5d18
Signed-off-by: ganesanb <ganesanb@ami.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Handled delete redfish sessions while rebooting the bmc

Changes:
- In suite setup disable the delete redfish session while reboot the bmc.
- In suite teardown enable the delete redfish sessi

Handled delete redfish sessions while rebooting the bmc

Changes:
- In suite setup disable the delete redfish session while reboot the bmc.
- In suite teardown enable the delete redfish session while reboot the bmc.

Tested:
- Ran All The Scripts Successfully

Change-Id: Icba0e9ab99142e34f4288c2c0156605b17445027
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

Clean up robot test suite imports

Changes:
- Remove resource file import to prevent cyclic reference

Tested:
- Ran test suites to check they are working.

Change-Id: I492b6eeda0023a515627

Clean up robot test suite imports

Changes:
- Remove resource file import to prevent cyclic reference

Tested:
- Ran test suites to check they are working.

Change-Id: I492b6eeda0023a5156274653d7db13e7f127822c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c8895

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c88953
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Created a seperate test case for operator user

Changes:
- Moved operator user related test out of
Create_Session_And_Verify_Response_Code_Using_Different_Credentials
test case and

Created a seperate test case for operator user

Changes:
- Moved operator user related test out of
Create_Session_And_Verify_Response_Code_Using_Different_Credentials
test case and added a new seperate test case for it
- This is done to skip operator user-related test

Tested: - Ran both the old and new test cases and they passed

Change-Id: Id03850e7ea4770a1d3c16ec32efac5f21c39b14a
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>

show more ...

Add code to handle response errors

Changes:
- Added new message response
- Add logic to except all errors and verify the message

Version Tessted:
redfish 3.1.6

Add code to handle response errors

Changes:
- Added new message response
- Add logic to except all errors and verify the message

Version Tessted:
redfish 3.1.6
redfish 3.1.7

Tested:
- Tested test case Redfish_Login_With_Invalid_Credentials
from suite redfish/service_root/test_service_root_security.robot

Resolves openbmc/openbmc-test-automation#2195

Change-Id: I13ff4bb9e6029f1039e9b8fea6d98f02329eb081
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Skip operator user based on SKIP_OPERATOR_USER value

Changes:
- Added a logic to skip operator user based on
SKIP_OPERATOR_USER value

Tested:
- Ran test_sessions_management.robot suit

Skip operator user based on SKIP_OPERATOR_USER value

Changes:
- Added a logic to skip operator user based on
SKIP_OPERATOR_USER value

Tested:
- Ran test_sessions_management.robot suite from sandbox

Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>
Change-Id: I033c7575f519bf6492ea2858876bfda48f55f838

show more ...

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or
# Once this commit is merged.
pip3 install -r requirements.txt

Version latest:
robotframework-requests 0.9.3

Refer Documentation:
https://marketsquare.github.io/robotframework-requests/doc/RequestsLibrary.html

What is not changed:
- The test cases under directory tests/ is not modified and is
deprecated but you can continue using it with older package
and configuration using

git clone -b v3.0-stable https://github.com/openbmc/openbmc-test-automation

Tested:
Upstream HW_CI test list, firmware code update and few other
test suite like ipmi, certificate, dumps, ffdc and redfish
test suites.

Note: I have not tested end to end, so it is likely there could be
grey areas where it could fail but should be minor w.r.t
response data format.

Resolves: openbmc/openbmc-test-automation#2105

Change-Id: Ie03b25ff88948bcccb09e9d82f8da86e28c92697
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Added new cases for Redfish session service

Testcases added:
- Set Session Timeout And Verify Session deleted After Timeout.
Set session timeout and create a new session, wait for the

Added new cases for Redfish session service

Testcases added:
- Set Session Timeout And Verify Session deleted After Timeout.
Set session timeout and create a new session, wait for the configured
timeout value and verify the created session deleted in redfish/v1/Session/Sessions
URI.

- Verify Session Login And Logout for Newly created User.
Create a new session for newly created user and verify we can able
to access the redfish URI's via that created session and logut of that session.

Modified cases:
- Added a new keyword to get Default session timeout value and
configured default timeout value on Teardown.

Tested : Run robot redfish/serive_root/test_session_management.robot

Signed-off-by: Nagarjun B <nagarjunb@ami.com>
Change-Id: Iaca7026fbf72227e5b025b7b9d0c46862edc196a

show more ...

Replace CSP plugin-types directive with object-src

The HTTP Content-Security-Policy (CSP) plugin-types directive has been
marked as deprecated and suggests set object-src none to disallow
plugins.

Replace CSP plugin-types directive with object-src

The HTTP Content-Security-Policy (CSP) plugin-types directive has been
marked as deprecated and suggests set object-src none to disallow
plugins.

Signed-off-by: Brian Ma <chma0@nuvoton.com>
Change-Id: Ie532deeb8d8cb0d1de275b5d864bd20dc5f11ce7

show more ...

Fix test cases name tags under redfish directory

Change-Id: Icec85bd3b11f541c185a9242191096774d04290e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Fix typo in tags used in test suites

Resolves openbmc/openbmc-test-automation#2149

Change-Id: I0d05267743acb4ee5283717a253cb11665659920
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Remove / base path for hypermedia URL

Refer: https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/46057

Change-Id: I52dfeb0f73bebcdd70d408e08926ae1b2cf7e7cc
Signed-off-by: George Keishing <gkeish

Remove / base path for hypermedia URL

Refer: https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/46057

Change-Id: I52dfeb0f73bebcdd70d408e08926ae1b2cf7e7cc
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Removal of test case

changes:
- REST Logging Interface Read Should Be A SUCCESS For Authorized Users

Change-Id: I83f9c3844ee0d60ddf69b200b0ebade276070df7
Signed-off-by: Sushil Singh <susilsi7@i

Removal of test case

changes:
- REST Logging Interface Read Should Be A SUCCESS For Authorized Users

Change-Id: I83f9c3844ee0d60ddf69b200b0ebade276070df7
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

redfish: service_root: security: fix security headers requirement for Level2 Directives

Symptom:
"Login And Verify HTTP Response Header" test item got failed.

Root cause:
Due to bmcweb add "Content

redfish: service_root: security: fix security headers requirement for Level2 Directives

Symptom:
"Login And Verify HTTP Response Header" test item got failed.

Root cause:
Due to bmcweb add "Content-Security-Policy(CSP)" to Level2 Directives.
However, the headers requriement didn't sync to Level2 Directives from bmcweb.

Solution:
Modify "Content-Security-Policy" of header_requirements for Level2 Directives.

Tested:
robot -t Login_And_Verify_HTTP_Response_Header redfish/service_root/test_service_root_security.robot
Test Service Root Security :: Test Redfish service root login secu... | PASS |
1 test, 1 passed, 0 failed

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: I3a983ac72db1915401f4793ea3c7897bb5e8f0dd

show more ...

Fix syntax and typo errors

Change-Id: Ie80a2abfb027a9977f0f5f9290c722c2ff288f37
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

rflint check warning and errors clean up

Fixing the documentation and test code for:
- exceeds 110 characters (LineTooLong)
- TrailingWhitespace
- RequireTestDocumentation
- Duplicat

rflint check warning and errors clean up

Fixing the documentation and test code for:
- exceeds 110 characters (LineTooLong)
- TrailingWhitespace
- RequireTestDocumentation
- DuplicateTestNames

Change-Id: Ia173888ed709ac7bd3511654bf89c822bc47e398
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...