Set system, chassis, and bmc as global variables

Changes:
- Add SYSTEM_ID as a global variable and set to default value system
- Replace redfish/v1/Systems/system to redfish/v1/Systems/SYSTEM_ID

Set system, chassis, and bmc as global variables

Changes:
- Add SYSTEM_ID as a global variable and set to default value system
- Replace redfish/v1/Systems/system to redfish/v1/Systems/SYSTEM_ID
- Replace redfish/v1/Chassis/chassis to redfish/v1/Chassis/CHASSIS_ID
- Replace redfish/v1/Managers/bmc to redfish/v1/Managers/MANAGER_ID

Tested:
- Tested on sandbox with the changes with sample test run with
sample test ID runs
1. without SYSTEM_ID provided
2. with -v SYSTEM_ID:system1
3. with export SYSTEM_ID=""
3. with export SYSTEM_ID="system2"

Change-Id: Ifc412b20038cef1eba632caaa6c300be328259bd
Signed-off-by: Wilson Suen <wilsons@supermicro.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Added variable for keyword timeout

Changes:
- Added variable for keyword timeout

Tested:
- Ran successfully
Redfish Get States.

Change-Id: I040fec611c48340901b7f2adc7d3a4a4639850e1
Sign

Added variable for keyword timeout

Changes:
- Added variable for keyword timeout

Tested:
- Ran successfully
Redfish Get States.

Change-Id: I040fec611c48340901b7f2adc7d3a4a4639850e1
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

Added keywords for dump and BMC state

Changes:
- Added keyword
"Redfish Get All System Dumps"
"Redfish Verify BMC State"

Tested:
- Ran successfully
Redfish Get All System Dumps

Added keywords for dump and BMC state

Changes:
- Added keyword
"Redfish Get All System Dumps"
"Redfish Verify BMC State"

Tested:
- Ran successfully
Redfish Get All System Dumps
Redfish Verify BMC State

Change-Id: Iaf0b1fac7adf17300a0a2bec4a80943a3a7d00f7
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

Added OSRunning value for expected boot state

Changes:
- Added default argument value as OSRunning for expected boot state.

Tested:
- Ran successfully
Wait For Host Boot Progress T

Added OSRunning value for expected boot state

Changes:
- Added default argument value as OSRunning for expected boot state.

Tested:
- Ran successfully
Wait For Host Boot Progress To Reach Required State.

Change-Id: I6f0b5259a1ee963ac6b57a46fb197b5f039defaa
Signed-off-by: praphullasuresh <Praphulla.S@ibm.com>

show more ...

Wait for boot progress till required state

Changes:
- Added keyword
Wait For Boot Progress To Reach Required State.

Tested:
- Ran successfully
Wait For Boot Progress To Reach Requir

Wait for boot progress till required state

Changes:
- Added keyword
Wait For Boot Progress To Reach Required State.

Tested:
- Ran successfully
Wait For Boot Progress To Reach Required State.

Change-Id: I3f3bf524b5eaeaad24813bfa49d9fb688152d42e
Signed-off-by: praphullasuresh <Praphulla.S@ibm.com>

show more ...

Modified Is BMC Operational Keyword

Changes:
- Added sleep time to handle redfish.login
- Added redfish.login
- Added code to get bmc status from redfish managers uri.

Tested:
- Ra

Modified Is BMC Operational Keyword

Changes:
- Added sleep time to handle redfish.login
- Added redfish.login
- Added code to get bmc status from redfish managers uri.

Tested:
- Ran All The Scripts Successfully

Change-Id: I68e05c527be0cde074ea8d697a83153be4f1998a
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot
- Replaced all the Managers/bmc to Managers/${MANAGER_ID} across all the scripts
- Also in data/variables.py updated chassis id for the few redfish uri.

Tested:
- Ran All The Scripts Successfully

Change-Id: Iff3673aae27657e0799dec5cb94c1651a0cd5d18
Signed-off-by: ganesanb <ganesanb@ami.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Verify BMC not in quiesced state

Changes:
- "Is BMC Not Quiesced" keywords is used
to check the BMC is not in Quiesced
state.
- Added keywords
"Match State Boot Progress State"

Verify BMC not in quiesced state

Changes:
- "Is BMC Not Quiesced" keywords is used
to check the BMC is not in Quiesced
state.
- Added keywords
"Match State Boot Progress State"
"Is BMC Not Quiesced"

Tested:
- Tested keywords

Change-Id: I90559eed6405f4fc80703754e5afa00b5ebaae6d
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

Keyword for checking Host state

Changes:
- Added a new keyword to check the host state

Tested:
- Tested on sandbox with changes to check the state.


Change-Id: Ic7c6d7cdf1e3ab3c627a0067969

Keyword for checking Host state

Changes:
- Added a new keyword to check the host state

Tested:
- Tested on sandbox with changes to check the state.


Change-Id: Ic7c6d7cdf1e3ab3c627a00679694cc7d43b339be
Signed-off-by: Sagar Anand <sagaranand@in.ibm.com>

show more ...

Increased the wait time for BMC standby state

Changes:
- On some system, BMC is taking 3 mins time to reach BMC
standby state. So increase the wait time to 5 mins.

Tested: - Ran Redfish

Increased the wait time for BMC standby state

Changes:
- On some system, BMC is taking 3 mins time to reach BMC
standby state. So increase the wait time to 5 mins.

Tested: - Ran Redfish_BMC_Manager_ForceRestart_When_Host_Off test
from sandbox successfully. This test was failing earlier.
Change-Id: Idbccb2744f22686f6ecc46569ffab41ac551a33d
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>

show more ...

Remove IPMI resource import

Changes:
- Remove import lib/ipmi_client.robot as this code does not
use IPMI related keywords. Any suites importing utils.robot
ends up IPMI pre check

Remove IPMI resource import

Changes:
- Remove import lib/ipmi_client.robot as this code does not
use IPMI related keywords. Any suites importing utils.robot
ends up IPMI pre check at the start of the test run.

Tested:
Ran test few suites and FFDC to make sure it does not break
basic test functions in general.

Change-Id: Ida792aa7c022c3256cdd8941e15516751d3068de
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

BIOS: Create API to set fw_boot_side value.

Changes:

-- Added three new keywords as mentioned below.

- Switch BIOS Attribute Firmware Boot Side
- Is Boot Progress At Any State
- Is Boot Progres

BIOS: Create API to set fw_boot_side value.

Changes:

-- Added three new keywords as mentioned below.

- Switch BIOS Attribute Firmware Boot Side
- Is Boot Progress At Any State
- Is Boot Progress At Required State

Tested:

Created a unit testcase and verified on BMC environment.

Change-Id: I37cb070fb1269c5d90cc1cbe3906f04262a2334d
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

show more ...

Removed unwanted keywords on lib/utils.robot

PLDM Get BIOS Attribute keyword has some unwanted keyword which was mistakenly added, Hence removed.

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-I

Removed unwanted keywords on lib/utils.robot

PLDM Get BIOS Attribute keyword has some unwanted keyword which was mistakenly added, Hence removed.

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: Ic47f1ad39fec94cddd72bb690390b1ae8fc2875d

show more ...

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or
# Once this commit is merged.
pip3 install -r requirements.txt

Version latest:
robotframework-requests 0.9.3

Refer Documentation:
https://marketsquare.github.io/robotframework-requests/doc/RequestsLibrary.html

What is not changed:
- The test cases under directory tests/ is not modified and is
deprecated but you can continue using it with older package
and configuration using

git clone -b v3.0-stable https://github.com/openbmc/openbmc-test-automation

Tested:
Upstream HW_CI test list, firmware code update and few other
test suite like ipmi, certificate, dumps, ffdc and redfish
test suites.

Note: I have not tested end to end, so it is likely there could be
grey areas where it could fail but should be minor w.r.t
response data format.

Resolves: openbmc/openbmc-test-automation#2105

Change-Id: Ie03b25ff88948bcccb09e9d82f8da86e28c92697
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Redfish code update changes

Changes:
- Added task state in json file
data/task_state.json
- Added Keyword Create List Of Task,
Create Initiated Task State Dict,
Match Target URI

Redfish code update changes

Changes:
- Added task state in json file
data/task_state.json
- Added Keyword Create List Of Task,
Create Initiated Task State Dict,
Match Target URI,
Check Task With Match TargetUri,
Verify Task Progress State
- Added Keyword Get Task State From File

Tested:
Ran succesfully redfish/
update_service/test_redfish_bmc_code_update.robot

Change-Id: Iba2131925cb60614f456cbf5ec91b1b02bddc06b
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

Added validation for power operation testcases using LDAP user.

Added code to check the host state after power operation and wait
until the host is up for power on.

Moved Redfish.Login to Test Tear

Added validation for power operation testcases using LDAP user.

Added code to check the host state after power operation and wait
until the host is up for power on.

Moved Redfish.Login to Test Teardown, to make the next testcase execute
with root user.

Added code to delete all redfish session in suite teardown.

Tested: Run robot redfish/account_service/test_ldap_configuration.robot

Signed-off-by: agarjun B <nagarjunb@ami.com>
Change-Id: Iaafe0657d41a82be067c1ea91fe02ef995567394

show more ...

Added condition to validate x86 platform

Signed-off-by: Aravinth R <aravinthr@ami.com>
Change-Id: I52ce6dbecb453f406bb070f62029272e6776dd9d

Changes in ipmi/test_ipmi_cold_reset.robot

Test Case

- Verify Cold Reset Impact On Sensor Threshold Via IPMI

Modified test case to avoid discrete sensor while selecting sensor

Changes in ipmi/test_ipmi_cold_reset.robot

Test Case

- Verify Cold Reset Impact On Sensor Threshold Via IPMI

Modified test case to avoid discrete sensor while selecting sensor random.
Added condition to avoid the sensor which didn't have single threshold value.
Added Ping Host keyword in Is BMC Operational Keyword on lib/ipmi_client.robot.

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: Iec4f65e42c9a4c7de7cab757401f5338f8e860e8

show more ...

Support to set and get BIOS attribute via pldmtool

Changes:
- Added keyword to set and get BIOS attribute using
pldmtool

++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Example

Support to set and get BIOS attribute via pldmtool

Changes:
- Added keyword to set and get BIOS attribute using
pldmtool

++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Example on how to use this new keywords:
++++++++++++++++++++++++++++++++++++++++++++++++++++++++
$ cat redfish/sample.robot
*** Settings ***
Resource ../lib/resource.robot
Resource ../lib/utils.robot

*** Test Cases ***

Test BIOS Example

${pldm_resp}= PLDM Get BIOS Attribute fw_boot_side
Log To Console ${pldm_resp}

PLDM Set BIOS Attribute fw_boot_side Perm

${pldm_resp}= PLDM Get BIOS Attribute fw_boot_side
Log To Console ${pldm_resp}

PLDM Set BIOS Attribute fw_boot_side Temp

${pldm_resp}= PLDM Get BIOS Attribute fw_boot_side
Log To Console ${pldm_resp}

++++++++++++++++++++++++++++++++++++++++++++++++++++++++

++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Example output of the above test sample code run:
++++++++++++++++++++++++++++++++++++++++++++++++++++++++

==============================================================================
Sample
==============================================================================
Test BIOS Example
root@xx.xx.xx.xx:~#
{
"CurrentValue": "Temp"
}
.{'CurrentValue': 'Temp'}
.#(CDT) 2022/05/19 10:45:19.445616 - 0.086554 - Issuing: pldmtool bios SetBIOSAttributeCurrentValue -a fw_boot_side -d Perm
{
"Response": "SUCCESS"
}
{
"CurrentValue": "Perm"
}
.#(CDT) 2022/05/19 10:45:22.940009 - 0.117587 - Issuing: pldmtool bios GetBIOSAttributeCurrentValueByHandle -a fw_boot_side
{
"CurrentValue": "Perm"
}
.{'CurrentValue': 'Perm'}
.#(CDT) 2022/05/19 10:45:23.203642 - 0.086487 - Issuing: pldmtool bios SetBIOSAttributeCurrentValue -a fw_boot_side -d Temp
{
"Response": "SUCCESS"
}
{
"CurrentValue": "Temp"
}
.#(CDT) 2022/05/19 10:45:26.669550 - 0.112921 - Issuing: pldmtool bios GetBIOSAttributeCurrentValueByHandle -a fw_boot_side
{
"CurrentValue": "Temp"
}
.{'CurrentValue': 'Temp'}
Test BIOS Example | PASS |
------------------------------------------------------------------------------
Sample | PASS |
1 test, 1 passed, 0 failed
==============================================================================

Change-Id: If24ad6fd61b4f9a6dcb8015aaec3ddd6d2a853b0
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Wait on the BootProgress state change

Changes:
- New keyword for Boot Progress change
- Remove the explicit sleep
- Wait on BootProgress changed from None

Change-Id: I336557de61c3f97

Wait on the BootProgress state change

Changes:
- New keyword for Boot Progress change
- Remove the explicit sleep
- Wait on BootProgress changed from None

Change-Id: I336557de61c3f97879dde577bb121f583d6b640f
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Host inid reset boot table and wait changes

Changes:
- bmc_reboot:1 directive to check for wait and change state
- Remove ping check from utils code for host reset

Change-Id: Iab24927570e9a

Host inid reset boot table and wait changes

Changes:
- bmc_reboot:1 directive to check for wait and change state
- Remove ping check from utils code for host reset

Change-Id: Iab24927570e9ad0cc8f8bf4c02941b20efc74be4
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Enforce BMC redfish state for BMC reset

Changes:
- Added directive in boot table for BMC state check
on BMC reset.
- remove 3 minute wait for ping and let state check
take over i

Enforce BMC redfish state for BMC reset

Changes:
- Added directive in boot table for BMC state check
on BMC reset.
- remove 3 minute wait for ping and let state check
take over it.

Change-Id: I17c76beec01130c8a64a4baf8940d82a0d491d7c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add BIOS attribute patch setting keyword

Change-Id: Ie84ed7e525db90ff921223d2d215f116b888e621
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Added new script to verify the IPMI KCS cmd.

created a testcase to run the IPMI KCS cmd overnight.

Created Resource file for KCS interface commands which
contains few of the IPMI commands to verify

Added new script to verify the IPMI KCS cmd.

created a testcase to run the IPMI KCS cmd overnight.

Created Resource file for KCS interface commands which
contains few of the IPMI commands to verify Kcs interface.

We can add other ipmi cmds in future.

Added IPMI raw commands in ipmi_raw_cmd_table.py

Added "Is BMC Operational" keyword instead of Sleep time,
to verify BMC is enabled via redfish.

Tested: Run robot /ipmi/test_ipmi_kcs.robot

Signed-off-by: Nagarjun B <nagarjunb@ami.com>
Change-Id: I59f1515792ab99fb5d1f55566ea3c0fcfcc2942b

show more ...

Get BIOS attribute keyword

Returns BIOS attribute dictionary.

Change-Id: I9c71a6a304ca09856b7ca7b0fa7283fdd2ce36eb
Signed-off-by: George Keishing <gkeishin@in.ibm.com>