NETWORK: In network_diagnostic_report.robot mtr --report output was in bytes

Changes:

- In network_diagnostic_report.robot mtr --report command output was in bytes but script expects in string.S

NETWORK: In network_diagnostic_report.robot mtr --report output was in bytes

Changes:

- In network_diagnostic_report.robot mtr --report command output was in bytes but script expects in string.So changed the format
by adding "out_buf = out_buf.decode("utf-8")" in lib/utilities.py

Tested:

- Ran network/network_diagnostic_report.robot script Successfully

Change-Id: I8100035ef24ff654982f4b3b7462b56ae3b72fe5
Signed-off-by: manimozhik <manimozhik@ami.com>

show more ...

Fan control dump utility

Changes:
- Add code to dump and get attributes from
fan config JSON file generated dump.
- Add python function to walk the nested dictionary
to find the matc

Fan control dump utility

Changes:
- Add code to dump and get attributes from
fan config JSON file generated dump.
- Add python function to walk the nested dictionary
to find the matched key.

Tested:
- Test on sandbox with sample test code calling it.

Robot code example:
${holds_data}= Get Fan Attribute Value target_holds
Should Be Empty ${holds_data}
${locks_data}= Get Fan Attribute Value target_locks
Should Be Empty ${locks_data}

Change-Id: Idae5f1d06331cd20f2d689a910efcea9251544a2
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Pylint warning and error fix

Changes:
- import orders and remove unused import module
- doctring changes

Tested: python3 -m pylint lib/utilities.py
There are other warnings still.

Ch

Pylint warning and error fix

Changes:
- import orders and remove unused import module
- doctring changes

Tested: python3 -m pylint lib/utilities.py
There are other warnings still.

Change-Id: I913806ac5ae02f13068940a166405c1b9328c52d
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update test tag and typo fixes in test scripts

Changes:
- Fix tag mismatch with test cases
- Fix typo in code documentation

Tested:
Checked with codespell and tag checker tool.

C

Update test tag and typo fixes in test scripts

Changes:
- Fix tag mismatch with test cases
- Fix typo in code documentation

Tested:
Checked with codespell and tag checker tool.

Change-Id: I4de23c9225cdd46ffa8868e94e0d8d4a410853f4
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Added new testcase for Get SDR info and Reserve SDR IPMI Commands

Modified Get SDR info testcase to verify supported commands dynamically,
rather than harcoded values.

Testcase Added:
- Test Re

Added new testcase for Get SDR info and Reserve SDR IPMI Commands

Modified Get SDR info testcase to verify supported commands dynamically,
rather than harcoded values.

Testcase Added:
- Test Reserve SDR repository.
- Verify Reserve SDR repository cmd functionality using get SDR cmd.
- Test Invalid reservation ID using Get SDR command.
- Verify Reserve SDR cmd after BMC reboot.

Tested Run robot ipmi/test_ipmi_sdr.robot

Signed-off-by: Nagarjun B <nagarjunb@ami.com>
Change-Id: I7ac3d23133c42c9823c6cbc4f14d968ecd89b78c

show more ...

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Codespell fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Codespell fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I2cf277da6cc16322eff8adaba83e1ea98dd4cb41
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Python 2.7x and 3.xx compatibility fixes

Change-Id: I84eb3bf7691fa867acadf9dae8c4f56a9781bf73
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Remove Barreleye footprint from test

Changes:
- Replace examples and code with Witherspoon.
- Delete data/Barreleye.py file.
- Remove command from tox.ini.

Remove Barreleye footprint from test

Changes:
- Replace examples and code with Witherspoon.
- Delete data/Barreleye.py file.
- Remove command from tox.ini.

Change-Id: Ib61723dc0a0f3961da6d72f1dd65914c9c62079b
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Formatted python files to follow PEP 8 python code standards.

- Changed the python files in the openbmc-test-automation
directory to conform to python code style standards with

Formatted python files to follow PEP 8 python code standards.

- Changed the python files in the openbmc-test-automation
directory to conform to python code style standards with
the exception of E402 and E501.
- Resolves openbmc/openbmc-test-automation#1308

Change-Id: I109995c2d248f5a6bb2c0e3c76a6144c8f3aac2e
Signed-off-by: Joy Onyerikwu <onyekachukwu.joy.onyerikwu@ibm.com>
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Fixed PEP 8 style using autopep8

Used autopep8 to correct styling.
Ran autopep8 on openbmc-test-automation, autopep8 is not
able to fix all styling issues. There is still around

Fixed PEP 8 style using autopep8

Used autopep8 to correct styling.
Ran autopep8 on openbmc-test-automation, autopep8 is not
able to fix all styling issues. There is still around
1000 styling violations in openbmc-test-automation.
More information on autopep8 can be found here,
https://pypi.python.org/pypi/autopep8

Change-Id: Iddc131da1d74d978eb3dd0fdd6ce5d0a0e49b0f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove hashtag lines from all .py files.

Change-Id: Ib2b52f6ff71c8f553e0cfb1936c8e0917e70c619
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

BMC version check logic fix when multiple images are active

Resolves openbmc/openbmc-test-automation#1023

Change-Id: I0f35c31323f6807c033ad944e294e0a56061c11e
Signed-off-by: Ge

BMC version check logic fix when multiple images are active

Resolves openbmc/openbmc-test-automation#1023

Change-Id: I0f35c31323f6807c033ad944e294e0a56061c11e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Replace system and network info from comment

Resolves openbmc/openbmc-test-automation#704

Change-Id: I760abb04fdb466f055bbe7b214e82ec475792203
Signed-off-by: George Keishing <g

Replace system and network info from comment

Resolves openbmc/openbmc-test-automation#704

Change-Id: I760abb04fdb466f055bbe7b214e82ec475792203
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

FRU fields validation

Verifying the FRU's properties defined in YAML file for inventory.

Logic:
1. Find the list of qualified FRU's from inventory.
2. Iterate the FR

FRU fields validation

Verifying the FRU's properties defined in YAML file for inventory.

Logic:
1. Find the list of qualified FRU's from inventory.
2. Iterate the FRU url and extract the fields.
3. Compare the FRU properties set from system vs the derived
FRU properties from YAML file (e.g. "data/inventory.py").
4. Any mismatch would be a failure.

Resolves openbmc/openbmc-test-automation#417

Change-Id: I526c28e957fc8ff9cd46bacfd3ff108728f8550e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

I created 2 new utilities.py functions:
- get_mtr_report()
- get_mtr_row()

Change-Id: I93f5469bec4cd43fcdccf9b1fef3910e505c71d8
Signed-off-by: Michael Walsh <micwalsh@us.ibm.

I created 2 new utilities.py functions:
- get_mtr_report()
- get_mtr_row()

Change-Id: I93f5469bec4cd43fcdccf9b1fef3910e505c71d8
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Enable test cases for host's network settings

What test cases are added
- Added test cases to set static and dhcp setting using REST
- Added test cases to set static and dhcp

Enable test cases for host's network settings

What test cases are added
- Added test cases to set static and dhcp setting using REST
- Added test cases to set static and dhcp setting using IPMI
- Added test case to clear settings using IPMI
- Added test cases to set invalid settings using both REST and IPMI

Resolves openbmc/openbmc-test-automation#48

Change-Id: Ia9ac56ad884318de703406d070aa7985474fab05
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>

show more ...

Removed all tabs and trailing spaces from /lib

This commit is style changes only.
It removes trailing spaces and tabs from all files in /lib

Change-Id: Ief03773a04de1fc0f8d40bb7

Removed all tabs and trailing spaces from /lib

This commit is style changes only.
It removes trailing spaces and tabs from all files in /lib

Change-Id: Ief03773a04de1fc0f8d40bb73eea940aa402f790
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Port suite from mkumatag personal repo w/o history

All these files came from https://github.com/mkumatag/openbmc-automation
The decision to remove the commit history was because most of

Port suite from mkumatag personal repo w/o history

All these files came from https://github.com/mkumatag/openbmc-automation
The decision to remove the commit history was because most of the 122
commits did not follow commit comment AND content best practices.
The ability to remove the commit history was possible because all
contributors where from the same company (IBM) making the coordination /
notification/acceptence easy. See all the gory details about the
first try to commit with history here...
https://github.com/openbmc/openbmc-test-automation/pull/1

This suite of tests will run against an OpenBMC based server. It will
run good/bad path testing against the REST interface. There are tests
that will also run ipmitool on the victim BMC too.

If you want to support a new system in to the suite you should only
have to edit two files...
data/<system>.py
tox.ini

The README.md contains details on how to setup for the first time along
with how to execute the test suite

NOTE: some test cases require tools that do not exist on the system.
Currently the ipmitool is needed and if you do not manually copy / link
it in to the tools directory some suites will fail.

show more ...