Changed obmc_boot_test to improve usability by robot programs.

- Created new obmc_boot_test_resource.robot to define parms for
obmc_boot_test.robot. This is to make it possible for ot

Changed obmc_boot_test to improve usability by robot programs.

- Created new obmc_boot_test_resource.robot to define parms for
obmc_boot_test.robot. This is to make it possible for other robot
programs to have access to obmc_boot_functionality.
- Created process_pgm_parms function to process program parameters.
Previously, this was done in the program prolog.
- Added support for new stack_mode parameter. When stack mode is
"normal", the program behaves as it always has. In "skip" mode,
when each boot test is pulled from the stack, the boot test is
skipped if the system is already in the desired end state for
the boot test in question. This feature allows a user to run
a boot like "REST Power Off" only if the machine is not already
powered off.
- Renamed main_py to obmc_boot_test so that other robot files can
call it and have it be more self documenting. Example:
OBMC Boot Test \ REST Power Off
- Added a single alt_boot_stack parm to the new obmc_boot_test
function. Again, this allows the user to call and pass a boot_stack
as shown in the prior example.
- Added support for new boot_fail_threshold parameter. This allows
a caller to indicate how many failures are acceptable. If the
number of boot failures exceeds boot_fail_threshold, then the
OBMC Boot Test keyword will fail.
- Switched many gen_robot_print references to gen_print.
- Made many changes to use new run_key function.

Change-Id: I56aad535dac30ab516fdc530866c09dcbca277f3
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Fixes to obmc_boot_test.py:

- 'Delete All Sessions' after each boot test to prevent too
many open connections, i.e. "ConnectionErrors".
- 'Delete Error logs' after each boot test t

Fixes to obmc_boot_test.py:

- 'Delete All Sessions' after each boot test to prevent too
many open connections, i.e. "ConnectionErrors".
- 'Delete Error logs' after each boot test to prevent build-up
of error logs.

Change-Id: I44b0e6e7145255786583136762598ac8c593e83d
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Added ffdc_only parm support to obmc_boot_test.robot/.py.

Change-Id: I13fe05382a56738a19ca448697b99804ceee7e98
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

obmc_boot_test.py RESTORE_LAST_STATE and PDU validation.

- Added code to 'Set BMC Power Policy RESTORE_LAST_STATE' at the
beginning of each test run.

- Added code to validate

obmc_boot_test.py RESTORE_LAST_STATE and PDU validation.

- Added code to 'Set BMC Power Policy RESTORE_LAST_STATE' at the
beginning of each test run.

- Added code to validate PDU parameters if any boot tests are
specified that require them.

Change-Id: If0f1b4a6bdfeee06530de9d660cb174e313c23a9
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

obmc_boot_test.py log cleanup:

- Separated out one-time setup from plug_in_setup and put it in
initial_plug_in_setup.
- In both initial_plug_in_setup and plug_in_setup, added code

obmc_boot_test.py log cleanup:

- Separated out one-time setup from plug_in_setup and put it in
initial_plug_in_setup.
- In both initial_plug_in_setup and plug_in_setup, added code to
change log level to NONE and restore to saved value when finished.
This is an attempt to remove irrelevant INFO traces.
- Change to validate pdu_slot_no only if pdu_host is provided.

Change-Id: I740a55e6cbff13db3c5a1abd6cc196e6d605ab95
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Attempt to catch errors on run_keyword_and_continue_on_failure.

The following statement in obmc_boot_test.py often fails.
However, we do NOT continue on error as expected.

Built

Attempt to catch errors on run_keyword_and_continue_on_failure.

The following statement in obmc_boot_test.py often fails.
However, we do NOT continue on error as expected.

BuiltIn().run_keyword_and_continue_on_failure("FFDC")

I surrounded this call with try/except to try to catch errors
and continue.

Change-Id: I7575b1453e82814a76aa8f9fbfb39ac0ac9ee849
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

obmc_boot_test.robot/obmc_boot_test.py changes:

- Change to call FFDC with run_keyword_and_continue_on_failure vs
run_keyword.
- Renamed program_teardown to main_keyword_teardown w

obmc_boot_test.robot/obmc_boot_test.py changes:

- Change to call FFDC with run_keyword_and_continue_on_failure vs
run_keyword.
- Renamed program_teardown to main_keyword_teardown which is more
accurate.
- Added a test_teardown. Added code to it to print an error message
when a keyword time-out is detected. Trying to add code to figure
out why failures in FFDC collection stop the test run.

Change-Id: I4bbef38daaa988922f07eeee61b47a7d3f283940
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

obmc_boot_test.py: boot_results.print_report() before stop_check.

Moved boot_results.print_report() prior to stop_check. If a
stop check indicates that the program should terminate, the

obmc_boot_test.py: boot_results.print_report() before stop_check.

Moved boot_results.print_report() prior to stop_check. If a
stop check indicates that the program should terminate, there
should still be a print out of latest results.

Change-Id: I16de8689f1412903494735362d51c54878875649
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Fixed error initiating boot_results in obmc_boot_test.py.

Change-Id: Idae47539f9b8e60d4ef9b069f5fcd18dbd232d41
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

obmc_boot_test.py changes:

- run_boot() using new my_run_keyword.
- Added code to save / read boot_results to preserve continuity
across multiple related runs.

Change-Id:

obmc_boot_test.py changes:

- run_boot() using new my_run_keyword.
- Added code to save / read boot_results to preserve continuity
across multiple related runs.

Change-Id: Ifd460ac29d6b1c602b4a781873544059cc6406ed
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

obmc_boot_test.py changes:

- run_boot:
- Need to call strip_anchor_state in test_mode.
- Added post_reboot plug-in call point support
- main_py: Added additional output.

obmc_boot_test.py changes:

- run_boot:
- Need to call strip_anchor_state in test_mode.
- Added post_reboot plug-in call point support
- main_py: Added additional output.

Change-Id: Icc06408f57f9ba40075c87d7cbbbff761372d0f6
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Changes to obmc_boot_test.robot/obmc_boot_test.py:

- I re-wrote nearly all robot code in python.

Change-Id: Ie68b2714fe107f10486c9b07cc29f4afd2af264c
Signed-off-by: Michael Wals

Changes to obmc_boot_test.robot/obmc_boot_test.py:

- I re-wrote nearly all robot code in python.

Change-Id: Ie68b2714fe107f10486c9b07cc29f4afd2af264c
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Making adjustments for coming state changes. I also rewrote some robot
keywords in python.

Note that the changes for the new "bmc" values are not present yet
since the product code

Making adjustments for coming state changes. I also rewrote some robot
keywords in python.

Note that the changes for the new "bmc" values are not present yet
since the product code for that is not yet available to me.

Change-Id: I30ea13930512ae1ffcf29000d0e4661352a797d7
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Changes to obmc_boot_test programs.

extended/obmc_boot_test.robot
- I added support for state_change_timeout, power_on_timeout,
power_on_timeout program parms.
- New code

Changes to obmc_boot_test programs.

extended/obmc_boot_test.robot
- I added support for state_change_timeout, power_on_timeout,
power_on_timeout program parms.
- New code to set default value for openbmc_nickname.
- I added support for new ffdc_check call point.
- Re-wrote "My FFDC" as my_ffdc in lib/obmc_boot_test.py.
- Removed unnecessary 'Log Defect Information' keyword.
- Made output improvements to "Print Defect Report"

lib/obmc_boot_test.py
- add_trailing_slash: Function moved to gen_misc.py.
- plug_in_setup:
- I added default assignment of openbmc_nickname.
- I added support for some more variables.
- my_ffdc: Moved from obmc_boot_test.robot to this file. Re-written in
python

Change-Id: Id07a20f9c6c5f9ccbca4b71e5590d8fa8bcdcd79
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Changes to FFDC to support ffdc_dir_path and ffdc_prefix as parms.

lib/openbmc_ffdc.py
- New py counterpart to openbmc_ffdc.robot. Converted ffdc keyword to
python. I did thi

Changes to FFDC to support ffdc_dir_path and ffdc_prefix as parms.

lib/openbmc_ffdc.py
- New py counterpart to openbmc_ffdc.robot. Converted ffdc keyword to
python. I did this as an effort to reduce dependencies on global
variables like FFDC_DIR_PATH, FFDC_LOG_PATH, etc and to support
ffdc_dir_path and ffdc_prefix as parms to the keyword.
lib/openbmc_ffdc.robot:
- Added line to bring in new lib/openbmc_ffdc.py.
- Removed ROBOT version of FFDC keyword.

Change-Id: Ic82255f4fbba3b0e6e8eb7faa942c948ce6a522d
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Support for new plug in environment variables.

lib/obmc_boot_test.py:
- plug_in_setup: I added support for the following environment
variables:
- BASE_TOOL_DIR_PATH

Support for new plug in environment variables.

lib/obmc_boot_test.py:
- plug_in_setup: I added support for the following environment
variables:
- BASE_TOOL_DIR_PATH
- FFDC_LIST_FILE_PATH

Change-Id: I82a173fd2166fa97e35a017e203a683a75b81af9
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Fixed problems introduced by obmc_boot_test.robot merge.

Note: The caller must set PATH and PYTHONPATH so that libraries and resources
can be found. Example:

export PATH=/home

Fixed problems introduced by obmc_boot_test.robot merge.

Note: The caller must set PATH and PYTHONPATH so that libraries and resources
can be found. Example:

export PATH=/home/robot/openbmc-test-automation/bin:$PATH
export PYTHONPATH=/home/robot/openbmc-test-automation/lib:$PYTHONPATH

lib/gen_print.py:
- sprint_varx: Failure to support dot_dict.
- sprint_pgm_header:
- Fixed failure to support uid of 0.
- Fixed failure to handle non-existent DISPLAY env variable.
lib/obmc_boot_test.py
- plug_in_setup: Fixed failure to handle non-existent FFDC_DIR_PATH env
variable.

Resolves https://github.com/openbmc/openbmc-test-automation/issues/230
Change-Id: I81a2ac6ad0bc69b24f9e160d38120ffb31c632f1
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Re-working of obmc_boot_test.robot and added obmc_boot_test.py.

Change-Id: I35fa575c71a01c94fb32c9b837afad866d0a86e3
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>