Fix for redfishtool certificate, snmp and session management

Changes:
- Set cert_id as test variable
- Remove colon in snmp destination when the snmp port is empty
- Fix redfish_delete_session

Fix for redfishtool certificate, snmp and session management

Changes:
- Set cert_id as test variable
- Remove colon in snmp destination when the snmp port is empty
- Fix redfish_delete_sessions assign location
- Set REDFISH_DELETE_SESSIONS to 0 in suite setup
- Set REDFISH_DELETE_SESSIONS back to 1 in suite teardown

Tested:
- redfish/service_root/test_sessions_management.robot
- redfish/dmtf_tools/test_redfishtool_certificate.robot
- redfish/events/test_bmc_snmp_trap.robot

Change-Id: Ibb16d52b5874484f8cf169456e2feb4ba7593e71
Signed-off-by: Wilson Suen <wilsons@supermicro.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

pycodestyle: Module level import not at top of file

Changes:
- Added NOQA on python files import to skip CI
- Fix import order reported by CI.

Tested:
- CI will catch this if there i

pycodestyle: Module level import not at top of file

Changes:
- Added NOQA on python files import to skip CI
- Fix import order reported by CI.

Tested:
- CI will catch this if there is error

Change-Id: I39a11d3e815a08488671ed948f073828e19aee37
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Revert "Fix for module level import not at top of file"

This reverts commit 47375aa789dcb11ba969895f61dfb12a773e2164.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Icc40562b861262

Revert "Fix for module level import not at top of file"

This reverts commit 47375aa789dcb11ba969895f61dfb12a773e2164.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Icc40562b861262d8fb72d68b43654334985eea4d

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix for module level import not at top of file

Change-Id: I1994b58a027cdac3bf4084b77db61bc646aaaba6
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

Update OPENBMC_MODEL if it fails to get from BMC

Test suites can be executed with different local user privilege.
Specially to execute boot plugin, the boot infrastructure requires
OPENBMC_MODEL to

Update OPENBMC_MODEL if it fails to get from BMC

Test suites can be executed with different local user privilege.
Specially to execute boot plugin, the boot infrastructure requires
OPENBMC_MODEL to be poplated.

Currently, this model is fetch from BMC via SSH, however, different
privilege user will not have the admin or root access causing the
boot setup to fail.

Change-Id: I0a013b622c52cc3f33f2870779b996dac1b3f11a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Ignore Power restore policy on error to continue boot

This is to prevent power restore policy blocking the system to
boot where by default some systems in community may not suport it.

Ignore Power restore policy on error to continue boot

This is to prevent power restore policy blocking the system to
boot where by default some systems in community may not suport it.

Change-Id: I97908e92cf0b5a3304989745e34222160974ecaa
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Get and set status directory user input variable

By default it will store status files at env HOME dir space else
user define env or input variable.

Usage(s):
Default en

Get and set status directory user input variable

By default it will store status files at env HOME dir space else
user define env or input variable.

Usage(s):
Default env HOME directory
User input -v STATUS_DIR_PATH:<path>
User env export STATUS_DIR_PATH=<path>

Change-Id: I53e0b146f8ef92bf5cdf2b48413d8f02ce58dda9
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Boot test Error log format for Redfish

Change-Id: I6f034d98049fc8633cafba2ec1ed2802df53258f
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Add support to flush out system dumps

Changes:
- Added keyword to delete system dumps.
- Call the new keyword at boot test and clean up path.

Change-Id: Ibdb880b7e

Add support to flush out system dumps

Changes:
- Added keyword to delete system dumps.
- Call the new keyword at boot test and clean up path.

Change-Id: Ibdb880b7e0ad07b9097b3c97701fea72c2d4f28a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update Redfish check for boot test

choose redfish keywords if user specified redfish_support_trans_state

Change-Id: I353bf9cd8a012661b3e909597ba06fdd88f93292
Signed-off-by: Geor

Update Redfish check for boot test

choose redfish keywords if user specified redfish_support_trans_state

Change-Id: I353bf9cd8a012661b3e909597ba06fdd88f93292
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add REDFISH_SUPPORT_TRANS_STATE to Auto_reboot plugin

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I3dc20129df3da198cf34f6d414b3e3e3d8a7832e

Skip purging REST/Redfish session post boot run

Changes:
- Added flag for user to control the behaviour of default
session delete to prevent function testing during BMC

Skip purging REST/Redfish session post boot run

Changes:
- Added flag for user to control the behaviour of default
session delete to prevent function testing during BMC reset
which relies on persistency of the session.

Change-Id: I0b6e8926af99a8a1ec8193c0afab823a2c606864
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Revert "Pass in REDFISH_SUPPORT_TRANS_STATE to robot_cmd_fnc"

This reverts commit cb6b53b8c90fdc4636acfc2e1824831a8a9f532b.

Reason for revert: Works good from sandbox but not on Jen

Revert "Pass in REDFISH_SUPPORT_TRANS_STATE to robot_cmd_fnc"

This reverts commit cb6b53b8c90fdc4636acfc2e1824831a8a9f532b.

Reason for revert: Works good from sandbox but not on Jenkins HW CI

Change-Id: I411a7b08a131936c089b69dbeb3ed62a72f59786

show more ...

Pass in REDFISH_SUPPORT_TRANS_STATE to robot_cmd_fnc

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I68a824b706c6781b833c69f45f244baf62a8ce0e

Purge all active redfish session post boot test run

Change-Id: Ic169b994c02eb5e3a5eba3b5a783974e86f4bb2b
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Add changes to fix REDFISH_REST_SUPPORTED not found

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I2eae7831771250317ab09c671c89ac6aa244812f

Use print_error_logs() to display BMC error_logs

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I1a41f6dcf504c7a1234be80e4a3e6fb2605b3fe1

Add redfish_rest_supported to additional_values.

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I131dad9b2cd18f64e14a68bafe2f45ddef56b783

Print to console error logs and PELs listing prior to deletion

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I8c411966396aba3c830645a47ffadad6a9705809

Add quiet arg to Delete Error Logs

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I2aaf3dcebd98a9f3101bc379dd1dee95c08fbb4d

REST and Redfish supported driver

Changes:
- Added REDFISH_REST_SUPPORTED global var as part of the
lib/bmc_redfish_utils.py init function.
- Update boot test to se

REST and Redfish supported driver

Changes:
- Added REDFISH_REST_SUPPORTED global var as part of the
lib/bmc_redfish_utils.py init function.
- Update boot test to select supported BMC REST or Reddfish
fucntions to set.

There are driver still out there in community which supports both
legacy REST (/xyz/openbmc_project/) and new redfish (/redfish/v1/).
This new logic is to derieve early in the program and use in the
functional and boot test path.

Tested:
- Disable REST and test the change.
- Test the change in current latest level of driver.

Change-Id: I0e0b480b97b64df8a264a3d54e7159e90b33f4af
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...