Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot
- Replaced all the Managers/bmc to Managers/${MANAGER_ID} across all the scripts
- Also in data/variables.py updated chassis id for the few redfish uri.

Tested:
- Ran All The Scripts Successfully

Change-Id: Iff3673aae27657e0799dec5cb94c1651a0cd5d18
Signed-off-by: ganesanb <ganesanb@ami.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

E275 missing whitespace after keyword

Changes:
- CI gerrit failed due to pycodestyle strict checking

Tested:
- CI gerrit should pass

Change-Id: I3bfcae57626fd484a9222da8532a413a0da6f610
S

E275 missing whitespace after keyword

Changes:
- CI gerrit failed due to pycodestyle strict checking

Tested:
- CI gerrit should pass

Change-Id: I3bfcae57626fd484a9222da8532a413a0da6f610
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Handle JSONDecodeError and other exception during redfish login

Intermittently, we hit this error

<class 'json.decoder.JSONDecodeError'>
Expecting value: line 1 column 1 (char 0)

Observati

Handle JSONDecodeError and other exception during redfish login

Intermittently, we hit this error

<class 'json.decoder.JSONDecodeError'>
Expecting value: line 1 column 1 (char 0)

Observation:
- redfish 2.1.5 package level gives JSONDecodeError
- redfish 3.1.1 package for the same raise exception
redfish.rest.v1.InvalidCredentialsError

After handling and re-try as well, noticed it does seems
to help but gracefully fail and also re-try better success
rate in case of temporary server problems.

Change-Id: Idf29a029b5291ffd2f62ed6cf2729b6485b335a6
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add support to return child end node as list

Changes:
- New function to return list of members for a given URL

Tested:
Redfish.Get Members List /redfish/v1/AccountS

Add support to return child end node as list

Changes:
- New function to return list of members for a given URL

Tested:
Redfish.Get Members List /redfish/v1/AccountService/
Redfish.Get Members List /redfish/v1/AccountService/Accounts/
Redfish.Get Members List /redfish/v1/AccountService/Accounts filter=root

Change-Id: Ibd962df93c09fb365ea522f3000b02637b3e474f
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add mTLS option for redfish test

When the BMC only enables mTLS auth type at build time. Robot test
should be test normally. Adding "MTLS_ENABLED" environment variable as
an option a

Add mTLS option for redfish test

When the BMC only enables mTLS auth type at build time. Robot test
should be test normally. Adding "MTLS_ENABLED" environment variable as
an option and modifications to achieve it.

Signed-off-by: Tony Lee <tony.lee@quantatw.com>
Change-Id: I68c753a453f0c958c900f8ba3e1d73145e093d6c

show more ...

REDFISH_REST_SUPPORTED initialize to support backward compatible

Due to the test infrastructure by default checks for redfish as
a first choice to probe to connect to BMC, by default set

REDFISH_REST_SUPPORTED initialize to support backward compatible

Due to the test infrastructure by default checks for redfish as
a first choice to probe to connect to BMC, by default set to true
for REST and redfish support.

Change-Id: Id195e7e89bbeb51645282347171d46fc62ac5bf2
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Copy enumerate_request to bmc_redfish.py

Copy enumerate_request from bmc_redfish_utils.py to bmc_redfish.py and
rename it to simply "enumerate".

Functions like "enumerate" and "

Copy enumerate_request to bmc_redfish.py

Copy enumerate_request from bmc_redfish_utils.py to bmc_redfish.py and
rename it to simply "enumerate".

Functions like "enumerate" and "list" are quite integral to BMC redfish
programming and belong in bmc_redfish.py.

Change-Id: I8e7aa9d8833ecf19194abc1e966841ac069ff5d8
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Default to Redfish Power On/Off

If Redfish is supported by the OBMC, obmc_boot_test.py will use
'Redfish Power On' and 'Redfish Power Off' as the default transitional
boot tests.

Default to Redfish Power On/Off

If Redfish is supported by the OBMC, obmc_boot_test.py will use
'Redfish Power On' and 'Redfish Power Off' as the default transitional
boot tests.

Change-Id: I56235ccd750bddd1be67d65340a0de9a1b73b76e
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Remove use of deprecated terse() on print_var

terse is now the default.

Change-Id: If25901eea7fdfa502b012cb995242790e7f6176d
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

redfish login() not __inited__: improved message

Also, fixed Rprint Vars in doc string to show proper use of fmt argument.

Change-Id: If8f65a9191bf0b3b7e6db5d0bb3179e1415d9df4
S

redfish login() not __inited__: improved message

Also, fixed Rprint Vars in doc string to show proper use of fmt argument.

Change-Id: If8f65a9191bf0b3b7e6db5d0bb3179e1415d9df4
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Tolerate failed redfish init for old bmc code

- Older bmc code does not support redfish and therefore robot code that
happens to use lib/bmc_redfish_resource.robot will get unsightly err

Tolerate failed redfish init for old bmc code

- Older bmc code does not support redfish and therefore robot code that
happens to use lib/bmc_redfish_resource.robot will get unsightly errors even if
these programs don't try to run actual redfish tests.

- Also, made correction to use of super() function in bmc_redfish.py login
method.

Change-Id: I25f9acac69a573a2d668d0fb97d84bce46545b4d
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Add get_properties, etc. to bmc_redfish class

Implement get_properties, get_attribute, get_session_info in bmc_redfish class

Change-Id: I7b748a3987a6515ec9c42b2910aeeb97e0dc9e79

Add get_properties, etc. to bmc_redfish class

Implement get_properties, get_attribute, get_session_info in bmc_redfish class

Change-Id: I7b748a3987a6515ec9c42b2910aeeb97e0dc9e79
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

New BMC redfish library integration

Changes:
- Use redfish_plus.py when importing Redfish instances.
- Update bmc_redfish.py.
- Update bmc_redfish_utility.py.
- U

New BMC redfish library integration

Changes:
- Use redfish_plus.py when importing Redfish instances.
- Update bmc_redfish.py.
- Update bmc_redfish_utility.py.
- Update object name 'redfish' to 'Redfish'.
- Update test setup and teardown in suites.
- Update response error checking using valid_status_codes.
- Fix test cases required for migration.

Change-Id: Ida154aede649d9a2bbef66d16ccf725f5ea37ed0
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Plugin find target to power on and BMC reset

Change-Id: I04067829af4c10189d1c8cf1e3a1f7f8fe9c5856
Tested: On Master https://openpower.xyz/job/openbmc-build/2006/
Signed-off-by: Georg

Plugin find target to power on and BMC reset

Change-Id: I04067829af4c10189d1c8cf1e3a1f7f8fe9c5856
Tested: On Master https://openpower.xyz/job/openbmc-build/2006/
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Create multiple session and verify

Changes:
- Added set session key function in lib.
- Added get session info function in lib utils.
- Added test case to create 50 se

Create multiple session and verify

Changes:
- Added set session key function in lib.
- Added get session info function in lib utils.
- Added test case to create 50 session and verify.

Tested: On Master

Change-Id: Iaf740c83d77fb1da7be65903872219e21b53c79e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Redfish python utility

Changes:
- New redfish utility library code.
- Move generic utility functions to new library.
- Update test cases with new utility object acces

Redfish python utility

Changes:
- New redfish utility library code.
- Move generic utility functions to new library.
- Update test cases with new utility object acces.

Change-Id: Ia2bb18cb46ca93503853bbfd1773d3e4447339c9
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix list URIs in library to take absolute path.

Change-Id: If05846f584ca8b35d42d76c102648b609f2c808f
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Code spell, alignment and spacing fixes

Change-Id: I69ae3447d4025dc024cbfe0a83a15595a76faf4c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Update the robot library redfish instance only to suite level

ROBOT_LIBRARY_SCOPE = "TEST SUITE"

This ensures that the object is alive at suite level.

Change-Id: Ib0afed46c

Update the robot library redfish instance only to suite level

ROBOT_LIBRARY_SCOPE = "TEST SUITE"

This ensures that the object is alive at suite level.

Change-Id: Ib0afed46c29e08d85601ffb266a2858bdf1f6ea8
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix class exit and temp object update in security

Change-Id: I18a95529fc2e2b27d3429f86eade852963873cb7
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

BMC redfish update and new test suite for security

Changes:
- Update bmc redfish to allow user to update credentials.
- Added test suite test_service_root_security.robot.

BMC redfish update and new test suite for security

Changes:
- Update bmc redfish to allow user to update credentials.
- Added test suite test_service_root_security.robot.

Added Test Case:
- Login To BMCweb With Invalid Credentials

Change-Id: Ia7e8cd6f3cab381ad41f34b6f502e3f92521f692
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...