Fix IPMI and code typo changes

Changes:
- IPMI changes refer ipmitool/ipmitool#96
IPMITOOL_1_8_19: Release Version 1.8.19
- Spelling fix

Tested:
- NA

Change-Id: Iad514073a

Fix IPMI and code typo changes

Changes:
- IPMI changes refer ipmitool/ipmitool#96
IPMITOOL_1_8_19: Release Version 1.8.19
- Spelling fix

Tested:
- NA

Change-Id: Iad514073ae28461158de8b39aded1efdcd146c52
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add re-try for redfish GET request for targets

Changes:
- This retries is added to improve the success rate
for the GET request in case returns JSON errors
for the following URI duri

Add re-try for redfish GET request for targets

Changes:
- This retries is added to improve the success rate
for the GET request in case returns JSON errors
for the following URI during operation
/redfish/v1/Systems/ and /redfish/v1/Managers/

- Added other places in code to handle exceptions.
- Fix IPMI import paths in test suite

Tested:
- Ran from sandbox.

Change-Id: Ie37dbdd9c7572e0003a56e65a7b5f0a4c3b26a1a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf30

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf305754b247b995a05d8da3b9de9ed613ecae2
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the 'RETURN' statement instead.
- Singular section headers like '*** Test Case ***'
are deprecated. Use plural format like
'*** Test Cases ***' instead.
- Singular section headers like '*** Variable ***'
are deprecated

Tested:
- Ran from sandbox with the version
$ robot --version
Robot Framework 7.0 (Python 3.10.12 on linux)

and also tested on latest python version

Robot Framework 7.0 (Python 3.11.9 on linux)

Change-Id: I54e85f9d799556c63b9a39f79483f83e9b980768
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Automation fix in ipmi/test_ipmi_sel.robot

Changes:
- Added a check to verify the information error log entry
after issuing the IPMI SEL clear command.

Tested:
- Ran and tested on BMC

Automation fix in ipmi/test_ipmi_sel.robot

Changes:
- Added a check to verify the information error log entry
after issuing the IPMI SEL clear command.

Tested:
- Ran and tested on BMC Environment

Change-Id: I23e772defa5314ee16f61fa22268301b24b5617e
Signed-off-by: Vidya-Kalasappanavar <Vidya.Kalasappanavar@ibm.com>

show more ...

Move TC from the error log suite to the IPMI suite

Changes:
   - Move TC Verify IPMI SEL Event Entries from
test_event_logging.robot to test_ipmi_sel.robot
   - Replace count with count + 1

Move TC from the error log suite to the IPMI suite

Changes:
   - Move TC Verify IPMI SEL Event Entries from
test_event_logging.robot to test_ipmi_sel.robot
   - Replace count with count + 1
- Added IPMI SEL Clear command to clear the entries

Tested:
  - Ran and tested on BMC Environment

Change-Id: Iff31d4e83ba060309174144760bbc576561684b6
Signed-off-by: Vidya-Kalasappanavar <Vidya.Kalasappanavar@ibm.com>

show more ...

Move tests from the error log suite to the IPMI suite

Changes:
- Created a new keyword
- Below test case moved to test_ipmi_sel.robot
Verify_IPMI_SEL_Event_Last_Add_Time
Delete Non-E

Move tests from the error log suite to the IPMI suite

Changes:
- Created a new keyword
- Below test case moved to test_ipmi_sel.robot
Verify_IPMI_SEL_Event_Last_Add_Time
Delete Non-Existing SEL Event Entry
Delete Invalid SEL Event Entry
- Removed above test cases from test_event_logging.robot
Tested:
- Ran and tested on BMC Environment.

Change-Id: I5db573687ed551e533c6b641ea1891da90e8d0d6
Signed-off-by: Vidya-Kalasappanavar <Vidya.Kalasappanavar@ibm.com>

show more ...

Fix code typo in the repository

Changes:
- Corrected spelling mistake in the repository

Tested:
- NA

Change-Id: Ic721bbb2efc0f9f5a1895e3f5994fdb38fe310cd
Signed-off-by: George Keishing <gk

Fix code typo in the repository

Changes:
- Corrected spelling mistake in the repository

Tested:
- NA

Change-Id: Ic721bbb2efc0f9f5a1895e3f5994fdb38fe310cd
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Set system, chassis, and bmc as global variables

Changes:
- Add SYSTEM_ID as a global variable and set to default value system
- Replace redfish/v1/Systems/system to redfish/v1/Systems/SYSTEM_ID

Set system, chassis, and bmc as global variables

Changes:
- Add SYSTEM_ID as a global variable and set to default value system
- Replace redfish/v1/Systems/system to redfish/v1/Systems/SYSTEM_ID
- Replace redfish/v1/Chassis/chassis to redfish/v1/Chassis/CHASSIS_ID
- Replace redfish/v1/Managers/bmc to redfish/v1/Managers/MANAGER_ID

Tested:
- Tested on sandbox with the changes with sample test run with
sample test ID runs
1. without SYSTEM_ID provided
2. with -v SYSTEM_ID:system1
3. with export SYSTEM_ID=""
3. with export SYSTEM_ID="system2"

Change-Id: Ifc412b20038cef1eba632caaa6c300be328259bd
Signed-off-by: Wilson Suen <wilsons@supermicro.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix test suites and move SNMP under redfish

Changes:
- Test consolidation for SNMP
- Fix test suites for line exceeding 110

Tested:
- NA

Change-Id: Ia1d3e8cab9ad31e6550100e25a3b3988a80a38

Fix test suites and move SNMP under redfish

Changes:
- Test consolidation for SNMP
- Fix test suites for line exceeding 110

Tested:
- NA

Change-Id: Ia1d3e8cab9ad31e6550100e25a3b3988a80a38f7
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

IPMI: Modified test_ipmi_fru_device.robot based on user input

Changes:
-Removed raw from Run IPMI command. It is not required here

Tested:
-Ran scripts and is it running Successfully

Change-

IPMI: Modified test_ipmi_fru_device.robot based on user input

Changes:
-Removed raw from Run IPMI command. It is not required here

Tested:
-Ran scripts and is it running Successfully

Change-Id: I5fde45490cbea166f3fd23070aa9beab34285db3
Signed-off-by: manimozhik <manimozhik@ami.com>

show more ...

IPMI: Modified script based on oem sensor

Changes:
-Modified script based on oem sensor count in
Verify_Sensor_And_SDR_Count_In_Get_Device_SDR_Info
_Via_Inband_IPMI Testcase
-Modified t

IPMI: Modified script based on oem sensor

Changes:
-Modified script based on oem sensor count in
Verify_Sensor_And_SDR_Count_In_Get_Device_SDR_Info
_Via_Inband_IPMI Testcase
-Modified the function name as fetch_oem_sdr_count in ipmi_utils.py
-Modified keyword name as Fetch OEM Sdr Count in ipmi_test_sdr.robot

Tested:
-Ran scripts Successfully

Change-Id: I6dabd17da4942258b855e01197d3de6229160b3d
Signed-off-by: manimozhik <manimozhik@ami.com>

show more ...

DCMI: Modified dcmi_management_controller script based on user input

Changes:
-Modified dcmi_management_controller script based on user input

Tested:
-Ran ipmi/ and ipmi/dcmi

Change-Id: I211

DCMI: Modified dcmi_management_controller script based on user input

Changes:
-Modified dcmi_management_controller script based on user input

Tested:
-Ran ipmi/ and ipmi/dcmi

Change-Id: I2113ac13ad8b16d9a44ad0edb22e6d937364c154
Signed-off-by: manimozhik <manimozhik@ami.com>

show more ...

IPMI test code variable syntax error

Changes:
- Variable '${initial_power_policy' was not closed properly.

Tested:
- Sandbox test run

Change-Id: I31acade12bf2789dd262e87f7a4eb52413800eb7
Sig

IPMI test code variable syntax error

Changes:
- Variable '${initial_power_policy' was not closed properly.

Tested:
- Sandbox test run

Change-Id: I31acade12bf2789dd262e87f7a4eb52413800eb7
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

IPMI: Modified script in ipmi/test_ipmi_network_verification.robot

Changes:
- Modified changes in the testcases
Retrieve_IP_Address_Via_IPMI_And_Verify_Using_Redfish,
Retrieve_MAC_Addre

IPMI: Modified script in ipmi/test_ipmi_network_verification.robot

Changes:
- Modified changes in the testcases
Retrieve_IP_Address_Via_IPMI_And_Verify_Using_Redfish,
Retrieve_MAC_Address_Via_IPMI_And_Verify_Using_Redfish
and Test Valid IPMI Channels Supported
- Modified keywords Verify Channel Info, Verify IPv4 Static Address
and Verify MAC Address

Tested:
- Ran ipmi/test_ipmi_network_verification.robot

Change-Id: I44de538e9fbb4ed19f82a125a0f3d297c8c35744
Signed-off-by: Ishwarya Mathi M <ishwaryamm@ami.com>

show more ...

IPMI/DCMI: Modified script based on user input

Changes:
    - Modified script based on user input
Tested:
    - Ran ipmi/ and ipmi/dcmi

Change-Id: Ic9d6e29ae199cffb6009e6718ae499293c319c96
Signed-o

IPMI/DCMI: Modified script based on user input

Changes:
    - Modified script based on user input
Tested:
    - Ran ipmi/ and ipmi/dcmi

Change-Id: Ic9d6e29ae199cffb6009e6718ae499293c319c96
Signed-off-by: Ishwarya Mathi M <ishwaryamm@ami.com>

show more ...

IPMI: Modified Verify IPMI Inband Network Configuration testcase

Changes:
- Modified Variables for ip, netmask and gateway.
- Also verified changed static ip is communicable through
exter

IPMI: Modified Verify IPMI Inband Network Configuration testcase

Changes:
- Modified Variables for ip, netmask and gateway.
- Also verified changed static ip is communicable through
external IPMI cmd.

Tested:
- Ran ipmi/test_ipmi_network_configuration.robot

Change-Id: Ibdcf0efcd91d588a710d766dc578d25ac5eea94b
Signed-off-by: Ishwarya Mathi M <ishwaryamm@ami.com>

show more ...

IPMI: Added the logic to extract oem record count from sdr elist

Changes:
    - In test_ipmi_sdr.robot under "Verify SDR Info" added new keyword
Fetch Sdr Type to extract the oem record count

IPMI: Added the logic to extract oem record count from sdr elist

Changes:
    - In test_ipmi_sdr.robot under "Verify SDR Info" added new keyword
Fetch Sdr Type to extract the oem record count from sdr elist.
New keyword logic has been added in lib/ipmi_util.py
Tested:
    - Ran ipmi/test_ipmi_sdr.robot script Successfully

Change-Id: I466e353c1224590fddc6175fa3c7dfe9ebbe5a2b
Signed-off-by: manimozhik <manimozhik@ami.com>

show more ...

DCMI: Modified script in ipmi/dcmi/test_dcmi_management_controller.robot

Changes:
- omit DCMI Management Controller Identifier String as it should stop up to the first null

Tested:
- Ran ipmi/d

DCMI: Modified script in ipmi/dcmi/test_dcmi_management_controller.robot

Changes:
- omit DCMI Management Controller Identifier String as it should stop up to the first null

Tested:
- Ran ipmi/dcmi/test_dcmi_management_controller.robot

Change-Id: Ica521b5636aa9db825cab17696d48e9035458e53
Signed-off-by: Wilson Suen <wilsons@supermicro.com>

show more ...

Robustness enhancements to test_ipmi_user

- Includes refactoring code from test_ipmi_user to ipmi_client,
which will allow greater reuse.

- Ipmi_client changes:
- Enhancements to keyword: Creat

Robustness enhancements to test_ipmi_user

- Includes refactoring code from test_ipmi_user to ipmi_client,
which will allow greater reuse.

- Ipmi_client changes:
- Enhancements to keyword: Create Random IPMI User
-- invokes Find Free User ID : to prevent clobbering pre-existing
IPMI userIDs;
-- invokes Wait And Confirm New User Entry : so that we have
confirmation before returning.
- In support of this:
- Add necessary Variables;
- Pull over keywords from test_ipmi_user :
-- Find Free User Id
-- Check Enabled User Count
-- Wait And Confirm New User Entry
-- Verify IPMI Username Visible.

- Test_ipmi_user changes:
- Remove unused variable (moved to ipmi_client);
- Verify IPMI User Summary : remove now redundant
Wait And Confirm New User Entry, since incorporated into
Create Random IPMI User;
- Test IPMI User Privilege : invoke the new and enhanced
Create Random IPMI User , to prevent clobbering pre-existing
IPMI userIDs and leverage the built-in confirmation;
- Remove the keywords that are being pulled over to ipmi_client.

Additional test_ipmi_user changes for robustness,
consistent with use already elsewhere in this suite:
- Verify Administrator And User Privilege For Different Channels :
Sleep 5s delay after Set Channel Access to allow privileges to set;
- Verify Operator And User Privilege For Different Channels :
Sleep 5s delay after Set Channel Access to allow privileges to set.

Tested: on x86 platforms.

Change-Id: I10548d5ad7f85542ab5b6b165dddb01089da0661
Signed-off-by: Ruud A. Haring <ruud@us.ibm.com>

show more ...

IPMI: Modified Maximum Record ID script in ipmi/test_ipmi_inband_sdr.robot

Changes:
- Handled Script change for LSB and MSB for Maximum Record ID

Tested:
- Ran ipmi/test_ipmi_inband_sdr.robot

IPMI: Modified Maximum Record ID script in ipmi/test_ipmi_inband_sdr.robot

Changes:
- Handled Script change for LSB and MSB for Maximum Record ID

Tested:
- Ran ipmi/test_ipmi_inband_sdr.robot

Change-Id: Ic9c9e25275724f1a3616264aa03a701655f4c88c
Signed-off-by: Ishwarya Mathi M <ishwaryamm@ami.com>

show more ...

test_ipmi_user_robot: skip instead of fail test for short pasword.

Skip 'Verify IPMI Root User Password Change' if len(OPENBMC_PASSWORD) < 8
Aspects:
- Graceful exit (skip instead of fail) for short

test_ipmi_user_robot: skip instead of fail test for short pasword.

Skip 'Verify IPMI Root User Password Change' if len(OPENBMC_PASSWORD) < 8
Aspects:
- Graceful exit (skip instead of fail) for short OPENBMC_PASSWORD.
- Add comment to clarify reason: password < 8 chars cannot be set,
thus the restore password step in Teardown would fail.
- This affects "out-of-the-box" operation with default password 0penBmc.
- Evaluate precondition in Setup step. Skip if precondition violated.
- Make restoring pw in Teardown conditional on 'TEST STATUS' != 'SKIP'.
- For clarity, rename keyword: 'Set Default Password For IPMI Root User'
-> 'Restore Default Password For IPMI Root User'

Tested: operates as intended with both a 7-char pw and a 15-char pw.

Signed-off-by: Ruud A. Haring <ruud@us.ibm.com>
Change-Id: If3b67e9479824e5c6b6b95df366887e0af5a7cd3

show more ...

GUI:Fix for power cap variable name

Changes:
- In gui/gui_test/security_and_access_menu/test_user_management_sub_menu.robot
- changes in redfish power value variable..

Tested:
-Ran above test

GUI:Fix for power cap variable name

Changes:
- In gui/gui_test/security_and_access_menu/test_user_management_sub_menu.robot
- changes in redfish power value variable..

Tested:
-Ran above test case from sandbox successfully.

Change-Id: I42d5ad2879c857cfc40d91e67c27c923131550d4
Signed-off-by: Nandish-Matti <nandish.matti@ibm.com>

show more ...

DCMI: Handled Sensor Name format in ipmi/dcmi/test_dcmi_get_temperature_reading.robot

Changes:
- Modified script considering for space and underscore between sensor name

Tested:
- Ran ipmi/dcmi

DCMI: Handled Sensor Name format in ipmi/dcmi/test_dcmi_get_temperature_reading.robot

Changes:
- Modified script considering for space and underscore between sensor name

Tested:
- Ran ipmi/dcmi/test_dcmi_get_temperature_reading.robot

Change-Id: I8e1d95885a77cc02f05757da89cb46a627d526ab
Signed-off-by: Ishwarya Mathi M <ishwaryamm@ami.com>

show more ...

IPMI: Added new condition for channel number with respect to Slave address test_dcmi_get_capabilities.robot

Changes:
    - In test_dcmi_get_capabilities.robot added new contion if Slave address of d

IPMI: Added new condition for channel number with respect to Slave address test_dcmi_get_capabilities.robot

Changes:
    - In test_dcmi_get_capabilities.robot added new contion if Slave address of device: 20h (BMC), Channel number is 0h and if
Slave address of device: 0h then Channel number should not be 0
Tested:
    - Ran ipmi/dcmi/test_dcmi_get_capabilities.robot script Successfully

Change-Id: I3aa9ac99a8711e60b6e54124488f650331130260
Signed-off-by: manimozhik <manimozhik@ami.com>

show more ...