Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf30

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf305754b247b995a05d8da3b9de9ed613ecae2
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

Robot 7.0 version code changes

Changes:
- Singular section headers like '*** Keyword ***'
are deprecated.
Use plural format like '*** Keywords ***' instead.

- Singular section heade

Robot 7.0 version code changes

Changes:
- Singular section headers like '*** Keyword ***'
are deprecated.
Use plural format like '*** Keywords ***' instead.

- Singular section headers like '*** Comment ***'
are deprecated.
Use plural format like '*** Comments ***' instead.

Tested:
Syntax check run using robot --dryrun option locally

Change-Id: Ifecc986b919fac504d8c3970a538de5a29f64307
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the 'RETURN' statement instead.
- Singular section headers like '*** Test Case ***'
are deprecated. Use plural format like
'*** Test Cases ***' instead.
- Singular section headers like '*** Variable ***'
are deprecated

Tested:
- Ran from sandbox with the version
$ robot --version
Robot Framework 7.0 (Python 3.10.12 on linux)

and also tested on latest python version

Robot Framework 7.0 (Python 3.11.9 on linux)

Change-Id: I54e85f9d799556c63b9a39f79483f83e9b980768
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Remove legacy test suites and move the SLP suite

Changes:
- As part of the legacy test cleanup, REST test suites
are removed and the SLP suite moved to security.

Tested:
- NA

Change-I

Remove legacy test suites and move the SLP suite

Changes:
- As part of the legacy test cleanup, REST test suites
are removed and the SLP suite moved to security.

Tested:
- NA

Change-Id: I0a44708981332b6cca35b7cef7480de8e8e68485
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Legacy REST clean up from extended directory

Changes:
- Removing test suites from extended as part
of the clean-up

Tested:
- NA

Change-Id: I0eb952d179a61af08716178480ebbaa222e1072c
S

Legacy REST clean up from extended directory

Changes:
- Removing test suites from extended as part
of the clean-up

Tested:
- NA

Change-Id: I0eb952d179a61af08716178480ebbaa222e1072c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Handle Redfish login for Legacy REST supported systems

Changes:
- Add ignore directive for boot test login try

Note:
- We will sunset legacy REST by Q4 2023 year end.

Fixes the following er

Handle Redfish login for Legacy REST supported systems

Changes:
- Add ignore directive for boot test login try

Note:
- We will sunset legacy REST by Q4 2023 year end.

Fixes the following error::
REST Host Code Update :: Do a PNOR code update by uploading image ... | FAIL |
ValueError: bmc_redfish.__init__() was never successfully run.
It is likely that the target BMC firmware code level does not support redfish.

Tested:
- Test from sandbox

Change-Id: Iec6281e06cd76150512bbfa724cba30f156b6a49
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Test suite robot syntax error fix

Error message:
Keyword 'BuiltIn.Should Be Equal As Strings'
got positional argument after named arguments.

Changes:
- Fix the dictionary access in test

Test suite robot syntax error fix

Error message:
Keyword 'BuiltIn.Should Be Equal As Strings'
got positional argument after named arguments.

Changes:
- Fix the dictionary access in test code. This is due to
robot old syntax vs newer version changes.

Tested:
- NA

Change-Id: I5bdfcb46e70e11c5dd77a8155d21c585bbeab0d2
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Added redfish.login in obmc_boot_test_resource.robot file

Changes:
- While running bunch of scripts, sometimes due to session not available power operations keywords are getting failed.
Hence ad

Added redfish.login in obmc_boot_test_resource.robot file

Changes:
- While running bunch of scripts, sometimes due to session not available power operations keywords are getting failed.
Hence added redfish.login in OBMC Boot Test keyword on extended/obmc_boot_test_resource.robot file.

Tested:
- Ran All The Scripts Successfully

Change-Id: I44b3c8469c8044a0e74aec030057da505b709281
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot
- Replaced all the Managers/bmc to Managers/${MANAGER_ID} across all the scripts
- Also in data/variables.py updated chassis id for the few redfish uri.

Tested:
- Ran All The Scripts Successfully

Change-Id: Iff3673aae27657e0799dec5cb94c1651a0cd5d18
Signed-off-by: ganesanb <ganesanb@ami.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add systemd circular dependency check

It's usefull add circular dependency check for systemd units.

The error log if had circular dependency:
```
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_proje

Add systemd circular dependency check

It's usefull add circular dependency check for systemd units.

The error log if had circular dependency:
```
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found ordering cycle on xyz.openbmc_project.Software.BMC.Updater.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on sel-ready.target/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on xyz.openbmc_project.Logging.IPMI.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on xyz.openbmc_project.Logging.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on obmc-fru-fault-monitor.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on xyz.openbmc_project.AssetManager.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Job xyz.openbmc_project.Software.BMC.Updater.service/start deleted to break ordering cycle start
Mar 10 06:20:45 g220b systemd[1]: Queued start job for default target Multi-User System.
```

I think this is good to check it in CI.

Tested:
```
~# python3 -m robot -v OPENBMC_HOST:xx.xx.xx.xx redfish/test_xit.robot

Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found ordering cycle on xyz.openbmc_project.Software.BMC.Updater.service/start
Verify No BMC Dump And Application Failures In BMC :: Verify no BM... | FAIL |
'Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found ordering cycle on xyz.openbmc_project.Software.BMC.Updater.service/start' should be empty.
------------------------------------------------------------------------------
Test Xit :: This suite is to run some test at the end of execution. | FAIL |
1 test, 0 passed, 1 failed
==============================================================================
```

Change-Id: I3288106b06399acf22fa44cba3b3d0fa69944cfc
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c8895

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c88953
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or
# Once this commit is merged.
pip3 install -r requirements.txt

Version latest:
robotframework-requests 0.9.3

Refer Documentation:
https://marketsquare.github.io/robotframework-requests/doc/RequestsLibrary.html

What is not changed:
- The test cases under directory tests/ is not modified and is
deprecated but you can continue using it with older package
and configuration using

git clone -b v3.0-stable https://github.com/openbmc/openbmc-test-automation

Tested:
Upstream HW_CI test list, firmware code update and few other
test suite like ipmi, certificate, dumps, ffdc and redfish
test suites.

Note: I have not tested end to end, so it is likely there could be
grey areas where it could fail but should be minor w.r.t
response data format.

Resolves: openbmc/openbmc-test-automation#2105

Change-Id: Ie03b25ff88948bcccb09e9d82f8da86e28c92697
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix Reset reload runtime

Change-Id: I33b199c64e24cf44ca6fa8a33d642daebaafc9b6

Update Reset reload loop to skip stack if already booted

Change-Id: Ic12399fcbba78c3cec8effd672fd293ccc374b95
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Fix test case tag names from multiple suites

Change-Id: I3890effc456c6f8f406d9c010dc7dafff22b503e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
py

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Watchdog: Add Redfish Initiate Auto Reboot

Redfish Initiate Auto Reboot using busctl command.

- Patchset #1: Initial commit.
- Patchset #2: Change per review comments.

Change-Id: I943c5086f87d133a

Watchdog: Add Redfish Initiate Auto Reboot

Redfish Initiate Auto Reboot using busctl command.

- Patchset #1: Initial commit.
- Patchset #2: Change per review comments.

Change-Id: I943c5086f87d133ac4b47e3bf5ade7c5849053f2
Signed-off-by: Peter D Phan <peterp@us.ibm.com>

show more ...

BMC Reset Reload when host is at runtime in loop

Changes:
- New Test and keyword to loop execution Reset Reload

Change-Id: Ie386902528de5db7549a6514c26b2b5ddd77de23
Signed-off-by: George Keish

BMC Reset Reload when host is at runtime in loop

Changes:
- New Test and keyword to loop execution Reset Reload

Change-Id: Ie386902528de5db7549a6514c26b2b5ddd77de23
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Automation fix to delete the non functional image

Changes:
- In previous code if user try to install the firmware which is
non-functional but in active state then the code update skip,

Automation fix to delete the non functional image

Changes:
- In previous code if user try to install the firmware which is
non-functional but in active state then the code update skip,
and it changes the priority to lowest and then make it
fucntional image.
- In new implementation, user can flash the firmware.
- When user flash an image which is non functional on BMC,
then these changes will delete the non functional image on BMC.
After the deleting the non fucntional image, a fresh code update
start with user image.

Signed-off-by: susilsi7 <susilsi7@in.ibm.com>
Change-Id: Ib4a42506614495e3c0b572d445d3858c13bfc4fc

show more ...

Clean up Redfish event notification subscriptions

Change-Id: I0e00c9ddfe9f0a756604c7fd06f88b0c2cfcbf7a
Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>

Add support to flush out system dumps

Changes:
- Added keyword to delete system dumps.
- Call the new keyword at boot test and clean up path.

Change-Id: Ibdb880b7e0ad07b9097b3c97701fea72c

Add support to flush out system dumps

Changes:
- Added keyword to delete system dumps.
- Call the new keyword at boot test and clean up path.

Change-Id: Ibdb880b7e0ad07b9097b3c97701fea72c2d4f28a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Move REST software manager from redfish to extended/code_update/ directory

Redfish code changes for the same are WIP.

Change-Id: I988aaf3350f2ff2966138e0a7dd21d79b41093cb
Signed-off-by: George Keis

Move REST software manager from redfish to extended/code_update/ directory

Redfish code changes for the same are WIP.

Change-Id: I988aaf3350f2ff2966138e0a7dd21d79b41093cb
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...