Consolidate username and password in test

Changes:
- Remove REST_USERNAME and REST_PASSWORD. Legacy username
and password, default user OPENBMC_USERNAME and
OPENBMC_PASSWORD.

Tested

Consolidate username and password in test

Changes:
- Remove REST_USERNAME and REST_PASSWORD. Legacy username
and password, default user OPENBMC_USERNAME and
OPENBMC_PASSWORD.

Tested:
- Boot test and sanity runs from sandbox

Change-Id: I86955d512530889c1a875b5efcc71f9df99432d9
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Clean up hardcoded paths from boot scripts

Changes:
- Remove default hardcoded paths from the code.

Tested:
- NA since not applicable for use in general.

Change-Id: Ib3f41055b580bf8ea68154

Clean up hardcoded paths from boot scripts

Changes:
- Remove default hardcoded paths from the code.

Tested:
- NA since not applicable for use in general.

Change-Id: Ib3f41055b580bf8ea681542361cdd8de2bcbf396
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

CI Python Markdown errors fixes

Changes:
- Fix line spacing

Tested:
- CI test from gerrit jenkins

Change-Id: I87675375085f509a3c0eb8cd0bfb6762be9bd5e0
Signed-off-by: George Keishing <gkeis

CI Python Markdown errors fixes

Changes:
- Fix line spacing

Tested:
- CI test from gerrit jenkins

Change-Id: I87675375085f509a3c0eb8cd0bfb6762be9bd5e0
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

pycodestyle: fix issues

When calling pycodestyle directly on a file (vs the project as a
whole) it seems to be a bit more opinionated. Fix up these issues
so we can change how we call pycodestyle o

pycodestyle: fix issues

When calling pycodestyle directly on a file (vs the project as a
whole) it seems to be a bit more opinionated. Fix up these issues
so we can change how we call pycodestyle organization-wide.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If561fb1ec3036b5fd5a600969fb5d81274464db2

show more ...

Add stop on certain PELs

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I0a54f2eeb0362dbd2d02156e4b2263e02d63c102

Add Redfish support to the Stop plug-in

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: Ib7957abaca4808682964a40774ebe91f60347c2e

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
py

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Changes to support redfish only build

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: Ibac9057e4d8e41fdb616c78239e1838a09c52878

Stop/cp_stop_check: ArgumentDefaultsHelpFormatter

With RawTextHelpFormatter, the help text is has a right margin and is
therefore easier to view.

Change-Id: I13d9cde391d05738a25414372b199e2047a29bf

Stop/cp_stop_check: ArgumentDefaultsHelpFormatter

With RawTextHelpFormatter, the help text is has a right margin and is
therefore easier to view.

Change-Id: I13d9cde391d05738a25414372b199e2047a29bfb
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Standardized Stop/cp_stop_check

Made changes to standardize Stop/cp_stop_check.

Change-Id: I56967d3c728a9170d59b8ed427cd7281e751c882
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Stop/cp_stop_check: get_plug_default("test_mode")

Change-Id: Ic4779b143da57816f16cc86b9cd5800e6aa667d2
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Stop/cp_stop_check newer style save_plug_in_value

Change-Id: I60c69f98ce20c37c3d90602d81d9b0b4428eebff
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Use SSH_PORT/HTTPS_PORT in basic functions

- In order to improve the code base's ability to run with simulated
machines, specified SSH_PORT and HTTPS_PORT in basic functions that
communicate with th

Use SSH_PORT/HTTPS_PORT in basic functions

- In order to improve the code base's ability to run with simulated
machines, specified SSH_PORT and HTTPS_PORT in basic functions that
communicate with the OBMC machine.
- Also adjusted some calls to set or pass SSH_PORT and HTTPS_PORT.

Change-Id: If3a8b317eda80ac9c071c51084ede20ce3023484
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Change several python and robot files to 110 chars

Taking advantage of current team limit of 110 chars.

Change-Id: If7ab51fe894889967b8c8bb2f2fa4664f01117d5
Signed-off-by: Michael Walsh <micwalsh@u

Change several python and robot files to 110 chars

Taking advantage of current team limit of 110 chars.

Change-Id: If7ab51fe894889967b8c8bb2f2fa4664f01117d5
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Switch to exit_on_error mode

Switch several programs to newer exit_on_error mode. This mode dictates
the behavior of the validation functions.

Also, valid_value recently:
- Switched the order of 2

Switch to exit_on_error mode

Switch several programs to newer exit_on_error mode. This mode dictates
the behavior of the validation functions.

Also, valid_value recently:
- Switched the order of 2 positional arguments
- Added code to default invalid_values to ["", None] vs [""]

Changed Auto_reboot/cp_master accordingliny.

Change-Id: I3ade00d8b51d567604f59ff6c8f993f4afc864ee
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Stop REST check moved last to improve performance

Changed to check for REST functionality last for better efficiency.
If a test has failed, and the test is to be stopped, it is a waste of time to
fi

Stop REST check moved last to improve performance

Changed to check for REST functionality last for better efficiency.
If a test has failed, and the test is to be stopped, it is a waste of time to
first check whether REST commands are working since the result will be the
same.

The same is true for esel_stop_check.

Change-Id: I3237c0e06659eb3f587742cd7e737b7e373e7c9b
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

plug_ins: Use exit_not_master/print_plug_in_header

Update several plug-ins as follows:
- Use exit_not_master where appropriate. See gen_plug_in_utils.py
exit_not_master prolog for more info.
- Ch

plug_ins: Use exit_not_master/print_plug_in_header

Update several plug-ins as follows:
- Use exit_not_master where appropriate. See gen_plug_in_utils.py
exit_not_master prolog for more info.
- Change from using dprint_plug_vars to print_plug_in_header which is
more comprehensive.

Change-Id: I5dedb7ae1faaa0cc6344e6f7e45a02cbba01d3b5
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Set and save stop_check_rc after each decision to stop test execution II

Change-Id: I7a8ca3df2b56c71746dd03fca0da054a2e9ba1fd

Revert "Set and save stop_check_rc after each decision to stop test execution"

This reverts commit c8483e3687aded01df097625a71a55075a326355.

Change-Id: I174d469085284843d306bef927b834fa4e27fafa

Set and save stop_check_rc after each decision to stop test execution

This allows other programs to make decisions based on the activity of
the Stop plug-in.

Change-Id: I8b51edf75fcc310e7b3671ee4bb

Set and save stop_check_rc after each decision to stop test execution

This allows other programs to make decisions based on the activity of
the Stop plug-in.

Change-Id: I8b51edf75fcc310e7b3671ee4bb8ff394deb1c66
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Stop/cp_stop_check: Add lib/gen_robot_print.py

This was made necessary by the change in
https://gerrit.openbmc-project.xyz/#/c/openbmc/openbmc-test-automation/+/15089/

Change-Id: I5579145cc304475a1

Stop/cp_stop_check: Add lib/gen_robot_print.py

This was made necessary by the change in
https://gerrit.openbmc-project.xyz/#/c/openbmc/openbmc-test-automation/+/15089/

Change-Id: I5579145cc304475a10d70c2fc62ae6791cf9031f
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Id20fe

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Id20fef954fd977a307ba36dce5c8c7365aa96a6d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...