Pass CHASSIS_ID, MANAGER_ID and SYSTEM_ID to subcommands

Changes:
- Read env variables and pass it as variables to the robot command
that runs tests. This makes tests using correct Redfish URL

Pass CHASSIS_ID, MANAGER_ID and SYSTEM_ID to subcommands

Changes:
- Read env variables and pass it as variables to the robot command
that runs tests. This makes tests using correct Redfish URLs if the
system uses non default IDs.

Tested:
Ran tests against 2 platforms and it fixed tests that had failed
before due to usage of default IDs despite correct IDs were set in env
and passed to the main robot process as variables.

Change-Id: I3ed04f2237f0ef250b9568f4833fbf99fd5dfc65
Signed-off-by: Igor Kanyuka <ifelmail@gmail.com>

show more ...

Consolidate username and password in test

Changes:
- Remove REST_USERNAME and REST_PASSWORD. Legacy username
and password, default user OPENBMC_USERNAME and
OPENBMC_PASSWORD.

Tested

Consolidate username and password in test

Changes:
- Remove REST_USERNAME and REST_PASSWORD. Legacy username
and password, default user OPENBMC_USERNAME and
OPENBMC_PASSWORD.

Tested:
- Boot test and sanity runs from sandbox

Change-Id: I86955d512530889c1a875b5efcc71f9df99432d9
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

pycodestyle: fix issues

When calling pycodestyle directly on a file (vs the project as a
whole) it seems to be a bit more opinionated. Fix up these issues
so we can change how we call pycodestyle o

pycodestyle: fix issues

When calling pycodestyle directly on a file (vs the project as a
whole) it seems to be a bit more opinionated. Fix up these issues
so we can change how we call pycodestyle organization-wide.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If561fb1ec3036b5fd5a600969fb5d81274464db2

show more ...

Add IPMI_USERNAME and IPMI_PASSWORD to Auto_reboot

Signed-off-by: David Shaw <dlshaw@us.ibm.com>
Change-Id: I60a95cecd42ec4ec99d5adeefc41295099125ccb

FIX REDFISH_SUPPORT_TRANS_STATE not defined in DVT environment.

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: Ie98c13dbf7b27ce52cbfc55abacf6a1568a32e02

Revert "Add retries to robot command."

This reverts commit ae56bee659967a826397bdea9a37c83ec0fa7070.

Reason for revert: Failed in boot plugin run

Change-Id: I2de4926fe3049b0f1491d17ea4a28c26c50b2a

Revert "Add retries to robot command."

This reverts commit ae56bee659967a826397bdea9a37c83ec0fa7070.

Reason for revert: Failed in boot plugin run

Change-Id: I2de4926fe3049b0f1491d17ea4a28c26c50b2a9e

show more ...

Add retries to robot command.

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I5a5b95a2024787a2e5896cccc6a1b92e1d61d75e

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
py

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add REDFISH_SUPPORT_TRANS_STATE to Auto_reboot plugin

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I3dc20129df3da198cf34f6d414b3e3e3d8a7832e

Revert "Pass in REDFISH_SUPPORT_TRANS_STATE to robot_cmd_fnc"

This reverts commit cb6b53b8c90fdc4636acfc2e1824831a8a9f532b.

Reason for revert: Works good from sandbox but not on Jenkins HW CI

Chan

Revert "Pass in REDFISH_SUPPORT_TRANS_STATE to robot_cmd_fnc"

This reverts commit cb6b53b8c90fdc4636acfc2e1824831a8a9f532b.

Reason for revert: Works good from sandbox but not on Jenkins HW CI

Change-Id: I411a7b08a131936c089b69dbeb3ed62a72f59786

show more ...

Pass in REDFISH_SUPPORT_TRANS_STATE to robot_cmd_fnc

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I68a824b706c6781b833c69f45f244baf62a8ce0e

Changes to support redfish only firmware

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I742c0740573ea7db99ff7c4eb1ed8542dce6bf0b

Auto_reboot/cp_master to use set_term_options

Required some modernization as well.

Change-Id: I1b9f50a1bdd0350312f4c28534bc97517a159f18
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Use SSH_PORT/HTTPS_PORT in basic functions

- In order to improve the code base's ability to run with simulated
machines, specified SSH_PORT and HTTPS_PORT in basic functions that
communicate with th

Use SSH_PORT/HTTPS_PORT in basic functions

- In order to improve the code base's ability to run with simulated
machines, specified SSH_PORT and HTTPS_PORT in basic functions that
communicate with the OBMC machine.
- Also adjusted some calls to set or pass SSH_PORT and HTTPS_PORT.

Change-Id: If3a8b317eda80ac9c071c51084ede20ce3023484
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Auto_reboot: Enable/disable values were backwards

- Also changed comments and doc strings to wrap at 110 chars vs 79.

Change-Id: Ia4a66265be50f40468b293a5a67765aa81fd52d6
Signed-off-by: Michael Wal

Auto_reboot: Enable/disable values were backwards

- Also changed comments and doc strings to wrap at 110 chars vs 79.

Change-Id: Ia4a66265be50f40468b293a5a67765aa81fd52d6
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Switch to exit_on_error mode

Switch several programs to newer exit_on_error mode. This mode dictates
the behavior of the validation functions.

Also, valid_value recently:
- Switched the order of 2

Switch to exit_on_error mode

Switch several programs to newer exit_on_error mode. This mode dictates
the behavior of the validation functions.

Also, valid_value recently:
- Switched the order of 2 positional arguments
- Added code to default invalid_values to ["", None] vs [""]

Changed Auto_reboot/cp_master accordingliny.

Change-Id: I3ade00d8b51d567604f59ff6c8f993f4afc864ee
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

plug_ins: Use exit_not_master/print_plug_in_header

Update several plug-ins as follows:
- Use exit_not_master where appropriate. See gen_plug_in_utils.py
exit_not_master prolog for more info.
- Ch

plug_ins: Use exit_not_master/print_plug_in_header

Update several plug-ins as follows:
- Use exit_not_master where appropriate. See gen_plug_in_utils.py
exit_not_master prolog for more info.
- Change from using dprint_plug_vars to print_plug_in_header which is
more comprehensive.

Change-Id: I5dedb7ae1faaa0cc6344e6f7e45a02cbba01d3b5
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

New Auto_reboot plug-in II

Also, added code to obmc boot test to process rest_username and
rest_password.

Change-Id: I7b64be7072d4848230e9d47a4da54ac89794af64

New Auto_reboot plug-in

Plug-in to set auto reboot value for obmc boot testing according to user's
wishes.

Change-Id: I3250141ec32ed0d529ba44f980221c86bc8d67dd
Signed-off-by: Michael Walsh <micwals

New Auto_reboot plug-in

Plug-in to set auto reboot value for obmc boot testing according to user's
wishes.

Change-Id: I3250141ec32ed0d529ba44f980221c86bc8d67dd
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...