8cfff0d5 | 20-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
tools: owners: support recursive OWNERS
Search for any OWNERS files anywhere in the repository, rather than just at the root, and incorporate their information into the review-set.
Tested: Modified
tools: owners: support recursive OWNERS
Search for any OWNERS files anywhere in the repository, rather than just at the root, and incorporate their information into the review-set.
Tested: Modified meta-aspeed/recipes-bsp/u-boot/u-boot-aspeed.inc and observed additional reviewers as expected.
``` $ tools/owners --path $(wd path lfopenbmc) reviewers {"reviewer": "bradleyb@fuzziesquirrel.com", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["bradleyb@fuzziesquirrel.com"]}}} {"reviewer": "edtanous@google.com", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["edtanous@google.com"]}}} {"reviewer": "geissonator@yahoo.com", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["geissonator@yahoo.com"]}}} {"reviewer": "joel@jms.id.au", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["joel@jms.id.au"]}}} {"reviewer": "patrick@stwcx.xyz", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["patrick@stwcx.xyz"]}}} {"reviewer": "chiawei_wang@aspeedtech.com", "state": "CC", "notify": "NONE", "notify_details": {"TO": {"accounts": ["chiawei_wang@aspeedtech.com"]}}} {"reviewer": "zweiss@equinix.com", "state": "CC", "notify": "NONE", "notify_details": {"TO": {"accounts": ["zweiss@equinix.com"]}}} ```
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I08775e3975897066d79c22ba38f0fdef364ed708
show more ...
|
29986f19 | 19-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
tools: owners: reduce notify spam from Jenkins
By default, the Gerrit 'reviewers' API will notify everyone of the change to add a new reviewer. When adding reviewers automatically from Jenkins this
tools: owners: reduce notify spam from Jenkins
By default, the Gerrit 'reviewers' API will notify everyone of the change to add a new reviewer. When adding reviewers automatically from Jenkins this can cause quite a bit of spam. Adjust the 'notify' fields of the API call so that only the newly-added reviewer is notified.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ib992284918145a31c9ff749737b3ae09f4d5ef0e
show more ...
|
ca1b89eb | 19-Jun-2022 |
Patrick Williams <patrick@stwcx.xyz> |
tools: owners: handle matchers
Enhance the owners tool to parse the 'matchers' directives in order to add additional owners and reviewers.
Tested:
* Created a bogus commit in 'docs' to detect GPIO
tools: owners: handle matchers
Enhance the owners tool to parse the 'matchers' directives in order to add additional owners and reviewers.
Tested:
* Created a bogus commit in 'docs' to detect GPIO and MCTP matchers. * Created a bogus commit in 'smbios-mdr' to detect change to speed_select.hpp.
``` $ tools/owners --path ../docs reviewers && echo "..." && tools/owners --path ../smbios-mdr reviewers {"reviewer": "bradleyb@fuzziesquirrel.com", "state": "REVIEWER"} {"reviewer": "patrick@stwcx.xyz", "state": "REVIEWER"} {"reviewer": "andrew@aj.id.au", "state": "CC"} {"reviewer": "anoo@us.ibm.com", "state": "CC"} {"reviewer": "gmills@linux.vnet.ibm.com", "state": "CC"} {"reviewer": "jk@ozlabs.org", "state": "CC"} {"reviewer": "joel@jms.id.au", "state": "CC"} ... {"reviewer": "jonathan.doman@intel.com", "state": "REVIEWER"} {"reviewer": "kuiying.wang@intel.com", "state": "REVIEWER"} {"reviewer": "yugang.chen@linux.intel.com", "state": "REVIEWER"} {"reviewer": "zhikui.ren@intel.com", "state": "REVIEWER"} ```
Change-Id: Idda5e344c1d061d1ceaef35b65d546b3b679b382 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
6cef255a | 29-May-2022 |
Patrick Williams <patrick@stwcx.xyz> |
tools: owners: initial parsing of OWNERS file
Tested:
``` $ tools/owners reviewers {"reviewer": "geissonator@yahoo.com", "state": "REVIEWER"} {"reviewer": "joel@jms.id.au", "state": "REVIEWER"} {"r
tools: owners: initial parsing of OWNERS file
Tested:
``` $ tools/owners reviewers {"reviewer": "geissonator@yahoo.com", "state": "REVIEWER"} {"reviewer": "joel@jms.id.au", "state": "REVIEWER"} {"reviewer": "patrick@stwcx.xyz", "state": "REVIEWER"} {"reviewer": "andrew@aj.id.au", "state": "CC"}
$ tools/owners reviewers --push-args r=geissonator@yahoo.com,r=joel@jms.id.au,r=patrick@stwcx.xyz,cc=andrew@aj.id.au ```
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I145bd065dff101776c733fddb26fea4f324dd100
show more ...
|