config-clang-tidy: support dropping config options

The latest docs .clang-tidy reference dropped some config options,
so add support for that to the tool.

Signed-off-by: Patrick Williams <patrick@s

config-clang-tidy: support dropping config options

The latest docs .clang-tidy reference dropped some config options,
so add support for that to the tool.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4b9c33f9d01697d06574f931aa2c8a782cafc262

show more ...

config-clang-tidy: add format subcommand

The 'merge' subcommand can be used for formatting, if the `--reference`
is the same clang-tidy file as the input, but this is not convenient
for users. Add

config-clang-tidy: add format subcommand

The 'merge' subcommand can be used for formatting, if the `--reference`
is the same clang-tidy file as the input, but this is not convenient
for users. Add a 'format' subcommand that does the expected.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If51ded84e85f6f285a6b5d1df0764ff20b1b2064

show more ...

config-clang-tidy: better handle wildcards

Some repositories had category wildcards; handle those better:
- Remove category disables since we already disable global.
- Allow category enables t

config-clang-tidy: better handle wildcards

Some repositories had category wildcards; handle those better:
- Remove category disables since we already disable global.
- Allow category enables to act as a single check.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibe320717331c0627439c54846465786b9316f186

show more ...

config-clang-tidy: strip comments better

Some repositories have a Checks line with embedded comments. This
is unsupported by the python YAML parser and results in strings where
comment lines can no

config-clang-tidy: strip comments better

Some repositories have a Checks line with embedded comments. This
is unsupported by the python YAML parser and results in strings where
comment lines can no longer be identified because it becomes one big
paragraph. Strip these out prior to YAML processing.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I455ea4584d71d1ff94710ad8a5c02d5eabb05b82

show more ...

config-clang-tidy: introduce tool

There have been a few efforts to enable clang-tidy across the
organization, many of which have either been partially applied or
inconsistently applied. Part of the

config-clang-tidy: introduce tool

There have been a few efforts to enable clang-tidy across the
organization, many of which have either been partially applied or
inconsistently applied. Part of the issue has been that enabling
options is done by hand by humans.

Introduce a tool that allows us to more automatically manipulate
the clang-tidy configs. There are currently 3 sub-commands:
- merge
- enable
- disable

The merge command can be used to merge an existing repository
clang-tidy config with a reference, such as the one in docs:
```
tools/config-clang-tidy --repo ../phosphor-virtual-sensor \
merge --reference ../docs/style/cpp/.clang-tidy
```

Similarly, the enable / disable commands can be used to enable or
disable an individual check.
```
./tools/config-clang-tidy --repo ../phosphor-virtual-sensor \
enable modernize-use-nullptr
```

This tool will enable us to create scripts jobs that:
- Synchronize the clang-tidy config across a large set of
repositories.
- Enable a single check across a large set of repositories and
examine the fallout.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib338f7dcbc7f1049122399e0b616f77ec5eb7dc2

show more ...

format-code: handle incorrect 'env python3'

I noticed the `tools/owners` file was not getting the linters ran
correctly and upon investigation I found that it had the wrong path
for env, which cause

format-code: handle incorrect 'env python3'

I noticed the `tools/owners` file was not getting the linters ran
correctly and upon investigation I found that it had the wrong path
for env, which caused `file` to give incorrect results.

Fix the path in tools/owners, reformat and fix linter issues, and
ensure the scripts can handle python3 scripts with the wrong env
path.

I checked the codebase and there was only one other script, which
happens to reside in openbmc/openbmc, which used this incorrect
path. Therefore this change should have no effect on existing
repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ice9703afbf104e3529f2c1b29ba8ba680eb07d94

show more ...

tools: owners: support recursive OWNERS

Search for any OWNERS files anywhere in the repository, rather than
just at the root, and incorporate their information into the
review-set.

Tested: Modified

tools: owners: support recursive OWNERS

Search for any OWNERS files anywhere in the repository, rather than
just at the root, and incorporate their information into the
review-set.

Tested: Modified meta-aspeed/recipes-bsp/u-boot/u-boot-aspeed.inc
and observed additional reviewers as expected.

```
$ tools/owners --path $(wd path lfopenbmc) reviewers
{"reviewer": "bradleyb@fuzziesquirrel.com", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["bradleyb@fuzziesquirrel.com"]}}}
{"reviewer": "edtanous@google.com", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["edtanous@google.com"]}}}
{"reviewer": "geissonator@yahoo.com", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["geissonator@yahoo.com"]}}}
{"reviewer": "joel@jms.id.au", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["joel@jms.id.au"]}}}
{"reviewer": "patrick@stwcx.xyz", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["patrick@stwcx.xyz"]}}}
{"reviewer": "chiawei_wang@aspeedtech.com", "state": "CC", "notify": "NONE", "notify_details": {"TO": {"accounts": ["chiawei_wang@aspeedtech.com"]}}}
{"reviewer": "zweiss@equinix.com", "state": "CC", "notify": "NONE", "notify_details": {"TO": {"accounts": ["zweiss@equinix.com"]}}}
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I08775e3975897066d79c22ba38f0fdef364ed708

show more ...

tools: owners: reduce notify spam from Jenkins

By default, the Gerrit 'reviewers' API will notify everyone of
the change to add a new reviewer. When adding reviewers automatically
from Jenkins this

tools: owners: reduce notify spam from Jenkins

By default, the Gerrit 'reviewers' API will notify everyone of
the change to add a new reviewer. When adding reviewers automatically
from Jenkins this can cause quite a bit of spam. Adjust the 'notify'
fields of the API call so that only the newly-added reviewer is
notified.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib992284918145a31c9ff749737b3ae09f4d5ef0e

show more ...

jenkins: add owners tool to userid-validation flow

Run the 'owners' tool during the userid-validation so that
owners and reviewers are automatically added by Jenkins.

Fix a few minor issues with th

jenkins: add owners tool to userid-validation flow

Run the 'owners' tool during the userid-validation so that
owners and reviewers are automatically added by Jenkins.

Fix a few minor issues with the 'owners' tool:

- Switch the 'push-args' option from BooleanOptionalAction since
this isn't supported in the Python version on the Jenkins
controller.

- Handle empty 'matchers' statements.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib496c5874a532299ecf821345c8c25d87a21f3f1

show more ...

tools: owners: handle matchers

Enhance the owners tool to parse the 'matchers' directives in order
to add additional owners and reviewers.

Tested:

* Created a bogus commit in 'docs' to detect GPIO

tools: owners: handle matchers

Enhance the owners tool to parse the 'matchers' directives in order
to add additional owners and reviewers.

Tested:

* Created a bogus commit in 'docs' to detect GPIO and MCTP matchers.
* Created a bogus commit in 'smbios-mdr' to detect change to
speed_select.hpp.

```
$ tools/owners --path ../docs reviewers && echo "..." && tools/owners --path ../smbios-mdr reviewers
{"reviewer": "bradleyb@fuzziesquirrel.com", "state": "REVIEWER"}
{"reviewer": "patrick@stwcx.xyz", "state": "REVIEWER"}
{"reviewer": "andrew@aj.id.au", "state": "CC"}
{"reviewer": "anoo@us.ibm.com", "state": "CC"}
{"reviewer": "gmills@linux.vnet.ibm.com", "state": "CC"}
{"reviewer": "jk@ozlabs.org", "state": "CC"}
{"reviewer": "joel@jms.id.au", "state": "CC"}
...
{"reviewer": "jonathan.doman@intel.com", "state": "REVIEWER"}
{"reviewer": "kuiying.wang@intel.com", "state": "REVIEWER"}
{"reviewer": "yugang.chen@linux.intel.com", "state": "REVIEWER"}
{"reviewer": "zhikui.ren@intel.com", "state": "REVIEWER"}
```

Change-Id: Idda5e344c1d061d1ceaef35b65d546b3b679b382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

tools: owners: initial parsing of OWNERS file

Tested:

```
$ tools/owners reviewers
{"reviewer": "geissonator@yahoo.com", "state": "REVIEWER"}
{"reviewer": "joel@jms.id.au", "state": "REVIEWER"}
{"r

tools: owners: initial parsing of OWNERS file

Tested:

```
$ tools/owners reviewers
{"reviewer": "geissonator@yahoo.com", "state": "REVIEWER"}
{"reviewer": "joel@jms.id.au", "state": "REVIEWER"}
{"reviewer": "patrick@stwcx.xyz", "state": "REVIEWER"}
{"reviewer": "andrew@aj.id.au", "state": "CC"}

$ tools/owners reviewers --push-args
r=geissonator@yahoo.com,r=joel@jms.id.au,r=patrick@stwcx.xyz,cc=andrew@aj.id.au
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I145bd065dff101776c733fddb26fea4f324dd100

show more ...

commit-tracker: remove dead tool

This tool was last touched in 2016 and uses python2. It seems like
nobody actively uses it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1806ade

commit-tracker: remove dead tool

This tool was last touched in 2016 and uses python2. It seems like
nobody actively uses it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1806ade444710ed82d4bab70d3e1f1d2b67c4c54

show more ...

Added JSON output to commit-tracker

Change-Id: I11cd0a7c7ca68824ae175556c4e09f70caa9e863
Signed-off-by: Charles Hofer <cphofer@us.ibm.com>

Added HTML output to commit-tracker

Change-Id: Ib62deb9204a79080fb45ba23ea43170a8590ade4
Signed-off-by: Charles Hofer <cphofer@us.ibm.com>

Commit tracker now prints information on closed issues

Change-Id: I09443d0045dd466390a4444982a618a5c93e7d1e
Signed-off-by: Charles Hofer <cphofer@us.ibm.com>

Added line counts and switched to object-based approach in commit-tracker

Change-Id: Ibd8e382fcfb39d73d7684663add99796b63ce729
Signed-off-by: Charles Hofer <cphofer@us.ibm.com>

Switched to argparse in commit-tracker

Change-Id: Idcdb676d309c4888a82bc0b556192507ab5b4617
Signed-off-by: Charles Hofer <cphofer@us.ibm.com>

Added commit-tracker tool

Created a tool to view the number of commits between two revisions

Change-Id: Iba3481e56c0745f85e31904ea06bc70bbe82f230
Signed-off-by: Charles Hofer <cphofer@us.ibm.com>