scripts/unit-test: Support multiple bootstrap files

Some packages don't follow our ./bootstrap.sh convention. Support other
common autotools bootstrap filenames.

Change-Id: Ia0356c734f7c5e8d6d1732f

scripts/unit-test: Support multiple bootstrap files

Some packages don't follow our ./bootstrap.sh convention. Support other
common autotools bootstrap filenames.

Change-Id: Ia0356c734f7c5e8d6d1732fd6960d61a59932167
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

unit-test: Support running as non-root

This is nice to have so that all of the generated files in our workspace
are owned by our user so we don't have to deal with ownership issues
after the build h

unit-test: Support running as non-root

This is nice to have so that all of the generated files in our workspace
are owned by our user so we don't have to deal with ownership issues
after the build has completed.

Tested:
Built all of the openbmc packages locally and found no regressions.

Change-Id: I0811ac4e356a023a1238e291f8184dfe01eb003e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

script/unit-test: Refactor out individual build

This doesn't change any behavior, but it will allow us to perform builds
outside of the original install_deps flow.

Change-Id: I93b6bca86ed92e28fde6c

script/unit-test: Refactor out individual build

This doesn't change any behavior, but it will allow us to perform builds
outside of the original install_deps flow.

Change-Id: I93b6bca86ed92e28fde6c1503c28f123bf8c3da4
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Redfish library API package install needed for test automation

Reference DMTF https://github.com/DMTF/python-redfish-library

Change-Id: I074ea33b6a4966297e9186eb8090748af5aee9ae
Signed-off-by: Geor

Redfish library API package install needed for test automation

Reference DMTF https://github.com/DMTF/python-redfish-library

Change-Id: I074ea33b6a4966297e9186eb8090748af5aee9ae
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

scripts: format-code: enable .clang-ignore file

Add an optional .clang-ignore file s.t. a repository can exclude files
by name or paths from clang-format. Paths must start "./" per find's
manual an

scripts: format-code: enable .clang-ignore file

Add an optional .clang-ignore file s.t. a repository can exclude files
by name or paths from clang-format. Paths must start "./" per find's
manual and not end in slash. Filenames must be simply the filename to
exclude.

For example:
./src/external
linux_header.h

This also supports comment lines starts with '#' and will skip over any
line that starts with whitespace.

Change-Id: I4129bc6e3003fc4a46f1dcc3ae38a0ab285c2dd8
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

scripts: format-code.sh: use double braces

Use double braces in format-code.sh

[[ ... ]] reduces errors as no pathname expansion or word splitting
takes place between [[ and ]]. In addition, [[ ...

scripts: format-code.sh: use double braces

Use double braces in format-code.sh

[[ ... ]] reduces errors as no pathname expansion or word splitting
takes place between [[ and ]]. In addition, [[ ... ]] allows for
regular expression matching while [ ... ] does not.

Change-Id: Ie74e625edd8b3f6f9b4c4ec2a9dce14983c73643
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build-unit-test-docker: add cppcheck static analysis tool

Add the cppcheck static analysis tool. This tool's output is only for
information while it's being tuned. The tool is meant to find securi

build-unit-test-docker: add cppcheck static analysis tool

Add the cppcheck static analysis tool. This tool's output is only for
information while it's being tuned. The tool is meant to find security
flaws in cpp as well as finding performance improvements and style. In
this case, the style improvements have been primarily scope reduction
or using a standard library algorithm instead of a raw mechanism.

The author of a patch should check the log output from their presubmit
to see if this tool has identified anything. The reviewers can also
check.

The tuning here refers to the configuration. This tool was chosen
partially because it's under very active development and partially
because it's very quick.

If cppcheck reports a false positive, please file an issue against that
project including the pertinent information.

Change-Id: Ia43d4b9d0995dfa6667c2a8b09d072931936e437
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

scripts: unit-test: add missing regex typing

Prepend regex string with "r"

Change-Id: Id448e3a7fead65650f9956eb948e4afe63e45204
Signed-off-by: Patrick Venture <venture@google.com>

scripts/format-code: Pass CLANG_FORMAT via environment

Some projects define their own code formatting scripts. Instead of
requiring them to update the code formatting script each time the
version of

scripts/format-code: Pass CLANG_FORMAT via environment

Some projects define their own code formatting scripts. Instead of
requiring them to update the code formatting script each time the
version of clang-format changes, pass it via the environment so they
can use our version.

Change-Id: Ia7e8210f28024e75fa63995695bb89c401b349ad
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

add phosphor-ipmi-blobs package to CI

The CI requires OpenBMC libraries or packages to be explicitly defined
for inclusion. Add the phosphor-ipmi-blobs package as there are
packages that build agai

add phosphor-ipmi-blobs package to CI

The CI requires OpenBMC libraries or packages to be explicitly defined
for inclusion. Add the phosphor-ipmi-blobs package as there are
packages that build against it.

Change-Id: I9ff92792969e299461fe97d1adc8f10bdc3e28b3
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Install openssl to test certificate in automation.

Resolves openbmc/openbmc-build-scripts#14

Change-Id: Ic3ac009c0b492b60808fa7c24867dd13d4560544
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in

Install openssl to test certificate in automation.

Resolves openbmc/openbmc-build-scripts#14

Change-Id: Ic3ac009c0b492b60808fa7c24867dd13d4560544
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>

show more ...

unit-test: Add gpioplus

Needed for using gpioplus with openbmc daemons.

Change-Id: I1a20281600b6a45963e12c24dd362b42d1a85dcc
Signed-off-by: Patrick Venture <venture@google.com>

unit-test: Add sdeventplus

Needed for new packages using sdeventplus

Change-Id: I00b0563d4f4d7a5c491f465d507d75b79a5e196a
Signed-off-by: William A. Kennington III <wak@google.com>

Create a script for generating index files

OpenBMC CI logs will be moved to GitHub Pages or to IBM Cloud Object
Storage for developers inside and outside of IBM to view them. Neither
of these servic

Create a script for generating index files

OpenBMC CI logs will be moved to GitHub Pages or to IBM Cloud Object
Storage for developers inside and outside of IBM to view them. Neither
of these services create index files that allow us to view the
directory structure of our logs. This change adds a script that
generates the required index files for these logs.

Change-Id: I0f463cf0c4b22d5edbaf4cf71f7df996856dd15f
Signed-off-by: Charles Paul Hofer <Charles.Hofer@ibm.com>

show more ...

unit-test CI: switch to clang-format-6.0

clang-format-5.0 doesn't support the IncludeBlocks configuration option.

Change-Id: I5668c46e502b64f3302754a29383f3137e321014
Signed-off-by: Patrick Venture

unit-test CI: switch to clang-format-6.0

clang-format-5.0 doesn't support the IncludeBlocks configuration option.

Change-Id: I5668c46e502b64f3302754a29383f3137e321014
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Adding snmp package to dependent packages in unit-test script

phosphor-dbus-monitor is dependent on library exported by
phosphor-snmp. To build phoshor-dbus-monitor phoshpor-snmp
needs to be extract

Adding snmp package to dependent packages in unit-test script

phosphor-dbus-monitor is dependent on library exported by
phosphor-snmp. To build phoshor-dbus-monitor phoshpor-snmp
needs to be extracted and built.

Change-Id: I76d941fa84c293ad8467a6e8a838eb7f99e5f91c
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Add Cmake Support

Added initial cmake suport to unit-test.py. Used
bmcweb as repo to test with so added missing dependencies
of boost and xxd as well.

Tested-by: Built and ran unit tests for bmcweb

Add Cmake Support

Added initial cmake suport to unit-test.py. Used
bmcweb as repo to test with so added missing dependencies
of boost and xxd as well.

Tested-by: Built and ran unit tests for bmcweb

Change-Id: If06b8484a96b9a711ef6aa42fc63138138077c30
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

unit-test: Disable valgrind testing for ppc64

There is an issue caused by inlining of a strcmp function in optimized
code that valgrind picks up as use of uninitialized memory in jmp / mov.
Just ign

unit-test: Disable valgrind testing for ppc64

There is an issue caused by inlining of a strcmp function in optimized
code that valgrind picks up as use of uninitialized memory in jmp / mov.
Just ignore running valgrind tests on powerpc for now.
https://github.com/openbmc/openbmc/issues/3315

Change-Id: I1252efdcea3acb05f1fb8043ac995645d6631805
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

unit-test: Refactor testing into functions

This will make it easier to modify individual behavior in future commits
withouth dealing with all of the previous levels of nesting.

Change-Id: I7c46836a

unit-test: Refactor testing into functions

This will make it easier to modify individual behavior in future commits
withouth dealing with all of the previous levels of nesting.

Change-Id: I7c46836a0e34e1db8780005e5af4aa61143c7dde
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

unit-test: Enable parallel building

Running one off unit test builds could saturate more of the provided CPU
if we enabled parallel make steps. Currently our make processes just use
single threaded

unit-test: Enable parallel building

Running one off unit test builds could saturate more of the provided CPU
if we enabled parallel make steps. Currently our make processes just use
single threaded mode. This allows us to use all of the available CPUs
when building and testing projects which vastly speeds up builds on
projects with many dependencies when run on machines with many cores. It
also ensures that our builds have specified their dependencies correctly
since the Makefile will be run out of order and based more on the DAG.

Change-Id: I8dfefa9bb4d314143e020c32d40b82661e0a3981
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

unit-test: Make sure tests build

Some of our packages now support an option for explicitly enabling test
cases to build. This ensures for their autotools configure run that they
have all of the need

unit-test: Make sure tests build

Some of our packages now support an option for explicitly enabling test
cases to build. This ensures for their autotools configure run that they
have all of the needed dependencies for running the test cases. Since it
is important for the CI unit-test script to run and configure the tests
properly, pass this flag.

Change-Id: I65363d92aa7b35530a1ef5e1059cb100428ac5f0
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Copy images to /tmp before booting QEMU

QEMU writes things back to images after booting. After doing
this, sometimes QEMU is unable to boot that image again. This
change makes a copy of the image an

Copy images to /tmp before booting QEMU

QEMU writes things back to images after booting. After doing
this, sometimes QEMU is unable to boot that image again. This
change makes a copy of the image and boots from the copy so
that we do not write anything back to the original image.

Change-Id: I541db5732d9e1cf6a5969ab5b9d54dffcbecf0dd
Signed-off-by: Charles Paul Hofer <Charles.Hofer@ibm.com>

show more ...

unit-test: Run coverage and valgrind testing

This is oportunisticly enabled. If a build supports valgrind and
coverage metrics through the standard autoconf-archive mechanisms,
it will be forced to

unit-test: Run coverage and valgrind testing

This is oportunisticly enabled. If a build supports valgrind and
coverage metrics through the standard autoconf-archive mechanisms,
it will be forced to enable those settings. The unit test script then
checks to see if the makefile has the generated `check-valgrind` and
`check-code-coverage` targets and runs them if they exist.

Tested:
With valgrind and code coverage tests added to sdbuplus, the tests
all run as expected. With a non-enabled repo like phosphor-logging
the unit test script still works. Also tested that when valgrind
tests fail the exception is thrown and logs are written out as
expected.

Change-Id: I4709cc6dbea7c97f0ef64fdddc5bce496d0751c7
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

unit-test: Use verbose make rules by default

Silent make rules can be nice for the end user, but it makes it hard to
diagnose what went wrong with a build if the compiler flags are funky.

Tested:

unit-test: Use verbose make rules by default

Silent make rules can be nice for the end user, but it makes it hard to
diagnose what went wrong with a build if the compiler flags are funky.

Tested:
sdbusplus and phosphor-logging still test out fine.

Change-Id: I46b9c628156b45e8776be223ab01d4c1b15484b6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

unit-test: Find all test-suite.log

This removes the hard coding of the test-suite.log reading logic so that
autotools test-suite logs can be in any output build directory.

Tested:
Added a test

unit-test: Find all test-suite.log

This removes the hard coding of the test-suite.log reading logic so that
autotools test-suite logs can be in any output build directory.

Tested:
Added a test failure to sdbusplus and logs are still printed out
correctly when the failure occurs. Successful runs are not printed.

Change-Id: I85fcc7d99b34bcaa5fcc398052844410047367d2
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...