format-code: simplify codespell

* Avoid copying codespell config files into the workspace.
* Drop 'ignore-words' support.
* Filter out Signed-off-by lines.

The 'openbmc-spelling-ignore.txt' file co

format-code: simplify codespell

* Avoid copying codespell config files into the workspace.
* Drop 'ignore-words' support.
* Filter out Signed-off-by lines.

The 'openbmc-spelling-ignore.txt' file contained someone's last
name, which was being triggered by codespell as being similar enough
to a real word that it was identified as a mispelling. Instead of
keeping their name in an ignore file, filter out the Signed-off-by.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie2c96a000c352dc02a5dee1db3d2d9ea2b629cef

show more ...

format-code: avoid copying eslint config

There isn't a strong reason to copy the eslint config into the
workspace when we can just reference the `openbmc-build-scripts`
repository from within the wo

format-code: avoid copying eslint config

There isn't a strong reason to copy the eslint config into the
workspace when we can just reference the `openbmc-build-scripts`
repository from within the workspace, like we did for gitlint.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iad6c05527fb60d906d7b9536f4e7608885d4c59f

show more ...

build-unit-test-docker: use latest gitlint

gitlint release 0.18.0 contains the previously pointed to commit,
so pull it in directly rather than by reference now.

Signed-off-by: Patrick Williams <pa

build-unit-test-docker: use latest gitlint

gitlint release 0.18.0 contains the previously pointed to commit,
so pull it in directly rather than by reference now.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I741b0bbfe88f5361a4324bafdf7af883ad1a51c1

show more ...

build-unit-test-docker: minor mypy/flake8 fixes

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I991e6cf64f876005976cb5de19cf214fcccf2e89

Make git commit message checking mandatory

This commit is intended to enable the commit message rule checking for
all OpenBMC repositories. It was previously discussed, and several
repos have opted

Make git commit message checking mandatory

This commit is intended to enable the commit message rule checking for
all OpenBMC repositories. It was previously discussed, and several
repos have opted into the current solution without any incident, or
incorrectly-rejected patchsets that I'm aware of.

The very minor issue of CI not rebuilding on a commit message update has
been resolved, so we should be good to enable this project-wide.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I2a845518b18de21d3fd1d71d38c71d3d36038eb2

show more ...

build-unit-test-docker: format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3a76e9cc86d91fa0180cd0c9df3286030fa3c6a7

Migrate to libpldm

There has been efforts to migrate the libpldm out of the pldm repository
& this patch would also fix the CI scripts to migrate to libpldm instead
of building libpldm out of pldm r

Migrate to libpldm

There has been efforts to migrate the libpldm out of the pldm repository
& this patch would also fix the CI scripts to migrate to libpldm instead
of building libpldm out of pldm repository.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I15e223b8ddd43787b9062de43686c96f2358a3d0

show more ...

build-unit-test-docker: support 'main' branches

Enhance the auto-rev code to support main branches.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic9d32b5d4e4cb8e18c394d91b2a55ce01

build-unit-test-docker: support 'main' branches

Enhance the auto-rev code to support main branches.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic9d32b5d4e4cb8e18c394d91b2a55ce010a41270

show more ...

build-unit-test-docker: Only build phosphor-logging library

We don't need the server or any of the tests.

Change-Id: I0509fbcbaa6486027902a8e6bbc43f637f4a3935
Signed-off-by: William A. Kennington I

build-unit-test-docker: Only build phosphor-logging library

We don't need the server or any of the tests.

Change-Id: I0509fbcbaa6486027902a8e6bbc43f637f4a3935
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build-unit-test-docker: Fix stdplus gtest support lib

This lib provides some support functions for making googletest routines
more convenient and is used by phosphor-networkd.

Change-Id: I58855538e

build-unit-test-docker: Fix stdplus gtest support lib

This lib provides some support functions for making googletest routines
more convenient and is used by phosphor-networkd.

Change-Id: I58855538eb94ca7c128c6cee3812cbea09177659
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build-unit-test-docker: Update fmt 8.1.1 -> 9.1.0

meta-openembedded has already landed 9.1.0 and this will shortly be
incorportated into our tree.

Change-Id: I7ed38452f3715a7d002e378a52a19dbb9e4f84

build-unit-test-docker: Update fmt 8.1.1 -> 9.1.0

meta-openembedded has already landed 9.1.0 and this will shortly be
incorportated into our tree.

Change-Id: I7ed38452f3715a7d002e378a52a19dbb9e4f8492
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build-unit-test-docker: cppcheck update to latest

The 2.9 release seems to be the latest and contains the previous
commit we had referenced off the mainline. Switch to use the
latest release tag.

build-unit-test-docker: cppcheck update to latest

The 2.9 release seems to be the latest and contains the previous
commit we had referenced off the mainline. Switch to use the
latest release tag.

```
$ git tag --contains 27578e9c4c1f90c62b6938867735a054082e178e
2.9
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I375b8cd1ef4c9f24bea3dbeac4744d31e4a2b63e

show more ...

build-unit-test-docker: update to clang-15

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id5532b96a7067ea831c3fcd67418a85314a3e840

build-unit-test-docker: update ubuntu to kinetic

The clang-15 packages are only going to be available in kinetic
or later. Switch the docker base to that distro version. That
version already has t

build-unit-test-docker: update ubuntu to kinetic

The clang-15 packages are only going to be available in kinetic
or later. Switch the docker base to that distro version. That
version already has the autoconf-archive required for C++20 and
it has gcc-12 by default, so we can remove (or comment for the time
being) some workarounds we had.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6eb7fd7218027941af949522e043ed5dd6ea4f9b

show more ...

build-unit-test-docker: minor dependency tweaks

Add explicit dependency for objmgr -> phosphor-dbus-interfaces.
Make formatting more consistent.
Remove googletest dependencies when '-Dtests=disabled

build-unit-test-docker: minor dependency tweaks

Add explicit dependency for objmgr -> phosphor-dbus-interfaces.
Make formatting more consistent.
Remove googletest dependencies when '-Dtests=disabled' is passed.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3a3d7aa290c850181a6c2edaeed1af7df8c44d26

show more ...

build-unit-test-docker: refresh package versions

Update various package versions based on the current
Yocto recipe equivalents for these packages.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz

build-unit-test-docker: refresh package versions

Update various package versions based on the current
Yocto recipe equivalents for these packages.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I12773a06d4d589285bb1477013278a9eae5b5901

show more ...

build-unit-test-docker: use alternative for cpp

We added an 'alternative' for GCC but not for the preprocessor.
It seems potentially problematic to use an older preprocessor,
which came with the dis

build-unit-test-docker: use alternative for cpp

We added an 'alternative' for GCC but not for the preprocessor.
It seems potentially problematic to use an older preprocessor,
which came with the distro, but a newer compiler, so set the
preprocessor as the same version as GCC. The preprocessor is
required to be installed as a separate alternative and not with
the "--slave" option.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3a3e17b93ab7ea1aad0e5ac3677ec463e0c5b5ed

show more ...

Add python3 packaging module

As part of the effort to standardize our version comparison scheme,
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57407 needs this package
to be able to sort redfish sch

Add python3 packaging module

As part of the effort to standardize our version comparison scheme,
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57407 needs this package
to be able to sort redfish schemas at build time. This seems like a
pretty common and well supported package.

Add it to the docker image.

Tested: the aformentioned review passes CI when run locally.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ifdb49cfacf4c6bf27fee882d08bdf469d32cc7a6

show more ...

qemu-docker: Update redfish version

The DMTF/python-redfish-library is updated and it raises
SessionCreationError for login errors with HTTP code 400, and only
raises InvalidCredentialError for HTTP

qemu-docker: Update redfish version

The DMTF/python-redfish-library is updated and it raises
SessionCreationError for login errors with HTTP code 400, and only
raises InvalidCredentialError for HTTP code 401.

The cases when user enter "empty" username or password will return 400
and thus change the expected exception to SessionCreationError.

This commit was released with `redfish` version 3.1.7.
[0]: https://github.com/DMTF/python-redfish-library/commit/9a32d80c1c0858f0360e8d1f5f322278de79a20f

Update the redfish version to trigger docker rebuild.

Tested:
Clean docker image and rebuild docker image, or use this commit
to update docker, make sure the redfish version update.

Use
https://gerrit.openbmc.org/c/openbmc/openbmc-test-automation/+/57366,
the case `Redfish_Login_With_Invalid_Credentials` passed.

Change-Id: I946f6f71c56ccc2af8648ebcd4e7ae42ceacad5f
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

build-unit-test-docker: Add function2 to stdplus

Header only upgrade for uses of std::function that can be converted.

Change-Id: I5f43a461c0446258c5456055569a6ed8c3c4d229
Signed-off-by: William A.

build-unit-test-docker: Add function2 to stdplus

Header only upgrade for uses of std::function that can be converted.

Change-Id: I5f43a461c0446258c5456055569a6ed8c3c4d229
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-tidy: use TemporaryDirectory

This patch changes clang-tidy build of cmake and meson to use
TemporaryDirectory. So that no need to explicitly delete the build
directory. There is no need to har

clang-tidy: use TemporaryDirectory

This patch changes clang-tidy build of cmake and meson to use
TemporaryDirectory. So that no need to explicitly delete the build
directory. There is no need to hardcode the name as well. I kept the
prefix of the temp folder to be "build". This is to make gitignore of
most repos still work.

Tested:
1. used phosphor-user-manager as a typical meson repo. Tested
with/without clang-tidy. Both worked
2. used peci-pcie as a typical CMakeList repo. Tested with/without
clang-tidy. Both worked (but the repo itself doesn't pass clang build
bacause of its own reason)

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Ic355e390db7349ded73ad3d17a03a40b83460249

show more ...

clang-tidy: try to remove old directories

Just like the existing meson build codes, this patch tries to delete old
clang-tidy build directories before making a new one.

Tested:
Tested both cmake an

clang-tidy: try to remove old directories

Just like the existing meson build codes, this patch tries to delete old
clang-tidy build directories before making a new one.

Tested:
Tested both cmake and meson repos, old directories are deleted as
expected before making a new one.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I36a484d5832a1f427ef0e1b9b1f28183ccdc387e

show more ...

build-unit-test-docker: add cli11 to mapper

One of the applications in the mapper repository is adding a dependency
on cli11.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Id5

build-unit-test-docker: add cli11 to mapper

One of the applications in the mapper repository is adding a dependency
on cli11.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Id50b701bf94f46b08927beb0fc9d7e187e1f0c47

show more ...

build-unit-test-docker: update GCC to 12

Yocto is already using GCC 12. Upgrade for compatibility.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ab6e39efba280e4bf60305c9909ad35e

build-unit-test-docker: update GCC to 12

Yocto is already using GCC 12. Upgrade for compatibility.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ab6e39efba280e4bf60305c9909ad35e71caec1

show more ...

build-unit-test-docker: upgrade googletest to 1.12.1

This is the same version used in Yocto now.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I843a9da46b87ecc9363c2a9bbddfa22daab6

build-unit-test-docker: upgrade googletest to 1.12.1

This is the same version used in Yocto now.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I843a9da46b87ecc9363c2a9bbddfa22daab60b99

show more ...